wavelet2 [Thu, 22 Mar 2018 19:08:02 +0000 (19:08 +0000)]
Add overlay for Semtech SX150X I2C GPIO Expanders
(cherry picked from commit f27db6ef05c79d6b04efa5c35fee9533ab0042e2
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
derpeter [Sun, 25 Mar 2018 21:27:30 +0000 (23:27 +0200)]
This commit adds support for RP3-B-Plus in in arch arm64 (#2464)
(cherry picked from commit 3fb8905967d4b29b98e2746c1d8eab7cabb6d5a0
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Also add two dtparams - eth_led0 and eth_led1 - to provide user control
over the LEDs.
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
(cherry picked from commit 5c1cbce6dd4388020c4c0f8b1e2fd660d9c1f914
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Phil Elwell [Wed, 21 Mar 2018 15:59:26 +0000 (15:59 +0000)]
lan78xx: Read LED states from Device Tree
Add support for DT property "microchip,led-modes", a vector of two
cells (u32s) in the range 0-15, each of which sets the mode for one
of the two LEDs. The possible values are:
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
(cherry picked from commit c8a4f7c735641d4a2f51d9bd02b75121157d27ee
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Phil Elwell [Wed, 21 Mar 2018 13:53:39 +0000 (13:53 +0000)]
overlays: Update 'upstream' overlay with new dwc2
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
(cherry picked from commit 14ba91b8722da7dd42bc6528dcae4c7c34e07348
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
hexameron [Tue, 20 Mar 2018 12:48:10 +0000 (12:48 +0000)]
overlays: use all seven dwc2 gadget fifos.
Linux 4.9 needed fifos to be set to their default values,
leaving the last one (silently) set to zero size.
From 4.12 Linux allows fifos to be set to any size EXCEPT zero.
Signed-off-by: John Greb <h3x4m3r0n@gmail.com>
(cherry picked from commit 3d85e84fdc9484f7a78ab3d3e8a04fed817ab576
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Giedrius [Fri, 16 Mar 2018 16:14:31 +0000 (18:14 +0200)]
Fix for Pisound's MIDI Input getting blocked for a while in rare cases.
There was a possible race condition which could lead to Input's FIFO queue
to be underflown, causing high amount of processing in the worker thread for
some period of time.
Signed-off-by: Giedrius Trainavicius <giedrius@blokas.io>
(cherry picked from commit 1b94679a9b7f1e4ffce7369e466f151d40e481ec
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Phil Elwell [Fri, 16 Mar 2018 10:13:19 +0000 (10:13 +0000)]
BCM27XX_DT: Delete 'stdout-path' property
The 'stdout-path' property introduced upstream changes the behaviour
on a non-Bluetooth Pi by enabling a console on UART0 when the user
may not want one. The boot order is such that /dev/console ends up
on the serial port instead of tty0.
Delete the property in downstream DTBs to retrurn to the previous
behaviour of only enabling consoles selected in cmdline.txt.
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
(cherry picked from commit a69c920f22883371042de9bb53d84e15f7818197
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Phil Elwell [Wed, 14 Mar 2018 11:31:04 +0000 (11:31 +0000)]
bcm2710-rpi-3-b.dts: Remove duplicate memreserve
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
(cherry picked from commit 20922ea2c8168e7b68156ea028b57b357f3bdba4
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Piraty [Mon, 12 Mar 2018 16:07:45 +0000 (17:07 +0100)]
arm64: enable thermal / enable mmc (#2425)
(cherry picked from commit d6bbdf6b130ac9cb8fa6e4ecf02c5fdf50d7a25f
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Phil Elwell [Wed, 7 Mar 2018 08:21:29 +0000 (08:21 +0000)]
ARM: dts: Add model-specific compatible strings
The upstream Pi DTs are model-specific, with both the model and
compatible strings identifying the model. Downstream groups the
closely-related models, with only the chip name in the compatible
strings and a model string patched by the firmware.
Bring the downstream model-specific DTs closer to upstream by
adding model-specific compatible strings.
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
(cherry picked from commit d90929181836e8a049275d8407cff70fb93b7f17
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Phil Elwell [Sat, 3 Mar 2018 16:25:19 +0000 (16:25 +0000)]
audioinjector-octo: Add continuous clock feature
By user request, add a switch to prevent the clocks being stopped when
the stream is paused, stopped or shutdown. Provide access to the switch
by adding a 'non-stop-clocks' parameter to the audioinjector-addons
overlay.
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
(cherry picked from commit 8eb4abd918a094dab50bab1b68fc4742ecea02f1
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Phil Elwell [Sat, 3 Mar 2018 14:18:03 +0000 (14:18 +0000)]
overlays: Add 'upstream' overlay
The 'upstream' overlay makes the necessary changes for a downstream
.dtb to be used with an upstream kernel. It is currently made up from
three other overlays - vc4-kms-v3d, dwc2 and upstream-aux-interrupt.
The VPU firmware will soon be made to automatically load this overlay
when an upstream kernel is detected (using the trailer supplied by the
mkknlimg script).
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
(cherry picked from commit 1b481f8a427561dc7fd2afaa317d7be13f55382e
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
popcornmix [Fri, 2 Mar 2018 13:26:51 +0000 (13:26 +0000)]
config: Enable CONFIG_GPIO_MOCKUP module
(cherry picked from commit 9408efbb0fe72573aaadafae71f6a7947598e638
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Phil Elwell [Thu, 1 Mar 2018 21:36:30 +0000 (21:36 +0000)]
overlays: Add updated mmc1 alias to sdio overlays
In the downstream RPi kernel, aliases are used to assign instance
numbers to the SD/MMC interfaces. The updated sdio overlays
effectively rename the device node, so the mmc1 alias has to be
updated in order to preserve the mmc1 numbering, otherwise the device
will appear as mmc2.
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
(cherry picked from commit e947e787796e72ca7fce395a0179b63d32b8eff8
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Matthias Reichl [Thu, 22 Feb 2018 10:55:06 +0000 (11:55 +0100)]
ASoC: pcm512x: implement set_tdm_slot interface
PCM512x can accept data padded with additional BCLK cycles
but the driver currently lacks an interface to configure this.
This leads to the problem that S24_LE format in master mode
can result in non-integer clock divisors and pcm512x running
at a rather off rate.
For example 48kHz with 48fs BCLK and SCLK at 24.576MHz uses
a divisor of 10 (rounded down from 10.6666) and results in a
51.2kHz LRCLK. With 64fs BCLK a divisor of 8 is used and
LRCLK runs at exactly 48kHz.
Fix this by providing a minimal set_tdm_slot implementation
so machine drivers can optionally configure custom BCLK ratios.
Signed-off-by: Matthias Reichl <hias@horus.com>
(cherry picked from commit fa3803dd2cadcaec79a05fba78f431cb9f741650
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
The downstream pcm512x changes caused a regression, it broke normal
use of the 24bit format with the codec, eg when using simple-audio-card.
The actual bug with 24bit playback is the incorrect usage
of physical_width in various drivers in the downstream tree
which causes 24bit data to be transmitted with 32 clock
cycles. So it's not the pcm512x that needs fixing, it's the
soundcard drivers.
Signed-off-by: Matthias Reichl <hias@horus.com>
(cherry picked from commit 1963d77dab0f352ae9a0d4cdf52dd2c055bf29b6
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Eric Anholt [Tue, 31 Oct 2017 18:33:10 +0000 (11:33 -0700)]
drm/vc4: Skip ULPS latching when we're in that ULPS state already.
It seems that trying to go from unlatched to unlatched will time out
waiting for STOP, and we can just skip that.
Signed-off-by: Eric Anholt <eric@anholt.net>
(cherry picked from commit dd1772f6158f896380cf1dbb824b965ea7f520a7
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Eric Anholt [Mon, 13 Nov 2017 22:23:48 +0000 (14:23 -0800)]
drm/vc4: Fix crash if we have to unbind HDMI.
We need the card to unregister before the codec that the card
references.
Signed-off-by: Eric Anholt <eric@anholt.net>
(cherry picked from commit c8dd53be83a5a1d06fc8f0001450149bd488a28b
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
David H [Wed, 4 Oct 2017 11:43:07 +0000 (04:43 -0700)]
bcm2835-camera: Fix timestamp calculation problem (#2214)
* bcm2835-camera: Fix timestamp calculation problem
Use div_s64_rem() to convert usec timestamp to timeval
to avoid integer signedness bug.
* bcm2835-camera: Store kernel start time in NSEC instead of USEC
* bcm2835-camera: Reword debug message for clarity
(cherry picked from commit 91bdd6739e52124312ca09e83354e4ec4dda5865
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Dave Stevenson [Mon, 13 Feb 2017 13:11:41 +0000 (13:11 +0000)]
BCM2835-V4L2: Correctly denote key frames in encoded data
Forward MMAL key frame flags to the V4L2 buffers.
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
(cherry picked from commit bca036359b15783f08931edfb86ce360b4f6b55e
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Dave Stevenson [Mon, 13 Feb 2017 11:10:50 +0000 (11:10 +0000)]
BCM2835-V4L2: Ensure H264 header bytes get a sensible timestamp
H264 header come off VC with 0 timestamps, which means they get a
strange timestamp when processed with VC/kernel start times,
particularly if used with the inline header option.
Remember the last frame timestamp and use that if set, or otherwise
use the kernel start time.
https://github.com/raspberrypi/linux/issues/1836
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
(cherry picked from commit e3a3d4f4dd6111f63c006cd8666f16914c62a69e
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
hid: Reduce default mouse polling interval to 60Hz
Reduces overhead when using X
(cherry picked from commit 2005ce5eefed1bb668c8f6cbaee8b9e2e2d4af96
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Eric Anholt [Mon, 5 Feb 2018 18:53:18 +0000 (18:53 +0000)]
drm/vc4: Don't wait for vblank on fkms cursor updates.
We don't use the same async update path between fkms and normal kms,
and the normal kms workaround ended up making us wait. This became a
larger problem in rpi-4.14.y, as the USB HID update rate throttling
got (accidentally?) dropped.
Signed-off-by: Eric Anholt <eric@anholt.net>
(cherry picked from commit e66aa155716afe1f58e9bbe69b882bca28ae3e46
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Eric Anholt [Mon, 5 Feb 2018 18:22:03 +0000 (18:22 +0000)]
drm/vc4: Remove duplicate primary/cursor fields from FKMS driver.
The CRTC has those fields and we can just use them.
Signed-off-by: Eric Anholt <eric@anholt.net>
(cherry picked from commit 2ad1a992b5194a01d2dbde9eead1d7a1e2b2677d
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Eric Anholt [Mon, 5 Feb 2018 18:02:30 +0000 (18:02 +0000)]
drm/vc4: Skip SET_CURSOR_INFO when the cursor contents didn't change.
Signed-off-by: Eric Anholt <eric@anholt.net>
(cherry picked from commit 32161ae7d5bbc9b2b6fe629ef9d631b927da93e1
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Eric Anholt [Mon, 5 Feb 2018 18:01:02 +0000 (18:01 +0000)]
drm/vc4: Fix warning about vblank interrupts before DRM core is ready.
The SMICS interrupt fires continuously, but since it's 1/100 the rate
of the USB interrupts, we don't really need a way to turn it off. We
do need to make sure that we don't tell DRM about it until DRM has
asked for the interrupt at least once, because otherwise it will throw
a warning at boot time.
Signed-off-by: Eric Anholt <eric@anholt.net>
(cherry picked from commit 9a62e73e23eabe7459755bccf8dd97bbfa9f5344
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Dave Stevenson [Thu, 16 Nov 2017 14:22:30 +0000 (14:22 +0000)]
drm/vc4: Use .pixel_order instead of custom .flip_cbcr
The hardware has enums for altering the Cr and Cb order,
so use this instead of having a flag which swaps the
order the pointers are presented to the hardware
(that only worked for 3 plane formats anyway).
Explicitly sets .pixel_order in each case, rather than
relying on then default XYCBCR order being a value 0.
vcsm: Revert to do page-table-walk-based cache manipulating on some ioctl calls
On FLUSH, INVALID, CLEAN_INVALID ioctl calls, cache operations based on
page table walk were used in case that the buffer of the cache is not
pinned. So reverted to do page-table-based cache manipulating.
Signed-off-by: Sugizaki Yukimasa <i.can.speak.c.and.basic@gmail.com>
(cherry picked from commit b5a40e4b66f25056c1c2f30ea9a7d2d131672b75
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
vcsm: Support for finding user/vc handle in memory pool
vmcs_sm_{usr,vc}_handle_from_pid_and_address() were failing to find
handle if specified user pointer is not exactly the one that the memory
locking call returned even if the pointer is in range of map/resource.
So fixed the functions to match the range.
Signed-off-by: Sugizaki Yukimasa <i.can.speak.c.and.basic@gmail.com>
(cherry picked from commit 662ef06002e3d43ad76671bb9598cd61e265bef5
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Phil Elwell [Wed, 21 Mar 2018 15:05:48 +0000 (15:05 +0000)]
Remove build products from the source tree
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
(cherry picked from commit 15f547c94f2fc3a21e7f08d95eabae112db3bfb1
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Phil Elwell [Fri, 9 Mar 2018 17:28:07 +0000 (17:28 +0000)]
lan78xx: Change LEDs to include 10Mb activity
The default LED modes put 1000Mb/activity on orange and 100Mb/activity
on green, but this leaves no indication for a 10Mb link. Change the
defaults to put 10Mb/100Mb/activity on green.
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
(cherry picked from commit 1c1a8c5cdcd24a279d8194774e7e7047b7519f5c
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Phil Elwell [Fri, 9 Mar 2018 12:01:00 +0000 (12:01 +0000)]
lan78xx: Read initial EEE status from DT
Add two new DT properties:
* microchip,eee-enabled - a boolean to enable EEE
* microchip,tx-lpi-timer - time in microseconds to wait before entering
low power state
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
(cherry picked from commit 3aa9eb6eeffde4c317b41f488de0682fc027d768
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Phil Elwell [Fri, 21 Jul 2017 10:33:25 +0000 (11:33 +0100)]
BCM270X_DT: Add Pi 3+ dts files
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
(cherry picked from commit 741b2171d923106c720cd406fd3f500e3ebd861f
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Phil Elwell [Thu, 8 Feb 2018 15:08:57 +0000 (15:08 +0000)]
config: Set CONFIG_USB_LAN78XX=y
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
(cherry picked from commit 024693d124d75bd48c5b8617b3d3a11c1934d81e
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Phil Elwell [Wed, 14 Mar 2018 15:32:02 +0000 (15:32 +0000)]
configs: Remove vestigial setting
(cherry picked from commit 065ecc12f9aa870a5fb9533eb62fc74c2036b265
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
hdoverobinson [Tue, 13 Mar 2018 10:58:39 +0000 (06:58 -0400)]
added capture_clear option to pps-gpio via dtoverlay (#2433)
(cherry picked from commit dfff43426667c3c4f063de7bcf65993573a9e5e9
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
These warnings appear with GCC 7.3.0 from toolchains.bootlin.com:
../drivers/net/wireless/realtek/rtl8192cu/core/rtw_mlme_ext.c: In function ‘mgt_dispatcher’:
../drivers/net/wireless/realtek/rtl8192cu/core/rtw_mlme_ext.c:734:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if(check_fwstate(pmlmepriv, WIFI_AP_STATE) == _TRUE)
^
../drivers/net/wireless/realtek/rtl8192cu/core/rtw_mlme_ext.c:739:3: note: here
case WIFI_ASSOCREQ:
^~~~
../drivers/net/wireless/realtek/rtl8192cu/hal/rtl8192c/rtl8192c_phycfg.c: In function ‘phy_TxPwrIdxToDbm’:
../drivers/net/wireless/realtek/rtl8192cu/hal/rtl8192c/rtl8192c_phycfg.c:2365:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
Offset = -8;
~~~~~~~^~~~
../drivers/net/wireless/realtek/rtl8192cu/hal/rtl8192c/rtl8192c_phycfg.c:2366:2: note: here
default:
^~~~~~~
../drivers/net/wireless/realtek/rtl8192cu/hal/rtl8192c/usb/usb_halinit.c: In function ‘GetHwReg8192CU’:
../drivers/net/wireless/realtek/rtl8192cu/hal/rtl8192c/usb/usb_halinit.c:5694:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
*((u16 *)(val)) = pHalData->BasicRateSet;
~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/wireless/realtek/rtl8192cu/hal/rtl8192c/usb/usb_halinit.c:5695:3: note: here
case HW_VAR_TXPAUSE:
^~~~
../drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_linux.c: In function ‘set_group_key’:
../drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_linux.c:7383:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
keylen = 16;
~~~~~~~^~~~
../drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_linux.c:7384:3: note: here
default:
^~~~~~~
../drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c: In function ‘set_group_key’:
../drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:822:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
keylen = 16;
~~~~~~~^~~~
../drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:823:3: note: here
default:
^~~~~~~
None of them appear to be a real issue but it is trivial to make the
warnings go away.
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
(cherry picked from commit 2d9f477a266146e5d5180be853d62bd2f1d35ca0
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
These warnings appear with GCC 6.4.0 from toolchains.bootlin.com:
../drivers/net/wireless/realtek/rtl8192cu/core/rtw_security.c: In function ‘aes_cipher’:
../drivers/net/wireless/realtek/rtl8192cu/core/rtw_security.c:1504:5: warning: this ‘for’ clause does not guard... [-Wmisleading-indentation]
for (j = 0; j < 8; j++)
^~~
../drivers/net/wireless/realtek/rtl8192cu/core/rtw_security.c:1507:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘for’
payload_index = hdrlen + 8;
^~~~~~~~~~~~~
../drivers/net/wireless/realtek/rtl8192cu/core/rtw_security.c: In function ‘aes_decipher’:
../drivers/net/wireless/realtek/rtl8192cu/core/rtw_security.c:1878:5: warning: this ‘for’ clause does not guard... [-Wmisleading-indentation]
for (j = 0; j < 8; j++)
^~~
../drivers/net/wireless/realtek/rtl8192cu/core/rtw_security.c:1881:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘for’
payload_index = hdrlen + 8;
^~~~~~~~~~~~~
../drivers/net/wireless/realtek/rtl8192cu/core/rtw_mlme_ext.c:5666:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
if( _rtw_memcmp(pwdinfo->rx_prov_disc_info.peerDevAddr, empty_addr, ETH_ALEN) );
^~
../drivers/net/wireless/realtek/rtl8192cu/core/rtw_mlme_ext.c:5667:6: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
_rtw_memcpy(pwdinfo->rx_prov_disc_info.peerDevAddr, GetAddr2Ptr(pframe), ETH_ALEN);
^~~~~~~~~~~
It appears to be due to tabs versus spaces.
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
(cherry picked from commit ebaa4fc86f43de359041a1584526facee123eba1
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
davidw5 [Fri, 9 Mar 2018 14:17:17 +0000 (01:17 +1100)]
Update arm64 Makefile to compile bcm2710 dtb file
The line 'dtb-$(CONFIG_ARCH_BCM2835) += bcm2710-rpi-3-b.dtb' has been copied from previous rpi-4.14.y version into rpi-4.15.y arch/arm64/boot/dts/broadcom/Makefile to restore compilation of bcm2710-rpi-3-b.dtb device tree blob under 'make ARCH=arm64 dtbs' command.
(cherry picked from commit 83e3957d6e771a5410d250fc546cf3a6279fcd19
https://github.com/raspberrypi/linux raspi/rpi-4.15.y)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
This warning appears with GCC 7.3.0 from toolchains.bootlin.com:
../drivers/usb/host/dwc_otg/dwc_otg_fiq_fsm.c: In function ‘fiq_fsm_update_hs_isoc’:
../drivers/usb/host/dwc_otg/dwc_otg_fiq_fsm.c:595:61: warning: statement will never be executed [-Wswitch-unreachable]
st->hctsiz_copy.b.xfersize = nrpackets * st->hcchar_copy.b.mps;
~~~~~~~~~~~~~~~~~^~~~
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
(cherry picked from commit 2ba68424f7b6f564743ff5bf83084b61f35846aa
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
This warning appears with GCC 6.4.0 from toolchains.bootlin.com:
../drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function ‘vchiq_open’:
../drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1735:7: warning: unused variable ‘ret’ [-Wunused-variable]
int ret;
^~~
This variable's usage was removed by commit 3c980263c592 ("staging:
vchiq_arm: Make debugfs failure non-fatal"), making it useless.
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
(cherry picked from commit 84b317f420d54a84cd7ca71c116c94b84d7b56a9
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
This warning appears with GCC 6.4.0 from toolchains.bootlin.com:
../sound/soc/bcm/allo-piano-dac-plus.c: In function ‘snd_allo_piano_dac_init’:
../sound/soc/bcm/allo-piano-dac-plus.c:711:30: warning: argument to ‘sizeof’ in ‘memset’ call is the same expression as the destination; did you mean to dereference it? [-Wsizeof-pointer-memaccess]
memset(glb_ptr, 0x00, sizeof(glb_ptr));
^
Suggested-by: Phil Elwell <phil@raspberrypi.org> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
(cherry picked from commit 1436697785725063122d9daf9af5d79dc709b06f
https://github.com/raspberrypi/linux raspi/rpi-4.15.y) Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>