]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
lan78xx: Change LEDs to include 10Mb activity
authorPhil Elwell <phil@raspberrypi.org>
Fri, 9 Mar 2018 17:28:07 +0000 (17:28 +0000)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 15 Aug 2018 17:23:07 +0000 (19:23 +0200)
The default LED modes put 1000Mb/activity on orange and 100Mb/activity
on green, but this leaves no indication for a 10Mb link. Change the
defaults to put 10Mb/100Mb/activity on green.

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
(cherry picked from commit 1c1a8c5cdcd24a279d8194774e7e7047b7519f5c
https://github.com/raspberrypi/linux raspi/rpi-4.15.y)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/net/usb/lan78xx.c

index c78c2cc24b470b0af4e71b3d4a8c61dd8ee6f195..4994da1ff771ec5cf55eb21949a03bb5dd823a30 100644 (file)
@@ -2017,6 +2017,7 @@ static int lan78xx_phy_init(struct lan78xx_net *dev)
 {
        int ret;
        u32 mii_adv;
+       u32 led_modes;
        struct phy_device *phydev = dev->net->phydev;
 
        phydev = phy_find_first(dev->mdiobus);
@@ -2089,6 +2090,19 @@ static int lan78xx_phy_init(struct lan78xx_net *dev)
        mii_adv = (u32)mii_advertise_flowctrl(dev->fc_request_control);
        phydev->advertising |= mii_adv_to_ethtool_adv_t(mii_adv);
 
+       /* Change LED defaults:
+        *   orange = link1000/activity
+        *   green  = link10/link100/activity
+        * led: 0=link/activity          1=link1000/activity
+        *      2=link100/activity       3=link10/activity
+        *      4=link100/1000/activity  5=link10/1000/activity
+        *      6=link10/100/activity    14=off    15=on
+        */
+       led_modes = phy_read(phydev, 0x1d);
+       led_modes &= ~0xff;
+       led_modes |= (1 << 0) | (6 << 4);
+       (void)phy_write(phydev, 0x1d, led_modes);
+
        genphy_config_aneg(phydev);
 
        dev->fc_autoneg = phydev->autoneg;