#define dout_subsys ceph_subsys_journaler
#undef dout_prefix
-#define dout_prefix *_dout << "ObjectRecorder: " << this << " "
+#define dout_prefix *_dout << "ObjectRecorder: " << this << " " \
+ << __func__ << " (" << m_oid << "): "
using namespace cls::journal;
using std::shared_ptr;
ObjectRecorder::ObjectRecorder(librados::IoCtx &ioctx, const std::string &oid,
uint64_t object_number, shared_ptr<Mutex> lock,
- ContextWQ *work_queue, SafeTimer &timer,
- Mutex &timer_lock, Handler *handler,
- uint8_t order, uint32_t flush_interval,
- uint64_t flush_bytes, double flush_age,
- uint64_t max_in_flight_appends)
+ ContextWQ *work_queue, Handler *handler,
+ uint8_t order, int32_t max_in_flight_appends)
: RefCountedObject(NULL, 0), m_oid(oid), m_object_number(object_number),
- m_cct(NULL), m_op_work_queue(work_queue), m_timer(timer),
- m_timer_lock(timer_lock), m_handler(handler), m_order(order),
- m_soft_max_size(1 << m_order), m_flush_interval(flush_interval),
- m_flush_bytes(flush_bytes), m_flush_age(flush_age),
+ m_cct(NULL), m_op_work_queue(work_queue), m_handler(handler),
+ m_order(order), m_soft_max_size(1 << m_order),
m_max_in_flight_appends(max_in_flight_appends), m_flush_handler(this),
- m_lock(lock), m_append_tid(0), m_pending_bytes(0),
- m_size(0), m_overflowed(false), m_object_closed(false),
- m_in_flight_flushes(false), m_aio_scheduled(false) {
+ m_lock(lock), m_last_flush_time(ceph_clock_now()), m_append_tid(0),
+ m_overflowed(false), m_object_closed(false), m_in_flight_flushes(false) {
m_ioctx.dup(ioctx);
m_cct = reinterpret_cast<CephContext*>(m_ioctx.cct());
ceph_assert(m_handler != NULL);
+ ldout(m_cct, 20) << dendl;
}
ObjectRecorder::~ObjectRecorder() {
- ceph_assert(m_append_task == NULL);
- ceph_assert(m_append_buffers.empty());
+ ldout(m_cct, 20) << dendl;
+ ceph_assert(m_pending_buffers.empty());
ceph_assert(m_in_flight_tids.empty());
ceph_assert(m_in_flight_appends.empty());
- ceph_assert(!m_aio_scheduled);
}
-bool ObjectRecorder::append_unlock(AppendBuffers &&append_buffers) {
+void ObjectRecorder::set_append_batch_options(int flush_interval,
+ uint64_t flush_bytes,
+ double flush_age) {
+ ldout(m_cct, 5) << "flush_interval=" << flush_interval << ", "
+ << "flush_bytes=" << flush_bytes << ", "
+ << "flush_age=" << flush_age << dendl;
+
ceph_assert(m_lock->is_locked());
+ m_flush_interval = flush_interval;
+ m_flush_bytes = flush_bytes;
+ m_flush_age = flush_age;
+}
- FutureImplPtr last_flushed_future;
- bool schedule_append = false;
+bool ObjectRecorder::append(AppendBuffers &&append_buffers) {
+ ldout(m_cct, 20) << "count=" << append_buffers.size() << dendl;
- if (m_overflowed) {
- m_append_buffers.insert(m_append_buffers.end(),
- append_buffers.begin(), append_buffers.end());
- m_lock->Unlock();
- return false;
- }
+ ceph_assert(m_lock->is_locked());
- for (AppendBuffers::const_iterator iter = append_buffers.begin();
- iter != append_buffers.end(); ++iter) {
- if (append(*iter, &schedule_append)) {
- last_flushed_future = iter->first;
+ FutureImplPtr last_flushed_future;
+ for (auto& append_buffer : append_buffers) {
+ ldout(m_cct, 20) << *append_buffer.first << ", "
+ << "size=" << append_buffer.second.length() << dendl;
+ bool flush_requested = append_buffer.first->attach(&m_flush_handler);
+ if (flush_requested) {
+ last_flushed_future = append_buffer.first;
}
- }
- if (last_flushed_future) {
- flush(last_flushed_future);
- m_lock->Unlock();
- } else {
- m_lock->Unlock();
- if (schedule_append) {
- schedule_append_task();
- } else {
- cancel_append_task();
- }
+ m_pending_buffers.push_back(append_buffer);
+ m_pending_bytes += append_buffer.second.length();
}
- return (!m_object_closed && !m_overflowed &&
- m_size + m_pending_bytes >= m_soft_max_size);
+
+ return send_appends(!!last_flushed_future, last_flushed_future);
}
void ObjectRecorder::flush(Context *on_safe) {
- ldout(m_cct, 20) << __func__ << ": " << m_oid << dendl;
+ ldout(m_cct, 20) << dendl;
- cancel_append_task();
Future future;
{
Mutex::Locker locker(*m_lock);
}
// attach the flush to the most recent append
- if (!m_append_buffers.empty()) {
- future = Future(m_append_buffers.rbegin()->first);
-
- flush_appends(true);
- } else if (!m_pending_buffers.empty()) {
+ if (!m_pending_buffers.empty()) {
future = Future(m_pending_buffers.rbegin()->first);
} else if (!m_in_flight_appends.empty()) {
AppendBuffers &append_buffers = m_in_flight_appends.rbegin()->second;
}
if (future.is_valid()) {
- future.flush(on_safe);
+ // cannot be invoked while the same lock context
+ m_op_work_queue->queue(new FunctionContext(
+ [future, on_safe] (int r) mutable {
+ future.flush(on_safe);
+ }));
} else {
on_safe->complete(0);
}
}
void ObjectRecorder::flush(const FutureImplPtr &future) {
- ldout(m_cct, 20) << __func__ << ": " << m_oid << " flushing " << *future
- << dendl;
-
- ceph_assert(m_lock->is_locked());
+ ldout(m_cct, 20) << "flushing " << *future << dendl;
+ m_lock->Lock();
if (future->get_flush_handler().get() != &m_flush_handler) {
// if we don't own this future, re-issue the flush so that it hits the
// correct journal object owner
future->flush();
+ m_lock->Unlock();
return;
} else if (future->is_flush_in_progress()) {
+ m_lock->Unlock();
return;
}
- if (m_object_closed || m_overflowed) {
- return;
- }
-
- AppendBuffers::reverse_iterator r_it;
- for (r_it = m_append_buffers.rbegin(); r_it != m_append_buffers.rend();
- ++r_it) {
- if (r_it->first == future) {
- break;
- }
+ bool overflowed = send_appends(true, future);
+ if (overflowed) {
+ notify_handler_unlock();
+ } else {
+ m_lock->Unlock();
}
- ceph_assert(r_it != m_append_buffers.rend());
-
- auto it = (++r_it).base();
- ceph_assert(it != m_append_buffers.end());
- ++it;
-
- AppendBuffers flush_buffers;
- flush_buffers.splice(flush_buffers.end(), m_append_buffers,
- m_append_buffers.begin(), it);
- send_appends(&flush_buffers);
}
void ObjectRecorder::claim_append_buffers(AppendBuffers *append_buffers) {
- ldout(m_cct, 20) << __func__ << ": " << m_oid << dendl;
+ ldout(m_cct, 20) << dendl;
ceph_assert(m_lock->is_locked());
ceph_assert(m_in_flight_tids.empty());
ceph_assert(m_in_flight_appends.empty());
ceph_assert(m_object_closed || m_overflowed);
- append_buffers->splice(append_buffers->end(), m_append_buffers,
- m_append_buffers.begin(), m_append_buffers.end());
+
+ for (auto& append_buffer : m_pending_buffers) {
+ ldout(m_cct, 20) << "detached " << *append_buffer.first << dendl;
+ append_buffer.first->detach();
+ }
+ append_buffers->splice(append_buffers->end(), m_pending_buffers,
+ m_pending_buffers.begin(), m_pending_buffers.end());
}
bool ObjectRecorder::close() {
ceph_assert(m_lock->is_locked());
- ldout(m_cct, 20) << __func__ << ": " << m_oid << dendl;
-
- cancel_append_task();
-
- flush_appends(true);
+ ldout(m_cct, 20) << dendl;
+ send_appends(true, {});
ceph_assert(!m_object_closed);
m_object_closed = true;
- return (m_in_flight_tids.empty() && !m_in_flight_flushes && !m_aio_scheduled);
-}
-
-void ObjectRecorder::handle_append_task() {
- ceph_assert(m_timer_lock.is_locked());
- m_append_task = NULL;
-
- Mutex::Locker locker(*m_lock);
- flush_appends(true);
-}
-
-void ObjectRecorder::cancel_append_task() {
- Mutex::Locker locker(m_timer_lock);
- if (m_append_task != NULL) {
- m_timer.cancel_event(m_append_task);
- m_append_task = NULL;
- }
-}
-
-void ObjectRecorder::schedule_append_task() {
- Mutex::Locker locker(m_timer_lock);
- if (m_append_task == nullptr && m_flush_age > 0) {
- m_append_task = m_timer.add_event_after(
- m_flush_age, new FunctionContext([this](int) {
- handle_append_task();
- }));
- }
-}
-
-bool ObjectRecorder::append(const AppendBuffer &append_buffer,
- bool *schedule_append) {
- ceph_assert(m_lock->is_locked());
-
- bool flush_requested = false;
- if (!m_object_closed && !m_overflowed) {
- flush_requested = append_buffer.first->attach(&m_flush_handler);
- }
-
- m_append_buffers.push_back(append_buffer);
- m_pending_bytes += append_buffer.second.length();
-
- if (!flush_appends(false)) {
- *schedule_append = true;
- }
- return flush_requested;
-}
-
-bool ObjectRecorder::flush_appends(bool force) {
- ceph_assert(m_lock->is_locked());
- if (m_object_closed || m_overflowed) {
- return true;
- }
-
- if (m_append_buffers.empty() ||
- (!force &&
- m_size + m_pending_bytes < m_soft_max_size &&
- (m_flush_interval > 0 && m_append_buffers.size() < m_flush_interval) &&
- (m_flush_bytes > 0 && m_pending_bytes < m_flush_bytes))) {
- return false;
- }
-
- m_pending_bytes = 0;
- AppendBuffers append_buffers;
- append_buffers.swap(m_append_buffers);
- send_appends(&append_buffers);
- return true;
+ return (m_in_flight_tids.empty() && !m_in_flight_flushes);
}
void ObjectRecorder::handle_append_flushed(uint64_t tid, int r) {
- ldout(m_cct, 10) << __func__ << ": " << m_oid << " tid=" << tid
- << ", r=" << r << dendl;
+ ldout(m_cct, 20) << "tid=" << tid << ", r=" << r << dendl;
AppendBuffers append_buffers;
{
m_in_flight_tids.erase(tid_iter);
InFlightAppends::iterator iter = m_in_flight_appends.find(tid);
- if (r == -EOVERFLOW || m_overflowed) {
- if (iter != m_in_flight_appends.end()) {
- m_overflowed = true;
- } else {
- // must have seen an overflow on a previous append op
- ceph_assert(r == -EOVERFLOW && m_overflowed);
- }
+ ceph_assert(iter != m_in_flight_appends.end());
+
+ if (r == -EOVERFLOW) {
+ ldout(m_cct, 10) << "append overflowed" << dendl;
+ m_overflowed = true;
// notify of overflow once all in-flight ops are complete
- if (m_in_flight_tids.empty() && !m_aio_scheduled) {
- m_append_buffers.splice(m_append_buffers.begin(), m_pending_buffers);
+ if (m_in_flight_tids.empty()) {
append_overflowed();
notify_handler_unlock();
} else {
return;
}
- ceph_assert(iter != m_in_flight_appends.end());
append_buffers.swap(iter->second);
ceph_assert(!append_buffers.empty());
+ for (auto& append_buffer : append_buffers) {
+ m_object_bytes += append_buffer.second.length();
+ }
+ ldout(m_cct, 20) << "object_bytes=" << m_object_bytes << dendl;
+
m_in_flight_appends.erase(iter);
m_in_flight_flushes = true;
m_lock->Unlock();
}
// Flag the associated futures as complete.
- for (AppendBuffers::iterator buf_it = append_buffers.begin();
- buf_it != append_buffers.end(); ++buf_it) {
- ldout(m_cct, 20) << __func__ << ": " << *buf_it->first << " marked safe"
- << dendl;
- buf_it->first->safe(r);
+ for (auto& append_buffer : append_buffers) {
+ ldout(m_cct, 20) << *append_buffer.first << " marked safe" << dendl;
+ append_buffer.first->safe(r);
}
// wake up any flush requests that raced with a RADOS callback
m_in_flight_flushes = false;
m_in_flight_flushes_cond.Signal();
- if (!m_aio_scheduled) {
- if (m_in_flight_appends.empty() && m_object_closed) {
- // all remaining unsent appends should be redirected to new object
- m_append_buffers.splice(m_append_buffers.begin(), m_pending_buffers);
+ if (m_in_flight_appends.empty() && (m_object_closed || m_overflowed)) {
+ // all remaining unsent appends should be redirected to new object
+ notify_handler_unlock();
+ } else {
+ bool overflowed = send_appends(false, {});
+ if (overflowed) {
notify_handler_unlock();
- } else if (!m_pending_buffers.empty()) {
- m_aio_scheduled = true;
- m_lock->Unlock();
- send_appends_aio();
} else {
m_lock->Unlock();
}
- } else {
- m_lock->Unlock();
}
}
void ObjectRecorder::append_overflowed() {
- ldout(m_cct, 10) << __func__ << ": " << m_oid << " append overflowed"
- << dendl;
+ ldout(m_cct, 10) << dendl;
ceph_assert(m_lock->is_locked());
ceph_assert(!m_in_flight_appends.empty());
- cancel_append_task();
-
InFlightAppends in_flight_appends;
in_flight_appends.swap(m_in_flight_appends);
}
restart_append_buffers.splice(restart_append_buffers.end(),
- m_append_buffers,
- m_append_buffers.begin(),
- m_append_buffers.end());
- restart_append_buffers.swap(m_append_buffers);
-
- for (AppendBuffers::const_iterator it = m_append_buffers.begin();
- it != m_append_buffers.end(); ++it) {
- ldout(m_cct, 20) << __func__ << ": overflowed " << *it->first
- << dendl;
- it->first->detach();
- }
+ m_pending_buffers,
+ m_pending_buffers.begin(),
+ m_pending_buffers.end());
+ restart_append_buffers.swap(m_pending_buffers);
}
-void ObjectRecorder::send_appends(AppendBuffers *append_buffers) {
+bool ObjectRecorder::send_appends(bool force, FutureImplPtr flush_future) {
+ ldout(m_cct, 20) << dendl;
+
ceph_assert(m_lock->is_locked());
- ceph_assert(!append_buffers->empty());
-
- for (AppendBuffers::iterator it = append_buffers->begin();
- it != append_buffers->end(); ++it) {
- ldout(m_cct, 20) << __func__ << ": flushing " << *it->first
- << dendl;
- it->first->set_flush_in_progress();
- m_size += it->second.length();
+ if (m_object_closed || m_overflowed) {
+ ldout(m_cct, 20) << "already closed or overflowed" << dendl;
+ return false;
}
- m_pending_buffers.splice(m_pending_buffers.end(), *append_buffers,
- append_buffers->begin(), append_buffers->end());
- if (!m_aio_scheduled) {
- m_op_work_queue->queue(new FunctionContext([this] (int r) {
- send_appends_aio();
- }));
- m_aio_scheduled = true;
+ if (m_pending_buffers.empty()) {
+ ldout(m_cct, 20) << "append buffers empty" << dendl;
+ return false;
}
-}
-void ObjectRecorder::send_appends_aio() {
- librados::AioCompletion *rados_completion;
- {
- Mutex::Locker locker(*m_lock);
- m_aio_scheduled = false;
+ if (!force &&
+ ((m_flush_interval > 0 && m_pending_buffers.size() >= m_flush_interval) ||
+ (m_flush_bytes > 0 && m_pending_bytes >= m_flush_bytes) ||
+ (m_flush_age > 0 &&
+ m_last_flush_time + m_flush_age >= ceph_clock_now()))) {
+ ldout(m_cct, 20) << "forcing batch flush" << dendl;
+ force = true;
+ }
- if (m_pending_buffers.empty()) {
- ldout(m_cct, 20) << __func__ << ": " << m_oid << " pending buffers empty"
- << dendl;
- return;
+ auto max_in_flight_appends = m_max_in_flight_appends;
+ if (m_flush_interval > 0 || m_flush_bytes > 0 || m_flush_age > 0) {
+ if (!force && max_in_flight_appends == 0) {
+ ldout(m_cct, 20) << "attempting to batch AIO appends" << dendl;
+ max_in_flight_appends = 1;
}
+ } else if (max_in_flight_appends < 0) {
+ max_in_flight_appends = 0;
+ }
- if (m_max_in_flight_appends != 0 &&
- m_in_flight_tids.size() >= m_max_in_flight_appends) {
- ldout(m_cct, 20) << __func__ << ": " << m_oid
- << " max in flight appends reached" << dendl;
- return;
+ if (!force && max_in_flight_appends != 0 &&
+ static_cast<int32_t>(m_in_flight_tids.size()) >= max_in_flight_appends) {
+ ldout(m_cct, 10) << "max in flight appends reached" << dendl;
+ return false;
+ }
+
+ librados::ObjectWriteOperation op;
+ client::guard_append(&op, m_soft_max_size);
+
+ size_t append_bytes = 0;
+ AppendBuffers append_buffers;
+ for (auto it = m_pending_buffers.begin(); it != m_pending_buffers.end(); ) {
+ auto& future = it->first;
+ auto& bl = it->second;
+ auto size = m_object_bytes + m_in_flight_bytes + append_bytes + bl.length();
+ if (size == m_soft_max_size) {
+ ldout(m_cct, 10) << "object at capacity " << *future << dendl;
+ m_overflowed = true;
+ } else if (size > m_soft_max_size) {
+ ldout(m_cct, 10) << "object beyond capacity " << *future << dendl;
+ m_overflowed = true;
+ break;
}
+ bool flush_break = (force && flush_future && flush_future == future);
+ ldout(m_cct, 20) << "flushing " << *future << dendl;
+ future->set_flush_in_progress();
+
+ op.append(bl);
+ op.set_op_flags2(CEPH_OSD_OP_FLAG_FADVISE_DONTNEED);
+
+ append_bytes += bl.length();
+ append_buffers.push_back(*it);
+ it = m_pending_buffers.erase(it);
+
+ if (flush_break) {
+ ldout(m_cct, 20) << "stopping at requested flush future" << dendl;
+ break;
+ }
+ }
+
+ if (append_bytes > 0) {
+ m_last_flush_time = ceph_clock_now();
+
uint64_t append_tid = m_append_tid++;
m_in_flight_tids.insert(append_tid);
+ m_in_flight_appends[append_tid].swap(append_buffers);
+ m_in_flight_bytes += append_bytes;
- ldout(m_cct, 10) << __func__ << ": " << m_oid << " flushing journal tid="
- << append_tid << dendl;
-
- librados::ObjectWriteOperation op;
- client::guard_append(&op, m_soft_max_size);
- auto append_buffers = &m_in_flight_appends[append_tid];
-
- for (auto it = m_pending_buffers.begin(); it != m_pending_buffers.end(); ) {
- ldout(m_cct, 20) << __func__ << ": flushing " << *it->first << dendl;
- op.append(it->second);
- op.set_op_flags2(CEPH_OSD_OP_FLAG_FADVISE_DONTNEED);
- m_aio_sent_size += it->second.length();
- append_buffers->push_back(*it);
- it = m_pending_buffers.erase(it);
- if (m_aio_sent_size >= m_soft_max_size) {
- break;
- }
- }
- rados_completion = librados::Rados::aio_create_completion(
- new C_AppendFlush(this, append_tid), nullptr,
- utils::rados_ctx_callback);
+ ceph_assert(m_pending_bytes >= append_bytes);
+ m_pending_bytes -= append_bytes;
+
+ auto rados_completion = librados::Rados::aio_create_completion(
+ new C_AppendFlush(this, append_tid), nullptr, utils::rados_ctx_callback);
int r = m_ioctx.aio_operate(m_oid, rados_completion, &op);
ceph_assert(r == 0);
+ rados_completion->release();
+ ldout(m_cct, 20) << "flushing journal tid=" << append_tid << ", "
+ << "append_bytes=" << append_bytes << ", "
+ << "in_flight_bytes=" << m_in_flight_bytes << ", "
+ << "pending_bytes=" << m_pending_bytes << dendl;
}
- rados_completion->release();
+
+ return m_overflowed;
}
void ObjectRecorder::notify_handler_unlock() {
projects / ceph.git / blobdiff