]> git.proxmox.com Git - libarchive-perl.git/commitdiff
buildsys: use simple parenthesis for variables
authorStoiko Ivanov <s.ivanov@proxmox.com>
Fri, 26 May 2023 16:44:05 +0000 (18:44 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Fri, 23 Jun 2023 13:14:59 +0000 (15:14 +0200)
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Makefile

index 1e293acc3e12a66661d23dd2695747fe28496383..a98142c99278d057dab22728e14bc6af550aee3e 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -11,52 +11,52 @@ PPSRC = LibArchive
 ARCH:=$(shell dpkg-architecture -qDEB_BUILD_ARCH)
 GITVERSION:=$(shell git rev-parse HEAD)
 
-BUILDSRC=${PACKAGE}-${DEB_VERSION_UPSTREAM}
-DEB=${PACKAGE}_${DEB_VERSION_UPSTREAM_REVISION}_${ARCH}.deb
-DSC=${PACKAGE}_${DEB_VERSION_UPSTREAM_REVISION}.dsc
+BUILDSRC=$(PACKAGE)-$(DEB_VERSION_UPSTREAM)
+DEB=$(PACKAGE)_$(DEB_VERSION_UPSTREAM_REVISION)_$(ARCH).deb
+DSC=$(PACKAGE)_$(DEB_VERSION_UPSTREAM_REVISION).dsc
 
-all: ${DEB}
+all: $(DEB)
 
 .PHONY: update-bindings
 update-bindings:
-       h2xs -M '^(archive|ARCHIVE)_' -v ${DEB_VERSION_UPSTREAM} -On LibArchive /usr/include/archive.h /usr/include/archive_entry.h -larchive
+       h2xs -M '^(archive|ARCHIVE)_' -v $(DEB_VERSION_UPSTREAM) -On LibArchive /usr/include/archive.h /usr/include/archive_entry.h -larchive
        echo "Please manually check and add the diff of the automatically generated update"
 
-.PHONY: ${BUILDSRC}
-${BUILDSRC}:
-       rm -rf ${BUILDSRC}
-       cp -a ${PPSRC}/ ${BUILDSRC}
-       cp -a debian ${BUILDSRC}
-       perl -MDevel::PPPort -e 'Devel::PPPort::WriteFile("${BUILDSRC}/ppport.h");'
-       echo "git clone git://git.proxmox.com/git/pve-storage.git\\ngit checkout ${GITVERSION}" >${BUILDSRC}/debian/SOURCE
+.PHONY: $(BUILDSRC)
+$(BUILDSRC):
+       rm -rf $(BUILDSRC)
+       cp -a $(PPSRC)/ $(BUILDSRC)
+       cp -a debian $(BUILDSRC)
+       perl -MDevel::PPPort -e 'Devel::PPPort::WriteFile("$(BUILDSRC)/ppport.h");'
+       echo "git clone git://git.proxmox.com/git/pve-storage.git\\ngit checkout $(GITVERSION)" >$(BUILDSRC)/debian/SOURCE
 
 .PHONY: dsc
-dsc: ${DSC}
-${DSC}: ${BUILDSRC}
-       cd ${BUILDSRC}; dpkg-buildpackage -S -us -uc -d -nc
-       lintian ${DSC}
+dsc: $(DSC)
+$(DSC): $(BUILDSRC)
+       cd $(BUILDSRC); dpkg-buildpackage -S -us -uc -d -nc
+       lintian $(DSC)
 
 .PHONY: sbuild
 sbuild: $(DSC)
        sbuild $(DSC)
 
 .PHONY: deb
-deb: ${DEB}
-${DEB}: ${PPSRC}/LibArchive.xs ${BUILDSRC}
-       cd ${BUILDSRC}; dpkg-buildpackage -b -us -uc -rfakeroot
-       lintian ${DEB}
+deb: $(DEB)
+$(DEB): $(PPSRC)/LibArchive.xs $(BUILDSRC)
+       cd $(BUILDSRC); dpkg-buildpackage -b -us -uc -rfakeroot
+       lintian $(DEB)
 
 .phony: upload
-upload: UPLOAD_DIST ?= ${DEB_DISTRIBUTION}
-upload: ${DEB}
-       tar cf - ${DEB} | ssh -X repoman@repo.proxmox.com -- upload --product pmg --dist ${UPLOAD_DIST}
+upload: UPLOAD_DIST ?= $(DEB_DISTRIBUTION)
+upload: $(DEB)
+       tar cf - $(DEB) | ssh -X repoman@repo.proxmox.com -- upload --product pmg --dist $(UPLOAD_DIST)
 
-CLEANFILES = *~ build *.deb libarchive_* libarchive-perl_* ${BUILDSRC} *.buildinfo *.build *.dsc *tar.?z
+CLEANFILES = *~ build *.deb libarchive_* libarchive-perl_* $(BUILDSRC) *.buildinfo *.build *.dsc *tar.?z
 
 .phony: clean
 clean:
-       rm -rf ${CLEANFILES}
+       rm -rf $(CLEANFILES)
 
 .PHONY: dinstall
-dinstall: ${DEB}
-       dpkg -i ${DEB}
+dinstall: $(DEB)
+       dpkg -i $(DEB)