totemconfig: fix integer underflow and logic bug

Fix integer underflow when computing `namelen` in `nodelist_byname`,
always use computed `namelen`.
Fixes #626.

Signed-off-by: Johannes Krupp <johannes.krupp@cispa.saarland>
Reviewed-by: Jan Friesse <jfriesse@redhat.com>

diff --git a/exec/totemconfig.c b/exec/totemconfig.c
index b8856073a82e02ef002e1ca5b50c8e43426e4746..645ff9ef89a4a6b6260addf9081993d9a1a09aec 100644 (file)
--- a/exec/totemconfig.c
+++ b/exec/totemconfig.c
@@ -651,11 +651,11 @@ static int nodelist_byname(icmap_map_t map, const char *find_name, int strip_dom
                        char *dot;
                        dot = strchr(name, '.');
                        if (dot) {
-                               namelen = name - dot - 1;
+                               namelen = dot - name;
                        }
                }
                if (strncmp(find_name, name, namelen) == 0 &&
-                   strlen(find_name) == strlen(name)) {
+                   strlen(find_name) == namelen) {
                        icmap_iter_finalize(iter);
                        return node_pos;
                }