]> git.proxmox.com Git - mirror_corosync.git/commitdiff
icmap: icmap_init_r() leaks if trie_create() fails
authorChristine Caulfield <ccaulfie@redhat.com>
Thu, 26 Mar 2020 10:26:16 +0000 (10:26 +0000)
committerJan Friesse <jfriesse@redhat.com>
Thu, 26 Mar 2020 13:42:41 +0000 (14:42 +0100)
Thanks to Coverity for finding this

Signed-off-by: Christine Caulfield <ccaulfie@redhat.com>
Reviewed-by: Jan Friesse <jfriesse@redhat.com>
exec/icmap.c

index 9bbf30f7c2e032b24f37c1d4a288a7e29ca23756..4aeababe1da7bbec03f60ef4215ff6c07f62710a 100644 (file)
@@ -195,8 +195,10 @@ cs_error_t icmap_init_r(icmap_map_t *result)
        }
 
         (*result)->qb_map = qb_trie_create();
-       if ((*result)->qb_map == NULL)
+       if ((*result)->qb_map == NULL) {
+               free(*result);
                return (CS_ERR_INIT);
+       }
 
        err = qb_map_notify_add((*result)->qb_map, NULL, icmap_map_free_cb, QB_MAP_NOTIFY_FREE, NULL);