totemconfig: validate totem.transport value

Signed-off-by: liangxin1300 <XLiang@suse.com>
Reviewed-by: Jan Friesse <jfriesse@redhat.com>

diff --git a/exec/totemconfig.c b/exec/totemconfig.c
index 3927da9cd41f92ff0b89c45518fb3769a0845ad8..45dd6ed6060a148c38ab9508078dfe0a9231648e 100644 (file)
--- a/exec/totemconfig.c
+++ b/exec/totemconfig.c
@@ -1747,14 +1747,14 @@ extern int totem_config_read (
        if (icmap_get_string("totem.transport", &str) == CS_OK) {
                if (strcmp (str, "udpu") == 0) {
                        totem_config->transport_number = TOTEM_TRANSPORT_UDPU;
-               }
-
-               if (strcmp (str, "udp") == 0) {
+               } else if (strcmp (str, "udp") == 0) {
                        totem_config->transport_number = TOTEM_TRANSPORT_UDP;
-               }
-
-               if (strcmp (str, "knet") == 0) {
+               } else if (strcmp (str, "knet") == 0) {
                        totem_config->transport_number = TOTEM_TRANSPORT_KNET;
+               } else {
+                       *error_string = "Invalid transport type. Should be udpu, udp or knet";
+                       free(str);
+                       return -1;
                }
 
                free(str);