]> git.proxmox.com Git - mirror_edk2.git/blobdiff - BaseTools/Source/Python/AutoGen/GenC.py
BaseTools: remove unnecessary calls of os.exist
[mirror_edk2.git] / BaseTools / Source / Python / AutoGen / GenC.py
old mode 100644 (file)
new mode 100755 (executable)
index 067d954..5e0d11e
@@ -2,22 +2,17 @@
 # Routines for generating AutoGen.h and AutoGen.c\r
 #\r
 # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>\r
-# This program and the accompanying materials\r
-# are licensed and made available under the terms and conditions of the BSD License\r
-# which accompanies this distribution.  The full text of the license may be found at\r
-# http://opensource.org/licenses/bsd-license.php\r
-#\r
-# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,\r
-# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.\r
+# SPDX-License-Identifier: BSD-2-Clause-Patent\r
 #\r
 \r
 ## Import Modules\r
 #\r
+from __future__ import absolute_import\r
 import string\r
 import collections\r
 import struct\r
 from Common import EdkLogger\r
-\r
+from Common import GlobalData\r
 from Common.BuildToolError import *\r
 from Common.DataType import *\r
 from Common.Misc import *\r
@@ -683,7 +678,7 @@ ${Function} (
 gLibraryStructorCall = {\r
 SUP_MODULE_BASE  : TemplateString("""${BEGIN}\r
   Status = ${Function} ();\r
-  ASSERT_EFI_ERROR (Status);${END}\r
+  ASSERT_RETURN_ERROR (Status);${END}\r
 """),\r
 \r
 'PEI'   : TemplateString("""${BEGIN}\r
@@ -713,7 +708,7 @@ ProcessLibrary${Type}List (
   VOID\r
   )\r
 {\r
-${BEGIN}  EFI_STATUS  Status;\r
+${BEGIN}  RETURN_STATUS  Status;\r
 ${FunctionCall}${END}\r
 }\r
 """),\r
@@ -767,7 +762,7 @@ ${FunctionCall}${END}
 gBasicHeaderFile = "Base.h"\r
 \r
 gModuleTypeHeaderFile = {\r
-    SUP_MODULE_BASE              :   [gBasicHeaderFile],\r
+    SUP_MODULE_BASE              :   [gBasicHeaderFile, "Library/DebugLib.h"],\r
     SUP_MODULE_SEC               :   ["PiPei.h", "Library/DebugLib.h"],\r
     SUP_MODULE_PEI_CORE          :   ["PiPei.h", "Library/DebugLib.h", "Library/PeiCoreEntryPoint.h"],\r
     SUP_MODULE_PEIM              :   ["PiPei.h", "Library/DebugLib.h", "Library/PeimEntryPoint.h"],\r
@@ -781,7 +776,8 @@ gModuleTypeHeaderFile = {
     SUP_MODULE_SMM_CORE          :   ["PiDxe.h", "Library/BaseLib.h", "Library/DebugLib.h", "Library/UefiDriverEntryPoint.h"],\r
     SUP_MODULE_MM_STANDALONE     :   ["PiMm.h", "Library/BaseLib.h", "Library/DebugLib.h", "Library/StandaloneMmDriverEntryPoint.h"],\r
     SUP_MODULE_MM_CORE_STANDALONE :  ["PiMm.h", "Library/BaseLib.h", "Library/DebugLib.h", "Library/StandaloneMmCoreEntryPoint.h"],\r
-    SUP_MODULE_USER_DEFINED      :   [gBasicHeaderFile]\r
+    SUP_MODULE_USER_DEFINED      :   [gBasicHeaderFile, "Library/DebugLib.h"],\r
+    SUP_MODULE_HOST_APPLICATION  :   [gBasicHeaderFile, "Library/DebugLib.h"]\r
 }\r
 \r
 ## Autogen internal worker macro to define DynamicEx PCD name includes both the TokenSpaceGuidName\r
@@ -936,7 +932,7 @@ def CreateModulePcdCode(Info, AutoGenC, AutoGenH, Pcd):
         if Info.IsLibrary:\r
             PcdList = Info.LibraryPcdList\r
         else:\r
-            PcdList = list(Info.ModulePcdList) + list(Info.LibraryPcdList)\r
+            PcdList = Info.ModulePcdList + Info.LibraryPcdList\r
         PcdExCNameTest = 0\r
         for PcdModule in PcdList:\r
             if PcdModule.Type in PCD_DYNAMIC_EX_TYPE_SET and Pcd.TokenCName == PcdModule.TokenCName:\r
@@ -970,7 +966,7 @@ def CreateModulePcdCode(Info, AutoGenC, AutoGenH, Pcd):
                 AutoGenH.Append('#define %s(Value)  LibPcdSetEx%sS(&%s, %s, (Value))\n' % (SetModeStatusName, DatumSizeLib, Pcd.TokenSpaceGuidCName, PcdTokenName))\r
     elif Pcd.Type in PCD_DYNAMIC_TYPE_SET:\r
         PcdCNameTest = 0\r
-        for PcdModule in list(Info.LibraryPcdList) + list(Info.ModulePcdList):\r
+        for PcdModule in Info.LibraryPcdList + Info.ModulePcdList:\r
             if PcdModule.Type in PCD_DYNAMIC_TYPE_SET and Pcd.TokenCName == PcdModule.TokenCName:\r
                 PcdCNameTest += 1\r
             # get out early once we found > 1...\r
@@ -1009,6 +1005,8 @@ def CreateModulePcdCode(Info, AutoGenC, AutoGenH, Pcd):
             try:\r
                 if Value.upper().endswith('L'):\r
                     Value = Value[:-1]\r
+                if Value.startswith('0') and not Value.lower().startswith('0x') and len(Value) > 1 and Value.lstrip('0'):\r
+                    Value = Value.lstrip('0')\r
                 ValueNumber = int (Value, 0)\r
             except:\r
                 EdkLogger.error("build", AUTOGEN_ERROR,\r
@@ -1050,7 +1048,7 @@ def CreateModulePcdCode(Info, AutoGenC, AutoGenH, Pcd):
                     else:\r
                         NewValue = NewValue + str(ord(Value[Index]) % 0x100) + ', '\r
                 if Unicode:\r
-                    ArraySize = ArraySize / 2\r
+                    ArraySize = ArraySize // 2\r
                 Value = NewValue + '0 }'\r
             if ArraySize < ValueSize:\r
                 if Pcd.MaxSizeUserSet:\r
@@ -1060,7 +1058,7 @@ def CreateModulePcdCode(Info, AutoGenC, AutoGenH, Pcd):
                 else:\r
                     ArraySize = Pcd.GetPcdSize()\r
                     if Unicode:\r
-                        ArraySize = ArraySize / 2\r
+                        ArraySize = ArraySize // 2\r
             Array = '[%d]' % ArraySize\r
         #\r
         # skip casting for fixed at build since it breaks ARM assembly.\r
@@ -1342,16 +1340,17 @@ def CreateLibraryConstructorCode(Info, AutoGenC, AutoGenH):
         if Lib.ModuleType in [SUP_MODULE_BASE, SUP_MODULE_SEC]:\r
             ConstructorPrototypeString.Append(gLibraryStructorPrototype[SUP_MODULE_BASE].Replace(Dict))\r
             ConstructorCallingString.Append(gLibraryStructorCall[SUP_MODULE_BASE].Replace(Dict))\r
-        elif Lib.ModuleType in SUP_MODULE_SET_PEI:\r
-            ConstructorPrototypeString.Append(gLibraryStructorPrototype['PEI'].Replace(Dict))\r
-            ConstructorCallingString.Append(gLibraryStructorCall['PEI'].Replace(Dict))\r
-        elif Lib.ModuleType in [SUP_MODULE_DXE_CORE, SUP_MODULE_DXE_DRIVER, SUP_MODULE_DXE_SMM_DRIVER, SUP_MODULE_DXE_RUNTIME_DRIVER,\r
-                                SUP_MODULE_DXE_SAL_DRIVER, SUP_MODULE_UEFI_DRIVER, SUP_MODULE_UEFI_APPLICATION, SUP_MODULE_SMM_CORE]:\r
-            ConstructorPrototypeString.Append(gLibraryStructorPrototype['DXE'].Replace(Dict))\r
-            ConstructorCallingString.Append(gLibraryStructorCall['DXE'].Replace(Dict))\r
-        elif Lib.ModuleType in [SUP_MODULE_MM_STANDALONE, SUP_MODULE_MM_CORE_STANDALONE]:\r
-            ConstructorPrototypeString.Append(gLibraryStructorPrototype['MM'].Replace(Dict))\r
-            ConstructorCallingString.Append(gLibraryStructorCall['MM'].Replace(Dict))\r
+        if Info.ModuleType not in [SUP_MODULE_BASE, SUP_MODULE_USER_DEFINED, SUP_MODULE_HOST_APPLICATION]:\r
+            if Lib.ModuleType in SUP_MODULE_SET_PEI:\r
+                ConstructorPrototypeString.Append(gLibraryStructorPrototype['PEI'].Replace(Dict))\r
+                ConstructorCallingString.Append(gLibraryStructorCall['PEI'].Replace(Dict))\r
+            elif Lib.ModuleType in [SUP_MODULE_DXE_CORE, SUP_MODULE_DXE_DRIVER, SUP_MODULE_DXE_SMM_DRIVER, SUP_MODULE_DXE_RUNTIME_DRIVER,\r
+                                    SUP_MODULE_DXE_SAL_DRIVER, SUP_MODULE_UEFI_DRIVER, SUP_MODULE_UEFI_APPLICATION, SUP_MODULE_SMM_CORE]:\r
+                ConstructorPrototypeString.Append(gLibraryStructorPrototype['DXE'].Replace(Dict))\r
+                ConstructorCallingString.Append(gLibraryStructorCall['DXE'].Replace(Dict))\r
+            elif Lib.ModuleType in [SUP_MODULE_MM_STANDALONE, SUP_MODULE_MM_CORE_STANDALONE]:\r
+                ConstructorPrototypeString.Append(gLibraryStructorPrototype['MM'].Replace(Dict))\r
+                ConstructorCallingString.Append(gLibraryStructorCall['MM'].Replace(Dict))\r
 \r
     if str(ConstructorPrototypeString) == '':\r
         ConstructorPrototypeList = []\r
@@ -1370,7 +1369,7 @@ def CreateLibraryConstructorCode(Info, AutoGenC, AutoGenH):
     if Info.IsLibrary:\r
         AutoGenH.Append("${BEGIN}${FunctionPrototype}${END}", Dict)\r
     else:\r
-        if Info.ModuleType in [SUP_MODULE_BASE, SUP_MODULE_SEC]:\r
+        if Info.ModuleType in [SUP_MODULE_BASE, SUP_MODULE_SEC, SUP_MODULE_USER_DEFINED, SUP_MODULE_HOST_APPLICATION]:\r
             AutoGenC.Append(gLibraryString[SUP_MODULE_BASE].Replace(Dict))\r
         elif Info.ModuleType in SUP_MODULE_SET_PEI:\r
             AutoGenC.Append(gLibraryString['PEI'].Replace(Dict))\r
@@ -1404,16 +1403,17 @@ def CreateLibraryDestructorCode(Info, AutoGenC, AutoGenH):
         if Lib.ModuleType in [SUP_MODULE_BASE, SUP_MODULE_SEC]:\r
             DestructorPrototypeString.Append(gLibraryStructorPrototype[SUP_MODULE_BASE].Replace(Dict))\r
             DestructorCallingString.Append(gLibraryStructorCall[SUP_MODULE_BASE].Replace(Dict))\r
-        elif Lib.ModuleType in SUP_MODULE_SET_PEI:\r
-            DestructorPrototypeString.Append(gLibraryStructorPrototype['PEI'].Replace(Dict))\r
-            DestructorCallingString.Append(gLibraryStructorCall['PEI'].Replace(Dict))\r
-        elif Lib.ModuleType in [SUP_MODULE_DXE_CORE, SUP_MODULE_DXE_DRIVER, SUP_MODULE_DXE_SMM_DRIVER, SUP_MODULE_DXE_RUNTIME_DRIVER,\r
-                                SUP_MODULE_DXE_SAL_DRIVER, SUP_MODULE_UEFI_DRIVER, SUP_MODULE_UEFI_APPLICATION, SUP_MODULE_SMM_CORE]:\r
-            DestructorPrototypeString.Append(gLibraryStructorPrototype['DXE'].Replace(Dict))\r
-            DestructorCallingString.Append(gLibraryStructorCall['DXE'].Replace(Dict))\r
-        elif Lib.ModuleType in [SUP_MODULE_MM_STANDALONE, SUP_MODULE_MM_CORE_STANDALONE]:\r
-            DestructorPrototypeString.Append(gLibraryStructorPrototype['MM'].Replace(Dict))\r
-            DestructorCallingString.Append(gLibraryStructorCall['MM'].Replace(Dict))\r
+        if Info.ModuleType not in [SUP_MODULE_BASE, SUP_MODULE_USER_DEFINED, SUP_MODULE_HOST_APPLICATION]:\r
+            if Lib.ModuleType in SUP_MODULE_SET_PEI:\r
+                DestructorPrototypeString.Append(gLibraryStructorPrototype['PEI'].Replace(Dict))\r
+                DestructorCallingString.Append(gLibraryStructorCall['PEI'].Replace(Dict))\r
+            elif Lib.ModuleType in [SUP_MODULE_DXE_CORE, SUP_MODULE_DXE_DRIVER, SUP_MODULE_DXE_SMM_DRIVER, SUP_MODULE_DXE_RUNTIME_DRIVER,\r
+                                    SUP_MODULE_DXE_SAL_DRIVER, SUP_MODULE_UEFI_DRIVER, SUP_MODULE_UEFI_APPLICATION, SUP_MODULE_SMM_CORE]:\r
+                DestructorPrototypeString.Append(gLibraryStructorPrototype['DXE'].Replace(Dict))\r
+                DestructorCallingString.Append(gLibraryStructorCall['DXE'].Replace(Dict))\r
+            elif Lib.ModuleType in [SUP_MODULE_MM_STANDALONE, SUP_MODULE_MM_CORE_STANDALONE]:\r
+                DestructorPrototypeString.Append(gLibraryStructorPrototype['MM'].Replace(Dict))\r
+                DestructorCallingString.Append(gLibraryStructorCall['MM'].Replace(Dict))\r
 \r
     if str(DestructorPrototypeString) == '':\r
         DestructorPrototypeList = []\r
@@ -1432,7 +1432,7 @@ def CreateLibraryDestructorCode(Info, AutoGenC, AutoGenH):
     if Info.IsLibrary:\r
         AutoGenH.Append("${BEGIN}${FunctionPrototype}${END}", Dict)\r
     else:\r
-        if Info.ModuleType in [SUP_MODULE_BASE, SUP_MODULE_SEC]:\r
+        if Info.ModuleType in [SUP_MODULE_BASE, SUP_MODULE_SEC, SUP_MODULE_USER_DEFINED, SUP_MODULE_HOST_APPLICATION]:\r
             AutoGenC.Append(gLibraryString[SUP_MODULE_BASE].Replace(Dict))\r
         elif Info.ModuleType in SUP_MODULE_SET_PEI:\r
             AutoGenC.Append(gLibraryString['PEI'].Replace(Dict))\r
@@ -1450,7 +1450,7 @@ def CreateLibraryDestructorCode(Info, AutoGenC, AutoGenH):
 #   @param      AutoGenH    The TemplateString object for header file\r
 #\r
 def CreateModuleEntryPointCode(Info, AutoGenC, AutoGenH):\r
-    if Info.IsLibrary or Info.ModuleType in [SUP_MODULE_USER_DEFINED, SUP_MODULE_SEC]:\r
+    if Info.IsLibrary or Info.ModuleType in [SUP_MODULE_USER_DEFINED, SUP_MODULE_HOST_APPLICATION, SUP_MODULE_SEC]:\r
         return\r
     #\r
     # Module Entry Points\r
@@ -1472,8 +1472,8 @@ def CreateModuleEntryPointCode(Info, AutoGenC, AutoGenH):
 \r
     if Info.ModuleType in [SUP_MODULE_PEI_CORE, SUP_MODULE_DXE_CORE, SUP_MODULE_SMM_CORE, SUP_MODULE_MM_CORE_STANDALONE]:\r
         if Info.SourceFileList:\r
-          if NumEntryPoints != 1:\r
-              EdkLogger.error(\r
+            if NumEntryPoints != 1:\r
+                EdkLogger.error(\r
                   "build",\r
                   AUTOGEN_ERROR,\r
                   '%s must have exactly one entry point' % Info.ModuleType,\r
@@ -1530,7 +1530,7 @@ def CreateModuleEntryPointCode(Info, AutoGenC, AutoGenH):
 #   @param      AutoGenH    The TemplateString object for header file\r
 #\r
 def CreateModuleUnloadImageCode(Info, AutoGenC, AutoGenH):\r
-    if Info.IsLibrary or Info.ModuleType in [SUP_MODULE_USER_DEFINED, SUP_MODULE_SEC]:\r
+    if Info.IsLibrary or Info.ModuleType in [SUP_MODULE_USER_DEFINED, SUP_MODULE_HOST_APPLICATION, SUP_MODULE_BASE, SUP_MODULE_SEC]:\r
         return\r
     #\r
     # Unload Image Handlers\r
@@ -1550,7 +1550,7 @@ def CreateModuleUnloadImageCode(Info, AutoGenC, AutoGenH):
 #   @param      AutoGenH    The TemplateString object for header file\r
 #\r
 def CreateGuidDefinitionCode(Info, AutoGenC, AutoGenH):\r
-    if Info.ModuleType in [SUP_MODULE_USER_DEFINED, SUP_MODULE_BASE]:\r
+    if Info.ModuleType in [SUP_MODULE_USER_DEFINED, SUP_MODULE_HOST_APPLICATION, SUP_MODULE_BASE]:\r
         GuidType = TAB_GUID\r
     else:\r
         GuidType = "EFI_GUID"\r
@@ -1574,7 +1574,7 @@ def CreateGuidDefinitionCode(Info, AutoGenC, AutoGenH):
 #   @param      AutoGenH    The TemplateString object for header file\r
 #\r
 def CreateProtocolDefinitionCode(Info, AutoGenC, AutoGenH):\r
-    if Info.ModuleType in [SUP_MODULE_USER_DEFINED, SUP_MODULE_BASE]:\r
+    if Info.ModuleType in [SUP_MODULE_USER_DEFINED, SUP_MODULE_HOST_APPLICATION, SUP_MODULE_BASE]:\r
         GuidType = TAB_GUID\r
     else:\r
         GuidType = "EFI_GUID"\r
@@ -1598,7 +1598,7 @@ def CreateProtocolDefinitionCode(Info, AutoGenC, AutoGenH):
 #   @param      AutoGenH    The TemplateString object for header file\r
 #\r
 def CreatePpiDefinitionCode(Info, AutoGenC, AutoGenH):\r
-    if Info.ModuleType in [SUP_MODULE_USER_DEFINED, SUP_MODULE_BASE]:\r
+    if Info.ModuleType in [SUP_MODULE_USER_DEFINED, SUP_MODULE_HOST_APPLICATION, SUP_MODULE_BASE]:\r
         GuidType = TAB_GUID\r
     else:\r
         GuidType = "EFI_GUID"\r
@@ -1629,13 +1629,13 @@ def CreatePcdCode(Info, AutoGenC, AutoGenH):
         if Pcd.Type in PCD_DYNAMIC_EX_TYPE_SET and Pcd.TokenSpaceGuidCName not in TokenSpaceList:\r
             TokenSpaceList.append(Pcd.TokenSpaceGuidCName)\r
 \r
-    SkuMgr = Info.Workspace.Platform.SkuIdMgr\r
+    SkuMgr = Info.PlatformInfo.Platform.SkuIdMgr\r
     AutoGenH.Append("\n// Definition of SkuId Array\n")\r
     AutoGenH.Append("extern UINT64 _gPcd_SkuId_Array[];\n")\r
     # Add extern declarations to AutoGen.h if one or more Token Space GUIDs were found\r
     if TokenSpaceList:\r
         AutoGenH.Append("\n// Definition of PCD Token Space GUIDs used in this module\n\n")\r
-        if Info.ModuleType in [SUP_MODULE_USER_DEFINED, SUP_MODULE_BASE]:\r
+        if Info.ModuleType in [SUP_MODULE_USER_DEFINED, SUP_MODULE_HOST_APPLICATION, SUP_MODULE_BASE]:\r
             GuidType = TAB_GUID\r
         else:\r
             GuidType = "EFI_GUID"\r
@@ -1680,22 +1680,6 @@ def CreateUnicodeStringCode(Info, AutoGenC, AutoGenH, UniGenCFlag, UniGenBinBuff
     # Get all files under [Sources] section in inf file for EDK-II module\r
     EDK2Module = True\r
     SrcList = [F for F in Info.SourceFileList]\r
-    if Info.AutoGenVersion < 0x00010005:\r
-        EDK2Module = False\r
-        # Get all files under the module directory for EDK-I module\r
-        Cwd = os.getcwd()\r
-        os.chdir(Info.MetaFile.Dir)\r
-        for Root, Dirs, Files in os.walk("."):\r
-            if 'CVS' in Dirs:\r
-                Dirs.remove('CVS')\r
-            if '.svn' in Dirs:\r
-                Dirs.remove('.svn')\r
-            for File in Files:\r
-                File = PathClass(os.path.join(Root, File), Info.MetaFile.Dir)\r
-                if File in SrcList:\r
-                    continue\r
-                SrcList.append(File)\r
-        os.chdir(Cwd)\r
 \r
     if 'BUILD' in Info.BuildOption and Info.BuildOption['BUILD']['FLAGS'].find('-c') > -1:\r
         CompatibleMode = True\r
@@ -1764,59 +1748,60 @@ def CreateIdfFileCode(Info, AutoGenC, StringH, IdfGenCFlag, IdfGenBinBuffer):
                     for FileObj in ImageFiles.ImageFilesDict[Idf]:\r
                         ID = FileObj.ImageID\r
                         File = FileObj.File\r
-                        if not os.path.exists(File.Path) or not os.path.isfile(File.Path):\r
-                            EdkLogger.error("build", FILE_NOT_FOUND, ExtraData=File.Path)\r
-                        SearchImageID (FileObj, FileList)\r
-                        if FileObj.Referenced:\r
-                            if (ValueStartPtr - len(DEFINE_STR + ID)) <= 0:\r
-                                Line = DEFINE_STR + ' ' + ID + ' ' + DecToHexStr(Index, 4) + '\n'\r
-                            else:\r
-                                Line = DEFINE_STR + ' ' + ID + ' ' * (ValueStartPtr - len(DEFINE_STR + ID)) + DecToHexStr(Index, 4) + '\n'\r
-\r
-                            if File not in FileDict:\r
-                                FileDict[File] = Index\r
-                            else:\r
-                                DuplicateBlock = pack('B', EFI_HII_IIBT_DUPLICATE)\r
-                                DuplicateBlock += pack('H', FileDict[File])\r
-                                ImageBuffer += DuplicateBlock\r
+                        try:\r
+                            SearchImageID (FileObj, FileList)\r
+                            if FileObj.Referenced:\r
+                                if (ValueStartPtr - len(DEFINE_STR + ID)) <= 0:\r
+                                    Line = DEFINE_STR + ' ' + ID + ' ' + DecToHexStr(Index, 4) + '\n'\r
+                                else:\r
+                                    Line = DEFINE_STR + ' ' + ID + ' ' * (ValueStartPtr - len(DEFINE_STR + ID)) + DecToHexStr(Index, 4) + '\n'\r
+\r
+                                if File not in FileDict:\r
+                                    FileDict[File] = Index\r
+                                else:\r
+                                    DuplicateBlock = pack('B', EFI_HII_IIBT_DUPLICATE)\r
+                                    DuplicateBlock += pack('H', FileDict[File])\r
+                                    ImageBuffer += DuplicateBlock\r
+                                    BufferStr = WriteLine(BufferStr, '// %s: %s: %s' % (DecToHexStr(Index, 4), ID, DecToHexStr(Index, 4)))\r
+                                    TempBufferList = AscToHexList(DuplicateBlock)\r
+                                    BufferStr = WriteLine(BufferStr, CreateArrayItem(TempBufferList, 16) + '\n')\r
+                                    StringH.Append(Line)\r
+                                    Index += 1\r
+                                    continue\r
+\r
+                                TmpFile = open(File.Path, 'rb')\r
+                                Buffer = TmpFile.read()\r
+                                TmpFile.close()\r
+                                if File.Ext.upper() == '.PNG':\r
+                                    TempBuffer = pack('B', EFI_HII_IIBT_IMAGE_PNG)\r
+                                    TempBuffer += pack('I', len(Buffer))\r
+                                    TempBuffer += Buffer\r
+                                elif File.Ext.upper() == '.JPG':\r
+                                    ImageType, = struct.unpack('4s', Buffer[6:10])\r
+                                    if ImageType != b'JFIF':\r
+                                        EdkLogger.error("build", FILE_TYPE_MISMATCH, "The file %s is not a standard JPG file." % File.Path)\r
+                                    TempBuffer = pack('B', EFI_HII_IIBT_IMAGE_JPEG)\r
+                                    TempBuffer += pack('I', len(Buffer))\r
+                                    TempBuffer += Buffer\r
+                                elif File.Ext.upper() == '.BMP':\r
+                                    TempBuffer, TempPalette = BmpImageDecoder(File, Buffer, PaletteIndex, FileObj.TransParent)\r
+                                    if len(TempPalette) > 1:\r
+                                        PaletteIndex += 1\r
+                                        NewPalette = pack('H', len(TempPalette))\r
+                                        NewPalette += TempPalette\r
+                                        PaletteBuffer += NewPalette\r
+                                        PaletteStr = WriteLine(PaletteStr, '// %s: %s: %s' % (DecToHexStr(PaletteIndex - 1, 4), ID, DecToHexStr(PaletteIndex - 1, 4)))\r
+                                        TempPaletteList = AscToHexList(NewPalette)\r
+                                        PaletteStr = WriteLine(PaletteStr, CreateArrayItem(TempPaletteList, 16) + '\n')\r
+                                ImageBuffer += TempBuffer\r
                                 BufferStr = WriteLine(BufferStr, '// %s: %s: %s' % (DecToHexStr(Index, 4), ID, DecToHexStr(Index, 4)))\r
-                                TempBufferList = AscToHexList(DuplicateBlock)\r
+                                TempBufferList = AscToHexList(TempBuffer)\r
                                 BufferStr = WriteLine(BufferStr, CreateArrayItem(TempBufferList, 16) + '\n')\r
+\r
                                 StringH.Append(Line)\r
                                 Index += 1\r
-                                continue\r
-\r
-                            TmpFile = open(File.Path, 'rb')\r
-                            Buffer = TmpFile.read()\r
-                            TmpFile.close()\r
-                            if File.Ext.upper() == '.PNG':\r
-                                TempBuffer = pack('B', EFI_HII_IIBT_IMAGE_PNG)\r
-                                TempBuffer += pack('I', len(Buffer))\r
-                                TempBuffer += Buffer\r
-                            elif File.Ext.upper() == '.JPG':\r
-                                ImageType, = struct.unpack('4s', Buffer[6:10])\r
-                                if ImageType != b'JFIF':\r
-                                    EdkLogger.error("build", FILE_TYPE_MISMATCH, "The file %s is not a standard JPG file." % File.Path)\r
-                                TempBuffer = pack('B', EFI_HII_IIBT_IMAGE_JPEG)\r
-                                TempBuffer += pack('I', len(Buffer))\r
-                                TempBuffer += Buffer\r
-                            elif File.Ext.upper() == '.BMP':\r
-                                TempBuffer, TempPalette = BmpImageDecoder(File, Buffer, PaletteIndex, FileObj.TransParent)\r
-                                if len(TempPalette) > 1:\r
-                                    PaletteIndex += 1\r
-                                    NewPalette = pack('H', len(TempPalette))\r
-                                    NewPalette += TempPalette\r
-                                    PaletteBuffer += NewPalette\r
-                                    PaletteStr = WriteLine(PaletteStr, '// %s: %s: %s' % (DecToHexStr(PaletteIndex - 1, 4), ID, DecToHexStr(PaletteIndex - 1, 4)))\r
-                                    TempPaletteList = AscToHexList(NewPalette)\r
-                                    PaletteStr = WriteLine(PaletteStr, CreateArrayItem(TempPaletteList, 16) + '\n')\r
-                            ImageBuffer += TempBuffer\r
-                            BufferStr = WriteLine(BufferStr, '// %s: %s: %s' % (DecToHexStr(Index, 4), ID, DecToHexStr(Index, 4)))\r
-                            TempBufferList = AscToHexList(TempBuffer)\r
-                            BufferStr = WriteLine(BufferStr, CreateArrayItem(TempBufferList, 16) + '\n')\r
-\r
-                            StringH.Append(Line)\r
-                            Index += 1\r
+                        except IOError:\r
+                            EdkLogger.error("build", FILE_NOT_FOUND, ExtraData=File.Path)\r
 \r
             BufferStr = WriteLine(BufferStr, '// End of the Image Info')\r
             BufferStr = WriteLine(BufferStr, CreateArrayItem(DecToHexList(EFI_HII_IIBT_END, 2)) + '\n')\r
@@ -1919,7 +1904,7 @@ def BmpImageDecoder(File, Buffer, PaletteIndex, TransParent):
         else:\r
             ImageBuffer = pack('B', EFI_HII_IIBT_IMAGE_1BIT)\r
         ImageBuffer += pack('B', PaletteIndex)\r
-        Width = (BmpHeader.biWidth + 7)/8\r
+        Width = (BmpHeader.biWidth + 7)//8\r
         if BmpHeader.bfOffBits > BMP_IMAGE_HEADER_STRUCT.size + 2:\r
             PaletteBuffer = Buffer[BMP_IMAGE_HEADER_STRUCT.size + 2 : BmpHeader.bfOffBits]\r
     elif BmpHeader.biBitCount == 4:\r
@@ -1928,7 +1913,7 @@ def BmpImageDecoder(File, Buffer, PaletteIndex, TransParent):
         else:\r
             ImageBuffer = pack('B', EFI_HII_IIBT_IMAGE_4BIT)\r
         ImageBuffer += pack('B', PaletteIndex)\r
-        Width = (BmpHeader.biWidth + 1)/2\r
+        Width = (BmpHeader.biWidth + 1)//2\r
         if BmpHeader.bfOffBits > BMP_IMAGE_HEADER_STRUCT.size + 2:\r
             PaletteBuffer = Buffer[BMP_IMAGE_HEADER_STRUCT.size + 2 : BmpHeader.bfOffBits]\r
     elif BmpHeader.biBitCount == 8:\r
@@ -1967,7 +1952,7 @@ def BmpImageDecoder(File, Buffer, PaletteIndex, TransParent):
         for Index in range(0, len(PaletteBuffer)):\r
             if Index % 4 == 3:\r
                 continue\r
-            PaletteTemp += bytes([PaletteBuffer[Index]])\r
+            PaletteTemp += PaletteBuffer[Index:Index+1]\r
         PaletteBuffer = PaletteTemp[1:]\r
     return ImageBuffer, PaletteBuffer\r
 \r
@@ -1983,42 +1968,41 @@ def CreateHeaderCode(Info, AutoGenC, AutoGenH):
     # header file Prologue\r
     AutoGenH.Append(gAutoGenHPrologueString.Replace({'File':'AUTOGENH','Guid':Info.Guid.replace('-', '_')}))\r
     AutoGenH.Append(gAutoGenHCppPrologueString)\r
-    if Info.AutoGenVersion >= 0x00010005:\r
-        # header files includes\r
-        if Info.ModuleType in gModuleTypeHeaderFile:\r
-            AutoGenH.Append("#include <%s>\n" % gModuleTypeHeaderFile[Info.ModuleType][0])\r
-        #\r
-        # if either PcdLib in [LibraryClasses] sections or there exist Pcd section, add PcdLib.h\r
-        # As if modules only uses FixedPcd, then PcdLib is not needed in [LibraryClasses] section.\r
-        #\r
-        if 'PcdLib' in Info.Module.LibraryClasses or Info.Module.Pcds:\r
-            AutoGenH.Append("#include <Library/PcdLib.h>\n")\r
 \r
-        AutoGenH.Append('\nextern GUID  gEfiCallerIdGuid;')\r
-        AutoGenH.Append('\nextern CHAR8 *gEfiCallerBaseName;\n\n')\r
+    # header files includes\r
+    if Info.ModuleType in gModuleTypeHeaderFile:\r
+        AutoGenH.Append("#include <%s>\n" % gModuleTypeHeaderFile[Info.ModuleType][0])\r
+    #\r
+    # if either PcdLib in [LibraryClasses] sections or there exist Pcd section, add PcdLib.h\r
+    # As if modules only uses FixedPcd, then PcdLib is not needed in [LibraryClasses] section.\r
+    #\r
+    if 'PcdLib' in Info.Module.LibraryClasses or Info.Module.Pcds:\r
+        AutoGenH.Append("#include <Library/PcdLib.h>\n")\r
+\r
+    AutoGenH.Append('\nextern GUID  gEfiCallerIdGuid;')\r
+    AutoGenH.Append('\nextern CHAR8 *gEfiCallerBaseName;\n\n')\r
 \r
-        if Info.IsLibrary:\r
-            return\r
+    if Info.IsLibrary:\r
+        return\r
 \r
-        AutoGenH.Append("#define EFI_CALLER_ID_GUID \\\n  %s\n" % GuidStringToGuidStructureString(Info.Guid))\r
+    AutoGenH.Append("#define EFI_CALLER_ID_GUID \\\n  %s\n" % GuidStringToGuidStructureString(Info.Guid))\r
 \r
     if Info.IsLibrary:\r
         return\r
     # C file header\r
     AutoGenC.Append(gAutoGenHeaderString.Replace({'FileName':'AutoGen.c'}))\r
-    if Info.AutoGenVersion >= 0x00010005:\r
-        # C file header files includes\r
-        if Info.ModuleType in gModuleTypeHeaderFile:\r
-            for Inc in gModuleTypeHeaderFile[Info.ModuleType]:\r
-                AutoGenC.Append("#include <%s>\n" % Inc)\r
-        else:\r
-            AutoGenC.Append("#include <%s>\n" % gBasicHeaderFile)\r
+    # C file header files includes\r
+    if Info.ModuleType in gModuleTypeHeaderFile:\r
+        for Inc in gModuleTypeHeaderFile[Info.ModuleType]:\r
+            AutoGenC.Append("#include <%s>\n" % Inc)\r
+    else:\r
+        AutoGenC.Append("#include <%s>\n" % gBasicHeaderFile)\r
 \r
-        #\r
-        # Publish the CallerId Guid\r
-        #\r
-        AutoGenC.Append('\nGLOBAL_REMOVE_IF_UNREFERENCED GUID gEfiCallerIdGuid = %s;\n' % GuidStringToGuidStructureString(Info.Guid))\r
-        AutoGenC.Append('\nGLOBAL_REMOVE_IF_UNREFERENCED CHAR8 *gEfiCallerBaseName = "%s";\n' % Info.Name)\r
+    #\r
+    # Publish the CallerId Guid\r
+    #\r
+    AutoGenC.Append('\nGLOBAL_REMOVE_IF_UNREFERENCED GUID gEfiCallerIdGuid = %s;\n' % GuidStringToGuidStructureString(Info.Guid))\r
+    AutoGenC.Append('\nGLOBAL_REMOVE_IF_UNREFERENCED CHAR8 *gEfiCallerBaseName = "%s";\n' % Info.Name)\r
 \r
 ## Create common code for header file\r
 #\r
@@ -2044,15 +2028,14 @@ def CreateFooterCode(Info, AutoGenC, AutoGenH):
 def CreateCode(Info, AutoGenC, AutoGenH, StringH, UniGenCFlag, UniGenBinBuffer, StringIdf, IdfGenCFlag, IdfGenBinBuffer):\r
     CreateHeaderCode(Info, AutoGenC, AutoGenH)\r
 \r
-    if Info.AutoGenVersion >= 0x00010005:\r
-        CreateGuidDefinitionCode(Info, AutoGenC, AutoGenH)\r
-        CreateProtocolDefinitionCode(Info, AutoGenC, AutoGenH)\r
-        CreatePpiDefinitionCode(Info, AutoGenC, AutoGenH)\r
-        CreatePcdCode(Info, AutoGenC, AutoGenH)\r
-        CreateLibraryConstructorCode(Info, AutoGenC, AutoGenH)\r
-        CreateLibraryDestructorCode(Info, AutoGenC, AutoGenH)\r
-        CreateModuleEntryPointCode(Info, AutoGenC, AutoGenH)\r
-        CreateModuleUnloadImageCode(Info, AutoGenC, AutoGenH)\r
+    CreateGuidDefinitionCode(Info, AutoGenC, AutoGenH)\r
+    CreateProtocolDefinitionCode(Info, AutoGenC, AutoGenH)\r
+    CreatePpiDefinitionCode(Info, AutoGenC, AutoGenH)\r
+    CreatePcdCode(Info, AutoGenC, AutoGenH)\r
+    CreateLibraryConstructorCode(Info, AutoGenC, AutoGenH)\r
+    CreateLibraryDestructorCode(Info, AutoGenC, AutoGenH)\r
+    CreateModuleEntryPointCode(Info, AutoGenC, AutoGenH)\r
+    CreateModuleUnloadImageCode(Info, AutoGenC, AutoGenH)\r
 \r
     if Info.UnicodeFileList:\r
         FileName = "%sStrDefs.h" % Info.Name\r
@@ -2111,10 +2094,6 @@ def CreateCode(Info, AutoGenC, AutoGenH, StringH, UniGenCFlag, UniGenBinBuffer,
 \r
     CreateFooterCode(Info, AutoGenC, AutoGenH)\r
 \r
-    # no generation of AutoGen.c for Edk modules without unicode file\r
-    if Info.AutoGenVersion < 0x00010005 and len(Info.UnicodeFileList) == 0:\r
-        AutoGenC.String = ''\r
-\r
 ## Create the code file\r
 #\r
 #   @param      FilePath     The path of code file\r