BaseTools: dont make iterator into list if not needed

[mirror_edk2.git] / BaseTools / Source / Python / AutoGen / GenVar.py

diff --git a/BaseTools/Source/Python/AutoGen/GenVar.py b/BaseTools/Source/Python/AutoGen/GenVar.py
index 5660cf1348e142c1b1504cf7009f47f170be5a8b..2eab278d68763f336f3ec24c067a54cb0569da6a 100644 (file)
--- a/BaseTools/Source/Python/AutoGen/GenVar.py
+++ b/BaseTools/Source/Python/AutoGen/GenVar.py
@@ -80,7 +80,7 @@ class VariableMgr(object):
             try:\r
                 newvaluestr = "{" + ",".join(VariableMgr.assemble_variable(newvalue)) +"}"\r
             except:\r
-                EdkLogger.error("build", AUTOGEN_ERROR, "Variable offset conflict in PCDs: %s \n" % (" and ".join([item.pcdname for item in sku_var_info_offset_list])))\r
+                EdkLogger.error("build", AUTOGEN_ERROR, "Variable offset conflict in PCDs: %s \n" % (" and ".join(item.pcdname for item in sku_var_info_offset_list)))\r
             n = sku_var_info_offset_list[0]\r
             indexedvarinfo[key] =  [var_info(n.pcdindex,n.pcdname,n.defaultstoragename,n.skuname,n.var_name, n.var_guid, "0x00",n.var_attribute,newvaluestr  , newvaluestr , DataType.TAB_VOID)]\r
         self.VarInfo = [item[0] for item in indexedvarinfo.values()]\r
@@ -116,9 +116,9 @@ class VariableMgr(object):
             default_sku_default = indexedvarinfo[index].get((DataType.TAB_DEFAULT,DataType.TAB_DEFAULT_STORES_DEFAULT))\r
 \r
             if default_sku_default.data_type not in DataType.TAB_PCD_NUMERIC_TYPES:\r
-                var_max_len = max([len(var_item.default_value.split(",")) for var_item in sku_var_info.values()])\r
+                var_max_len = max(len(var_item.default_value.split(",")) for var_item in sku_var_info.values())\r
                 if len(default_sku_default.default_value.split(",")) < var_max_len:\r
-                    tail = ",".join([ "0x00" for i in range(var_max_len-len(default_sku_default.default_value.split(",")))])\r
+                    tail = ",".join("0x00" for i in range(var_max_len-len(default_sku_default.default_value.split(","))))\r
 \r
             default_data_buffer = VariableMgr.PACK_VARIABLES_DATA(default_sku_default.default_value,default_sku_default.data_type,tail)\r
 \r
@@ -136,7 +136,7 @@ class VariableMgr(object):
 \r
                 if default_sku_default.data_type not in DataType.TAB_PCD_NUMERIC_TYPES:\r
                     if len(other_sku_other.default_value.split(",")) < var_max_len:\r
-                        tail = ",".join([ "0x00" for i in range(var_max_len-len(other_sku_other.default_value.split(",")))])\r
+                        tail = ",".join("0x00" for i in range(var_max_len-len(other_sku_other.default_value.split(","))))\r
 \r
                 others_data_buffer = VariableMgr.PACK_VARIABLES_DATA(other_sku_other.default_value,other_sku_other.data_type,tail)\r
 \r