]> git.proxmox.com Git - mirror_edk2.git/blobdiff - BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
BaseTools: Cleanup unneeded code
[mirror_edk2.git] / BaseTools / Source / Python / GenFds / GenFdsGlobalVariable.py
index 6cf82526efd2b9bcb488ba723b3bd66936d76101..c2e82de891d3594cc08cfbcd769f476200455762 100644 (file)
@@ -439,36 +439,33 @@ class GenFdsGlobalVariable:
 \r
     @staticmethod\r
     def GenerateSection(Output, Input, Type=None, CompressionType=None, Guid=None,\r
-                        GuidHdrLen=None, GuidAttr=[], Ui=None, Ver=None, InputAlign=None, BuildNumber=None, DummyFile=None, IsMakefile=False):\r
+                        GuidHdrLen=None, GuidAttr=[], Ui=None, Ver=None, InputAlign=[], BuildNumber=None, DummyFile=None, IsMakefile=False):\r
         Cmd = ["GenSec"]\r
         if Type:\r
-            Cmd += ["-s", Type]\r
+            Cmd += ("-s", Type)\r
         if CompressionType:\r
-            Cmd += ["-c", CompressionType]\r
+            Cmd += ("-c", CompressionType)\r
         if Guid is not None:\r
-            Cmd += ["-g", Guid]\r
+            Cmd += ("-g", Guid)\r
         if DummyFile is not None:\r
-            Cmd += ["--dummy", DummyFile]\r
+            Cmd += ("--dummy", DummyFile)\r
         if GuidHdrLen:\r
-            Cmd += ["-l", GuidHdrLen]\r
-        if len(GuidAttr) != 0:\r
-            #Add each guided attribute\r
-            for Attr in GuidAttr:\r
-                Cmd += ["-r", Attr]\r
-        if InputAlign is not None:\r
-            #Section Align is only for dummy section without section type\r
-            for SecAlign in InputAlign:\r
-                Cmd += ["--sectionalign", SecAlign]\r
+            Cmd += ("-l", GuidHdrLen)\r
+        #Add each guided attribute\r
+        for Attr in GuidAttr:\r
+            Cmd += ("-r", Attr)\r
+        #Section Align is only for dummy section without section type\r
+        for SecAlign in InputAlign:\r
+            Cmd += ("--sectionalign", SecAlign)\r
 \r
         CommandFile = Output + '.txt'\r
         if Ui:\r
-            #Cmd += ["-n", '"' + Ui + '"']\r
             if IsMakefile:\r
                 if Ui == "$(MODULE_NAME)":\r
-                    Cmd += ['-n', Ui]\r
+                    Cmd += ('-n', Ui)\r
                 else:\r
-                    Cmd += ["-n", '"' + Ui + '"']\r
-                Cmd += ["-o", Output]\r
+                    Cmd += ("-n", '"' + Ui + '"')\r
+                Cmd += ("-o", Output)\r
                 if ' '.join(Cmd).strip() not in GenFdsGlobalVariable.SecCmdList:\r
                     GenFdsGlobalVariable.SecCmdList.append(' '.join(Cmd).strip())\r
             else:\r
@@ -481,10 +478,10 @@ class GenFdsGlobalVariable:
                 SaveFileOnChange(Output, SectionData.tostring())\r
 \r
         elif Ver:\r
-            Cmd += ["-n", Ver]\r
+            Cmd += ("-n", Ver)\r
             if BuildNumber:\r
-                Cmd += ["-j", BuildNumber]\r
-            Cmd += ["-o", Output]\r
+                Cmd += ("-j", BuildNumber)\r
+            Cmd += ("-o", Output)\r
 \r
             SaveFileOnChange(CommandFile, ' '.join(Cmd), False)\r
             if IsMakefile:\r
@@ -495,7 +492,7 @@ class GenFdsGlobalVariable:
                     return\r
                 GenFdsGlobalVariable.CallExternalTool(Cmd, "Failed to generate section")\r
         else:\r
-            Cmd += ["-o", Output]\r
+            Cmd += ("-o", Output)\r
             Cmd += Input\r
 \r
             SaveFileOnChange(CommandFile, ' '.join(Cmd), False)\r
@@ -526,9 +523,9 @@ class GenFdsGlobalVariable:
         Cmd = ["GenFfs", "-t", Type, "-g", Guid]\r
         mFfsValidAlign = ["0", "8", "16", "128", "512", "1K", "4K", "32K", "64K", "128K", "256K", "512K", "1M", "2M", "4M", "8M", "16M"]\r
         if Fixed == True:\r
-            Cmd += ["-x"]\r
+            Cmd.append("-x")\r
         if CheckSum:\r
-            Cmd += ["-s"]\r
+            Cmd.append("-s")\r
         if Align:\r
             if Align not in mFfsValidAlign:\r
                 Align = GenFdsGlobalVariable.GetAlignment (Align)\r
@@ -536,9 +533,9 @@ class GenFdsGlobalVariable:
                     if ((Align > GenFdsGlobalVariable.GetAlignment(mFfsValidAlign[index])) and (Align <= GenFdsGlobalVariable.GetAlignment(mFfsValidAlign[index + 1]))):\r
                         break\r
                 Align = mFfsValidAlign[index + 1]\r
-            Cmd += ["-a", Align]\r
+            Cmd += ("-a", Align)\r
 \r
-        Cmd += ["-o", Output]\r
+        Cmd += ("-o", Output)\r
         for I in range(0, len(Input)):\r
             Cmd += ("-i", Input[I])\r
             if SectionAlign and SectionAlign[I]:\r
@@ -567,26 +564,26 @@ class GenFdsGlobalVariable:
 \r
         Cmd = ["GenFv"]\r
         if BaseAddress:\r
-            Cmd += ["-r", BaseAddress]\r
+            Cmd += ("-r", BaseAddress)\r
 \r
         if ForceRebase == False:\r
-            Cmd += ["-F", "FALSE"]\r
+            Cmd += ("-F", "FALSE")\r
         elif ForceRebase == True:\r
-            Cmd += ["-F", "TRUE"]\r
+            Cmd += ("-F", "TRUE")\r
 \r
         if Capsule:\r
-            Cmd += ["-c"]\r
+            Cmd.append("-c")\r
         if Dump:\r
-            Cmd += ["-p"]\r
+            Cmd.append("-p")\r
         if AddressFile:\r
-            Cmd += ["-a", AddressFile]\r
+            Cmd += ("-a", AddressFile)\r
         if MapFile:\r
-            Cmd += ["-m", MapFile]\r
+            Cmd += ("-m", MapFile)\r
         if FileSystemGuid:\r
-            Cmd += ["-g", FileSystemGuid]\r
-        Cmd += ["-o", Output]\r
+            Cmd += ("-g", FileSystemGuid)\r
+        Cmd += ("-o", Output)\r
         for I in Input:\r
-            Cmd += ["-i", I]\r
+            Cmd += ("-i", I)\r
 \r
         GenFdsGlobalVariable.CallExternalTool(Cmd, "Failed to generate FV")\r
 \r
@@ -600,10 +597,10 @@ class GenFdsGlobalVariable:
         if BaseAddress and FvSize \\r
             and len(BaseAddress) == len(FvSize):\r
             for I in range(0, len(BaseAddress)):\r
-                Cmd += ["-r", BaseAddress[I], "-s", FvSize[I]]\r
-        Cmd += ["-o", Output]\r
+                Cmd += ("-r", BaseAddress[I], "-s", FvSize[I])\r
+        Cmd += ("-o", Output)\r
         for F in Input:\r
-            Cmd += ["-f", F]\r
+            Cmd += ("-f", F)\r
 \r
         GenFdsGlobalVariable.CallExternalTool(Cmd, "Failed to generate VTF")\r
 \r
@@ -617,26 +614,26 @@ class GenFdsGlobalVariable:
 \r
         Cmd = ["GenFw"]\r
         if Type.lower() == "te":\r
-            Cmd += ["-t"]\r
+            Cmd.append("-t")\r
         if SubType:\r
-            Cmd += ["-e", SubType]\r
+            Cmd += ("-e", SubType)\r
         if TimeStamp:\r
-            Cmd += ["-s", TimeStamp]\r
+            Cmd += ("-s", TimeStamp)\r
         if Align:\r
-            Cmd += ["-a", Align]\r
+            Cmd += ("-a", Align)\r
         if Padding:\r
-            Cmd += ["-p", Padding]\r
+            Cmd += ("-p", Padding)\r
         if Zero:\r
-            Cmd += ["-z"]\r
+            Cmd.append("-z")\r
         if Strip:\r
-            Cmd += ["-l"]\r
+            Cmd.append("-l")\r
         if Replace:\r
-            Cmd += ["-r"]\r
+            Cmd.append("-r")\r
         if Join:\r
-            Cmd += ["-j"]\r
+            Cmd.append("-j")\r
         if Convert:\r
-            Cmd += ["-m"]\r
-        Cmd += ["-o", Output]\r
+            Cmd.append("-m")\r
+        Cmd += ("-o", Output)\r
         Cmd += Input\r
         if IsMakefile:\r
             if " ".join(Cmd).strip() not in GenFdsGlobalVariable.SecCmdList:\r
@@ -652,18 +649,18 @@ class GenFdsGlobalVariable:
         if len(EfiInput) > 0:\r
             \r
             if Compress:\r
-                Cmd += ["-ec"]\r
+                Cmd.append("-ec")\r
             else:\r
-                Cmd += ["-e"]\r
+                Cmd.append("-e")\r
                 \r
             for EfiFile in EfiInput:\r
-                Cmd += [EfiFile]\r
+                Cmd.append(EfiFile)\r
                 InputList.append (EfiFile)\r
         \r
         if len(BinaryInput) > 0:\r
-            Cmd += ["-b"]\r
+            Cmd.append("-b")\r
             for BinFile in BinaryInput:\r
-                Cmd += [BinFile]\r
+                Cmd.append(BinFile)\r
                 InputList.append (BinFile)\r
 \r
         # Check List\r
@@ -672,15 +669,15 @@ class GenFdsGlobalVariable:
         GenFdsGlobalVariable.DebugLogger(EdkLogger.DEBUG_5, "%s needs update because of newer %s" % (Output, InputList))\r
                         \r
         if ClassCode is not None:\r
-            Cmd += ["-l", ClassCode]\r
+            Cmd += ("-l", ClassCode)\r
         if Revision is not None:\r
-            Cmd += ["-r", Revision]\r
+            Cmd += ("-r", Revision)\r
         if DeviceId is not None:\r
-            Cmd += ["-i", DeviceId]\r
+            Cmd += ("-i", DeviceId)\r
         if VendorId is not None:\r
-            Cmd += ["-f", VendorId]\r
+            Cmd += ("-f", VendorId)\r
 \r
-        Cmd += ["-o", Output]\r
+        Cmd += ("-o", Output)\r
         if IsMakefile:\r
             if " ".join(Cmd).strip() not in GenFdsGlobalVariable.SecCmdList:\r
                 GenFdsGlobalVariable.SecCmdList.append(" ".join(Cmd).strip())\r
@@ -695,7 +692,7 @@ class GenFdsGlobalVariable:
 \r
         Cmd = [ToolPath, ]\r
         Cmd += Options.split(' ')\r
-        Cmd += ["-o", Output]\r
+        Cmd += ("-o", Output)\r
         Cmd += Input\r
         if IsMakefile:\r
             if " ".join(Cmd).strip() not in GenFdsGlobalVariable.SecCmdList:\r