]> git.proxmox.com Git - mirror_edk2.git/blobdiff - BaseTools/Source/Python/Workspace/DscBuildData.py
BaseTools: Remove 'COMMON' in PCD SkuInfoList
[mirror_edk2.git] / BaseTools / Source / Python / Workspace / DscBuildData.py
index 5b5dbb64f9af89c5d8619c1ff3355394ad8ae72b..a9117afa5cebb2246cfff2bbddc843b44173c90c 100644 (file)
@@ -1,7 +1,7 @@
 ## @file\r
 # This file is used to create a database used by build tool\r
 #\r
-# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>\r
+# Copyright (c) 2008 - 2017, Intel Corporation. All rights reserved.<BR>\r
 # (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>\r
 # This program and the accompanying materials\r
 # are licensed and made available under the terms and conditions of the BSD License\r
@@ -23,7 +23,8 @@ from Common.Misc import *
 from types import *\r
 \r
 from CommonDataClass.CommonClass import SkuInfoClass\r
-\r
+from Common.TargetTxtClassObject import *\r
+from Common.ToolDefClassObject import *\r
 from MetaDataTable import *\r
 from MetaFileTable import *\r
 from MetaFileParser import *\r
@@ -77,11 +78,11 @@ PcdMakefileHeader = '''
 \r
 '''\r
 \r
+WindowsCFLAGS = 'CFLAGS = $(CFLAGS) /wd4200 /wd4034 /wd4101 '\r
+LinuxCFLAGS = 'BUILD_CFLAGS += -Wno-pointer-to-int-cast -Wno-unused-variable '\r
 PcdMakefileEnd = '''\r
 !INCLUDE $(BASE_TOOLS_PATH)\Source\C\Makefiles\ms.common\r
 \r
-CFLAGS = $(CFLAGS) /wd4200 /wd4034 /wd4101\r
-\r
 LIBS = $(LIB_PATH)\Common.lib\r
 \r
 !INCLUDE $(BASE_TOOLS_PATH)\Source\C\Makefiles\ms.app\r
@@ -152,6 +153,7 @@ class DscBuildData(PlatformBuildClassObject):
         self._Arch = Arch\r
         self._Target = Target\r
         self._Toolchain = Toolchain\r
+        self._ToolChainFamily = None\r
         self._Clear()\r
         self._HandleOverridePath()\r
         if os.getenv("WORKSPACE"):\r
@@ -159,7 +161,7 @@ class DscBuildData(PlatformBuildClassObject):
         else:\r
             self.OutputPath = os.path.dirname(self.DscFile)\r
         self.DefaultStores = None\r
-        self.SkuIdMgr = SkuClass(self.SkuIdentifier, self.SkuIds)\r
+        self.SkuIdMgr = SkuClass(self.SkuName, self.SkuIds)\r
         arraystr = self.SkuIdMgr.DumpSkuIdArrary()\r
 \r
     ## XXX[key] = value\r
@@ -185,8 +187,6 @@ class DscBuildData(PlatformBuildClassObject):
         self._SupArchList       = None\r
         self._BuildTargets      = None\r
         self._SkuName           = None\r
-        self._SkuIdentifier     = None\r
-        self._AvilableSkuIds    = None\r
         self._PcdInfoFlag       = None\r
         self._VarCheckFlag      = None\r
         self._FlashDefinition   = None\r
@@ -306,8 +306,8 @@ class DscBuildData(PlatformBuildClassObject):
             elif Name == TAB_DSC_DEFINES_SKUID_IDENTIFIER:\r
                 if self._SkuName == None:\r
                     self._SkuName = Record[2]\r
-                self._SkuIdentifier = Record[2]\r
-                self._AvilableSkuIds = Record[2]\r
+                if GlobalData.gSKUID_CMD:\r
+                    self._SkuName = GlobalData.gSKUID_CMD\r
             elif Name == TAB_DSC_DEFINES_PCD_INFO_GENERATION:\r
                 self._PcdInfoFlag = Record[2]\r
             elif Name == TAB_DSC_DEFINES_PCD_VAR_CHECK_GENERATION:\r
@@ -438,23 +438,13 @@ class DscBuildData(PlatformBuildClassObject):
             return True\r
         else:\r
             return False\r
-    def _GetAviableSkuIds(self):\r
-        if self._AvilableSkuIds:\r
-            return self._AvilableSkuIds\r
-        return self.SkuIdentifier\r
-    def _GetSkuIdentifier(self):\r
-        if self._SkuName:\r
-            return self._SkuName\r
-        if self._SkuIdentifier == None:\r
-            if self._Header == None:\r
-                self._GetHeaderInfo()\r
-        return self._SkuIdentifier\r
-    ## Retrieve SKUID_IDENTIFIER\r
+\r
+    # # Retrieve SKUID_IDENTIFIER\r
     def _GetSkuName(self):\r
         if self._SkuName == None:\r
             if self._Header == None:\r
                 self._GetHeaderInfo()\r
-            if (self._SkuName == None or self._SkuName not in self.SkuIds):\r
+            if self._SkuName == None:\r
                 self._SkuName = 'DEFAULT'\r
         return self._SkuName\r
 \r
@@ -598,7 +588,7 @@ class DscBuildData(PlatformBuildClassObject):
                 if not IsValidWord(Record[1]):\r
                     EdkLogger.error('build', FORMAT_INVALID, "The format of the Sku ID name is invalid. The correct format is '(a-zA-Z0-9_)(a-zA-Z0-9_-.)*'",\r
                                     File=self.MetaFile, Line=Record[-1])\r
-                self._SkuIds[Record[1]] = (Record[0],Record[1],Record[2])\r
+                self._SkuIds[Record[1].upper()] = (Record[0], Record[1].upper(), Record[2].upper())\r
             if 'DEFAULT' not in self._SkuIds:\r
                 self._SkuIds['DEFAULT'] = ("0","DEFAULT","DEFAULT")\r
             if 'COMMON' not in self._SkuIds:\r
@@ -617,9 +607,12 @@ class DscBuildData(PlatformBuildClassObject):
                 if Record[1] in [None, '']:\r
                     EdkLogger.error('build', FORMAT_INVALID, 'No DefaultStores ID name',\r
                                     File=self.MetaFile, Line=Record[-1])\r
-                self.DefaultStores[Record[1]] = (self.ToInt(Record[0]),Record[1])\r
+                self.DefaultStores[Record[1].upper()] = (self.ToInt(Record[0]),Record[1].upper())\r
             if TAB_DEFAULT_STORES_DEFAULT not in self.DefaultStores:\r
                 self.DefaultStores[TAB_DEFAULT_STORES_DEFAULT] = (0,TAB_DEFAULT_STORES_DEFAULT)\r
+            GlobalData.gDefaultStores = self.DefaultStores.keys()\r
+            if GlobalData.gDefaultStores:\r
+                GlobalData.gDefaultStores.sort()\r
         return self.DefaultStores\r
 \r
     ## Retrieve [Components] section information\r
@@ -794,7 +787,7 @@ class DscBuildData(PlatformBuildClassObject):
 \r
     def _ValidatePcd(self, PcdCName, TokenSpaceGuid, Setting, PcdType, LineNo):\r
         if self._DecPcds == None:\r
-            self._DecPcds = GetDeclaredPcd(self, self._Bdb, self._Arch, self._Target, self._Toolchain)\r
+\r
             FdfInfList = []\r
             if GlobalData.gFdfParser:\r
                 FdfInfList = GlobalData.gFdfParser.Profile.InfList\r
@@ -806,25 +799,30 @@ class DscBuildData(PlatformBuildClassObject):
                     continue\r
                 ModuleData = self._Bdb[ModuleFile, self._Arch, self._Target, self._Toolchain]\r
                 PkgSet.update(ModuleData.Packages)\r
-            DecPcds = {}\r
-            for Pkg in PkgSet:\r
-                for Pcd in Pkg.Pcds:\r
-                    DecPcds[Pcd[0], Pcd[1]] = Pkg.Pcds[Pcd]\r
-            self._DecPcds.update(DecPcds)\r
 \r
-        if (PcdCName, TokenSpaceGuid) not in self._DecPcds and "." in TokenSpaceGuid and (TokenSpaceGuid.split(".")[1], TokenSpaceGuid.split(".")[0]) not in self._DecPcds:\r
+            self._DecPcds, self._GuidDict = GetDeclaredPcd(self, self._Bdb, self._Arch, self._Target, self._Toolchain,PkgSet)\r
+\r
+\r
+        if (PcdCName, TokenSpaceGuid) not in self._DecPcds:\r
             EdkLogger.error('build', PARSER_ERROR,\r
                             "Pcd (%s.%s) defined in DSC is not declared in DEC files. Arch: ['%s']" % (TokenSpaceGuid, PcdCName, self._Arch),\r
                             File=self.MetaFile, Line=LineNo)\r
         ValueList, IsValid, Index = AnalyzeDscPcd(Setting, PcdType, self._DecPcds[PcdCName, TokenSpaceGuid].DatumType)\r
-        if not IsValid and PcdType not in [MODEL_PCD_FEATURE_FLAG, MODEL_PCD_FIXED_AT_BUILD]:\r
-            EdkLogger.error('build', FORMAT_INVALID, "Pcd format incorrect.", File=self.MetaFile, Line=LineNo,\r
-                            ExtraData="%s.%s|%s" % (TokenSpaceGuid, PcdCName, Setting))\r
+        if not IsValid:\r
+            if PcdType not in [MODEL_PCD_FEATURE_FLAG, MODEL_PCD_FIXED_AT_BUILD]:\r
+                EdkLogger.error('build', FORMAT_INVALID, "Pcd format incorrect.", File=self.MetaFile, Line=LineNo,\r
+                                ExtraData="%s.%s|%s" % (TokenSpaceGuid, PcdCName, Setting))\r
+            else:\r
+                if ValueList[2] == '-1':\r
+                    EdkLogger.error('build', FORMAT_INVALID, "Pcd format incorrect.", File=self.MetaFile, Line=LineNo,\r
+                                ExtraData="%s.%s|%s" % (TokenSpaceGuid, PcdCName, Setting))\r
         if ValueList[Index] and PcdType not in [MODEL_PCD_FEATURE_FLAG, MODEL_PCD_FIXED_AT_BUILD]:\r
             try:\r
                 ValueList[Index] = ValueExpression(ValueList[Index], GlobalData.gPlatformPcds)(True)\r
             except WrnExpression, Value:\r
                 ValueList[Index] = Value.result\r
+            except BadExpression, Value:\r
+                EdkLogger.error('Parser', FORMAT_INVALID, Value, File=self.MetaFile, Line=self._LineIndex + 1)\r
             except EvaluationException, Excpt:\r
                 if hasattr(Excpt, 'Pcd'):\r
                     if Excpt.Pcd in GlobalData.gPlatformOtherPcds:\r
@@ -838,15 +836,21 @@ class DscBuildData(PlatformBuildClassObject):
                 else:\r
                     EdkLogger.error('Parser', FORMAT_INVALID, "Invalid expression: %s" % str(Excpt),\r
                                     File=self.MetaFile, Line=LineNo)\r
-            if ValueList[Index] == 'True':\r
-                ValueList[Index] = '1'\r
-            elif ValueList[Index] == 'False':\r
-                ValueList[Index] = '0'\r
         if ValueList[Index]:\r
+            DatumType = self._DecPcds[PcdCName, TokenSpaceGuid].DatumType\r
+            try:\r
+                ValueList[Index] = ValueExpressionEx(ValueList[Index], DatumType, self._GuidDict)(True)\r
+            except BadExpression, Value:\r
+                EdkLogger.error('Parser', FORMAT_INVALID, Value, File=self.MetaFile, Line=LineNo,\r
+                                ExtraData="PCD [%s.%s] Value \"%s\" " % (TokenSpaceGuid, PcdCName, ValueList[Index]))\r
             Valid, ErrStr = CheckPcdDatum(self._DecPcds[PcdCName, TokenSpaceGuid].DatumType, ValueList[Index])\r
             if not Valid:\r
                 EdkLogger.error('build', FORMAT_INVALID, ErrStr, File=self.MetaFile, Line=LineNo,\r
                                 ExtraData="%s.%s" % (TokenSpaceGuid, PcdCName))\r
+            if PcdType in (MODEL_PCD_DYNAMIC_DEFAULT, MODEL_PCD_DYNAMIC_EX_DEFAULT):\r
+                if self._DecPcds[PcdCName, TokenSpaceGuid].DatumType.strip() != ValueList[1].strip():\r
+                    EdkLogger.error('build', FORMAT_INVALID, ErrStr , File=self.MetaFile, Line=LineNo,\r
+                                ExtraData="%s.%s|%s" % (TokenSpaceGuid, PcdCName, Setting))\r
         return ValueList\r
 \r
     def _FilterPcdBySkuUsage(self,Pcds):\r
@@ -856,11 +860,27 @@ class DscBuildData(PlatformBuildClassObject):
             for pcdname in Pcds:\r
                 pcd = Pcds[pcdname]\r
                 Pcds[pcdname].SkuInfoList = {"DEFAULT":pcd.SkuInfoList[skuid] for skuid in pcd.SkuInfoList if skuid in available_sku}\r
+                if type(pcd) is StructurePcd and pcd.SkuOverrideValues:\r
+                    Pcds[pcdname].SkuOverrideValues = {"DEFAULT":pcd.SkuOverrideValues[skuid] for skuid in pcd.SkuOverrideValues if skuid in available_sku}\r
         else:\r
             for pcdname in Pcds:\r
                 pcd = Pcds[pcdname]\r
                 Pcds[pcdname].SkuInfoList = {skuid:pcd.SkuInfoList[skuid] for skuid in pcd.SkuInfoList if skuid in available_sku}\r
+                if type(pcd) is StructurePcd and pcd.SkuOverrideValues:\r
+                    Pcds[pcdname].SkuOverrideValues = {skuid:pcd.SkuOverrideValues[skuid] for skuid in pcd.SkuOverrideValues if skuid in available_sku}\r
         return Pcds\r
+    def CompleteHiiPcdsDefaultStores(self,Pcds):\r
+        HiiPcd = [Pcds[pcd] for pcd in Pcds if Pcds[pcd].Type in [self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_HII], self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_HII]]]\r
+        DefaultStoreMgr = DefaultStore(self.DefaultStores)\r
+        for pcd in HiiPcd:\r
+            for skuid in pcd.SkuInfoList:\r
+                skuobj = pcd.SkuInfoList.get(skuid)\r
+                if "STANDARD" not in skuobj.DefaultStoreDict:\r
+                    PcdDefaultStoreSet = set([defaultstorename  for defaultstorename in skuobj.DefaultStoreDict])\r
+                    mindefaultstorename = DefaultStoreMgr.GetMin(PcdDefaultStoreSet)\r
+                    skuobj.DefaultStoreDict['STANDARD'] = copy.deepcopy(skuobj.DefaultStoreDict[mindefaultstorename])\r
+        return Pcds\r
+\r
     ## Retrieve all PCD settings in platform\r
     def _GetPcds(self):\r
         if self._Pcds == None:\r
@@ -877,6 +897,7 @@ class DscBuildData(PlatformBuildClassObject):
 \r
             self._Pcds = self.CompletePcdValues(self._Pcds)\r
             self._Pcds = self.UpdateStructuredPcds(MODEL_PCD_TYPE_LIST, self._Pcds)\r
+            self._Pcds = self.CompleteHiiPcdsDefaultStores(self._Pcds)\r
             self._Pcds = self._FilterPcdBySkuUsage(self._Pcds)\r
         return self._Pcds\r
 \r
@@ -901,6 +922,8 @@ class DscBuildData(PlatformBuildClassObject):
             for CodeBase in (EDKII_NAME, EDK_NAME):\r
                 RecordList = self._RawData[MODEL_META_DATA_BUILD_OPTION, self._Arch, CodeBase]\r
                 for ToolChainFamily, ToolChain, Option, Dummy1, Dummy2, Dummy3, Dummy4,Dummy5 in RecordList:\r
+                    if Dummy3.upper() != 'COMMON':\r
+                        continue\r
                     CurKey = (ToolChainFamily, ToolChain, CodeBase)\r
                     #\r
                     # Only flags can be appended\r
@@ -908,7 +931,8 @@ class DscBuildData(PlatformBuildClassObject):
                     if CurKey not in self._BuildOptions or not ToolChain.endswith('_FLAGS') or Option.startswith('='):\r
                         self._BuildOptions[CurKey] = Option\r
                     else:\r
-                        self._BuildOptions[CurKey] += ' ' + Option\r
+                        if ' ' + Option not in self._BuildOptions[CurKey]:\r
+                            self._BuildOptions[CurKey] += ' ' + Option\r
         return self._BuildOptions\r
 \r
     def GetBuildOptionsByModuleType(self, Edk, ModuleType):\r
@@ -919,14 +943,16 @@ class DscBuildData(PlatformBuildClassObject):
             self._ModuleTypeOptions[Edk, ModuleType] = options\r
             DriverType = '%s.%s' % (Edk, ModuleType)\r
             CommonDriverType = '%s.%s' % ('COMMON', ModuleType)\r
-            RecordList = self._RawData[MODEL_META_DATA_BUILD_OPTION, self._Arch, DriverType]\r
-            for ToolChainFamily, ToolChain, Option, Arch, Type, Dummy3, Dummy4,Dummy5 in RecordList:\r
-                if Type == DriverType or Type == CommonDriverType:\r
+            RecordList = self._RawData[MODEL_META_DATA_BUILD_OPTION, self._Arch]\r
+            for ToolChainFamily, ToolChain, Option, Dummy1, Dummy2, Dummy3, Dummy4,Dummy5 in RecordList:\r
+                Type = Dummy2 + '.' + Dummy3\r
+                if Type.upper() == DriverType.upper() or Type.upper() == CommonDriverType.upper():\r
                     Key = (ToolChainFamily, ToolChain, Edk)\r
                     if Key not in options or not ToolChain.endswith('_FLAGS') or Option.startswith('='):\r
                         options[Key] = Option\r
                     else:\r
-                        options[Key] += ' ' + Option\r
+                        if ' ' + Option not in options[Key]:\r
+                            options[Key] += ' ' + Option\r
         return self._ModuleTypeOptions[Edk, ModuleType]\r
 \r
     def GetStructurePcdInfo(self, PcdSet):\r
@@ -938,47 +964,37 @@ class DscBuildData(PlatformBuildClassObject):
 \r
         return structure_pcd_data\r
 \r
-    def CompleteStructurePcdValue(self,pcdset):\r
-        skuset = set([item[3] for item in pcdset])\r
-        pcddatamap = {(item[0],item[1],item[2],item[3]):item for item in pcdset}\r
-        FieldSet = {}\r
-        for item in pcdset:\r
-            if (item[0],item[1]) not in FieldSet:\r
-                FieldSet[(item[0],item[1])] = set()\r
-            FieldSet[(item[0],item[1])].add(item[2])\r
-        completeset = []\r
-        for tockenspacename,pcdname, in FieldSet:\r
-            for field in FieldSet[(tockenspacename,pcdname)]:\r
-                for skuid in skuset:\r
-                    nextskuid = skuid\r
-                    while (tockenspacename,pcdname,field,nextskuid) not in pcddatamap:\r
-                        nextskuid = self.SkuIdMgr.GetNextSkuId(nextskuid)\r
-                        if nextskuid == "DEFAULT":\r
-                            break\r
-                    if (tockenspacename,pcdname,field,nextskuid) not in pcddatamap:\r
-                        continue\r
-                    item = pcddatamap[tockenspacename,pcdname,field,nextskuid]\r
-                    completeset.append((tockenspacename,pcdname,field,skuid, item[4],item[5], item[6]))\r
-        return completeset\r
     def UpdateStructuredPcds(self, TypeList, AllPcds):\r
+\r
+        DynamicPcdType = [self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_DEFAULT],\r
+                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_HII],\r
+                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_VPD],\r
+                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_DEFAULT],\r
+                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_HII],\r
+                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_VPD]]\r
+\r
         Pcds = AllPcds\r
         DefaultStoreMgr = DefaultStore(self.DefaultStores)\r
-        SkuIds = set([skuid for pcdobj in AllPcds.values() for skuid in pcdobj.SkuInfoList.keys()])\r
+        SkuIds = self.SkuIdMgr.AvailableSkuIdSet\r
+        SkuIds.update({'DEFAULT':0})\r
         DefaultStores = set([storename for pcdobj in AllPcds.values() for skuobj in pcdobj.SkuInfoList.values() for storename in skuobj.DefaultStoreDict.keys()])\r
 \r
         S_PcdSet = []\r
         # Find out all possible PCD candidates for self._Arch\r
         RecordList = []\r
+\r
         for Type in TypeList:\r
             RecordList.extend(self._RawData[Type, self._Arch])\r
 \r
         for TokenSpaceGuid, PcdCName, Setting, Arch, SkuName, default_store, Dummy4,Dummy5 in RecordList:\r
+            SkuName = SkuName.upper()\r
+            default_store = default_store.upper()\r
+            SkuName = 'DEFAULT' if SkuName == 'COMMON' else SkuName\r
             if SkuName not in SkuIds:\r
                 continue\r
-            SkuName = 'DEFAULT' if SkuName == 'COMMON' else SkuName\r
+\r
             if SkuName in SkuIds and "." in TokenSpaceGuid:\r
                 S_PcdSet.append(( TokenSpaceGuid.split(".")[0],TokenSpaceGuid.split(".")[1], PcdCName,SkuName, default_store,Dummy5, AnalyzePcdExpression(Setting)[0]))\r
-        S_PcdSet = self.CompleteStructurePcdValue(S_PcdSet)\r
 \r
         # handle pcd value override\r
         StrPcdSet = self.GetStructurePcdInfo(S_PcdSet)\r
@@ -997,8 +1013,12 @@ class DscBuildData(PlatformBuildClassObject):
                     if str_pcd_data[3] in SkuIds:\r
                         str_pcd_obj_str.AddOverrideValue(str_pcd_data[2], str(str_pcd_data[6]), 'DEFAULT' if str_pcd_data[3] == 'COMMON' else str_pcd_data[3],'STANDARD' if str_pcd_data[4] == 'COMMON' else str_pcd_data[4], self.MetaFile.File,LineNo=str_pcd_data[5])\r
                 S_pcd_set[str_pcd[1], str_pcd[0]] = str_pcd_obj_str\r
+            else:\r
+                EdkLogger.error('build', PARSER_ERROR,\r
+                            "Pcd (%s.%s) defined in DSC is not declared in DEC files. Arch: ['%s']" % (str_pcd[0], str_pcd[1], self._Arch),\r
+                            File=self.MetaFile,Line = StrPcdSet[str_pcd][0][5])\r
         # Add the Structure PCD that only defined in DEC, don't have override in DSC file\r
-        for Pcd in self._DecPcds:\r
+        for Pcd in self.DecPcds:\r
             if type (self._DecPcds[Pcd]) is StructurePcd:\r
                 if Pcd not in S_pcd_set:\r
                     str_pcd_obj_str = StructurePcd()\r
@@ -1012,37 +1032,42 @@ class DscBuildData(PlatformBuildClassObject):
         if S_pcd_set:\r
             GlobalData.gStructurePcd[self.Arch] = S_pcd_set\r
         for stru_pcd in S_pcd_set.values():\r
-            if stru_pcd.Type not in [self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_DEFAULT],\r
-                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_HII],\r
-                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_VPD],\r
-                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_DEFAULT],\r
-                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_HII],\r
-                        self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_VPD]]:\r
-                continue\r
+            for skuid in SkuIds:\r
+                if skuid in stru_pcd.SkuOverrideValues:\r
+                    continue\r
+                nextskuid = self.SkuIdMgr.GetNextSkuId(skuid)\r
+                NoDefault = False\r
+                while nextskuid not in stru_pcd.SkuOverrideValues:\r
+                    if nextskuid == "DEFAULT":\r
+                        NoDefault = True\r
+                        break\r
+                    nextskuid = self.SkuIdMgr.GetNextSkuId(nextskuid)\r
+                stru_pcd.SkuOverrideValues[skuid] = copy.deepcopy(stru_pcd.SkuOverrideValues[nextskuid]) if not NoDefault else copy.deepcopy({defaultstorename: stru_pcd.DefaultValues for defaultstorename in DefaultStores} if DefaultStores else {'STANDARD':stru_pcd.DefaultValues})\r
             if stru_pcd.Type in [self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_HII], self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_HII]]:\r
                 for skuid in SkuIds:\r
                     nextskuid = skuid\r
+                    NoDefault = False\r
                     if skuid not in stru_pcd.SkuOverrideValues:\r
                         while nextskuid not in stru_pcd.SkuOverrideValues:\r
+                            if nextskuid == "DEFAULT":\r
+                                NoDefault = True\r
+                                break\r
                             nextskuid = self.SkuIdMgr.GetNextSkuId(nextskuid)\r
-                        stru_pcd.SkuOverrideValues[skuid] = {}\r
-                    PcdDefaultStoreSet = set([defaultstorename  for defaultstorename in stru_pcd.SkuOverrideValues[skuid]])\r
+                    if NoDefault:\r
+                        continue\r
+                    PcdDefaultStoreSet = set([defaultstorename  for defaultstorename in stru_pcd.SkuOverrideValues[nextskuid]])\r
                     mindefaultstorename = DefaultStoreMgr.GetMin(PcdDefaultStoreSet)\r
+\r
                     for defaultstoreid in DefaultStores:\r
                         if defaultstoreid not in stru_pcd.SkuOverrideValues[skuid]:\r
-                            stru_pcd.SkuOverrideValues[skuid][defaultstoreid] = stru_pcd.SkuOverrideValues[nextskuid][mindefaultstorename]\r
-            for skuid in SkuIds:\r
-                if skuid in stru_pcd.SkuOverrideValues:\r
-                    continue\r
-                nextskuid = self.SkuIdMgr.GetNextSkuId(skuid)\r
-                while nextskuid not in stru_pcd.SkuOverrideValues:\r
-                    nextskuid = self.SkuIdMgr.GetNextSkuId(nextskuid)\r
-                stru_pcd.SkuOverrideValues[skuid] = stru_pcd.SkuOverrideValues[nextskuid]\r
+                            stru_pcd.SkuOverrideValues[skuid][defaultstoreid] = copy.deepcopy(stru_pcd.SkuOverrideValues[nextskuid][mindefaultstorename])\r
+\r
         Str_Pcd_Values = self.GenerateByteArrayValue(S_pcd_set)\r
         if Str_Pcd_Values:\r
             for (skuname,StoreName,PcdGuid,PcdName,PcdValue) in Str_Pcd_Values:\r
                 str_pcd_obj = S_pcd_set.get((PcdName, PcdGuid))\r
                 if str_pcd_obj is None:\r
+                    print PcdName, PcdGuid\r
                     raise\r
                 if str_pcd_obj.Type in [self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_HII],\r
                                         self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_HII]]:\r
@@ -1057,7 +1082,16 @@ class DscBuildData(PlatformBuildClassObject):
                         str_pcd_obj.DefaultValue = PcdValue\r
                 else:\r
                     if skuname not in str_pcd_obj.SkuInfoList:\r
-                        str_pcd_obj.SkuInfoList[skuname] = SkuInfoClass(SkuIdName=skuname, SkuId=self.SkuIds[skuname][0], DefaultValue=PcdValue)\r
+                        nextskuid = self.SkuIdMgr.GetNextSkuId(skuname)\r
+                        NoDefault = False\r
+                        while nextskuid not in str_pcd_obj.SkuInfoList:\r
+                            if nextskuid == "DEFAULT":\r
+                                NoDefault = True\r
+                                break\r
+                            nextskuid = self.SkuIdMgr.GetNextSkuId(nextskuid)\r
+                        str_pcd_obj.SkuInfoList[skuname] = copy.deepcopy(str_pcd_obj.SkuInfoList[nextskuid]) if not NoDefault else SkuInfoClass(SkuIdName=skuname, SkuId=self.SkuIds[skuname][0], DefaultValue=PcdValue)\r
+                        str_pcd_obj.SkuInfoList[skuname].SkuId = self.SkuIds[skuname][0]\r
+                        str_pcd_obj.SkuInfoList[skuname].SkuIdName = skuname\r
                     else:\r
                         str_pcd_obj.SkuInfoList[skuname].DefaultValue = PcdValue\r
             for str_pcd_obj in S_pcd_set.values():\r
@@ -1070,11 +1104,19 @@ class DscBuildData(PlatformBuildClassObject):
                 str_pcd_obj.SkuInfoList[self.SkuIdMgr.SystemSkuId].HiiDefaultValue = str_pcd_obj.SkuInfoList[self.SkuIdMgr.SystemSkuId].DefaultStoreDict[mindefaultstorename]\r
 \r
             for str_pcd_obj in S_pcd_set.values():\r
-                if not str_pcd_obj.OverrideValues:\r
-                    continue\r
+\r
                 str_pcd_obj.MaxDatumSize = self.GetStructurePcdMaxSize(str_pcd_obj)\r
                 Pcds[str_pcd_obj.TokenCName, str_pcd_obj.TokenSpaceGuidCName] = str_pcd_obj\r
 \r
+            for pcdkey in Pcds:\r
+                pcd = Pcds[pcdkey]\r
+                if 'DEFAULT' not in pcd.SkuInfoList.keys() and 'COMMON' in pcd.SkuInfoList.keys():\r
+                    pcd.SkuInfoList['DEFAULT'] = pcd.SkuInfoList['COMMON']\r
+                    del(pcd.SkuInfoList['COMMON'])\r
+                elif 'DEFAULT' in pcd.SkuInfoList.keys() and 'COMMON' in pcd.SkuInfoList.keys():\r
+                    del(pcd.SkuInfoList['COMMON'])\r
+\r
+        map(self.FilterSkuSettings,[Pcds[pcdkey] for pcdkey in Pcds if Pcds[pcdkey].Type in DynamicPcdType])\r
         return Pcds\r
 \r
     ## Retrieve non-dynamic PCD settings\r
@@ -1089,7 +1131,7 @@ class DscBuildData(PlatformBuildClassObject):
         # tdict is a special dict kind of type, used for selecting correct\r
         # PCD settings for certain ARCH\r
         #\r
-\r
+        AvailableSkuIdSet = copy.copy(self.SkuIds)\r
 \r
         PcdDict = tdict(True, 3)\r
         PcdSet = set()\r
@@ -1097,6 +1139,11 @@ class DscBuildData(PlatformBuildClassObject):
         RecordList = self._RawData[Type, self._Arch]\r
         PcdValueDict = sdict()\r
         for TokenSpaceGuid, PcdCName, Setting, Arch, SkuName, Dummy3, Dummy4,Dummy5 in RecordList:\r
+            SkuName = SkuName.upper()\r
+            SkuName = 'DEFAULT' if SkuName == 'COMMON' else SkuName\r
+            if SkuName not in AvailableSkuIdSet:\r
+                EdkLogger.error('build ', PARAMETER_INVALID, 'Sku %s is not defined in [SkuIds] section' % SkuName,\r
+                                            File=self.MetaFile, Line=Dummy5)\r
             if SkuName in (self.SkuIdMgr.SystemSkuId, 'DEFAULT', 'COMMON'):\r
                 if "." not in TokenSpaceGuid:\r
                     PcdSet.add((PcdCName, TokenSpaceGuid, SkuName, Dummy4))\r
@@ -1169,18 +1216,19 @@ class DscBuildData(PlatformBuildClassObject):
 \r
         def get_length(value):\r
             Value = value.strip()\r
-            if Value.startswith('GUID') and Value.endswith(')'):\r
-                return 16\r
-            if Value.startswith('L"') and Value.endswith('"'):\r
-                return len(Value[2:-1])\r
-            if Value[0] == '"' and Value[-1] == '"':\r
-                return len(Value) - 2\r
-            if Value[0] == '{' and Value[-1] == '}':\r
-                return len(Value.split(","))\r
-            if Value.startswith("L'") and Value.endswith("'") and len(list(Value[2:-1])) > 1:\r
-                return  len(list(Value[2:-1]))\r
-            if Value[0] == "'" and Value[-1] == "'" and len(list(Value[1:-1])) > 1:\r
-                return len(Value) - 2\r
+            if len(value) > 1:\r
+                if Value.startswith('GUID') and Value.endswith(')'):\r
+                    return 16\r
+                if Value.startswith('L"') and Value.endswith('"'):\r
+                    return len(Value[2:-1])\r
+                if Value[0] == '"' and Value[-1] == '"':\r
+                    return len(Value) - 2\r
+                if Value[0] == '{' and Value[-1] == '}':\r
+                    return len(Value.split(","))\r
+                if Value.startswith("L'") and Value.endswith("'") and len(list(Value[2:-1])) > 1:\r
+                    return  len(list(Value[2:-1]))\r
+                if Value[0] == "'" and Value[-1] == "'" and len(list(Value[1:-1])) > 1:\r
+                    return len(Value) - 2\r
             return len(Value)\r
 \r
         return str(max([pcd_size for pcd_size in [get_length(item) for item in sku_values]]))\r
@@ -1235,18 +1283,15 @@ class DscBuildData(PlatformBuildClassObject):
             CApp = CApp + '{\n'\r
             CApp = CApp + '  UINT32  Size;\n'\r
             CApp = CApp + '  UINT32  FieldSize;\n'\r
-            CApp = CApp + '  UINT8   *Value;\n'\r
+            CApp = CApp + '  CHAR8   *Value;\n'\r
             CApp = CApp + '  UINT32  OriginalSize;\n'\r
             CApp = CApp + '  VOID    *OriginalPcd;\n'\r
             CApp = CApp + '  %s      *Pcd;\n' % (Pcd.DatumType)\r
             CApp = CApp + '\n'\r
+\r
             Pcd.DefaultValue = Pcd.DefaultValue.strip()\r
-            if Pcd.DefaultValue.startswith('L"') and Pcd.DefaultValue.endswith('"'):\r
-                PcdDefaultValue = "{" + ",".join(self.__UNICODE2OCTList(Pcd.DefaultValue)) + "}"\r
-            elif Pcd.DefaultValue.startswith('"') and Pcd.DefaultValue.endswith('"'):\r
-                PcdDefaultValue = "{" + ",".join(self.__STRING2OCTList(Pcd.DefaultValue)) + "}"\r
-            else:\r
-                PcdDefaultValue = Pcd.DefaultValue\r
+            PcdDefaultValue = StringToArray(Pcd.DefaultValue)\r
+\r
             InitByteValue += '%s.%s.%s.%s|%s|%s\n' % (SkuName, DefaultStoreName, Pcd.TokenSpaceGuidCName, Pcd.TokenCName, Pcd.DatumType, PcdDefaultValue)\r
 \r
             #\r
@@ -1263,25 +1308,29 @@ class DscBuildData(PlatformBuildClassObject):
             # OFFSET_OF(FlexbleArrayField) + sizeof(FlexibleArray[0]) * (HighestIndex + 1)\r
             #\r
             CApp = CApp + '  Size = sizeof(%s);\n' % (Pcd.DatumType)\r
-            for FieldList in [Pcd.DefaultValues, OverrideValues.get(DefaultStoreName)]:\r
-                if not FieldList:\r
-                    continue\r
-                for FieldName in FieldList:\r
-                    FieldName = "." + FieldName\r
-                    IsArray = self.IsFieldValueAnArray(FieldList[FieldName.strip(".")][0])\r
-                    if IsArray:\r
-                        Value, ValueSize = ParseFieldValue (FieldList[FieldName.strip(".")][0])\r
-                        CApp = CApp + '  __FLEXIBLE_SIZE(Size, %s, %s, %d / __ARRAY_ELEMENT_SIZE(%s, %s));\n' % (Pcd.DatumType, FieldName.strip("."), ValueSize, Pcd.DatumType, FieldName.strip("."));\r
-                    else:\r
-                        NewFieldName = ''\r
-                        while '[' in  FieldName:\r
-                            NewFieldName = NewFieldName + FieldName.split('[', 1)[0] + '[0]'\r
-                            ArrayIndex = int(FieldName.split('[', 1)[1].split(']', 1)[0])\r
-                            FieldName = FieldName.split(']', 1)[1]\r
-                        FieldName = NewFieldName + FieldName\r
-                        while '[' in FieldName:\r
-                            FieldName = FieldName.rsplit('[', 1)[0]\r
-                            CApp = CApp + '  __FLEXIBLE_SIZE(Size, %s, %s, %d);\n' % (Pcd.DatumType, FieldName.strip("."), ArrayIndex + 1)\r
+            for skuname in self.SkuIdMgr.SkuOverrideOrder():\r
+                inherit_OverrideValues = Pcd.SkuOverrideValues[skuname]\r
+                for FieldList in [Pcd.DefaultValues, inherit_OverrideValues.get(DefaultStoreName)]:\r
+                    if not FieldList:\r
+                        continue\r
+                    for FieldName in FieldList:\r
+                        FieldName = "." + FieldName\r
+                        IsArray = self.IsFieldValueAnArray(FieldList[FieldName.strip(".")][0])\r
+                        if IsArray:\r
+                            Value, ValueSize = ParseFieldValue (FieldList[FieldName.strip(".")][0])\r
+                            CApp = CApp + '  __FLEXIBLE_SIZE(Size, %s, %s, %d / __ARRAY_ELEMENT_SIZE(%s, %s) + ((%d %% __ARRAY_ELEMENT_SIZE(%s, %s)) ? 1 : 0));\n' % (Pcd.DatumType, FieldName.strip("."), ValueSize, Pcd.DatumType, FieldName.strip("."), ValueSize, Pcd.DatumType, FieldName.strip("."));\r
+                        else:\r
+                            NewFieldName = ''\r
+                            while '[' in  FieldName:\r
+                                NewFieldName = NewFieldName + FieldName.split('[', 1)[0] + '[0]'\r
+                                ArrayIndex = int(FieldName.split('[', 1)[1].split(']', 1)[0])\r
+                                FieldName = FieldName.split(']', 1)[1]\r
+                            FieldName = NewFieldName + FieldName\r
+                            while '[' in FieldName:\r
+                                FieldName = FieldName.rsplit('[', 1)[0]\r
+                                CApp = CApp + '  __FLEXIBLE_SIZE(Size, %s, %s, %d);\n' % (Pcd.DatumType, FieldName.strip("."), ArrayIndex + 1)\r
+                if skuname == SkuName:\r
+                    break\r
 \r
             #\r
             # Allocate and zero buffer for the PCD\r
@@ -1300,43 +1349,46 @@ class DscBuildData(PlatformBuildClassObject):
             #\r
             # Assign field values in PCD\r
             #\r
-            for FieldList in [Pcd.DefaultValues, Pcd.DefaultFromDSC,OverrideValues.get(DefaultStoreName)]:\r
-                if not FieldList:\r
-                    continue\r
-                if Pcd.DefaultFromDSC and FieldList == Pcd.DefaultFromDSC:\r
-                    IsArray = self.IsFieldValueAnArray(FieldList)\r
-                    Value, ValueSize = ParseFieldValue (FieldList)\r
-                    if isinstance(Value, str):\r
-                        CApp = CApp + '  Pcd = %s; // From DSC Default Value %s\n' % (Value, Pcd.DefaultFromDSC)\r
-                    elif IsArray:\r
+            for skuname in self.SkuIdMgr.SkuOverrideOrder():\r
+                inherit_OverrideValues = Pcd.SkuOverrideValues[skuname]\r
+                for FieldList in [Pcd.DefaultValues, Pcd.DefaultFromDSC,inherit_OverrideValues.get(DefaultStoreName)]:\r
+                    if not FieldList:\r
+                        continue\r
+                    if Pcd.DefaultFromDSC and FieldList == Pcd.DefaultFromDSC:\r
+                        IsArray = self.IsFieldValueAnArray(FieldList)\r
+                        Value, ValueSize = ParseFieldValue (FieldList)\r
+                        if isinstance(Value, str):\r
+                            CApp = CApp + '  Pcd = %s; // From DSC Default Value %s\n' % (Value, Pcd.DefaultFromDSC)\r
+                        elif IsArray:\r
                         #\r
                         # Use memcpy() to copy value into field\r
                         #\r
-                        CApp = CApp + '  Value     = %s; // From DSC Default Value %s\n' % (self.IntToCString(Value, ValueSize), Pcd.DefaultFromDSC)\r
-                        CApp = CApp + '  memcpy (Pcd, Value, %d);\n' % (ValueSize)\r
-                    continue\r
+                            CApp = CApp + '  Value     = %s; // From DSC Default Value %s\n' % (self.IntToCString(Value, ValueSize), Pcd.DefaultFromDSC)\r
+                            CApp = CApp + '  memcpy (Pcd, Value, %d);\n' % (ValueSize)\r
+                        continue\r
 \r
-                for FieldName in FieldList:\r
-                    IsArray = self.IsFieldValueAnArray(FieldList[FieldName][0])\r
-                    try:\r
-                        Value, ValueSize = ParseFieldValue (FieldList[FieldName][0])\r
-                    except Exception:\r
-                        print FieldList[FieldName][0]\r
-                    if isinstance(Value, str):\r
-                        CApp = CApp + '  Pcd->%s = %s; // From %s Line %d Value %s\n' % (FieldName, Value, FieldList[FieldName][1], FieldList[FieldName][2], FieldList[FieldName][0])\r
-                    elif IsArray:\r
+                    for FieldName in FieldList:\r
+                        IsArray = self.IsFieldValueAnArray(FieldList[FieldName][0])\r
+                        try:\r
+                            Value, ValueSize = ParseFieldValue (FieldList[FieldName][0])\r
+                        except Exception:\r
+                            print FieldList[FieldName][0]\r
+                        if isinstance(Value, str):\r
+                            CApp = CApp + '  Pcd->%s = %s; // From %s Line %d Value %s\n' % (FieldName, Value, FieldList[FieldName][1], FieldList[FieldName][2], FieldList[FieldName][0])\r
+                        elif IsArray:\r
                         #\r
                         # Use memcpy() to copy value into field\r
                         #\r
-                        CApp = CApp + '  FieldSize = __FIELD_SIZE(%s, %s);\n' % (Pcd.DatumType, FieldName)\r
-                        CApp = CApp + '  Value     = %s; // From %s Line %d Value %s\n' % (self.IntToCString(Value, ValueSize), FieldList[FieldName][1], FieldList[FieldName][2], FieldList[FieldName][0])\r
-                        CApp = CApp + '  memcpy (&Pcd->%s[0], Value, (FieldSize > 0 && FieldSize < %d) ? FieldSize : %d);\n' % (FieldName, ValueSize, ValueSize)\r
-                    else:\r
-                        if ValueSize > 4:\r
-                            CApp = CApp + '  Pcd->%s = %dULL; // From %s Line %d Value %s\n' % (FieldName, Value, FieldList[FieldName][1], FieldList[FieldName][2], FieldList[FieldName][0])\r
+                            CApp = CApp + '  FieldSize = __FIELD_SIZE(%s, %s);\n' % (Pcd.DatumType, FieldName)\r
+                            CApp = CApp + '  Value     = %s; // From %s Line %d Value %s\n' % (self.IntToCString(Value, ValueSize), FieldList[FieldName][1], FieldList[FieldName][2], FieldList[FieldName][0])\r
+                            CApp = CApp + '  memcpy (&Pcd->%s[0], Value, (FieldSize > 0 && FieldSize < %d) ? FieldSize : %d);\n' % (FieldName, ValueSize, ValueSize)\r
                         else:\r
-                            CApp = CApp + '  Pcd->%s = %d; // From %s Line %d Value %s\n' % (FieldName, Value, FieldList[FieldName][1], FieldList[FieldName][2], FieldList[FieldName][0])\r
-\r
+                            if ValueSize > 4:\r
+                                CApp = CApp + '  Pcd->%s = %dULL; // From %s Line %d Value %s\n' % (FieldName, Value, FieldList[FieldName][1], FieldList[FieldName][2], FieldList[FieldName][0])\r
+                            else:\r
+                                CApp = CApp + '  Pcd->%s = %d; // From %s Line %d Value %s\n' % (FieldName, Value, FieldList[FieldName][1], FieldList[FieldName][2], FieldList[FieldName][0])\r
+                if skuname == SkuName:\r
+                    break\r
             #\r
             # Set new PCD value and size\r
             #\r
@@ -1374,7 +1426,9 @@ class DscBuildData(PlatformBuildClassObject):
             if not Pcd.SkuOverrideValues:\r
                 InitByteValue, CApp = self.GenerateInitializeFunc(self.SkuIdMgr.SystemSkuId, 'STANDARD', Pcd, InitByteValue, CApp)\r
             else:\r
-                for SkuName in Pcd.SkuOverrideValues:\r
+                for SkuName in self.SkuIdMgr.SkuOverrideOrder():\r
+                    if SkuName not in Pcd.SkuOverrideValues:\r
+                        continue\r
                     for DefaultStoreName in Pcd.DefaultStoreName:\r
                         Pcd = StructuredPcds[PcdName]\r
                         InitByteValue, CApp = self.GenerateInitializeFunc(SkuName, DefaultStoreName, Pcd, InitByteValue, CApp)\r
@@ -1388,7 +1442,9 @@ class DscBuildData(PlatformBuildClassObject):
             if not Pcd.SkuOverrideValues:\r
                 CApp = CApp + '  Initialize_%s_%s_%s_%s();\n' % (self.SkuIdMgr.SystemSkuId, 'STANDARD', Pcd.TokenSpaceGuidCName, Pcd.TokenCName)\r
             else:\r
-                for SkuName in Pcd.SkuOverrideValues:\r
+                for SkuName in self.SkuIdMgr.SkuOverrideOrder():\r
+                    if SkuName not in Pcd.SkuOverrideValues:\r
+                        continue\r
                     for DefaultStoreName in Pcd.SkuOverrideValues[SkuName]:\r
                         CApp = CApp + '  Initialize_%s_%s_%s_%s();\n' % (SkuName, DefaultStoreName, Pcd.TokenSpaceGuidCName, Pcd.TokenCName)\r
         CApp = CApp + '}\n'\r
@@ -1408,7 +1464,7 @@ class DscBuildData(PlatformBuildClassObject):
         else:\r
             MakeApp = MakeApp + PcdGccMakefile\r
             MakeApp = MakeApp + 'APPNAME = %s\n' % (PcdValueInitName) + 'OBJECTS = %s/%s.o\n' % (self.OutputPath, PcdValueInitName) + \\r
-                      'include $(MAKEROOT)/Makefiles/app.makefile\n' + 'BUILD_CFLAGS += -Wno-error\n' + 'INCLUDE +='\r
+                      'include $(MAKEROOT)/Makefiles/app.makefile\n' + 'INCLUDE +='\r
 \r
         PlatformInc = {}\r
         for Cache in self._Bdb._CACHE_.values():\r
@@ -1433,6 +1489,50 @@ class DscBuildData(PlatformBuildClassObject):
                     for inc in PlatformInc[pkg]:\r
                         MakeApp += '-I'  + str(inc) + ' '\r
         MakeApp = MakeApp + '\n'\r
+\r
+        CC_FLAGS = LinuxCFLAGS\r
+        if sys.platform == "win32":\r
+            CC_FLAGS = WindowsCFLAGS\r
+        BuildOptions = {}\r
+        for Options in self.BuildOptions:\r
+            if Options[2] != EDKII_NAME:\r
+                continue\r
+            Family = Options[0]\r
+            if Family and Family != self.ToolChainFamily:\r
+                continue\r
+            Target, Tag, Arch, Tool, Attr = Options[1].split("_")\r
+            if Tool != 'CC':\r
+                continue\r
+\r
+            if Target == "*" or Target == self._Target:\r
+                if Tag == "*" or Tag == self._Toolchain:\r
+                    if Arch == "*" or Arch == self.Arch:\r
+                        if Tool not in BuildOptions:\r
+                            BuildOptions[Tool] = {}\r
+                        if Attr != "FLAGS" or Attr not in BuildOptions[Tool] or self.BuildOptions[Options].startswith('='):\r
+                            BuildOptions[Tool][Attr] = self.BuildOptions[Options]\r
+                        else:\r
+                            # append options for the same tool except PATH\r
+                            if Attr != 'PATH':\r
+                                BuildOptions[Tool][Attr] += " " + self.BuildOptions[Options]\r
+                            else:\r
+                                BuildOptions[Tool][Attr] = self.BuildOptions[Options]\r
+        if BuildOptions:\r
+            for Tool in BuildOptions:\r
+                for Attr in BuildOptions[Tool]:\r
+                    if Attr == "FLAGS":\r
+                        Value = BuildOptions[Tool][Attr]\r
+                        ValueList = Value.split()\r
+                        if ValueList:\r
+                            for Id, Item in enumerate(ValueList):\r
+                                if Item == '-D' or Item == '/D':\r
+                                    CC_FLAGS += ' ' + Item\r
+                                    if Id + 1 < len(ValueList):\r
+                                        CC_FLAGS += ' ' + ValueList[Id + 1]\r
+                                elif Item.startswith('/D') or Item.startswith('-D'):\r
+                                    CC_FLAGS += ' ' + Item\r
+        MakeApp += CC_FLAGS\r
+\r
         if sys.platform == "win32":\r
             MakeApp = MakeApp + PcdMakefileEnd\r
         MakeFileName = os.path.join(self.OutputPath, 'Makefile')\r
@@ -1446,15 +1546,18 @@ class DscBuildData(PlatformBuildClassObject):
         File.write(InitByteValue)\r
         File.close()\r
 \r
+        Messages = ''\r
         if sys.platform == "win32":\r
             StdOut, StdErr = self.ExecuteCommand ('nmake clean & nmake -f %s' % (MakeFileName))\r
+            Messages = StdOut\r
         else:\r
             StdOut, StdErr = self.ExecuteCommand ('make clean & make -f %s' % (MakeFileName))\r
-        Messages = StdOut.split('\r')\r
+            Messages = StdErr\r
+        Messages = Messages.split('\n')\r
         for Message in Messages:\r
-            if " error " in Message:\r
+            if " error" in Message:\r
                 FileInfo = Message.strip().split('(')\r
-                if len (FileInfo) > 0:\r
+                if len (FileInfo) > 1:\r
                     FileName = FileInfo [0]\r
                     FileLine = FileInfo [1].split (')')[0]\r
                 else:\r
@@ -1472,11 +1575,14 @@ class DscBuildData(PlatformBuildClassObject):
                     dsc_line = error_line\r
 \r
                 message_itmes = Message.split(":")\r
+                Index = 0\r
                 for item in message_itmes:\r
                     if "PcdValueInit.c" in item:\r
-                        message_itmes[message_itmes.index(item)] = dsc_line.strip()\r
+                        Index = message_itmes.index(item)\r
+                        message_itmes[Index] = dsc_line.strip()\r
+                        break\r
 \r
-                EdkLogger.error("build", PCD_STRUCTURE_PCD_ERROR, ":".join(message_itmes[1:]))\r
+                EdkLogger.error("build", PCD_STRUCTURE_PCD_ERROR, ":".join(message_itmes[Index:]))\r
 \r
         PcdValueInitExe = PcdValueInitName\r
         if not sys.platform == "win32":\r
@@ -1516,8 +1622,11 @@ class DscBuildData(PlatformBuildClassObject):
 \r
 \r
         for TokenSpaceGuid, PcdCName, Setting, Arch, SkuName, Dummy3, Dummy4,Dummy5 in RecordList:\r
+            SkuName = SkuName.upper()\r
+            SkuName = 'DEFAULT' if SkuName == 'COMMON' else SkuName\r
             if SkuName not in AvailableSkuIdSet:\r
-                continue\r
+                EdkLogger.error('build', PARAMETER_INVALID, 'Sku %s is not defined in [SkuIds] section' % SkuName,\r
+                                            File=self.MetaFile, Line=Dummy5)\r
             if "." not in TokenSpaceGuid:\r
                 PcdList.append((PcdCName, TokenSpaceGuid, SkuName, Dummy4))\r
             PcdDict[Arch, SkuName, PcdCName, TokenSpaceGuid] = Setting\r
@@ -1560,6 +1669,10 @@ class DscBuildData(PlatformBuildClassObject):
 \r
         for pcd in Pcds.values():\r
             pcdDecObject = self._DecPcds[pcd.TokenCName, pcd.TokenSpaceGuidCName]\r
+            # Only fix the value while no value provided in DSC file.\r
+            for sku in pcd.SkuInfoList.values():\r
+                if (sku.DefaultValue == "" or sku.DefaultValue==None):\r
+                    sku.DefaultValue = pcdDecObject.DefaultValue\r
             if 'DEFAULT' not in pcd.SkuInfoList.keys() and 'COMMON' not in pcd.SkuInfoList.keys():\r
                 valuefromDec = pcdDecObject.DefaultValue\r
                 SkuInfo = SkuInfoClass('DEFAULT', '0', '', '', '', '', '', valuefromDec)\r
@@ -1569,13 +1682,26 @@ class DscBuildData(PlatformBuildClassObject):
                 del(pcd.SkuInfoList['COMMON'])\r
             elif 'DEFAULT' in pcd.SkuInfoList.keys() and 'COMMON' in pcd.SkuInfoList.keys():\r
                 del(pcd.SkuInfoList['COMMON'])\r
-            if self.SkuIdMgr.SkuUsageType == self.SkuIdMgr.SINGLE:\r
-                if 'DEFAULT' in pcd.SkuInfoList.keys() and self.SkuIdMgr.SystemSkuId not in pcd.SkuInfoList.keys():\r
-                    pcd.SkuInfoList[self.SkuIdMgr.SystemSkuId] = pcd.SkuInfoList['DEFAULT']\r
-                del(pcd.SkuInfoList['DEFAULT'])\r
+\r
+        map(self.FilterSkuSettings,Pcds.values())\r
 \r
         return Pcds\r
 \r
+    def FilterSkuSettings(self, PcdObj):\r
+\r
+        if self.SkuIdMgr.SkuUsageType == self.SkuIdMgr.SINGLE:\r
+            if 'DEFAULT' in PcdObj.SkuInfoList.keys() and self.SkuIdMgr.SystemSkuId not in PcdObj.SkuInfoList.keys():\r
+                PcdObj.SkuInfoList[self.SkuIdMgr.SystemSkuId] = PcdObj.SkuInfoList['DEFAULT']\r
+            PcdObj.SkuInfoList = {'DEFAULT':PcdObj.SkuInfoList[self.SkuIdMgr.SystemSkuId]}\r
+            PcdObj.SkuInfoList['DEFAULT'].SkuIdName = 'DEFAULT'\r
+            PcdObj.SkuInfoList['DEFAULT'].SkuId = '0'\r
+\r
+        elif self.SkuIdMgr.SkuUsageType == self.SkuIdMgr.DEFAULT:\r
+            PcdObj.SkuInfoList = {'DEFAULT':PcdObj.SkuInfoList['DEFAULT']}\r
+\r
+        return PcdObj\r
+\r
+\r
     def CompareVarAttr(self, Attr1, Attr2):\r
         if not Attr1 or not Attr2:  # for empty string\r
             return True\r
@@ -1590,7 +1716,7 @@ class DscBuildData(PlatformBuildClassObject):
     def CompletePcdValues(self,PcdSet):\r
         Pcds = {}\r
         DefaultStoreObj = DefaultStore(self._GetDefaultStores())\r
-        SkuIds = set([skuid for pcdobj in PcdSet.values() for skuid in pcdobj.SkuInfoList.keys()])\r
+        SkuIds = {skuname:skuid for skuname,skuid in self.SkuIdMgr.AvailableSkuIdSet.items() if skuname !='COMMON'}\r
         DefaultStores = set([storename for pcdobj in PcdSet.values() for skuobj in pcdobj.SkuInfoList.values() for storename in skuobj.DefaultStoreDict.keys()])\r
         for PcdCName, TokenSpaceGuid in PcdSet:\r
             PcdObj = PcdSet[(PcdCName, TokenSpaceGuid)]\r
@@ -1609,14 +1735,16 @@ class DscBuildData(PlatformBuildClassObject):
                     mindefaultstorename = DefaultStoreObj.GetMin(set([defaultstorename  for defaultstorename in skuobj.DefaultStoreDict]))\r
                     for defaultstorename in DefaultStores:\r
                         if defaultstorename not in skuobj.DefaultStoreDict:\r
-                            skuobj.DefaultStoreDict[defaultstorename] = skuobj.DefaultStoreDict[mindefaultstorename]\r
+                            skuobj.DefaultStoreDict[defaultstorename] = copy.deepcopy(skuobj.DefaultStoreDict[mindefaultstorename])\r
                     skuobj.HiiDefaultValue = skuobj.DefaultStoreDict[mindefaultstorename]\r
-            for skuid in SkuIds:\r
-                if skuid not in PcdObj.SkuInfoList:\r
-                    nextskuid = self.SkuIdMgr.GetNextSkuId(skuid)\r
+            for skuname,skuid in SkuIds.items():\r
+                if skuname not in PcdObj.SkuInfoList:\r
+                    nextskuid = self.SkuIdMgr.GetNextSkuId(skuname)\r
                     while nextskuid not in PcdObj.SkuInfoList:\r
                         nextskuid = self.SkuIdMgr.GetNextSkuId(nextskuid)\r
-                    PcdObj.SkuInfoList[skuid] = PcdObj.SkuInfoList[nextskuid]\r
+                    PcdObj.SkuInfoList[skuname] = copy.deepcopy(PcdObj.SkuInfoList[nextskuid])\r
+                    PcdObj.SkuInfoList[skuname].SkuId = skuid\r
+                    PcdObj.SkuInfoList[skuname].SkuIdName = skuname\r
             if PcdType in [self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_HII], self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_HII]]:\r
                 PcdObj.DefaultValue = PcdObj.SkuInfoList.values()[0].HiiDefaultValue if self.SkuIdMgr.SkuUsageType == self.SkuIdMgr.SINGLE else PcdObj.SkuInfoList["DEFAULT"].HiiDefaultValue\r
             Pcds[PcdCName, TokenSpaceGuid]= PcdObj\r
@@ -1641,12 +1769,20 @@ class DscBuildData(PlatformBuildClassObject):
         RecordList = self._RawData[Type, self._Arch]\r
         # Find out all possible PCD candidates for self._Arch\r
         AvailableSkuIdSet = copy.copy(self.SkuIds)\r
+        DefaultStoresDefine = self._GetDefaultStores()\r
 \r
         for TokenSpaceGuid, PcdCName, Setting, Arch, SkuName, DefaultStore, Dummy4,Dummy5 in RecordList:\r
+            SkuName = SkuName.upper()\r
+            SkuName = 'DEFAULT' if SkuName == 'COMMON' else SkuName\r
+            DefaultStore = DefaultStore.upper()\r
             if DefaultStore == "COMMON":\r
                 DefaultStore = "STANDARD"\r
             if SkuName not in AvailableSkuIdSet:\r
-                continue\r
+                EdkLogger.error('build', PARAMETER_INVALID, 'Sku %s is not defined in [SkuIds] section' % SkuName,\r
+                                            File=self.MetaFile, Line=Dummy5)\r
+            if DefaultStore not in DefaultStoresDefine:\r
+                EdkLogger.error('build', PARAMETER_INVALID, 'DefaultStores %s is not defined in [DefaultStores] section' % DefaultStore,\r
+                                            File=self.MetaFile, Line=Dummy5)\r
             if "." not in TokenSpaceGuid:\r
                 PcdSet.add((PcdCName, TokenSpaceGuid, SkuName,DefaultStore, Dummy4))\r
             PcdDict[Arch, SkuName, PcdCName, TokenSpaceGuid,DefaultStore] = Setting\r
@@ -1729,7 +1865,7 @@ class DscBuildData(PlatformBuildClassObject):
                     sku.HiiDefaultValue = pcdDecObject.DefaultValue\r
             if 'DEFAULT' not in pcd.SkuInfoList.keys() and 'COMMON' not in pcd.SkuInfoList.keys():\r
                 valuefromDec = pcdDecObject.DefaultValue\r
-                SkuInfo = SkuInfoClass('DEFAULT', '0', SkuInfoObj.VariableName, SkuInfoObj.VariableGuid, SkuInfoObj.VariableOffset, valuefromDec)\r
+                SkuInfo = SkuInfoClass('DEFAULT', '0', SkuInfoObj.VariableName, SkuInfoObj.VariableGuid, SkuInfoObj.VariableOffset, valuefromDec,VariableAttribute=SkuInfoObj.VariableAttribute,DefaultStore={DefaultStore:valuefromDec})\r
                 pcd.SkuInfoList['DEFAULT'] = SkuInfo\r
             elif 'DEFAULT' not in pcd.SkuInfoList.keys() and 'COMMON' in pcd.SkuInfoList.keys():\r
                 pcd.SkuInfoList['DEFAULT'] = pcd.SkuInfoList['COMMON']\r
@@ -1737,30 +1873,41 @@ class DscBuildData(PlatformBuildClassObject):
             elif 'DEFAULT' in pcd.SkuInfoList.keys() and 'COMMON' in pcd.SkuInfoList.keys():\r
                 del(pcd.SkuInfoList['COMMON'])\r
 \r
-            if self.SkuIdMgr.SkuUsageType == self.SkuIdMgr.SINGLE:\r
-                if 'DEFAULT' in pcd.SkuInfoList.keys() and self.SkuIdMgr.SystemSkuId not in pcd.SkuInfoList.keys():\r
-                    pcd.SkuInfoList[self.SkuIdMgr.SystemSkuId] = pcd.SkuInfoList['DEFAULT']\r
-                del(pcd.SkuInfoList['DEFAULT'])\r
-\r
             if pcd.MaxDatumSize.strip():\r
                 MaxSize = int(pcd.MaxDatumSize, 0)\r
             else:\r
                 MaxSize = 0\r
             if pcdDecObject.DatumType == 'VOID*':\r
-                for (skuname, skuobj) in pcd.SkuInfoList.items():\r
+                for (_, skuobj) in pcd.SkuInfoList.items():\r
                     datalen = 0\r
-                    if skuobj.HiiDefaultValue.startswith("L"):\r
-                        datalen = (len(skuobj.HiiDefaultValue) - 3 + 1) * 2\r
-                    elif skuobj.HiiDefaultValue.startswith("{"):\r
-                        datalen = len(skuobj.HiiDefaultValue.split(","))\r
-                    else:\r
-                        datalen = len(skuobj.HiiDefaultValue) - 2 + 1\r
+                    skuobj.HiiDefaultValue = StringToArray(skuobj.HiiDefaultValue)\r
+                    datalen = len(skuobj.HiiDefaultValue.split(","))\r
                     if datalen > MaxSize:\r
                         MaxSize = datalen\r
+                    for defaultst in skuobj.DefaultStoreDict:\r
+                        skuobj.DefaultStoreDict[defaultst] = StringToArray(skuobj.DefaultStoreDict[defaultst])\r
+                pcd.DefaultValue = StringToArray(pcd.DefaultValue)\r
                 pcd.MaxDatumSize = str(MaxSize)\r
-        return Pcds\r
+        rt, invalidhii = self.CheckVariableNameAssignment(Pcds)\r
+        if not rt:\r
+            invalidpcd = ",".join(invalidhii)\r
+            EdkLogger.error('build', PCD_VARIABLE_INFO_ERROR, Message='The same HII PCD must map to the same EFI variable for all SKUs', File=self.MetaFile, ExtraData=invalidpcd)\r
 \r
+        map(self.FilterSkuSettings,Pcds.values())\r
 \r
+        return Pcds\r
+\r
+    def CheckVariableNameAssignment(self,Pcds):\r
+        invalidhii = []\r
+        for pcdname in Pcds:\r
+            pcd = Pcds[pcdname]\r
+            varnameset = set([sku.VariableName for (skuid,sku) in pcd.SkuInfoList.items()])\r
+            if len(varnameset) > 1:\r
+                invalidhii.append(".".join((pcdname[1],pcdname[0])))\r
+        if len(invalidhii):\r
+            return False,invalidhii\r
+        else:\r
+            return True, []\r
     ## Retrieve dynamic VPD PCD settings\r
     #\r
     #   @param  Type    PCD type\r
@@ -1783,8 +1930,11 @@ class DscBuildData(PlatformBuildClassObject):
         AvailableSkuIdSet = copy.copy(self.SkuIds)\r
 \r
         for TokenSpaceGuid, PcdCName, Setting, Arch, SkuName, Dummy3, Dummy4,Dummy5 in RecordList:\r
+            SkuName = SkuName.upper()\r
+            SkuName = 'DEFAULT' if SkuName == 'COMMON' else SkuName\r
             if SkuName not in AvailableSkuIdSet:\r
-                continue\r
+                EdkLogger.error('build', PARAMETER_INVALID, 'Sku %s is not defined in [SkuIds] section' % SkuName,\r
+                                            File=self.MetaFile, Line=Dummy5)\r
             if "." not in TokenSpaceGuid:\r
                 PcdList.append((PcdCName, TokenSpaceGuid, SkuName, Dummy4))\r
             PcdDict[Arch, SkuName, PcdCName, TokenSpaceGuid] = Setting\r
@@ -1831,6 +1981,10 @@ class DscBuildData(PlatformBuildClassObject):
         for pcd in Pcds.values():\r
             SkuInfoObj = pcd.SkuInfoList.values()[0]\r
             pcdDecObject = self._DecPcds[pcd.TokenCName, pcd.TokenSpaceGuidCName]\r
+            # Only fix the value while no value provided in DSC file.\r
+            for sku in pcd.SkuInfoList.values():\r
+                if (sku.DefaultValue == "" or sku.DefaultValue==None):\r
+                    sku.DefaultValue = pcdDecObject.DefaultValue\r
             if 'DEFAULT' not in pcd.SkuInfoList.keys() and 'COMMON' not in pcd.SkuInfoList.keys():\r
                 valuefromDec = pcdDecObject.DefaultValue\r
                 SkuInfo = SkuInfoClass('DEFAULT', '0', '', '', '', '', SkuInfoObj.VpdOffset, valuefromDec)\r
@@ -1840,11 +1994,9 @@ class DscBuildData(PlatformBuildClassObject):
                 del(pcd.SkuInfoList['COMMON'])\r
             elif 'DEFAULT' in pcd.SkuInfoList.keys() and 'COMMON' in pcd.SkuInfoList.keys():\r
                 del(pcd.SkuInfoList['COMMON'])\r
-            if self.SkuIdMgr.SkuUsageType == self.SkuIdMgr.SINGLE:\r
-                if 'DEFAULT' in pcd.SkuInfoList.keys() and self.SkuIdMgr.SystemSkuId not in pcd.SkuInfoList.keys():\r
-                    pcd.SkuInfoList[self.SkuIdMgr.SystemSkuId] = pcd.SkuInfoList['DEFAULT']\r
-                del(pcd.SkuInfoList['DEFAULT'])\r
 \r
+\r
+        map(self.FilterSkuSettings,Pcds.values())\r
         return Pcds\r
 \r
     ## Add external modules\r
@@ -1861,6 +2013,28 @@ class DscBuildData(PlatformBuildClassObject):
             Module.MetaFile = FilePath\r
             self.Modules.append(Module)\r
 \r
+    def _GetToolChainFamily(self):\r
+        self._ToolChainFamily = "MSFT"\r
+        BuildConfigurationFile = os.path.normpath(os.path.join(GlobalData.gConfDirectory, "target.txt"))\r
+        if os.path.isfile(BuildConfigurationFile) == True:\r
+            TargetTxt      = TargetTxtClassObject()\r
+            TargetTxt.LoadTargetTxtFile(BuildConfigurationFile)\r
+            ToolDefinitionFile = TargetTxt.TargetTxtDictionary[DataType.TAB_TAT_DEFINES_TOOL_CHAIN_CONF]\r
+            if ToolDefinitionFile == '':\r
+                ToolDefinitionFile = "tools_def.txt"\r
+                ToolDefinitionFile = os.path.normpath(mws.join(self.WorkspaceDir, 'Conf', ToolDefinitionFile))\r
+            if os.path.isfile(ToolDefinitionFile) == True:\r
+                ToolDef        = ToolDefClassObject()\r
+                ToolDef.LoadToolDefFile(ToolDefinitionFile)\r
+                ToolDefinition = ToolDef.ToolsDefTxtDatabase\r
+                if TAB_TOD_DEFINES_FAMILY not in ToolDefinition \\r
+                   or self._Toolchain not in ToolDefinition[TAB_TOD_DEFINES_FAMILY] \\r
+                   or not ToolDefinition[TAB_TOD_DEFINES_FAMILY][self._Toolchain]:\r
+                    self._ToolChainFamily = "MSFT"\r
+                else:\r
+                    self._ToolChainFamily = ToolDefinition[TAB_TOD_DEFINES_FAMILY][self._Toolchain]\r
+        return self._ToolChainFamily\r
+\r
     ## Add external PCDs\r
     #\r
     #   The external PCDs are mostly those listed in FDF file to specify address\r
@@ -1874,7 +2048,21 @@ class DscBuildData(PlatformBuildClassObject):
         if (Name, Guid) not in self.Pcds:\r
             self.Pcds[Name, Guid] = PcdClassObject(Name, Guid, '', '', '', '', '', {}, False, None)\r
         self.Pcds[Name, Guid].DefaultValue = Value\r
-\r
+    @property\r
+    def DecPcds(self):\r
+        if self._DecPcds == None:\r
+            FdfInfList = []\r
+            if GlobalData.gFdfParser:\r
+                FdfInfList = GlobalData.gFdfParser.Profile.InfList\r
+            PkgSet = set()\r
+            for Inf in FdfInfList:\r
+                ModuleFile = PathClass(NormPath(Inf), GlobalData.gWorkspace, Arch=self._Arch)\r
+                if ModuleFile in self._Modules:\r
+                    continue\r
+                ModuleData = self._Bdb[ModuleFile, self._Arch, self._Target, self._Toolchain]\r
+                PkgSet.update(ModuleData.Packages)\r
+            self._DecPcds, self._GuidDict = GetDeclaredPcd(self, self._Bdb, self._Arch, self._Target, self._Toolchain,PkgSet)\r
+        return self._DecPcds\r
     _Macros             = property(_GetMacros)\r
     Arch                = property(_GetArch, _SetArch)\r
     Platform            = property(_GetPlatformName)\r
@@ -1886,8 +2074,6 @@ class DscBuildData(PlatformBuildClassObject):
     SupArchList         = property(_GetSupArch)\r
     BuildTargets        = property(_GetBuildTarget)\r
     SkuName             = property(_GetSkuName, _SetSkuName)\r
-    SkuIdentifier       = property(_GetSkuIdentifier)\r
-    AvilableSkuIds      = property(_GetAviableSkuIds)\r
     PcdInfoFlag         = property(_GetPcdInfoFlag)\r
     VarCheckFlag        = property(_GetVarCheckFlag)\r
     FlashDefinition     = property(_GetFdfFile)\r
@@ -1907,3 +2093,4 @@ class DscBuildData(PlatformBuildClassObject):
     LibraryClasses      = property(_GetLibraryClasses)\r
     Pcds                = property(_GetPcds)\r
     BuildOptions        = property(_GetBuildOptions)\r
+    ToolChainFamily     = property(_GetToolChainFamily)\r