]> git.proxmox.com Git - mirror_edk2.git/blobdiff - IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacySio.c
IntelFrameworkModulePkg/LegacyBios: Rename local variables
[mirror_edk2.git] / IntelFrameworkModulePkg / Csm / LegacyBiosDxe / LegacySio.c
index 6c7d7d6b9f9cda35abc33940fae89e842adffe66..9844d64fd62516c1c009d1319889081000b04f5c 100644 (file)
@@ -23,7 +23,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 \r
   @param  SioPtr       Pointer to SIO data.\r
 \r
-  @retval EFI_SUCCESS  It should always work.\r
+  @retval EFI_SUCCESS   When SIO data is got successfully.\r
+  @retval EFI_NOT_FOUND When ISA IO interface is absent.\r
 \r
 **/\r
 EFI_STATUS\r
@@ -32,9 +33,9 @@ LegacyBiosBuildSioDataFromIsaIo (
   )\r
 {\r
   EFI_STATUS                          Status;\r
-  DEVICE_PRODUCER_SERIAL              *Sio1Ptr;\r
-  DEVICE_PRODUCER_PARALLEL            *Sio2Ptr;\r
-  DEVICE_PRODUCER_FLOPPY              *Sio3Ptr;\r
+  DEVICE_PRODUCER_SERIAL              *SioSerial;\r
+  DEVICE_PRODUCER_PARALLEL            *SioParallel;\r
+  DEVICE_PRODUCER_FLOPPY              *SioFloppy;\r
   UINTN                               HandleCount;\r
   EFI_HANDLE                          *HandleBuffer;\r
   UINTN                               Index;\r
@@ -62,7 +63,7 @@ LegacyBiosBuildSioDataFromIsaIo (
                   &HandleBuffer\r
                   );\r
   if (EFI_ERROR (Status)) {\r
-    return EFI_SUCCESS;\r
+    return EFI_NOT_FOUND;\r
   }\r
   //\r
   // Collect legacy information from each of the ISA controllers in the system\r
@@ -136,10 +137,10 @@ LegacyBiosBuildSioDataFromIsaIo (
         // We want resource for legacy even if no 32-bit driver installed\r
         //\r
         for (ChildIndex = 0; ChildIndex < EntryCount; ChildIndex++) {\r
-          Sio1Ptr           = &SioPtr->Serial[ResourceList->Device.UID];\r
-          Sio1Ptr->Address  = (UINT16) IoResource->StartRange;\r
-          Sio1Ptr->Irq      = (UINT8) InterruptResource->StartRange;\r
-          Sio1Ptr->Mode     = DEVICE_SERIAL_MODE_NORMAL | DEVICE_SERIAL_MODE_DUPLEX_HALF;\r
+          SioSerial           = &SioPtr->Serial[ResourceList->Device.UID];\r
+          SioSerial->Address  = (UINT16) IoResource->StartRange;\r
+          SioSerial->Irq      = (UINT8) InterruptResource->StartRange;\r
+          SioSerial->Mode     = DEVICE_SERIAL_MODE_NORMAL | DEVICE_SERIAL_MODE_DUPLEX_HALF;\r
         }\r
 \r
         FreePool (OpenInfoBuffer);\r
@@ -157,11 +158,11 @@ LegacyBiosBuildSioDataFromIsaIo (
           InterruptResource != NULL &&\r
           DmaResource != NULL\r
           ) {\r
-        Sio2Ptr           = &SioPtr->Parallel[ResourceList->Device.UID];\r
-        Sio2Ptr->Address  = (UINT16) IoResource->StartRange;\r
-        Sio2Ptr->Irq      = (UINT8) InterruptResource->StartRange;\r
-        Sio2Ptr->Dma      = (UINT8) DmaResource->StartRange;\r
-        Sio2Ptr->Mode     = DEVICE_PARALLEL_MODE_MODE_OUTPUT_ONLY;\r
+        SioParallel           = &SioPtr->Parallel[ResourceList->Device.UID];\r
+        SioParallel->Address  = (UINT16) IoResource->StartRange;\r
+        SioParallel->Irq      = (UINT8) InterruptResource->StartRange;\r
+        SioParallel->Dma      = (UINT8) DmaResource->StartRange;\r
+        SioParallel->Mode     = DEVICE_PARALLEL_MODE_MODE_OUTPUT_ONLY;\r
       }\r
     }\r
     //\r
@@ -171,11 +172,11 @@ LegacyBiosBuildSioDataFromIsaIo (
       if (IoResource != NULL && InterruptResource != NULL && DmaResource != NULL) {\r
         Status = gBS->HandleProtocol (HandleBuffer[Index], &gEfiBlockIoProtocolGuid, (VOID **) &BlockIo);\r
         if (!EFI_ERROR (Status)) {\r
-          Sio3Ptr           = &SioPtr->Floppy;\r
-          Sio3Ptr->Address  = (UINT16) IoResource->StartRange;\r
-          Sio3Ptr->Irq      = (UINT8) InterruptResource->StartRange;\r
-          Sio3Ptr->Dma      = (UINT8) DmaResource->StartRange;\r
-          Sio3Ptr->NumberOfFloppy++;\r
+          SioFloppy           = &SioPtr->Floppy;\r
+          SioFloppy->Address  = (UINT16) IoResource->StartRange;\r
+          SioFloppy->Irq      = (UINT8) InterruptResource->StartRange;\r
+          SioFloppy->Dma      = (UINT8) DmaResource->StartRange;\r
+          SioFloppy->NumberOfFloppy++;\r
         }\r
       }\r
     }\r