IntelFrameworkModulePkg GenericBdsLib: Potential read over memory boudary

[mirror_edk2.git] / IntelFrameworkModulePkg / Library / GenericBdsLib / BdsMisc.c

diff --git a/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsMisc.c b/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsMisc.c
index b5be63140f4f8023dab011a47cab8488c0bc8429..24c1998a1415de2773f20416bc68ef659408da78 100644 (file)
--- a/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsMisc.c
+++ b/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsMisc.c
@@ -1127,16 +1127,20 @@ SetupResetReminder (
   if (IsResetReminderFeatureEnable ()) {\r
     if (IsResetRequired ()) {\r
 \r
-      StringBuffer1 = AllocateCopyPool (\r
-                        MAX_STRING_LEN * sizeof (CHAR16),\r
-                        L"Configuration changed. Reset to apply it Now."\r
-                        );\r
+      StringBuffer1 = AllocateZeroPool (MAX_STRING_LEN * sizeof (CHAR16));\r
       ASSERT (StringBuffer1 != NULL);\r
-      StringBuffer2 = AllocateCopyPool (\r
-                        MAX_STRING_LEN * sizeof (CHAR16),\r
-                        L"Press ENTER to reset"\r
-                        );\r
+      StringBuffer2 = AllocateZeroPool (MAX_STRING_LEN * sizeof (CHAR16));\r
       ASSERT (StringBuffer2 != NULL);\r
+      StrCpyS (\r
+        StringBuffer1,\r
+        MAX_STRING_LEN,\r
+        L"Configuration changed. Reset to apply it Now."\r
+        );\r
+      StrCpyS (\r
+        StringBuffer2,\r
+        MAX_STRING_LEN,\r
+        L"Press ENTER to reset"\r
+        );\r
       //\r
       // Popup a menu to notice user\r
       //\r