1.Refine all the goto and action opcode. When the menu link to the sub form, use...

[mirror_edk2.git] / IntelFrameworkModulePkg / Universal / BdsDxe / DeviceMngr / DeviceManager.c

diff --git a/IntelFrameworkModulePkg/Universal/BdsDxe/DeviceMngr/DeviceManager.c b/IntelFrameworkModulePkg/Universal/BdsDxe/DeviceMngr/DeviceManager.c
index dfc1b887a7acbca3c346e994f150ce43ba826a90..7da685103330c26c7f0369034122e418e6e49e56 100644 (file)
--- a/IntelFrameworkModulePkg/Universal/BdsDxe/DeviceMngr/DeviceManager.c
+++ b/IntelFrameworkModulePkg/Universal/BdsDxe/DeviceMngr/DeviceManager.c
@@ -883,13 +883,13 @@ CallDeviceManager (
         //\r
         if (!AddNetworkMenu) {\r
           AddNetworkMenu = TRUE;\r
-          HiiCreateActionOpCode (\r
+          HiiCreateGotoOpCode (\r
             StartOpCodeHandle,\r
-            (EFI_QUESTION_ID) QUESTION_NETWORK_DEVICE_ID,\r
+            DEVICE_MANAGER_FORM_ID,\r
             STRING_TOKEN (STR_FORM_NETWORK_DEVICE_LIST_TITLE),\r
             STRING_TOKEN (STR_FORM_NETWORK_DEVICE_LIST_HELP),\r
             EFI_IFR_FLAG_CALLBACK,\r
-            0\r
+            (EFI_QUESTION_ID) QUESTION_NETWORK_DEVICE_ID\r
             );\r
         }\r
       } else if (mNextShowFormId == NETWORK_DEVICE_LIST_FORM_ID) {\r
@@ -897,13 +897,13 @@ CallDeviceManager (
         // In network device list form, same mac address device only show one menu.\r
         //\r
         while (AddItemCount > 0) {\r
-            HiiCreateActionOpCode (\r
+            HiiCreateGotoOpCode (\r
               StartOpCodeHandle,\r
-              mMacDeviceList.NodeList[mMacDeviceList.CurListLen - AddItemCount].QuestionId,\r
+              NETWORK_DEVICE_LIST_FORM_ID,\r
               mMacDeviceList.NodeList[mMacDeviceList.CurListLen - AddItemCount].PromptId,\r
               STRING_TOKEN (STR_NETWORK_DEVICE_HELP),\r
               EFI_IFR_FLAG_CALLBACK,\r
-              0\r
+              mMacDeviceList.NodeList[mMacDeviceList.CurListLen - AddItemCount].QuestionId\r
               );\r
             AddItemCount -= 1;\r
           }\r
@@ -911,13 +911,13 @@ CallDeviceManager (
         //\r
         // In network device form, only the selected mac address device need to be show.\r
         //\r
-        HiiCreateActionOpCode (\r
+        HiiCreateGotoOpCode (\r
           StartOpCodeHandle,\r
-          (EFI_QUESTION_ID) (Index + DEVICE_KEY_OFFSET),\r
+          NETWORK_DEVICE_FORM_ID,\r
           Token,\r
           TokenHelp,\r
           EFI_IFR_FLAG_CALLBACK,\r
-          0\r
+          (EFI_QUESTION_ID) (Index + DEVICE_KEY_OFFSET)\r
           );\r
       }\r
     } else {\r
@@ -926,13 +926,13 @@ CallDeviceManager (
       // Not network device process, only need to show at device manger form.\r
       //\r
       if (mNextShowFormId == DEVICE_MANAGER_FORM_ID) {\r
-        HiiCreateActionOpCode (\r
+        HiiCreateGotoOpCode (\r
           StartOpCodeHandle,\r
-          (EFI_QUESTION_ID) (Index + DEVICE_KEY_OFFSET),\r
+          DEVICE_MANAGER_FORM_ID,\r
           Token,\r
           TokenHelp,\r
           EFI_IFR_FLAG_CALLBACK,\r
-          0\r
+          (EFI_QUESTION_ID) (Index + DEVICE_KEY_OFFSET)\r
           );\r
       }\r
     }\r
@@ -954,14 +954,14 @@ CallDeviceManager (
     // If driver health protocol is installed, create Driver Health subtitle and entry\r
     //\r
     HiiCreateSubTitleOpCode (StartOpCodeHandle, STRING_TOKEN (STR_DM_DRIVER_HEALTH_TITLE), 0, 0, 0);\r
-    HiiCreateActionOpCode (\r
-      StartOpCodeHandle,                                // Container for dynamic created opcodes\r
-      DEVICE_MANAGER_KEY_DRIVER_HEALTH,                 // Question ID\r
+    HiiCreateGotoOpCode (\r
+      StartOpCodeHandle,\r
+      DRIVER_HEALTH_FORM_ID,\r
       STRING_TOKEN(STR_DRIVER_HEALTH_ALL_HEALTHY),      // Prompt text\r
       STRING_TOKEN(STR_DRIVER_HEALTH_STATUS_HELP),      // Help text\r
-      EFI_IFR_FLAG_CALLBACK,                            // Question flag\r
-      0                                                 // Action String ID\r
-    );\r
+      EFI_IFR_FLAG_CALLBACK,\r
+      DEVICE_MANAGER_KEY_DRIVER_HEALTH                  // Question ID\r
+      );\r
 \r
     //\r
     // Check All Driver health status\r