]> git.proxmox.com Git - mirror_edk2.git/blobdiff - MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
Revert "MdeModulePkg: Fix a PciBusDxe hot plug bug"
[mirror_edk2.git] / MdeModulePkg / Bus / Pci / PciBusDxe / PciLib.c
index f4b6ebfc0d30ffe8ada9712e846a726045353808..3e275e34ecebe4c998d18cf05184e373120494c6 100644 (file)
@@ -188,21 +188,19 @@ DumpBridgeResource (
       BridgeResource->PciDev->PciBar[BridgeResource->Bar].BaseAddress,\r
       BridgeResource->Length, BridgeResource->Alignment\r
       ));\r
-    for ( Link = GetFirstNode (&BridgeResource->ChildList)\r
-        ; !IsNull (&BridgeResource->ChildList, Link)\r
-        ; Link = GetNextNode (&BridgeResource->ChildList, Link)\r
+    for ( Link = BridgeResource->ChildList.ForwardLink\r
+        ; Link != &BridgeResource->ChildList\r
+        ; Link = Link->ForwardLink\r
         ) {\r
       Resource = RESOURCE_NODE_FROM_LINK (Link);\r
       if (Resource->ResourceUsage == PciResUsageTypical) {\r
         Bar = Resource->Virtual ? Resource->PciDev->VfPciBar : Resource->PciDev->PciBar;\r
         DEBUG ((\r
-          EFI_D_INFO, "   Base = 0x%lx;\tLength = 0x%lx;\tAlignment = 0x%lx;\tOwner = %s [%02x|%02x|%02x:",\r
+          EFI_D_INFO, " Base = 0x%lx;\tLength = 0x%lx;\tAlignment = 0x%lx;\tOwner = %s ",\r
           Bar[Resource->Bar].BaseAddress, Resource->Length, Resource->Alignment,\r
           IS_PCI_BRIDGE (&Resource->PciDev->Pci)     ? L"PPB" :\r
           IS_CARDBUS_BRIDGE (&Resource->PciDev->Pci) ? L"P2C" :\r
-                                                       L"PCI",\r
-          Resource->PciDev->BusNumber, Resource->PciDev->DeviceNumber,\r
-          Resource->PciDev->FunctionNumber\r
+                                                       L"PCI"\r
           ));\r
 \r
         if ((!IS_PCI_BRIDGE (&Resource->PciDev->Pci) && !IS_CARDBUS_BRIDGE (&Resource->PciDev->Pci)) ||\r
@@ -212,20 +210,24 @@ DumpBridgeResource (
           //\r
           // The resource requirement comes from the device itself.\r
           //\r
-          DEBUG ((EFI_D_INFO, "%02x]", Bar[Resource->Bar].Offset));\r
+          DEBUG ((\r
+            EFI_D_INFO, " [%02x|%02x|%02x:%02x]\n",\r
+            Resource->PciDev->BusNumber, Resource->PciDev->DeviceNumber,\r
+            Resource->PciDev->FunctionNumber, Bar[Resource->Bar].Offset\r
+            ));\r
         } else {\r
           //\r
           // The resource requirement comes from the subordinate devices.\r
           //\r
-          DEBUG ((EFI_D_INFO, "**]"));\r
+          DEBUG ((\r
+            EFI_D_INFO, " [%02x|%02x|%02x:**]\n",\r
+            Resource->PciDev->BusNumber, Resource->PciDev->DeviceNumber,\r
+            Resource->PciDev->FunctionNumber\r
+            ));\r
         }\r
       } else {\r
-        DEBUG ((EFI_D_INFO, "   Base = Padding;\tLength = 0x%lx;\tAlignment = 0x%lx", Resource->Length, Resource->Alignment));\r
+        DEBUG ((EFI_D_INFO, " Padding:Length = 0x%lx;\tAlignment = 0x%lx\n", Resource->Length, Resource->Alignment));\r
       }\r
-      if (BridgeResource->ResType != Resource->ResType) {\r
-        DEBUG ((EFI_D_INFO, "; Type = %s", mBarTypeStr[MIN (Resource->ResType, PciBarTypeMaxType)]));\r
-      }\r
-      DEBUG ((EFI_D_INFO, "\n"));\r
     }\r
   }\r
 }\r
@@ -233,61 +235,63 @@ DumpBridgeResource (
 /**\r
   Find the corresponding resource node for the Device in child list of BridgeResource.\r
   \r
-  @param[in]  Device          Pointer to PCI_IO_DEVICE.\r
-  @param[in]  BridgeResource  Pointer to PCI_RESOURCE_NODE.\r
-  @param[out] DeviceResources Pointer to a buffer to receive resources for the Device.\r
+  @param[in] Device         Pointer to PCI_IO_DEVICE.\r
+  @param[in] BridgeResource Pointer to PCI_RESOURCE_NODE.\r
   \r
-  @return Count of the resource descriptors returned.\r
+  @return !NULL  The corresponding resource node for the Device.\r
+  @return NULL   No corresponding resource node for the Device.\r
 **/\r
-UINTN\r
+PCI_RESOURCE_NODE *\r
 FindResourceNode (\r
-  IN  PCI_IO_DEVICE     *Device,\r
-  IN  PCI_RESOURCE_NODE *BridgeResource,\r
-  OUT PCI_RESOURCE_NODE **DeviceResources OPTIONAL\r
+  IN PCI_IO_DEVICE     *Device,\r
+  IN PCI_RESOURCE_NODE *BridgeResource\r
   )\r
 {\r
   LIST_ENTRY               *Link;\r
   PCI_RESOURCE_NODE        *Resource;\r
-  UINTN                    Count;\r
 \r
-  Count = 0;\r
   for ( Link = BridgeResource->ChildList.ForwardLink\r
       ; Link != &BridgeResource->ChildList\r
       ; Link = Link->ForwardLink\r
       ) {\r
     Resource = RESOURCE_NODE_FROM_LINK (Link);\r
     if (Resource->PciDev == Device) {\r
-      if (DeviceResources != NULL) {\r
-        DeviceResources[Count] = Resource;\r
-      }\r
-      Count++;\r
+      return Resource;\r
     }\r
   }\r
 \r
-  return Count;\r
+  return NULL;\r
 }\r
 \r
 /**\r
   Dump the resource map of all the devices under Bridge.\r
   \r
-  @param[in] Bridge        Bridge device instance.\r
-  @param[in] Resources     Resource descriptors for the bridge device.\r
-  @param[in] ResourceCount Count of resource descriptors.\r
+  @param[in] Bridge     Bridge device instance.\r
+  @param[in] IoNode     IO resource descriptor for the bridge device.\r
+  @param[in] Mem32Node  Mem32 resource descriptor for the bridge device.\r
+  @param[in] PMem32Node PMem32 resource descriptor for the bridge device.\r
+  @param[in] Mem64Node  Mem64 resource descriptor for the bridge device.\r
+  @param[in] PMem64Node PMem64 resource descriptor for the bridge device.\r
 **/\r
 VOID\r
 DumpResourceMap (\r
   IN PCI_IO_DEVICE     *Bridge,\r
-  IN PCI_RESOURCE_NODE **Resources,\r
-  IN UINTN             ResourceCount\r
+  IN PCI_RESOURCE_NODE *IoNode,\r
+  IN PCI_RESOURCE_NODE *Mem32Node,\r
+  IN PCI_RESOURCE_NODE *PMem32Node,\r
+  IN PCI_RESOURCE_NODE *Mem64Node,\r
+  IN PCI_RESOURCE_NODE *PMem64Node\r
   )\r
 {\r
-  EFI_STATUS           Status;\r
-  LIST_ENTRY           *Link;\r
-  PCI_IO_DEVICE        *Device;\r
-  UINTN                Index;\r
-  CHAR16               *Str;\r
-  PCI_RESOURCE_NODE    **ChildResources;\r
-  UINTN                ChildResourceCount;\r
+  EFI_STATUS                       Status;\r
+  LIST_ENTRY                       *Link;\r
+  PCI_IO_DEVICE                    *Device;\r
+  PCI_RESOURCE_NODE                *ChildIoNode;\r
+  PCI_RESOURCE_NODE                *ChildMem32Node;\r
+  PCI_RESOURCE_NODE                *ChildPMem32Node;\r
+  PCI_RESOURCE_NODE                *ChildMem64Node;\r
+  PCI_RESOURCE_NODE                *ChildPMem64Node;\r
+  CHAR16                           *Str;\r
 \r
   DEBUG ((EFI_D_INFO, "PciBus: Resource Map for "));\r
 \r
@@ -316,9 +320,11 @@ DumpResourceMap (
     }\r
   }\r
 \r
-  for (Index = 0; Index < ResourceCount; Index++) {\r
-    DumpBridgeResource (Resources[Index]);\r
-  }\r
+  DumpBridgeResource (IoNode);\r
+  DumpBridgeResource (Mem32Node);\r
+  DumpBridgeResource (PMem32Node);\r
+  DumpBridgeResource (Mem64Node);\r
+  DumpBridgeResource (PMem64Node);\r
   DEBUG ((EFI_D_INFO, "\n"));\r
 \r
   for ( Link = Bridge->ChildList.ForwardLink\r
@@ -328,19 +334,20 @@ DumpResourceMap (
     Device = PCI_IO_DEVICE_FROM_LINK (Link);\r
     if (IS_PCI_BRIDGE (&Device->Pci)) {\r
 \r
-      ChildResourceCount = 0;\r
-      for (Index = 0; Index < ResourceCount; Index++) {\r
-        ChildResourceCount += FindResourceNode (Device, Resources[Index], NULL);\r
-      }\r
-      ChildResources = AllocatePool (sizeof (PCI_RESOURCE_NODE *) * ChildResourceCount);\r
-      ASSERT (ChildResources != NULL);\r
-      ChildResourceCount = 0;\r
-      for (Index = 0; Index < ResourceCount; Index++) {\r
-        ChildResourceCount += FindResourceNode (Device, Resources[Index], &ChildResources[ChildResourceCount]);\r
-      }\r
-\r
-      DumpResourceMap (Device, ChildResources, ChildResourceCount);\r
-      FreePool (ChildResources);\r
+      ChildIoNode     = (IoNode     == NULL ? NULL : FindResourceNode (Device, IoNode));\r
+      ChildMem32Node  = (Mem32Node  == NULL ? NULL : FindResourceNode (Device, Mem32Node));\r
+      ChildPMem32Node = (PMem32Node == NULL ? NULL : FindResourceNode (Device, PMem32Node));\r
+      ChildMem64Node  = (Mem64Node  == NULL ? NULL : FindResourceNode (Device, Mem64Node));\r
+      ChildPMem64Node = (PMem64Node == NULL ? NULL : FindResourceNode (Device, PMem64Node));\r
+\r
+      DumpResourceMap (\r
+        Device,\r
+        ChildIoNode,\r
+        ChildMem32Node,\r
+        ChildPMem32Node,\r
+        ChildMem64Node,\r
+        ChildPMem64Node\r
+        );\r
     }\r
   }\r
 }\r
@@ -800,11 +807,11 @@ PciHostBridgeResourceAllocator (
     // Create the entire system resource map from the information collected by\r
     // enumerator. Several resource tree was created\r
     //\r
-    FindResourceNode (RootBridgeDev, &IoPool, &IoBridge);\r
-    FindResourceNode (RootBridgeDev, &Mem32Pool, &Mem32Bridge);\r
-    FindResourceNode (RootBridgeDev, &PMem32Pool, &PMem32Bridge);\r
-    FindResourceNode (RootBridgeDev, &Mem64Pool, &Mem64Bridge);\r
-    FindResourceNode (RootBridgeDev, &PMem64Pool, &PMem64Bridge);\r
+    IoBridge     = FindResourceNode (RootBridgeDev, &IoPool);\r
+    Mem32Bridge  = FindResourceNode (RootBridgeDev, &Mem32Pool);\r
+    PMem32Bridge = FindResourceNode (RootBridgeDev, &PMem32Pool);\r
+    Mem64Bridge  = FindResourceNode (RootBridgeDev, &Mem64Pool);\r
+    PMem64Bridge = FindResourceNode (RootBridgeDev, &PMem64Pool);\r
 \r
     ASSERT (IoBridge     != NULL);\r
     ASSERT (Mem32Bridge  != NULL);\r
@@ -862,13 +869,14 @@ PciHostBridgeResourceAllocator (
     // Dump the resource map for current root bridge\r
     //\r
     DEBUG_CODE (\r
-      PCI_RESOURCE_NODE *Resources[5];\r
-      Resources[0] = IoBridge;\r
-      Resources[1] = Mem32Bridge;\r
-      Resources[2] = PMem32Bridge;\r
-      Resources[3] = Mem64Bridge;\r
-      Resources[4] = PMem64Bridge;\r
-      DumpResourceMap (RootBridgeDev, Resources, sizeof (Resources) / sizeof (Resources[0]));\r
+      DumpResourceMap (\r
+        RootBridgeDev,\r
+        IoBridge,\r
+        Mem32Bridge,\r
+        PMem32Bridge,\r
+        Mem64Bridge,\r
+        PMem64Bridge\r
+        );\r
     );\r
 \r
     FreePool (AcpiConfig);\r
@@ -976,8 +984,7 @@ PciScanBus (
   UINT8                             Device;\r
   UINT8                             Func;\r
   UINT64                            Address;\r
-  UINT8                             SecondBus;\r
-  UINT8                             PaddedSubBus;\r
+  UINTN                             SecondBus;\r
   UINT16                            Register;\r
   UINTN                             HpIndex;\r
   PCI_IO_DEVICE                     *PciDevice;\r
@@ -1211,7 +1218,7 @@ PciScanBus (
 \r
           Status = PciScanBus (\r
                     PciDevice,\r
-                    SecondBus,\r
+                    (UINT8) (SecondBus),\r
                     SubBusNumber,\r
                     PaddedBusRange\r
                     );\r
@@ -1227,16 +1234,12 @@ PciScanBus (
           if ((Attributes == EfiPaddingPciRootBridge) &&\r
               (State & EFI_HPC_STATE_ENABLED) != 0    &&\r
               (State & EFI_HPC_STATE_INITIALIZED) != 0) {\r
-            *PaddedBusRange = (UINT8) ((UINT8) (BusRange) + *PaddedBusRange);\r
+            *PaddedBusRange = (UINT8) ((UINT8) (BusRange) +*PaddedBusRange);\r
           } else {\r
-            //\r
-            // Reserve the larger one between the actual occupied bus number and padded bus number\r
-            //\r
-            Status = PciAllocateBusNumber (PciDevice, StartBusNumber, (UINT8) (BusRange), &PaddedSubBus);\r
+            Status = PciAllocateBusNumber (PciDevice, *SubBusNumber, (UINT8) (BusRange), SubBusNumber);\r
             if (EFI_ERROR (Status)) {\r
               return Status;\r
             }\r
-            *SubBusNumber = MAX (PaddedSubBus, *SubBusNumber);\r
           }\r
         }\r
 \r