/** @file\r
\r
-Copyright (c) 2007 - 2008, Intel Corporation\r
-All rights reserved. This program and the accompanying materials\r
-are licensed and made available under the terms and conditions of the BSD License\r
-which accompanies this distribution. The full text of the license may be found at\r
-http://opensource.org/licenses/bsd-license.php\r
-\r
-THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,\r
-WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.\r
-\r
-Module Name:\r
-\r
- UhciSched.c\r
-\r
-Abstract:\r
-\r
The EHCI register operation routines.\r
\r
-Revision History\r
-\r
+Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>\r
+SPDX-License-Identifier: BSD-2-Clause-Patent\r
\r
**/\r
\r
\r
\r
/**\r
- Create Frame List Structure\r
+ Create Frame List Structure.\r
\r
- @param Uhc UHCI device\r
+ @param Uhc UHCI device.\r
\r
- @retval EFI_OUT_OF_RESOURCES Can't allocate memory resources\r
- @retval EFI_UNSUPPORTED Map memory fail\r
- @retval EFI_SUCCESS Success\r
+ @retval EFI_OUT_OF_RESOURCES Can't allocate memory resources.\r
+ @retval EFI_UNSUPPORTED Map memory fail.\r
+ @retval EFI_SUCCESS Success.\r
\r
**/\r
EFI_STATUS\r
UINTN Pages;\r
UINTN Bytes;\r
UINTN Index;\r
+ EFI_PHYSICAL_ADDRESS PhyAddr;\r
\r
//\r
// The Frame List is a common buffer that will be\r
goto ON_ERROR;\r
}\r
\r
- Uhc->FrameBase = (UINT32 *) (UINTN) MappedAddr;\r
- Uhc->FrameMapping = Mapping;\r
+ Uhc->FrameBase = (UINT32 *) (UINTN) Buffer;\r
+ Uhc->FrameMapping = Mapping;\r
+\r
+ //\r
+ // Tell the Host Controller where the Frame List lies,\r
+ // by set the Frame List Base Address Register.\r
+ //\r
+ UhciSetFrameListBaseAddr (Uhc->PciIo, (VOID *) (UINTN) MappedAddr);\r
\r
//\r
// Allocate the QH used by sync interrupt/control/bulk transfer.\r
// Each frame entry is linked to this sequence of QH. These QH\r
// will remain on the schedul, never got removed\r
//\r
- Uhc->SyncIntQh->QhHw.HorizonLink = QH_HLINK (Uhc->CtrlQh, FALSE);\r
+ PhyAddr = UsbHcGetPciAddressForHostMem (Uhc->MemPool, Uhc->CtrlQh, sizeof (UHCI_QH_HW));\r
+ Uhc->SyncIntQh->QhHw.HorizonLink = QH_HLINK (PhyAddr, FALSE);\r
Uhc->SyncIntQh->NextQh = Uhc->CtrlQh;\r
\r
- Uhc->CtrlQh->QhHw.HorizonLink = QH_HLINK (Uhc->BulkQh, FALSE);\r
+ PhyAddr = UsbHcGetPciAddressForHostMem (Uhc->MemPool, Uhc->BulkQh, sizeof (UHCI_QH_HW));\r
+ Uhc->CtrlQh->QhHw.HorizonLink = QH_HLINK (PhyAddr, FALSE);\r
Uhc->CtrlQh->NextQh = Uhc->BulkQh;\r
\r
//\r
// in supporting the full speed bandwidth reclamation in the previous\r
// mentioned form. Most new platforms don't suffer it.\r
//\r
- Uhc->BulkQh->QhHw.HorizonLink = QH_HLINK (Uhc->BulkQh, FALSE);\r
+ Uhc->BulkQh->QhHw.HorizonLink = QH_HLINK (PhyAddr, FALSE);\r
\r
Uhc->BulkQh->NextQh = NULL;\r
\r
+ Uhc->FrameBaseHostAddr = AllocateZeroPool (4096);\r
+ if (Uhc->FrameBaseHostAddr == NULL) {\r
+ Status = EFI_OUT_OF_RESOURCES;\r
+ goto ON_ERROR;\r
+ }\r
+\r
+ PhyAddr = UsbHcGetPciAddressForHostMem (Uhc->MemPool, Uhc->SyncIntQh, sizeof (UHCI_QH_HW));\r
for (Index = 0; Index < UHCI_FRAME_NUM; Index++) {\r
- Uhc->FrameBase[Index] = QH_HLINK (Uhc->SyncIntQh, FALSE);\r
+ Uhc->FrameBase[Index] = QH_HLINK (PhyAddr, FALSE);\r
+ Uhc->FrameBaseHostAddr[Index] = (UINT32)(UINTN)Uhc->SyncIntQh;\r
}\r
\r
- //\r
- // Tell the Host Controller where the Frame List lies,\r
- // by set the Frame List Base Address Register.\r
- //\r
- UhciSetFrameListBaseAddr (Uhc->PciIo, (VOID *) (Uhc->FrameBase));\r
return EFI_SUCCESS;\r
\r
ON_ERROR:\r
\r
\r
/**\r
- Destory FrameList buffer\r
+ Destory FrameList buffer.\r
\r
- @param Uhc The UHCI device\r
-\r
- @return VOID\r
+ @param Uhc The UHCI device.\r
\r
**/\r
VOID\r
(VOID *) Uhc->FrameBase\r
);\r
\r
+ if (Uhc->FrameBaseHostAddr != NULL) {\r
+ FreePool (Uhc->FrameBaseHostAddr);\r
+ }\r
+\r
if (Uhc->SyncIntQh != NULL) {\r
UsbHcFreeMem (Uhc->MemPool, Uhc->SyncIntQh, sizeof (UHCI_QH_SW));\r
}\r
UsbHcFreeMem (Uhc->MemPool, Uhc->BulkQh, sizeof (UHCI_QH_SW));\r
}\r
\r
- Uhc->FrameBase = NULL;\r
- Uhc->SyncIntQh = NULL;\r
- Uhc->CtrlQh = NULL;\r
- Uhc->BulkQh = NULL;\r
+ Uhc->FrameBase = NULL;\r
+ Uhc->FrameBaseHostAddr = NULL;\r
+ Uhc->SyncIntQh = NULL;\r
+ Uhc->CtrlQh = NULL;\r
+ Uhc->BulkQh = NULL;\r
}\r
\r
\r
/**\r
Convert the poll rate to the maxium 2^n that is smaller\r
- than Interval\r
+ than Interval.\r
\r
- @param Interval The poll rate to convert\r
+ @param Interval The poll rate to convert.\r
\r
- @return The converted poll rate\r
+ @return The converted poll rate.\r
\r
**/\r
UINTN\r
Link a queue head (for asynchronous interrupt transfer) to\r
the frame list.\r
\r
- @param FrameBase The base of the frame list\r
- @param Qh The queue head to link into\r
-\r
- @return None\r
+ @param Uhc The UHCI device.\r
+ @param Qh The queue head to link into.\r
\r
**/\r
VOID\r
UhciLinkQhToFrameList (\r
- UINT32 *FrameBase,\r
+ USB_HC_DEV *Uhc,\r
UHCI_QH_SW *Qh\r
)\r
{\r
UINTN Index;\r
UHCI_QH_SW *Prev;\r
UHCI_QH_SW *Next;\r
+ EFI_PHYSICAL_ADDRESS PhyAddr;\r
+ EFI_PHYSICAL_ADDRESS QhPciAddr;\r
+\r
+ ASSERT ((Uhc->FrameBase != NULL) && (Qh != NULL));\r
\r
- ASSERT ((FrameBase != NULL) && (Qh != NULL));\r
+ QhPciAddr = UsbHcGetPciAddressForHostMem (Uhc->MemPool, Qh, sizeof (UHCI_QH_HW));\r
\r
for (Index = 0; Index < UHCI_FRAME_NUM; Index += Qh->Interval) {\r
//\r
// First QH can't be NULL because we always keep static queue\r
// heads on the frame list\r
//\r
- ASSERT (!LINK_TERMINATED (FrameBase[Index]));\r
- Next = UHCI_ADDR (FrameBase[Index]);\r
+ ASSERT (!LINK_TERMINATED (Uhc->FrameBase[Index]));\r
+ Next = (UHCI_QH_SW*)(UINTN)Uhc->FrameBaseHostAddr[Index];\r
Prev = NULL;\r
\r
//\r
while (Next->Interval > Qh->Interval) {\r
Prev = Next;\r
Next = Next->NextQh;\r
+ ASSERT (Next != NULL);\r
}\r
\r
- ASSERT (Next != NULL);\r
-\r
//\r
// The entry may have been linked into the frame by early insertation.\r
// For example: if insert a Qh with Qh.Interval == 4, and there is a Qh\r
Prev->NextQh = Qh;\r
\r
Qh->QhHw.HorizonLink = Prev->QhHw.HorizonLink;\r
- Prev->QhHw.HorizonLink = QH_HLINK (Qh, FALSE);\r
+\r
+ Prev->QhHw.HorizonLink = QH_HLINK (QhPciAddr, FALSE);\r
break;\r
}\r
\r
//\r
if (Qh->NextQh == NULL) {\r
Qh->NextQh = Next;\r
- Qh->QhHw.HorizonLink = QH_HLINK (Next, FALSE);\r
+ PhyAddr = UsbHcGetPciAddressForHostMem (Uhc->MemPool, Next, sizeof (UHCI_QH_HW));\r
+ Qh->QhHw.HorizonLink = QH_HLINK (PhyAddr, FALSE);\r
}\r
\r
if (Prev == NULL) {\r
- FrameBase[Index] = QH_HLINK (Qh, FALSE);\r
+ Uhc->FrameBase[Index] = QH_HLINK (QhPciAddr, FALSE);\r
+ Uhc->FrameBaseHostAddr[Index] = (UINT32)(UINTN)Qh;\r
} else {\r
Prev->NextQh = Qh;\r
- Prev->QhHw.HorizonLink = QH_HLINK (Qh, FALSE);\r
+ Prev->QhHw.HorizonLink = QH_HLINK (QhPciAddr, FALSE);\r
}\r
}\r
}\r
the precedence node, and pointer there next to QhSw's\r
next.\r
\r
- @param FrameBase The base address of the frame list\r
- @param Qh The queue head to unlink\r
-\r
- @return None\r
+ @param Uhc The UHCI device.\r
+ @param Qh The queue head to unlink.\r
\r
**/\r
VOID\r
UhciUnlinkQhFromFrameList (\r
- UINT32 *FrameBase,\r
- UHCI_QH_SW *Qh\r
+ USB_HC_DEV *Uhc,\r
+ UHCI_QH_SW *Qh\r
)\r
{\r
UINTN Index;\r
UHCI_QH_SW *Prev;\r
UHCI_QH_SW *This;\r
\r
- ASSERT ((FrameBase != NULL) && (Qh != NULL));\r
+ ASSERT ((Uhc->FrameBase != NULL) && (Qh != NULL));\r
\r
for (Index = 0; Index < UHCI_FRAME_NUM; Index += Qh->Interval) {\r
//\r
// Frame link can't be NULL because we always keep static\r
// queue heads on the frame list\r
//\r
- ASSERT (!LINK_TERMINATED (FrameBase[Index]));\r
- This = UHCI_ADDR (FrameBase[Index]);\r
+ ASSERT (!LINK_TERMINATED (Uhc->FrameBase[Index]));\r
+ This = (UHCI_QH_SW*)(UINTN)Uhc->FrameBaseHostAddr[Index];\r
Prev = NULL;\r
\r
//\r
//\r
// Qh is the first entry in the frame\r
//\r
- FrameBase[Index] = Qh->QhHw.HorizonLink;\r
+ Uhc->FrameBase[Index] = Qh->QhHw.HorizonLink;\r
+ Uhc->FrameBaseHostAddr[Index] = (UINT32)(UINTN)Qh->NextQh;\r
} else {\r
Prev->NextQh = Qh->NextQh;\r
Prev->QhHw.HorizonLink = Qh->QhHw.HorizonLink;\r
\r
\r
/**\r
- Check TDs Results\r
+ Check TDs Results.\r
\r
- @param Uhc This UHCI device\r
- @param Td UHCI_TD_SW to check\r
- @param IsLow Is Low Speed Device\r
- @param QhResult Return the result of this TD list\r
+ @param Uhc This UHCI device.\r
+ @param Td UHCI_TD_SW to check.\r
+ @param IsLow Is Low Speed Device.\r
+ @param QhResult Return the result of this TD list.\r
\r
@return Whether the TD's result is finialized.\r
\r
**/\r
-STATIC\r
BOOLEAN\r
UhciCheckTdStatus (\r
IN USB_HC_DEV *Uhc,\r
// upper layer won't distinguish these condtions. So, only\r
// set these bits when TD is actually halted.\r
//\r
- if (State & USBTD_STALLED) {\r
- if (State & USBTD_BABBLE) {\r
+ if ((State & USBTD_STALLED) != 0) {\r
+ if ((State & USBTD_BABBLE) != 0) {\r
QhResult->Result |= EFI_USB_ERR_BABBLE;\r
\r
} else if (TdHw->ErrorCount != 0) {\r
QhResult->Result |= EFI_USB_ERR_STALL;\r
}\r
\r
- if (State & USBTD_CRC) {\r
+ if ((State & USBTD_CRC) != 0) {\r
QhResult->Result |= EFI_USB_ERR_CRC;\r
}\r
\r
- if (State & USBTD_BUFFERR) {\r
+ if ((State & USBTD_BUFFERR) != 0) {\r
QhResult->Result |= EFI_USB_ERR_BUFFER;\r
}\r
\r
- if (Td->TdHw.Status & USBTD_BITSTUFF) {\r
+ if ((Td->TdHw.Status & USBTD_BITSTUFF) != 0) {\r
QhResult->Result |= EFI_USB_ERR_BITSTUFF;\r
}\r
\r
Finished = TRUE;\r
goto ON_EXIT;\r
\r
- } else if (State & USBTD_ACTIVE) {\r
+ } else if ((State & USBTD_ACTIVE) != 0) {\r
//\r
// The TD is still active, no need to check further.\r
//\r
// terminate the transfer\r
//\r
if (!IsLow && (TdHw->ShortPacket == 1) && (Len < Td->DataLen)) {\r
- DEBUG ((EFI_D_INFO, "UhciCheckTdStatus: short packet read occured\n"));\r
+ DEBUG ((EFI_D_VERBOSE, "UhciCheckTdStatus: short packet read occured\n"));\r
\r
Finished = TRUE;\r
goto ON_EXIT;\r
}\r
\r
\r
-\r
/**\r
- Check the result of the transfer\r
+ Check the result of the transfer.\r
\r
- @param Uhc The UHCI device\r
- @param Td The first TDs of the transfer\r
- @param TimeOut TimeOut value in milliseconds\r
- @param IsLow Is Low Speed Device\r
- @param QhResult The variable to return result\r
+ @param Uhc The UHCI device.\r
+ @param Qh The queue head of the transfer.\r
+ @param Td The first TDs of the transfer.\r
+ @param TimeOut TimeOut value in milliseconds.\r
+ @param IsLow Is Low Speed Device.\r
+ @param QhResult The variable to return result.\r
\r
- @retval EFI_SUCCESS The transfer finished with success\r
- @retval EFI_DEVICE_ERROR Transfer failed\r
+ @retval EFI_SUCCESS The transfer finished with success.\r
+ @retval EFI_DEVICE_ERROR Transfer failed.\r
\r
**/\r
EFI_STATUS\r
UINTN Delay;\r
BOOLEAN Finished;\r
EFI_STATUS Status;\r
+ BOOLEAN InfiniteLoop;\r
\r
- Finished = FALSE;\r
- Status = EFI_SUCCESS;\r
- Delay = (TimeOut * UHC_1_MILLISECOND / UHC_SYNC_POLL_INTERVAL) + 1;\r
+ Finished = FALSE;\r
+ Status = EFI_SUCCESS;\r
+ Delay = TimeOut * UHC_1_MILLISECOND;\r
+ InfiniteLoop = FALSE;\r
\r
- for (Index = 0; Index < Delay; Index++) {\r
+ //\r
+ // According to UEFI spec section 16.2.4, If Timeout is 0, then the caller\r
+ // must wait for the function to be completed until EFI_SUCCESS or EFI_DEVICE_ERROR\r
+ // is returned.\r
+ //\r
+ if (TimeOut == 0) {\r
+ InfiniteLoop = TRUE;\r
+ }\r
+\r
+ for (Index = 0; InfiniteLoop || (Index < Delay); Index++) {\r
Finished = UhciCheckTdStatus (Uhc, Td, IsLow, QhResult);\r
\r
//\r
break;\r
}\r
\r
- gBS->Stall (UHC_SYNC_POLL_INTERVAL);\r
+ gBS->Stall (UHC_1_MICROSECOND);\r
}\r
\r
if (!Finished) {\r
- DEBUG ((EFI_D_ERROR, "UhciExecuteTransfer: execution not finished for %dms\n", TimeOut));\r
+ DEBUG ((EFI_D_ERROR, "UhciExecuteTransfer: execution not finished for %dms\n", (UINT32)TimeOut));\r
UhciDumpQh (Qh);\r
UhciDumpTds (Td);\r
\r
\r
\r
/**\r
- Update Async Request, QH and TDs\r
-\r
- @param AsyncReq The UHCI asynchronous transfer to update\r
- @param Result Transfer reslut\r
- @param ErrTdPos Error TD Position\r
+ Update Async Request, QH and TDs.\r
\r
- @return VOID\r
+ @param Uhc The UHCI device.\r
+ @param AsyncReq The UHCI asynchronous transfer to update.\r
+ @param Result Transfer reslut.\r
+ @param NextToggle The toggle of next data.\r
\r
**/\r
-STATIC\r
VOID\r
UhciUpdateAsyncReq (\r
+ IN USB_HC_DEV *Uhc,\r
IN UHCI_ASYNC_REQUEST *AsyncReq,\r
IN UINT32 Result,\r
IN UINT32 NextToggle\r
Td->TdHw.Status |= USBTD_ACTIVE;\r
}\r
\r
- UhciLinkTdToQh (Qh, FirstTd);\r
+ UhciLinkTdToQh (Uhc, Qh, FirstTd);\r
return ;\r
}\r
}\r
\r
\r
/**\r
- Create Async Request node, and Link to List\r
-\r
- @param Uhc The UHCI device\r
- @param Qh The queue head of the transfer\r
- @param FirstTd First TD of the transfer\r
- @param DevAddr Device Address\r
- @param EndPoint EndPoint Address\r
- @param DataLen Data length\r
- @param Interval Polling Interval when inserted to frame list\r
- @param Mapping Mapping value\r
- @param Data Data buffer, unmapped\r
- @param Callback Callback after interrupt transfeer\r
- @param Context Callback Context passed as function parameter\r
- @param IsLow Is Low Speed\r
-\r
- @retval EFI_SUCCESS An asynchronous transfer is created\r
- @retval EFI_INVALID_PARAMETER Paremeter is error\r
+ Create Async Request node, and Link to List.\r
+\r
+ @param Uhc The UHCI device.\r
+ @param Qh The queue head of the transfer.\r
+ @param FirstTd First TD of the transfer.\r
+ @param DevAddr Device Address.\r
+ @param EndPoint EndPoint Address.\r
+ @param DataLen Data length.\r
+ @param Interval Polling Interval when inserted to frame list.\r
+ @param Data Data buffer, unmapped.\r
+ @param Callback Callback after interrupt transfeer.\r
+ @param Context Callback Context passed as function parameter.\r
+ @param IsLow Is Low Speed.\r
+\r
+ @retval EFI_SUCCESS An asynchronous transfer is created.\r
+ @retval EFI_INVALID_PARAMETER Paremeter is error.\r
@retval EFI_OUT_OF_RESOURCES Failed because of resource shortage.\r
\r
**/\r
IN UINT8 EndPoint,\r
IN UINTN DataLen,\r
IN UINTN Interval,\r
- IN VOID *Mapping,\r
IN UINT8 *Data,\r
IN EFI_ASYNC_USB_TRANSFER_CALLBACK Callback,\r
IN VOID *Context,\r
AsyncReq->EndPoint = EndPoint;\r
AsyncReq->DataLen = DataLen;\r
AsyncReq->Interval = UhciConvertPollRate(Interval);\r
- AsyncReq->Mapping = Mapping;\r
AsyncReq->Data = Data;\r
AsyncReq->Callback = Callback;\r
AsyncReq->Context = Context;\r
}\r
\r
\r
-\r
/**\r
- Free an asynchronous request's resource such as memory\r
+ Free an asynchronous request's resource such as memory.\r
\r
- @param Uhc The UHCI device\r
- @param AsyncReq The asynchronous request to free\r
-\r
- @return None\r
+ @param Uhc The UHCI device.\r
+ @param AsyncReq The asynchronous request to free.\r
\r
**/\r
-STATIC\r
VOID\r
UhciFreeAsyncReq (\r
IN USB_HC_DEV *Uhc,\r
UhciDestoryTds (Uhc, AsyncReq->FirstTd);\r
UsbHcFreeMem (Uhc->MemPool, AsyncReq->QhSw, sizeof (UHCI_QH_SW));\r
\r
- if (AsyncReq->Mapping != NULL) {\r
- Uhc->PciIo->Unmap (Uhc->PciIo, AsyncReq->Mapping);\r
- }\r
-\r
if (AsyncReq->Data != NULL) {\r
- gBS->FreePool (AsyncReq->Data);\r
+ UsbHcFreeMem (Uhc->MemPool, AsyncReq->Data, AsyncReq->DataLen);\r
}\r
\r
gBS->FreePool (AsyncReq);\r
UHC's recycle list to wait for a while before release the memory.\r
Until then, hardware won't hold point to the request.\r
\r
- @param Uhc The UHCI device\r
- @param AsyncReq The asynchronous request to free\r
+ @param Uhc The UHCI device.\r
+ @param AsyncReq The asynchronous request to free.\r
@param FreeNow If TRUE, free the resource immediately, otherwise\r
add the request to recycle wait list.\r
\r
- @return None\r
-\r
**/\r
-STATIC\r
VOID\r
UhciUnlinkAsyncReq (\r
IN USB_HC_DEV *Uhc,\r
ASSERT ((Uhc != NULL) && (AsyncReq != NULL));\r
\r
RemoveEntryList (&(AsyncReq->Link));\r
- UhciUnlinkQhFromFrameList (Uhc->FrameBase, AsyncReq->QhSw);\r
+ UhciUnlinkQhFromFrameList (Uhc, AsyncReq->QhSw);\r
\r
if (FreeNow) {\r
UhciFreeAsyncReq (Uhc, AsyncReq);\r
\r
\r
/**\r
- Delete Async Interrupt QH and TDs\r
+ Delete Async Interrupt QH and TDs.\r
\r
- @param Uhc The UHCI device\r
- @param DevAddr Device Address\r
- @param EndPoint EndPoint Address\r
- @param Toggle The next data toggle to use\r
+ @param Uhc The UHCI device.\r
+ @param DevAddr Device Address.\r
+ @param EndPoint EndPoint Address.\r
+ @param Toggle The next data toggle to use.\r
\r
- @retval EFI_SUCCESS The request is deleted\r
- @retval EFI_INVALID_PARAMETER Paremeter is error\r
- @retval EFI_NOT_FOUND The asynchronous isn't found\r
+ @retval EFI_SUCCESS The request is deleted.\r
+ @retval EFI_INVALID_PARAMETER Paremeter is error.\r
+ @retval EFI_NOT_FOUND The asynchronous isn't found.\r
\r
**/\r
EFI_STATUS\r
existing for at least 50ms, far enough for the hardware\r
to clear its cache.\r
\r
- @param Uhc The UHCI device\r
-\r
- @return None\r
+ @param Uhc The UHCI device.\r
\r
**/\r
-STATIC\r
VOID\r
UhciRecycleAsyncReq (\r
IN USB_HC_DEV *Uhc\r
/**\r
Release all the asynchronous transfers on the lsit.\r
\r
- @param Uhc The UHCI device\r
-\r
- @return VOID\r
+ @param Uhc The UHCI device.\r
\r
**/\r
VOID\r
\r
\r
/**\r
- Interrupt transfer periodic check handler\r
-\r
- @param Event The event of the time\r
- @param Context Context of the event, pointer to USB_HC_DEV\r
+ Interrupt transfer periodic check handler.\r
\r
- @return VOID\r
+ @param Event The event of the time.\r
+ @param Context Context of the event, pointer to USB_HC_DEV.\r
\r
**/\r
VOID\r
+EFIAPI\r
UhciMonitorAsyncReqList (\r
IN EFI_EVENT Event,\r
IN VOID *Context\r
\r
//\r
// Copy the data to temporary buffer if there are some\r
- // data transferred. We may have zero-length packet\r
+ // data transferred. We may have zero-length packet.\r
+ // Make sure the data received from HW is no more than expected.\r
//\r
Data = NULL;\r
\r
- if (QhResult.Complete != 0) {\r
+ if ((QhResult.Complete != 0) && (QhResult.Complete <= AsyncReq->DataLen)) {\r
Data = AllocatePool (QhResult.Complete);\r
\r
if (Data == NULL) {\r
CopyMem (Data, AsyncReq->FirstTd->Data, QhResult.Complete);\r
}\r
\r
- UhciUpdateAsyncReq (AsyncReq, QhResult.Result, QhResult.NextToggle);\r
+ UhciUpdateAsyncReq (Uhc, AsyncReq, QhResult.Result, QhResult.NextToggle);\r
\r
//\r
// Now, either transfer is SUCCESS or met errors since\r