Global variables have been moved backward ahead of functions.

[mirror_edk2.git] / MdeModulePkg / Core / Pei / Security / Security.c

diff --git a/MdeModulePkg/Core/Pei/Security/Security.c b/MdeModulePkg/Core/Pei/Security/Security.c
index cf3344760208164c6420a5379e22556058d2e6be..12924bf720e37bd7ceef20a65fa0cbf26d46fb5e 100644 (file)
--- a/MdeModulePkg/Core/Pei/Security/Security.c
+++ b/MdeModulePkg/Core/Pei/Security/Security.c
@@ -12,40 +12,20 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 \r
 **/\r
 \r
-#include <PeiMain.h>\r
+#include "PeiMain.h"\r
 \r
-/**\r
-\r
-  Provide a callback for when the security PPI is installed.\r
-\r
-  @param PeiServices     - The PEI core services table.\r
-  @param NotifyDescriptor - The descriptor for the notification event.\r
-  @param Ppi             - Pointer to the PPI in question.\r
-\r
-  @return Always success\r
 \r
-**/\r
-EFI_STATUS\r
-EFIAPI\r
-SecurityPpiNotifyCallback (\r
-  IN EFI_PEI_SERVICES           **PeiServices,\r
-  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,\r
-  IN VOID                       *Ppi\r
-  );\r
-\r
-STATIC EFI_PEI_NOTIFY_DESCRIPTOR mNotifyList = {\r
+EFI_PEI_NOTIFY_DESCRIPTOR mNotifyList = {\r
    EFI_PEI_PPI_DESCRIPTOR_NOTIFY_DISPATCH | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST,\r
    &gEfiPeiSecurity2PpiGuid,\r
    SecurityPpiNotifyCallback\r
 };\r
 \r
 /**\r
-\r
   Initialize the security services.\r
 \r
-\r
-  @param PeiServices     - The PEI core services table.\r
-  @param OldCoreData     - Pointer to the old core data.\r
+  @param PeiServices     An indirect pointer to the EFI_PEI_SERVICES table published by the PEI Foundation.\r
+  @param OldCoreData     Pointer to the old core data.\r
                          NULL if being run in non-permament memory mode.\r
 \r
 **/\r
@@ -64,10 +44,11 @@ InitializeSecurityServices (
 /**\r
 \r
   Provide a callback for when the security PPI is installed.\r
-\r
-  @param PeiServices     - The PEI core services table.\r
-  @param NotifyDescriptor - The descriptor for the notification event.\r
-  @param Ppi             - Pointer to the PPI in question.\r
+  This routine will cache installed security PPI into PeiCore's private data.\r
+  \r
+  @param PeiServices        An indirect pointer to the EFI_PEI_SERVICES table published by the PEI Foundation.\r
+  @param NotifyDescriptor   The descriptor for the notification event.\r
+  @param Ppi                Pointer to the PPI in question.\r
 \r
   @return Always success\r
 \r
@@ -107,7 +88,7 @@ SecurityPpiNotifyCallback (
 \r
   @retval EFI_SUCCESS              Image is OK\r
   @retval EFI_SECURITY_VIOLATION   Image is illegal\r
-\r
+  @retval EFI_NOT_FOUND            If security PPI is not installed.\r
 **/\r
 EFI_STATUS\r
 VerifyPeim (\r
@@ -150,10 +131,9 @@ VerifyPeim (
 /**\r
   Verify a Firmware volume.\r
 \r
-  @param CurrentFvAddress - Pointer to the current Firmware Volume under consideration\r
+  @param CurrentFvAddress   Pointer to the current Firmware Volume under consideration\r
 \r
-  @retval EFI_SUCCESS             - Firmware Volume is legal\r
-  @retval EFI_SECURITY_VIOLATION  - Firmware Volume fails integrity test\r
+  @retval EFI_SUCCESS       Firmware Volume is legal\r
 \r
 **/\r
 EFI_STATUS\r