MdeModulePkg/UdfDxe: ASSERT for false positives of NULL ptr deref

[mirror_edk2.git] / MdeModulePkg / Universal / Disk / UdfDxe / File.c

diff --git a/MdeModulePkg/Universal/Disk/UdfDxe/File.c b/MdeModulePkg/Universal/Disk/UdfDxe/File.c
index 6f07bf2066dced6e3836ecfa659b3e984c71f063..2249f4ea0e8e566f3fc67d8a81d8985bb3d4fc4b 100644 (file)
--- a/MdeModulePkg/Universal/Disk/UdfDxe/File.c
+++ b/MdeModulePkg/Universal/Disk/UdfDxe/File.c
@@ -408,6 +408,15 @@ UdfRead (
 \r
         goto Done;\r
       }\r
+      //\r
+      // After calling function ReadDirectoryEntry(), if 'NewFileIdentifierDesc'\r
+      // is NULL, then the 'Status' must be EFI_OUT_OF_RESOURCES. Hence, if the\r
+      // code reaches here, 'NewFileIdentifierDesc' must be not NULL.\r
+      //\r
+      // The ASSERT here is for addressing a false positive NULL pointer\r
+      // dereference issue raised from static analysis.\r
+      //\r
+      ASSERT (NewFileIdentifierDesc != NULL);\r
 \r
       if (!IS_FID_PARENT_FILE (NewFileIdentifierDesc)) {\r
         break;\r