MdeModulePkg/Udf: Refine function description comments

[mirror_edk2.git] / MdeModulePkg / Universal / Disk / UdfDxe / File.c

diff --git a/MdeModulePkg/Universal/Disk/UdfDxe/File.c b/MdeModulePkg/Universal/Disk/UdfDxe/File.c
index 8b9339567f8e3070df04390a2940c05fa2a6f0cc..625f2c5637d4b2c974f947fb42b1e4b07feb2dde 100644 (file)
--- a/MdeModulePkg/Universal/Disk/UdfDxe/File.c
+++ b/MdeModulePkg/Universal/Disk/UdfDxe/File.c
@@ -176,11 +176,12 @@ UdfOpen (
   EFI_STATUS                  Status;\r
   PRIVATE_UDF_FILE_DATA       *PrivFileData;\r
   PRIVATE_UDF_SIMPLE_FS_DATA  *PrivFsData;\r
-  CHAR16                      FilePath[UDF_PATH_LENGTH] = { 0 };\r
+  CHAR16                      FilePath[UDF_PATH_LENGTH];\r
   UDF_FILE_INFO               File;\r
   PRIVATE_UDF_FILE_DATA       *NewPrivFileData;\r
   CHAR16                      *TempFileName;\r
 \r
+  ZeroMem (FilePath, sizeof FilePath);\r
   OldTpl = gBS->RaiseTPL (TPL_CALLBACK);\r
 \r
   if (This == NULL || NewHandle == NULL || FileName == NULL) {\r
@@ -324,10 +325,11 @@ UdfRead (
   UDF_FILE_INFO                   FoundFile;\r
   UDF_FILE_IDENTIFIER_DESCRIPTOR  *NewFileIdentifierDesc;\r
   VOID                            *NewFileEntryData;\r
-  CHAR16                          FileName[UDF_FILENAME_LENGTH] = { 0 };\r
+  CHAR16                          FileName[UDF_FILENAME_LENGTH];\r
   UINT64                          FileSize;\r
   UINT64                          BufferSizeUint64;\r
 \r
+  ZeroMem (FileName, sizeof FileName);\r
   OldTpl = gBS->RaiseTPL (TPL_CALLBACK);\r
 \r
   if (This == NULL || BufferSize == NULL || (*BufferSize != 0 &&\r
@@ -425,6 +427,7 @@ UdfRead (
     if (EFI_ERROR (Status)) {\r
       goto Error_Find_Fe;\r
     }\r
+    ASSERT (NewFileEntryData != NULL);\r
 \r
     if (IS_FE_SYMLINK (NewFileEntryData)) {\r
       Status = ResolveSymlink (\r
@@ -690,7 +693,8 @@ UdfSetPosition (
 \r
   PrivFileData = PRIVATE_UDF_FILE_DATA_FROM_THIS (This);\r
 \r
-  FileIdentifierDesc = PrivFileData->File.FileIdentifierDesc;\r
+  FileIdentifierDesc = _FILE (PrivFileData)->FileIdentifierDesc;\r
+  ASSERT (FileIdentifierDesc != NULL);\r
   if (IS_FID_DIRECTORY_FILE (FileIdentifierDesc)) {\r
     //\r
     // If the file handle is a directory, the _only_ position that may be set is\r
@@ -802,7 +806,7 @@ UdfGetInfo (
       }\r
 \r
       if (Index < 128) {\r
-        *String |= *(UINT8 *)(OstaCompressed + Index);\r
+        *String |= (CHAR16)(*(UINT8 *)(OstaCompressed + Index));\r
       }\r
 \r
       //\r
@@ -857,7 +861,7 @@ UdfGetInfo (
 /**\r
   Set information about a file.\r
 \r
-  @param  File            Protocol instance pointer.\r
+  @param  This            Protocol instance pointer.\r
   @param  InformationType Type of information in Buffer.\r
   @param  BufferSize      Size of buffer.\r
   @param  Buffer          The data to write.\r