Clean up the private GUID definition in module Level.

[mirror_edk2.git] / MdeModulePkg / Universal / Network / IScsiDxe / IScsiCHAP.h

diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiCHAP.h b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiCHAP.h
index 2889167b32b19f67a40a41ce3fee4d187ffcc220..59d514fe188bb824b16564086face23320656363 100644 (file)
--- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiCHAP.h
+++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiCHAP.h
@@ -1,7 +1,8 @@
-/*++\r
+/** @file\r
+  The header file of CHAP configuration.\r
 \r
-Copyright (c) 2004 - 2007, Intel Corporation\r
-All rights reserved. This program and the accompanying materials\r
+Copyright (c) 2004 - 2011, Intel Corporation. All rights reserved.<BR>\r
+This program and the accompanying materials\r
 are licensed and made available under the terms and conditions of the BSD License\r
 which accompanies this distribution.  The full text of the license may be found at\r
 http://opensource.org/licenses/bsd-license.php\r
@@ -9,24 +10,11 @@ http://opensource.org/licenses/bsd-license.php
 THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,\r
 WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.\r
 \r
-Module Name:\r
-\r
-  IScsiCHAP.h\r
-\r
-Abstract:\r
-\r
---*/\r
+**/\r
 \r
 #ifndef _ISCSI_CHAP_H_\r
 #define _ISCSI_CHAP_H_\r
 \r
-#define ISCSI_CHAP_AUTH_INFO_GUID \\r
-  { \\r
-    0x786ec0ac, 0x65ae, 0x4d1b, {0xb1, 0x37, 0xd, 0x11, 0xa, 0x48, 0x37, 0x97} \\r
-  }\r
-\r
-extern EFI_GUID mIScsiCHAPAuthInfoGuid;\r
-\r
 #define ISCSI_AUTH_METHOD_CHAP    "CHAP"\r
 \r
 #define ISCSI_KEY_CHAP_ALGORITHM  "CHAP_A"\r
@@ -38,30 +26,32 @@ extern EFI_GUID mIScsiCHAPAuthInfoGuid;
 #define ISCSI_CHAP_ALGORITHM_MD5  5\r
 \r
 #define ISCSI_CHAP_AUTH_MAX_LEN   1024\r
-#define ISCSI_CHAP_RSP_LEN        16  // == MD5_HASHSIZE\r
-typedef enum {\r
-  ISCSI_CHAP_INITIAL,\r
-  ISCSI_CHAP_STEP_ONE,\r
-  ISCSI_CHAP_STEP_TWO,\r
-  ISCSI_CHAP_STEP_THREE,\r
-  ISCSI_CHAP_STEP_FOUR\r
-} ISCSI_CHAP_STEP;\r
+///\r
+/// MD5_HASHSIZE\r
+///\r
+#define ISCSI_CHAP_RSP_LEN        16  \r
+\r
+#define ISCSI_CHAP_INITIAL        0 \r
+#define ISCSI_CHAP_STEP_ONE       1\r
+#define ISCSI_CHAP_STEP_TWO       2\r
+#define ISCSI_CHAP_STEP_THREE     3\r
+#define ISCSI_CHAP_STEP_FOUR      4\r
 \r
 #pragma pack(1)\r
 \r
 typedef struct _ISCSI_CHAP_AUTH_CONFIG_NVDATA {\r
   UINT8 CHAPType;\r
   CHAR8 CHAPName[ISCSI_CHAP_NAME_MAX_LEN];\r
-  CHAR8 CHAPSecret[ISCSI_CHAP_SECRET_MAX_LEN];\r
+  CHAR8 CHAPSecret[ISCSI_CHAP_SECRET_STORAGE];\r
   CHAR8 ReverseCHAPName[ISCSI_CHAP_NAME_MAX_LEN];\r
-  CHAR8 ReverseCHAPSecret[ISCSI_CHAP_SECRET_MAX_LEN];\r
+  CHAR8 ReverseCHAPSecret[ISCSI_CHAP_SECRET_STORAGE];\r
 } ISCSI_CHAP_AUTH_CONFIG_NVDATA;\r
 \r
 #pragma pack()\r
 \r
-//\r
-// ISCSI CHAP Authentication Data\r
-//\r
+///\r
+/// ISCSI CHAP Authentication Data\r
+///\r
 typedef struct _ISCSI_CHAP_AUTH_DATA {\r
   ISCSI_CHAP_AUTH_CONFIG_NVDATA AuthConfig;\r
   UINT32                        InIdentifier;\r
@@ -80,16 +70,37 @@ typedef struct _ISCSI_CHAP_AUTH_DATA {
   UINT32                        OutChallengeLength;\r
 } ISCSI_CHAP_AUTH_DATA;\r
 \r
+/**\r
+  This function checks the received iSCSI Login Response during the security\r
+  negotiation stage.\r
+  \r
+  @param[in] Conn             The iSCSI connection.\r
+\r
+  @retval EFI_SUCCESS          The Login Response passed the CHAP validation.\r
+  @retval EFI_OUT_OF_RESOURCES Failed to allocate memory.\r
+  @retval EFI_PROTOCOL_ERROR   Some kind of protocol error happend.\r
+  @retval Others               Other errors as indicated.\r
+**/\r
 EFI_STATUS\r
 IScsiCHAPOnRspReceived (\r
-  IN ISCSI_CONNECTION  *Conn,\r
-  IN BOOLEAN           Transit\r
+  IN ISCSI_CONNECTION  *Conn\r
   );\r
-\r
+/**\r
+  This function fills the CHAP authentication information into the login PDU\r
+  during the security negotiation stage in the iSCSI connection login.\r
+\r
+  @param[in]       Conn        The iSCSI connection.\r
+  @param[in, out]  Pdu         The PDU to send out.\r
+\r
+  @retval EFI_SUCCESS          All check passed and the phase-related CHAP\r
+                               authentication info is filled into the iSCSI PDU.\r
+  @retval EFI_OUT_OF_RESOURCES Failed to allocate memory.\r
+  @retval EFI_PROTOCOL_ERROR   Some kind of protocol error happend.\r
+**/\r
 EFI_STATUS\r
 IScsiCHAPToSendReq (\r
-  IN ISCSI_CONNECTION  *Conn,\r
-  IN NET_BUF           *Pdu\r
+  IN      ISCSI_CONNECTION  *Conn,\r
+  IN OUT  NET_BUF           *Pdu\r
   );\r
 \r
 #endif\r