it was root caused to be Spec issue instead of code issue. It should be Action inste...

[mirror_edk2.git] / MdeModulePkg / Universal / Network / IScsiDxe / IScsiConfig.c

diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c
index b0976731668cfd4bd8a3fb67fd2e9e14f4da7708..6d143ffa0a6179ed99bbee054e42eab56d6db789 100644 (file)
--- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c
+++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c
@@ -58,7 +58,7 @@ PopUpInvalidNotify (
   Update the list of iSCSI devices the iSCSI driver is controlling.\r
   \r
   @retval EFI_SUCCESS            The callback successfully handled the action.\r
-  @retval Others                 Some unexpected errors happened.   \r
+  @retval Others                 Other errors as indicated.   \r
 **/\r
 EFI_STATUS\r
 IScsiUpdateDeviceList (\r
@@ -226,13 +226,13 @@ IScsiGetConfigFormEntryByIndex (
 /**\r
   Convert the iSCSI configuration data into the IFR data.\r
 \r
-  @param[in]  ConfigFormEntry The iSCSI configuration form entry.\r
-  @param[in]  IfrNvData       The IFR nv data.\r
+  @param[in]   ConfigFormEntry The iSCSI configuration form entry.\r
+  @param[out]  IfrNvData       The IFR nv data.\r
 **/\r
 VOID\r
 IScsiConvertDeviceConfigDataToIfrNvData (\r
-  IN ISCSI_CONFIG_FORM_ENTRY  *ConfigFormEntry,\r
-  IN ISCSI_CONFIG_IFR_NVDATA  *IfrNvData\r
+  IN ISCSI_CONFIG_FORM_ENTRY      *ConfigFormEntry,\r
+  OUT ISCSI_CONFIG_IFR_NVDATA     *IfrNvData\r
   )\r
 {\r
   ISCSI_SESSION_CONFIG_NVDATA   *SessionConfigData;\r
@@ -460,7 +460,7 @@ IScsiFormRouteConfig (
   @retval EFI_UNSUPPORTED        The specified Action is not supported by the\r
                                  callback.Currently not implemented.\r
   @retval EFI_INVALID_PARAMETERS Passing in wrong parameter. \r
-  @retval Others                 Some unexpected error happened. \r
+  @retval Others                 Other errors as indicated. \r
 **/\r
 EFI_STATUS\r
 EFIAPI\r
@@ -737,7 +737,7 @@ IScsiFormCallback (
 \r
   @retval EFI_SUCCESS             The iSCSI configuration form is updated.\r
   @retval EFI_OUT_OF_RESOURCES    Failed to allocate memory.\r
-  @retval Others                  Some unexpected errors happened.\r
+  @retval Others                  Other errors as indicated.\r
 **/\r
 EFI_STATUS\r
 IScsiConfigUpdateForm (\r
@@ -891,11 +891,11 @@ IScsiConfigUpdateForm (
 \r
   @retval EFI_SUCCESS              The iSCSI configuration form is initialized.\r
   @retval EFI_OUT_OF_RESOURCES     Failed to allocate memory.\r
-  @retval Others                   Some unexpected error happened.\r
+  @retval Others                   Other errors as indicated.\r
 **/\r
 EFI_STATUS\r
 IScsiConfigFormInit (\r
-  IN EFI_HANDLE  DriverBindingHandle\r
+  VOID\r
   )\r
 {\r
   EFI_STATUS                  Status;\r