add security check.

[mirror_edk2.git] / MdeModulePkg / Universal / Network / Ip4Dxe / Ip4Impl.c

diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c
index bb9b99e9fc5267305b82f853f6d5c45269a43d58..84a39656f6a10e3e92dc4d37edc0e13dec4f8170 100644 (file)
--- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c
+++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c
@@ -1,6 +1,6 @@
 /** @file\r
 \r
-Copyright (c) 2005 - 2007, Intel Corporation.<BR>\r
+Copyright (c) 2005 - 2009, Intel Corporation.<BR>\r
 All rights reserved. This program and the accompanying materials\r
 are licensed and made available under the terms and conditions of the BSD License\r
 which accompanies this distribution.  The full text of the license may be found at\r
@@ -35,8 +35,8 @@ EFI_STATUS
 EFIAPI\r
 EfiIp4GetModeData (\r
   IN  CONST EFI_IP4_PROTOCOL                *This,\r
-  OUT       EFI_IP4_MODE_DATA               *Ip4ModeData,    OPTIONAL\r
-  OUT       EFI_MANAGED_NETWORK_CONFIG_DATA *MnpConfigData,  OPTIONAL\r
+  OUT       EFI_IP4_MODE_DATA               *Ip4ModeData     OPTIONAL,\r
+  OUT       EFI_MANAGED_NETWORK_CONFIG_DATA *MnpConfigData   OPTIONAL,\r
   OUT       EFI_SIMPLE_NETWORK_MODE         *SnpModeData     OPTIONAL\r
   );\r
   \r
@@ -366,8 +366,8 @@ EFI_STATUS
 EFIAPI\r
 EfiIp4GetModeData (\r
   IN  CONST EFI_IP4_PROTOCOL                *This,\r
-  OUT       EFI_IP4_MODE_DATA               *Ip4ModeData,    OPTIONAL\r
-  OUT       EFI_MANAGED_NETWORK_CONFIG_DATA *MnpConfigData,  OPTIONAL\r
+  OUT       EFI_IP4_MODE_DATA               *Ip4ModeData     OPTIONAL,\r
+  OUT       EFI_MANAGED_NETWORK_CONFIG_DATA *MnpConfigData   OPTIONAL,\r
   OUT       EFI_SIMPLE_NETWORK_MODE         *SnpModeData     OPTIONAL\r
   )\r
 {\r
@@ -1314,6 +1314,10 @@ Ip4Groups (
   // host byte order\r
   //\r
   if (JoinFlag) {\r
+    //  \r
+    // When JoinFlag is TRUE, GroupAddress shouldn't be NULL.\r
+    //\r
+    ASSERT (GroupAddress != NULL);\r
     CopyMem (&Group, GroupAddress, sizeof (IP4_ADDR));\r
 \r
     for (Index = 0; Index < IpInstance->GroupCount; Index++) {\r