Add missing ASSERT()s in PeiPcdLib

[mirror_edk2.git] / MdePkg / Library / PeiPcdLib / PeiPcdLib.c

diff --git a/MdePkg/Library/PeiPcdLib/PeiPcdLib.c b/MdePkg/Library/PeiPcdLib/PeiPcdLib.c
index 4018e44f702b45514164bbbeb195bcf6dc5711f8..b67d5f4ef21e458806d0a9a1355677a6f3730ebd 100644 (file)
--- a/MdePkg/Library/PeiPcdLib/PeiPcdLib.c
+++ b/MdePkg/Library/PeiPcdLib/PeiPcdLib.c
@@ -68,6 +68,8 @@ LibPcdSetSku (
   )\r
 {\r
 \r
+  ASSERT (SkuId < 0x100);\r
+\r
   GetPcdPpiPtr()->SetSku (SkuId);;\r
 \r
   return SkuId;\r
@@ -256,6 +258,8 @@ LibPcdGetEx8 (
 {\r
   PCD_PPI * PcdPpi;\r
 \r
+  ASSERT (Guid != NULL);\r
+\r
   PcdPpi = GetPcdPpiPtr ();\r
 \r
   return PcdPpi->Get8Ex (Guid, TokenNumber);\r
@@ -283,6 +287,8 @@ LibPcdGetEx16 (
 {\r
   PCD_PPI * PcdPpi;\r
 \r
+  ASSERT (Guid != NULL);\r
+\r
   PcdPpi = GetPcdPpiPtr ();\r
 \r
   return PcdPpi->Get16Ex (Guid, TokenNumber);\r
@@ -310,6 +316,8 @@ LibPcdGetEx32 (
 {\r
   PCD_PPI * PcdPpi;\r
 \r
+  ASSERT (Guid != NULL);\r
+\r
   PcdPpi = GetPcdPpiPtr ();\r
 \r
   return PcdPpi->Get32Ex (Guid, TokenNumber);\r
@@ -338,6 +346,8 @@ LibPcdGetEx64 (
 {\r
   PCD_PPI * PcdPpi;\r
 \r
+  ASSERT (Guid != NULL);\r
+\r
   PcdPpi = GetPcdPpiPtr ();\r
 \r
   return PcdPpi->Get64Ex (Guid, TokenNumber);\r
@@ -365,6 +375,8 @@ LibPcdGetExPtr (
 {\r
   PCD_PPI * PcdPpi;\r
 \r
+  ASSERT (Guid != NULL);\r
+\r
   PcdPpi = GetPcdPpiPtr ();\r
 \r
   return PcdPpi->GetPtrEx (Guid, TokenNumber);\r
@@ -392,6 +404,8 @@ LibPcdGetExBool (
 {\r
   PCD_PPI * PcdPpi;\r
 \r
+  ASSERT (Guid != NULL);\r
+\r
   PcdPpi = GetPcdPpiPtr ();\r
 \r
   return PcdPpi->GetBoolEx (Guid, TokenNumber);\r
@@ -419,6 +433,8 @@ LibPcdGetExSize (
 {\r
   PCD_PPI * PcdPpi;\r
 \r
+  ASSERT (Guid != NULL);\r
+\r
   PcdPpi = GetPcdPpiPtr ();\r
 \r
   return PcdPpi->GetSizeEx (Guid, TokenNumber);\r
@@ -448,7 +464,6 @@ LibPcdSet8 (
 \r
   PcdPpi = GetPcdPpiPtr ();\r
 \r
-\r
   Status = PcdPpi->Set8 (TokenNumber, Value);\r
 \r
   ASSERT_EFI_ERROR (Status);\r
@@ -480,7 +495,6 @@ LibPcdSet16 (
 \r
   PcdPpi = GetPcdPpiPtr ();\r
 \r
-\r
   Status = PcdPpi->Set16 (TokenNumber, Value);\r
 \r
   ASSERT_EFI_ERROR (Status);\r
@@ -543,7 +557,6 @@ LibPcdSet64 (
 \r
   PcdPpi = GetPcdPpiPtr ();\r
 \r
-\r
   Status = PcdPpi->Set64 (TokenNumber, Value);\r
 \r
   ASSERT_EFI_ERROR (Status);\r
@@ -584,7 +597,8 @@ LibPcdSetPtr (
 {\r
   EFI_STATUS Status;\r
   PCD_PPI    *PcdPpi;\r
-  UINTN      Size;\r
+\r
+  ASSERT (SizeOfBuffer != NULL);\r
 \r
   if (*SizeOfBuffer > 0) {\r
     ASSERT (Buffer != NULL);\r
@@ -592,17 +606,12 @@ LibPcdSetPtr (
 \r
   PcdPpi = GetPcdPpiPtr ();\r
   \r
-  Size = LibPcdGetSize (TokenNumber);\r
-  \r
-  if (*SizeOfBuffer > Size) {\r
-    *SizeOfBuffer = Size;\r
+  Status = PcdPpi->SetPtr (TokenNumber, SizeOfBuffer, Buffer);\r
+\r
+  if (EFI_ERROR (Status)) {\r
     return NULL;\r
   }\r
 \r
-  Status = PcdPpi->SetPtr (TokenNumber, *SizeOfBuffer, Buffer);\r
-\r
-  ASSERT_EFI_ERROR (Status);\r
-\r
   return Buffer;\r
 }\r
 \r
@@ -630,7 +639,6 @@ LibPcdSetBool (
 \r
   PcdPpi = GetPcdPpiPtr ();\r
 \r
-\r
   Status = PcdPpi->SetBool (TokenNumber, Value);\r
 \r
   ASSERT_EFI_ERROR (Status);\r
@@ -666,6 +674,7 @@ LibPcdSetEx8 (
 \r
   PcdPpi = GetPcdPpiPtr ();\r
 \r
+  ASSERT (Guid != NULL);\r
 \r
   Status = PcdPpi->Set8Ex (Guid, TokenNumber, Value);\r
 \r
@@ -702,7 +711,7 @@ LibPcdSetEx16 (
 \r
   PcdPpi = GetPcdPpiPtr ();\r
 \r
-\r
+  ASSERT (Guid != NULL);\r
   Status = PcdPpi->Set16Ex (Guid, TokenNumber, Value);\r
 \r
   ASSERT_EFI_ERROR (Status);\r
@@ -735,7 +744,7 @@ LibPcdSetEx32 (
 {\r
   EFI_STATUS Status;\r
   PCD_PPI * PcdPpi;\r
-\r
+  ASSERT (Guid != NULL);\r
   PcdPpi = GetPcdPpiPtr ();\r
 \r
 \r
@@ -771,7 +780,7 @@ LibPcdSetEx64 (
 {\r
   EFI_STATUS Status;\r
   PCD_PPI * PcdPpi;\r
-\r
+  ASSERT (Guid != NULL);\r
   PcdPpi = GetPcdPpiPtr ();\r
 \r
 \r
@@ -813,24 +822,19 @@ LibPcdSetExPtr (
 {\r
   EFI_STATUS      Status;\r
   PCD_PPI         *PcdPpi;\r
-  UINTN           Size;\r
-\r
+ ASSERT (SizeOfBuffer != NULL);\r
   if (*SizeOfBuffer > 0) {\r
     ASSERT (Buffer != NULL);\r
   }\r
-\r
+  ASSERT (Guid != NULL);\r
   PcdPpi = GetPcdPpiPtr ();\r
 \r
-  Size = LibPcdGetExSize (Guid, TokenNumber);\r
-  if (*SizeOfBuffer > Size) {\r
-    *SizeOfBuffer = Size;\r
+  Status = PcdPpi->SetPtrEx (Guid, TokenNumber, SizeOfBuffer, Buffer);\r
+\r
+  if (EFI_ERROR (Status)) {\r
     return NULL;\r
   }\r
 \r
-  Status = PcdPpi->SetPtrEx (Guid, TokenNumber, *SizeOfBuffer, Buffer);\r
-\r
-  ASSERT_EFI_ERROR (Status);\r
-\r
   return Buffer;\r
 }\r
 \r
@@ -862,7 +866,7 @@ LibPcdSetExBool (
 \r
   PcdPpi = GetPcdPpiPtr ();\r
 \r
-\r
+  ASSERT (Guid != NULL);\r
   Status = PcdPpi->SetBoolEx (Guid, TokenNumber, Value);\r
 \r
   ASSERT_EFI_ERROR (Status);\r
@@ -999,7 +1003,7 @@ LibPcdGetNextToken (
   @retval CONST GUID *  The next valid token namespace.\r
 \r
 **/\r
-CONST GUID*           \r
+GUID *           \r
 EFIAPI\r
 LibPcdGetNextTokenSpace (\r
   IN CONST GUID  *Guid\r
@@ -1015,6 +1019,55 @@ LibPcdGetNextTokenSpace (
 \r
   ASSERT_EFI_ERROR (Status);\r
 \r
-  return Guid;\r
+  return (GUID *)Guid;\r
 }\r
 \r
+\r
+\r
+/**\r
+  Sets the PCD entry specified by PatchVariable to the value specified by Buffer \r
+  and SizeOfValue.  Buffer is returned.  If SizeOfValue is greater than \r
+  MaximumDatumSize, then set SizeOfValue to MaximumDatumSize and return \r
+  NULL to indicate that the set operation was not actually performed.  \r
+  If SizeOfValue is set to MAX_ADDRESS, then SizeOfValue must be set to \r
+  MaximumDatumSize and NULL must be returned.\r
+  \r
+  If PatchVariable is NULL, then ASSERT().\r
+  If SizeOfValue is NULL, then ASSERT().\r
+  If SizeOfValue > 0 and Buffer is NULL, then ASSERT().\r
+\r
+  @param[in] PatchVariable      A pointer to the global variable in a module that is \r
+                                the target of the set operation.\r
+  @param[in] MaximumDatumSize   The maximum size allowed for the PCD entry specified by PatchVariable.\r
+  @param[in, out] SizeOfBuffer  A pointer to the size, in bytes, of Buffer.\r
+  @param[in] Buffer             A pointer to the buffer to used to set the target variable.\r
+\r
+**/\r
+VOID *\r
+EFIAPI\r
+LibPatchPcdSetPtr (\r
+  IN        VOID        *PatchVariable,\r
+  IN        UINTN       MaximumDatumSize,\r
+  IN OUT    UINTN       *SizeOfBuffer,\r
+  IN CONST  VOID        *Buffer\r
+  )\r
+{\r
+  ASSERT (PatchVariable != NULL);\r
+  ASSERT (SizeOfBuffer  != NULL);\r
+  \r
+  if (*SizeOfBuffer > 0) {\r
+    ASSERT (Buffer != NULL);\r
+  }\r
+\r
+  if ((*SizeOfBuffer > MaximumDatumSize) ||\r
+      (*SizeOfBuffer == MAX_ADDRESS)) {\r
+    *SizeOfBuffer = MaximumDatumSize;\r
+    return NULL;\r
+  }\r
+    \r
+  CopyMem (PatchVariable, Buffer, *SizeOfBuffer);\r
+  \r
+  return (VOID *) Buffer;\r
+}\r
+\r
+\r