]> git.proxmox.com Git - mirror_edk2.git/blobdiff - NetworkPkg/SnpDxe/Snp.c
NetworkPkg: Apply uncrustify changes
[mirror_edk2.git] / NetworkPkg / SnpDxe / Snp.c
index d0d086e5780a35579cb3e950f83bfb0d1ae3b906..95361c3cd3436c0b63c0ae2ea6c28961693e3b95 100644 (file)
@@ -19,13 +19,13 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 VOID\r
 EFIAPI\r
 SnpNotifyExitBootServices (\r
-  EFI_EVENT Event,\r
-  VOID      *Context\r
+  EFI_EVENT  Event,\r
+  VOID       *Context\r
   )\r
 {\r
-  SNP_DRIVER             *Snp;\r
+  SNP_DRIVER  *Snp;\r
 \r
-  Snp  = (SNP_DRIVER *)Context;\r
+  Snp = (SNP_DRIVER *)Context;\r
 \r
   //\r
   // Shutdown and stop UNDI driver\r
@@ -47,22 +47,21 @@ SnpNotifyExitBootServices (
 EFI_STATUS\r
 EFIAPI\r
 IssueHwUndiCommand (\r
-  UINT64 Cdb\r
+  UINT64  Cdb\r
   )\r
 {\r
   DEBUG ((DEBUG_ERROR, "\nIssueHwUndiCommand() - This should not be called!"));\r
 \r
   if (Cdb == 0) {\r
     return EFI_INVALID_PARAMETER;\r
-\r
   }\r
+\r
   //\r
   //  %%TBD - For now, nothing is done.\r
   //\r
   return EFI_UNSUPPORTED;\r
 }\r
 \r
-\r
 /**\r
   Compute 8-bit checksum of a buffer.\r
 \r
@@ -75,22 +74,22 @@ IssueHwUndiCommand (
 **/\r
 UINT8\r
 Calc8BitCksum (\r
-  VOID  *Buffer,\r
-  UINTN Length\r
+  VOID   *Buffer,\r
+  UINTN  Length\r
   )\r
 {\r
-  UINT8 *Ptr;\r
-  UINT8 Cksum;\r
+  UINT8  *Ptr;\r
+  UINT8  Cksum;\r
 \r
   Ptr   = Buffer;\r
   Cksum = 0;\r
 \r
-  if (Ptr == NULL || Length == 0) {\r
+  if ((Ptr == NULL) || (Length == 0)) {\r
     return 0;\r
   }\r
 \r
   while (Length-- != 0) {\r
-    Cksum = (UINT8) (Cksum + *Ptr++);\r
+    Cksum = (UINT8)(Cksum + *Ptr++);\r
   }\r
 \r
   return Cksum;\r
@@ -117,14 +116,14 @@ Calc8BitCksum (
 EFI_STATUS\r
 EFIAPI\r
 SimpleNetworkDriverSupported (\r
-  IN EFI_DRIVER_BINDING_PROTOCOL    *This,\r
-  IN EFI_HANDLE                     Controller,\r
-  IN EFI_DEVICE_PATH_PROTOCOL       *RemainingDevicePath\r
+  IN EFI_DRIVER_BINDING_PROTOCOL  *This,\r
+  IN EFI_HANDLE                   Controller,\r
+  IN EFI_DEVICE_PATH_PROTOCOL     *RemainingDevicePath\r
   )\r
 {\r
-  EFI_STATUS                                Status;\r
-  EFI_NETWORK_INTERFACE_IDENTIFIER_PROTOCOL *NiiProtocol;\r
-  PXE_UNDI                                  *Pxe;\r
+  EFI_STATUS                                 Status;\r
+  EFI_NETWORK_INTERFACE_IDENTIFIER_PROTOCOL  *NiiProtocol;\r
+  PXE_UNDI                                   *Pxe;\r
 \r
   Status = gBS->OpenProtocol (\r
                   Controller,\r
@@ -141,7 +140,7 @@ SimpleNetworkDriverSupported (
   Status = gBS->OpenProtocol (\r
                   Controller,\r
                   &gEfiNetworkInterfaceIdentifierProtocolGuid_31,\r
-                  (VOID **) &NiiProtocol,\r
+                  (VOID **)&NiiProtocol,\r
                   This->DriverBindingHandle,\r
                   Controller,\r
                   EFI_OPEN_PROTOCOL_BY_DRIVER\r
@@ -151,6 +150,7 @@ SimpleNetworkDriverSupported (
     if (Status == EFI_ALREADY_STARTED) {\r
       DEBUG ((DEBUG_INFO, "Support(): Already Started. on handle %p\n", Controller));\r
     }\r
+\r
     return Status;\r
   }\r
 \r
@@ -163,6 +163,7 @@ SimpleNetworkDriverSupported (
     Status = EFI_UNSUPPORTED;\r
     goto Done;\r
   }\r
+\r
   //\r
   // Check to see if !PXE structure is valid. Paragraph alignment of !PXE structure is required.\r
   //\r
@@ -172,7 +173,7 @@ SimpleNetworkDriverSupported (
     goto Done;\r
   }\r
 \r
-  Pxe = (PXE_UNDI *) (UINTN) (NiiProtocol->Id);\r
+  Pxe = (PXE_UNDI *)(UINTN)(NiiProtocol->Id);\r
 \r
   //\r
   //  Verify !PXE revisions.\r
@@ -190,16 +191,15 @@ SimpleNetworkDriverSupported (
   }\r
 \r
   if (Pxe->hw.MajorVer < PXE_ROMID_MAJORVER) {\r
-\r
     DEBUG ((DEBUG_NET, "\n!PXE.MajorVer is not supported.\n"));\r
     Status = EFI_UNSUPPORTED;\r
     goto Done;\r
-\r
-  } else if (Pxe->hw.MajorVer == PXE_ROMID_MAJORVER && Pxe->hw.MinorVer < PXE_ROMID_MINORVER) {\r
+  } else if ((Pxe->hw.MajorVer == PXE_ROMID_MAJORVER) && (Pxe->hw.MinorVer < PXE_ROMID_MINORVER)) {\r
     DEBUG ((DEBUG_NET, "\n!PXE.MinorVer is not supported."));\r
     Status = EFI_UNSUPPORTED;\r
     goto Done;\r
   }\r
+\r
   //\r
   // Do S/W UNDI specific checks.\r
   //\r
@@ -222,11 +222,11 @@ SimpleNetworkDriverSupported (
 \r
 Done:\r
   gBS->CloseProtocol (\r
-        Controller,\r
-        &gEfiNetworkInterfaceIdentifierProtocolGuid_31,\r
-        This->DriverBindingHandle,\r
-        Controller\r
-        );\r
+         Controller,\r
+         &gEfiNetworkInterfaceIdentifierProtocolGuid_31,\r
+         This->DriverBindingHandle,\r
+         Controller\r
+         );\r
 \r
   return Status;\r
 }\r
@@ -252,31 +252,31 @@ Done:
 EFI_STATUS\r
 EFIAPI\r
 SimpleNetworkDriverStart (\r
-  IN EFI_DRIVER_BINDING_PROTOCOL    *This,\r
-  IN EFI_HANDLE                     Controller,\r
-  IN EFI_DEVICE_PATH_PROTOCOL       *RemainingDevicePath\r
+  IN EFI_DRIVER_BINDING_PROTOCOL  *This,\r
+  IN EFI_HANDLE                   Controller,\r
+  IN EFI_DEVICE_PATH_PROTOCOL     *RemainingDevicePath\r
   )\r
 {\r
-  EFI_NETWORK_INTERFACE_IDENTIFIER_PROTOCOL *Nii;\r
-  EFI_DEVICE_PATH_PROTOCOL                  *NiiDevicePath;\r
-  EFI_STATUS                                Status;\r
-  PXE_UNDI                                  *Pxe;\r
-  SNP_DRIVER                                *Snp;\r
-  VOID                                      *Address;\r
-  EFI_HANDLE                                Handle;\r
-  UINT8                                     BarIndex;\r
-  PXE_STATFLAGS                             InitStatFlags;\r
-  EFI_PCI_IO_PROTOCOL                       *PciIo;\r
-  EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR         *BarDesc;\r
-  BOOLEAN                                   FoundIoBar;\r
-  BOOLEAN                                   FoundMemoryBar;\r
+  EFI_NETWORK_INTERFACE_IDENTIFIER_PROTOCOL  *Nii;\r
+  EFI_DEVICE_PATH_PROTOCOL                   *NiiDevicePath;\r
+  EFI_STATUS                                 Status;\r
+  PXE_UNDI                                   *Pxe;\r
+  SNP_DRIVER                                 *Snp;\r
+  VOID                                       *Address;\r
+  EFI_HANDLE                                 Handle;\r
+  UINT8                                      BarIndex;\r
+  PXE_STATFLAGS                              InitStatFlags;\r
+  EFI_PCI_IO_PROTOCOL                        *PciIo;\r
+  EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR          *BarDesc;\r
+  BOOLEAN                                    FoundIoBar;\r
+  BOOLEAN                                    FoundMemoryBar;\r
 \r
   DEBUG ((DEBUG_NET, "\nSnpNotifyNetworkInterfaceIdentifier()  "));\r
 \r
   Status = gBS->OpenProtocol (\r
                   Controller,\r
                   &gEfiDevicePathProtocolGuid,\r
-                  (VOID **) &NiiDevicePath,\r
+                  (VOID **)&NiiDevicePath,\r
                   This->DriverBindingHandle,\r
                   Controller,\r
                   EFI_OPEN_PROTOCOL_BY_DRIVER\r
@@ -299,7 +299,7 @@ SimpleNetworkDriverStart (
   Status = gBS->OpenProtocol (\r
                   Handle,\r
                   &gEfiPciIoProtocolGuid,\r
-                  (VOID **) &PciIo,\r
+                  (VOID **)&PciIo,\r
                   This->DriverBindingHandle,\r
                   Controller,\r
                   EFI_OPEN_PROTOCOL_GET_PROTOCOL\r
@@ -307,30 +307,31 @@ SimpleNetworkDriverStart (
   if (EFI_ERROR (Status)) {\r
     return Status;\r
   }\r
+\r
   //\r
   // Get the NII interface.\r
   //\r
   Status = gBS->OpenProtocol (\r
                   Controller,\r
                   &gEfiNetworkInterfaceIdentifierProtocolGuid_31,\r
-                  (VOID **) &Nii,\r
+                  (VOID **)&Nii,\r
                   This->DriverBindingHandle,\r
                   Controller,\r
                   EFI_OPEN_PROTOCOL_BY_DRIVER\r
                   );\r
   if (EFI_ERROR (Status)) {\r
     gBS->CloseProtocol (\r
-          Controller,\r
-          &gEfiDevicePathProtocolGuid,\r
-          This->DriverBindingHandle,\r
-          Controller\r
-          );\r
+           Controller,\r
+           &gEfiDevicePathProtocolGuid,\r
+           This->DriverBindingHandle,\r
+           Controller\r
+           );\r
     return Status;\r
   }\r
 \r
   DEBUG ((DEBUG_INFO, "Start(): UNDI3.1 found\n"));\r
 \r
-  Pxe = (PXE_UNDI *) (UINTN) (Nii->Id);\r
+  Pxe = (PXE_UNDI *)(UINTN)(Nii->Id);\r
 \r
   if (Calc8BitCksum (Pxe, Pxe->hw.Len) != 0) {\r
     DEBUG ((DEBUG_NET, "\n!PXE checksum is not correct.\n"));\r
@@ -351,6 +352,7 @@ SimpleNetworkDriverStart (
     DEBUG ((DEBUG_NET, "\nUNDI does not have promiscuous or broadcast support."));\r
     goto NiiError;\r
   }\r
+\r
   //\r
   // OK, we like this UNDI, and we know snp is not already there on this handle\r
   // Allocate and initialize a new simple network protocol structure.\r
@@ -369,12 +371,12 @@ SimpleNetworkDriverStart (
     goto NiiError;\r
   }\r
 \r
-  Snp = (SNP_DRIVER *) (UINTN) Address;\r
+  Snp = (SNP_DRIVER *)(UINTN)Address;\r
 \r
   ZeroMem (Snp, sizeof (SNP_DRIVER));\r
 \r
-  Snp->PciIo      = PciIo;\r
-  Snp->Signature  = SNP_DRIVER_SIGNATURE;\r
+  Snp->PciIo     = PciIo;\r
+  Snp->Signature = SNP_DRIVER_SIGNATURE;\r
 \r
   EfiInitializeLock (&Snp->Lock, TPL_NOTIFY);\r
 \r
@@ -394,38 +396,39 @@ SimpleNetworkDriverStart (
   Snp->Snp.Receive        = SnpUndi32Receive;\r
   Snp->Snp.WaitForPacket  = NULL;\r
 \r
-  Snp->Snp.Mode           = &Snp->Mode;\r
+  Snp->Snp.Mode = &Snp->Mode;\r
 \r
-  Snp->TxRxBufferSize     = 0;\r
-  Snp->TxRxBuffer         = NULL;\r
+  Snp->TxRxBufferSize = 0;\r
+  Snp->TxRxBuffer     = NULL;\r
 \r
   Snp->RecycledTxBuf = AllocatePool (sizeof (UINT64) * SNP_TX_BUFFER_INCREASEMENT);\r
   if (Snp->RecycledTxBuf == NULL) {\r
     Status = EFI_OUT_OF_RESOURCES;\r
     goto Error_DeleteSNP;\r
   }\r
-  Snp->MaxRecycledTxBuf    = SNP_TX_BUFFER_INCREASEMENT;\r
-  Snp->RecycledTxBufCount  = 0;\r
+\r
+  Snp->MaxRecycledTxBuf   = SNP_TX_BUFFER_INCREASEMENT;\r
+  Snp->RecycledTxBufCount = 0;\r
 \r
   if (Nii->Revision >= EFI_NETWORK_INTERFACE_IDENTIFIER_PROTOCOL_REVISION) {\r
     Snp->IfNum = Nii->IfNum;\r
-\r
   } else {\r
-    Snp->IfNum = (UINT8) (Nii->IfNum & 0xFF);\r
+    Snp->IfNum = (UINT8)(Nii->IfNum & 0xFF);\r
   }\r
 \r
   if ((Pxe->hw.Implementation & PXE_ROMID_IMP_HW_UNDI) != 0) {\r
-    Snp->IsSwUndi             = FALSE;\r
-    Snp->IssueUndi32Command   = &IssueHwUndiCommand;\r
+    Snp->IsSwUndi           = FALSE;\r
+    Snp->IssueUndi32Command = &IssueHwUndiCommand;\r
   } else {\r
     Snp->IsSwUndi = TRUE;\r
 \r
     if ((Pxe->sw.Implementation & PXE_ROMID_IMP_SW_VIRT_ADDR) != 0) {\r
-      Snp->IssueUndi32Command = (ISSUE_UNDI32_COMMAND) (UINTN) Pxe->sw.EntryPoint;\r
+      Snp->IssueUndi32Command = (ISSUE_UNDI32_COMMAND)(UINTN)Pxe->sw.EntryPoint;\r
     } else {\r
-      Snp->IssueUndi32Command = (ISSUE_UNDI32_COMMAND) (UINTN) ((UINT8) (UINTN) Pxe + Pxe->sw.EntryPoint);\r
+      Snp->IssueUndi32Command = (ISSUE_UNDI32_COMMAND)(UINTN)((UINT8)(UINTN)Pxe + Pxe->sw.EntryPoint);\r
     }\r
   }\r
+\r
   //\r
   // Allocate a global CPB and DB buffer for this UNDI interface.\r
   // we do this because:\r
@@ -456,8 +459,8 @@ SimpleNetworkDriverStart (
     goto Error_DeleteSNP;\r
   }\r
 \r
-  Snp->Cpb  = (VOID *) (UINTN) Address;\r
-  Snp->Db   = (VOID *) ((UINTN) Address + 2048);\r
+  Snp->Cpb = (VOID *)(UINTN)Address;\r
+  Snp->Db  = (VOID *)((UINTN)Address + 2048);\r
 \r
   //\r
   // Find the correct BAR to do IO.\r
@@ -475,7 +478,7 @@ SimpleNetworkDriverStart (
                       PciIo,\r
                       BarIndex,\r
                       NULL,\r
-                      (VOID**) &BarDesc\r
+                      (VOID **)&BarDesc\r
                       );\r
     if (Status == EFI_UNSUPPORTED) {\r
       continue;\r
@@ -504,24 +507,24 @@ SimpleNetworkDriverStart (
     goto Error_DeleteSNP;\r
   }\r
 \r
-  Snp->Cdb.OpCode     = PXE_OPCODE_GET_INIT_INFO;\r
-  Snp->Cdb.OpFlags    = PXE_OPFLAGS_NOT_USED;\r
+  Snp->Cdb.OpCode  = PXE_OPCODE_GET_INIT_INFO;\r
+  Snp->Cdb.OpFlags = PXE_OPFLAGS_NOT_USED;\r
 \r
-  Snp->Cdb.CPBsize    = PXE_CPBSIZE_NOT_USED;\r
-  Snp->Cdb.CPBaddr    = PXE_DBADDR_NOT_USED;\r
+  Snp->Cdb.CPBsize = PXE_CPBSIZE_NOT_USED;\r
+  Snp->Cdb.CPBaddr = PXE_DBADDR_NOT_USED;\r
 \r
-  Snp->Cdb.DBsize     = (UINT16) sizeof (Snp->InitInfo);\r
-  Snp->Cdb.DBaddr     = (UINT64)(UINTN) (&Snp->InitInfo);\r
+  Snp->Cdb.DBsize = (UINT16)sizeof (Snp->InitInfo);\r
+  Snp->Cdb.DBaddr = (UINT64)(UINTN)(&Snp->InitInfo);\r
 \r
-  Snp->Cdb.StatCode   = PXE_STATCODE_INITIALIZE;\r
-  Snp->Cdb.StatFlags  = PXE_STATFLAGS_INITIALIZE;\r
+  Snp->Cdb.StatCode  = PXE_STATCODE_INITIALIZE;\r
+  Snp->Cdb.StatFlags = PXE_STATFLAGS_INITIALIZE;\r
 \r
-  Snp->Cdb.IFnum      = Snp->IfNum;\r
-  Snp->Cdb.Control    = PXE_CONTROL_LAST_CDB_IN_LIST;\r
+  Snp->Cdb.IFnum   = Snp->IfNum;\r
+  Snp->Cdb.Control = PXE_CONTROL_LAST_CDB_IN_LIST;\r
 \r
   DEBUG ((DEBUG_NET, "\nSnp->undi.get_init_info()  "));\r
 \r
-  (*Snp->IssueUndi32Command) ((UINT64)(UINTN) &Snp->Cdb);\r
+  (*Snp->IssueUndi32Command)((UINT64)(UINTN)&Snp->Cdb);\r
 \r
   //\r
   // Save the INIT Stat Code...\r
@@ -548,23 +551,23 @@ SimpleNetworkDriverStart (
   Snp->Mode.MCastFilterCount    = 0;\r
 \r
   switch (InitStatFlags & PXE_STATFLAGS_CABLE_DETECT_MASK) {\r
-  case PXE_STATFLAGS_CABLE_DETECT_SUPPORTED:\r
-    Snp->CableDetectSupported = TRUE;\r
-    break;\r
+    case PXE_STATFLAGS_CABLE_DETECT_SUPPORTED:\r
+      Snp->CableDetectSupported = TRUE;\r
+      break;\r
 \r
-  case PXE_STATFLAGS_CABLE_DETECT_NOT_SUPPORTED:\r
-  default:\r
-    Snp->CableDetectSupported = FALSE;\r
+    case PXE_STATFLAGS_CABLE_DETECT_NOT_SUPPORTED:\r
+    default:\r
+      Snp->CableDetectSupported = FALSE;\r
   }\r
 \r
   switch (InitStatFlags & PXE_STATFLAGS_GET_STATUS_NO_MEDIA_MASK) {\r
-  case PXE_STATFLAGS_GET_STATUS_NO_MEDIA_SUPPORTED:\r
-    Snp->MediaStatusSupported = TRUE;\r
-    break;\r
+    case PXE_STATFLAGS_GET_STATUS_NO_MEDIA_SUPPORTED:\r
+      Snp->MediaStatusSupported = TRUE;\r
+      break;\r
 \r
-  case PXE_STATFLAGS_GET_STATUS_NO_MEDIA_NOT_SUPPORTED:\r
-  default:\r
-    Snp->MediaStatusSupported = FALSE;\r
+    case PXE_STATFLAGS_GET_STATUS_NO_MEDIA_NOT_SUPPORTED:\r
+    default:\r
+      Snp->MediaStatusSupported = FALSE;\r
   }\r
 \r
   if (Snp->CableDetectSupported || Snp->MediaStatusSupported) {\r
@@ -587,27 +590,22 @@ SimpleNetworkDriverStart (
 \r
   if ((Pxe->hw.Implementation & PXE_ROMID_IMP_PROMISCUOUS_MULTICAST_RX_SUPPORTED) != 0) {\r
     Snp->Mode.ReceiveFilterMask |= EFI_SIMPLE_NETWORK_RECEIVE_PROMISCUOUS_MULTICAST;\r
-\r
   }\r
 \r
   if ((Pxe->hw.Implementation & PXE_ROMID_IMP_PROMISCUOUS_RX_SUPPORTED) != 0) {\r
     Snp->Mode.ReceiveFilterMask |= EFI_SIMPLE_NETWORK_RECEIVE_PROMISCUOUS;\r
-\r
   }\r
 \r
   if ((Pxe->hw.Implementation & PXE_ROMID_IMP_BROADCAST_RX_SUPPORTED) != 0) {\r
     Snp->Mode.ReceiveFilterMask |= EFI_SIMPLE_NETWORK_RECEIVE_BROADCAST;\r
-\r
   }\r
 \r
   if ((Pxe->hw.Implementation & PXE_ROMID_IMP_FILTERED_MULTICAST_RX_SUPPORTED) != 0) {\r
     Snp->Mode.ReceiveFilterMask |= EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST;\r
-\r
   }\r
 \r
   if ((Pxe->hw.Implementation & PXE_ROMID_IMP_PROMISCUOUS_MULTICAST_RX_SUPPORTED) != 0) {\r
     Snp->Mode.ReceiveFilterMask |= EFI_SIMPLE_NETWORK_RECEIVE_PROMISCUOUS_MULTICAST;\r
-\r
   }\r
 \r
   Snp->Mode.ReceiveFilterSetting = 0;\r
@@ -698,18 +696,18 @@ Error_DeleteSNP:
            );\r
 NiiError:\r
   gBS->CloseProtocol (\r
-        Controller,\r
-        &gEfiNetworkInterfaceIdentifierProtocolGuid_31,\r
-        This->DriverBindingHandle,\r
-        Controller\r
-        );\r
+         Controller,\r
+         &gEfiNetworkInterfaceIdentifierProtocolGuid_31,\r
+         This->DriverBindingHandle,\r
+         Controller\r
+         );\r
 \r
   gBS->CloseProtocol (\r
-        Controller,\r
-        &gEfiDevicePathProtocolGuid,\r
-        This->DriverBindingHandle,\r
-        Controller\r
-        );\r
+         Controller,\r
+         &gEfiDevicePathProtocolGuid,\r
+         This->DriverBindingHandle,\r
+         Controller\r
+         );\r
 \r
   //\r
   // If we got here that means we are in error state.\r
@@ -742,16 +740,16 @@ NiiError:
 EFI_STATUS\r
 EFIAPI\r
 SimpleNetworkDriverStop (\r
-  IN  EFI_DRIVER_BINDING_PROTOCOL    *This,\r
-  IN  EFI_HANDLE                     Controller,\r
-  IN  UINTN                          NumberOfChildren,\r
-  IN  EFI_HANDLE                     *ChildHandleBuffer\r
+  IN  EFI_DRIVER_BINDING_PROTOCOL  *This,\r
+  IN  EFI_HANDLE                   Controller,\r
+  IN  UINTN                        NumberOfChildren,\r
+  IN  EFI_HANDLE                   *ChildHandleBuffer\r
   )\r
 {\r
-  EFI_STATUS                  Status;\r
-  EFI_SIMPLE_NETWORK_PROTOCOL *SnpProtocol;\r
-  SNP_DRIVER                  *Snp;\r
-  EFI_PCI_IO_PROTOCOL         *PciIo;\r
+  EFI_STATUS                   Status;\r
+  EFI_SIMPLE_NETWORK_PROTOCOL  *SnpProtocol;\r
+  SNP_DRIVER                   *Snp;\r
+  EFI_PCI_IO_PROTOCOL          *PciIo;\r
 \r
   //\r
   // Get our context back.\r
@@ -759,7 +757,7 @@ SimpleNetworkDriverStop (
   Status = gBS->OpenProtocol (\r
                   Controller,\r
                   &gEfiSimpleNetworkProtocolGuid,\r
-                  (VOID **) &SnpProtocol,\r
+                  (VOID **)&SnpProtocol,\r
                   This->DriverBindingHandle,\r
                   Controller,\r
                   EFI_OPEN_PROTOCOL_GET_PROTOCOL\r
@@ -826,7 +824,7 @@ SimpleNetworkDriverStop (
 //\r
 // Simple Network Protocol Driver Global Variables\r
 //\r
-EFI_DRIVER_BINDING_PROTOCOL gSimpleNetworkDriverBinding = {\r
+EFI_DRIVER_BINDING_PROTOCOL  gSimpleNetworkDriverBinding = {\r
   SimpleNetworkDriverSupported,\r
   SimpleNetworkDriverStart,\r
   SimpleNetworkDriverStop,\r
@@ -852,8 +850,8 @@ EFI_DRIVER_BINDING_PROTOCOL gSimpleNetworkDriverBinding = {
 EFI_STATUS\r
 EFIAPI\r
 InitializeSnpNiiDriver (\r
-  IN EFI_HANDLE       ImageHandle,\r
-  IN EFI_SYSTEM_TABLE *SystemTable\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
   return EfiLibInstallDriverBindingComponentName2 (\r