\r
#include "PxeBcImpl.h"\r
\r
-\r
/**\r
Enables the use of the PXE Base Code Protocol functions.\r
\r
EFI_STATUS\r
EFIAPI\r
EfiPxeBcStart (\r
- IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
- IN BOOLEAN UseIpv6\r
+ IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
+ IN BOOLEAN UseIpv6\r
)\r
{\r
PXEBC_PRIVATE_DATA *Private;\r
//\r
// Detect whether using IPv6 or not, and set it into mode data.\r
//\r
- if (UseIpv6 && Mode->Ipv6Available && Mode->Ipv6Supported && Private->Ip6Nic != NULL) {\r
+ if (UseIpv6 && Mode->Ipv6Available && Mode->Ipv6Supported && (Private->Ip6Nic != NULL)) {\r
Mode->UsingIpv6 = TRUE;\r
- } else if (!UseIpv6 && Private->Ip4Nic != NULL) {\r
+ } else if (!UseIpv6 && (Private->Ip4Nic != NULL)) {\r
Mode->UsingIpv6 = FALSE;\r
} else {\r
return EFI_UNSUPPORTED;\r
// Configure block size for TFTP as a default value to handle all link layers.\r
//\r
Private->BlockSize = Private->Ip6MaxPacketSize -\r
- PXEBC_DEFAULT_UDP_OVERHEAD_SIZE - PXEBC_DEFAULT_TFTP_OVERHEAD_SIZE;\r
+ PXEBC_DEFAULT_UDP_OVERHEAD_SIZE - PXEBC_DEFAULT_TFTP_OVERHEAD_SIZE;\r
\r
//\r
// PXE over IPv6 starts here, initialize the fields and list header.\r
// Create event and set status for token to capture ICMP6 error message.\r
//\r
Private->Icmp6Token.Status = EFI_NOT_READY;\r
- Status = gBS->CreateEvent (\r
- EVT_NOTIFY_SIGNAL,\r
- TPL_NOTIFY,\r
- PxeBcIcmp6ErrorUpdate,\r
- Private,\r
- &Private->Icmp6Token.Event\r
- );\r
+ Status = gBS->CreateEvent (\r
+ EVT_NOTIFY_SIGNAL,\r
+ TPL_NOTIFY,\r
+ PxeBcIcmp6ErrorUpdate,\r
+ Private,\r
+ &Private->Icmp6Token.Event\r
+ );\r
if (EFI_ERROR (Status)) {\r
goto ON_ERROR;\r
}\r
// Configure block size for TFTP as a default value to handle all link layers.\r
//\r
Private->BlockSize = Private->Ip4MaxPacketSize -\r
- PXEBC_DEFAULT_UDP_OVERHEAD_SIZE - PXEBC_DEFAULT_TFTP_OVERHEAD_SIZE;\r
+ PXEBC_DEFAULT_UDP_OVERHEAD_SIZE - PXEBC_DEFAULT_TFTP_OVERHEAD_SIZE;\r
\r
//\r
// PXE over IPv4 starts here, initialize the fields.\r
// Create event and set status for token to capture ICMP error message.\r
//\r
Private->Icmp6Token.Status = EFI_NOT_READY;\r
- Status = gBS->CreateEvent (\r
- EVT_NOTIFY_SIGNAL,\r
- TPL_NOTIFY,\r
- PxeBcIcmpErrorUpdate,\r
- Private,\r
- &Private->IcmpToken.Event\r
- );\r
+ Status = gBS->CreateEvent (\r
+ EVT_NOTIFY_SIGNAL,\r
+ TPL_NOTIFY,\r
+ PxeBcIcmpErrorUpdate,\r
+ Private,\r
+ &Private->IcmpToken.Event\r
+ );\r
if (EFI_ERROR (Status)) {\r
goto ON_ERROR;\r
}\r
\r
//\r
- //DHCP4 service allows only one of its children to be configured in\r
- //the active state, If the DHCP4 D.O.R.A started by IP4 auto\r
- //configuration and has not been completed, the Dhcp4 state machine\r
- //will not be in the right state for the PXE to start a new round D.O.R.A.\r
- //so we need to switch its policy to static.\r
+ // DHCP4 service allows only one of its children to be configured in\r
+ // the active state, If the DHCP4 D.O.R.A started by IP4 auto\r
+ // configuration and has not been completed, the Dhcp4 state machine\r
+ // will not be in the right state for the PXE to start a new round D.O.R.A.\r
+ // so we need to switch its policy to static.\r
//\r
Status = PxeBcSetIp4Policy (Private);\r
if (EFI_ERROR (Status)) {\r
// If PcdTftpBlockSize is set to non-zero, override the default value.\r
//\r
if (PcdGet64 (PcdTftpBlockSize) != 0) {\r
- Private->BlockSize = (UINTN) PcdGet64 (PcdTftpBlockSize);\r
+ Private->BlockSize = (UINTN)PcdGet64 (PcdTftpBlockSize);\r
}\r
\r
//\r
gBS->CloseEvent (Private->Icmp6Token.Event);\r
Private->Icmp6Token.Event = NULL;\r
}\r
+\r
Private->Udp6Read->Configure (Private->Udp6Read, NULL);\r
Private->Ip6->Configure (Private->Ip6, NULL);\r
} else {\r
gBS->CloseEvent (Private->ArpUpdateEvent);\r
Private->ArpUpdateEvent = NULL;\r
}\r
+\r
if (Private->IcmpToken.Event != NULL) {\r
gBS->CloseEvent (Private->IcmpToken.Event);\r
Private->IcmpToken.Event = NULL;\r
}\r
+\r
Private->Udp4Read->Configure (Private->Udp4Read, NULL);\r
Private->Ip4->Configure (Private->Ip4, NULL);\r
}\r
+\r
return Status;\r
}\r
\r
-\r
/**\r
Disable the use of the PXE Base Code Protocol functions.\r
\r
EFI_STATUS\r
EFIAPI\r
EfiPxeBcStop (\r
- IN EFI_PXE_BASE_CODE_PROTOCOL *This\r
+ IN EFI_PXE_BASE_CODE_PROTOCOL *This\r
)\r
{\r
PXEBC_PRIVATE_DATA *Private;\r
gBS->CloseEvent (Private->Icmp6Token.Event);\r
Private->Icmp6Token.Event = NULL;\r
}\r
+\r
if (Private->Dhcp6Request != NULL) {\r
FreePool (Private->Dhcp6Request);\r
Private->Dhcp6Request = NULL;\r
}\r
+\r
if (Private->BootFileName != NULL) {\r
FreePool (Private->BootFileName);\r
Private->BootFileName = NULL;\r
gBS->CloseEvent (Private->ArpUpdateEvent);\r
Private->ArpUpdateEvent = NULL;\r
}\r
+\r
if (Private->IcmpToken.Event != NULL) {\r
gBS->CloseEvent (Private->IcmpToken.Event);\r
Private->IcmpToken.Event = NULL;\r
}\r
+\r
Private->BootFileName = NULL;\r
}\r
\r
return EFI_SUCCESS;\r
}\r
\r
-\r
/**\r
Attempts to complete a DHCPv4 D.O.R.A. (discover / offer / request / acknowledge) or DHCPv6\r
S.A.R.R (solicit / advertise / request / reply) sequence.\r
EFI_STATUS\r
EFIAPI\r
EfiPxeBcDhcp (\r
- IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
- IN BOOLEAN SortOffers\r
+ IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
+ IN BOOLEAN SortOffers\r
)\r
{\r
PXEBC_PRIVATE_DATA *Private;\r
}\r
\r
if (Mode->UsingIpv6) {\r
-\r
//\r
// Stop Udp6Read instance\r
//\r
//\r
Status = PxeBcDhcp6Sarr (Private, Private->Dhcp6);\r
} else {\r
-\r
//\r
// Stop Udp4Read instance\r
//\r
} else {\r
Private->Udp4Read->Configure (Private->Udp4Read, &Private->Udp4CfgData);\r
}\r
+\r
//\r
// Dhcp(), Discover(), and Mtftp() set the IP filter, and return with the IP\r
// receive filter list emptied and the filter set to EFI_PXE_BASE_CODE_IP_FILTER_STATION_IP.\r
//\r
- ZeroMem(&IpFilter, sizeof (EFI_PXE_BASE_CODE_IP_FILTER));\r
+ ZeroMem (&IpFilter, sizeof (EFI_PXE_BASE_CODE_IP_FILTER));\r
IpFilter.Filters = EFI_PXE_BASE_CODE_IP_FILTER_STATION_IP;\r
This->SetIpFilter (This, &IpFilter);\r
\r
return Status;\r
}\r
\r
-\r
/**\r
Attempts to complete the PXE Boot Server and/or boot image discovery sequence.\r
\r
IN EFI_PXE_BASE_CODE_DISCOVER_INFO *Info OPTIONAL\r
)\r
{\r
- PXEBC_PRIVATE_DATA *Private;\r
- EFI_PXE_BASE_CODE_MODE *Mode;\r
- EFI_PXE_BASE_CODE_DISCOVER_INFO DefaultInfo;\r
- EFI_PXE_BASE_CODE_SRVLIST *SrvList;\r
- PXEBC_BOOT_SVR_ENTRY *BootSvrEntry;\r
- UINT16 Index;\r
- EFI_STATUS Status;\r
- EFI_PXE_BASE_CODE_IP_FILTER IpFilter;\r
- EFI_PXE_BASE_CODE_DISCOVER_INFO *NewCreatedInfo;\r
+ PXEBC_PRIVATE_DATA *Private;\r
+ EFI_PXE_BASE_CODE_MODE *Mode;\r
+ EFI_PXE_BASE_CODE_DISCOVER_INFO DefaultInfo;\r
+ EFI_PXE_BASE_CODE_SRVLIST *SrvList;\r
+ PXEBC_BOOT_SVR_ENTRY *BootSvrEntry;\r
+ UINT16 Index;\r
+ EFI_STATUS Status;\r
+ EFI_PXE_BASE_CODE_IP_FILTER IpFilter;\r
+ EFI_PXE_BASE_CODE_DISCOVER_INFO *NewCreatedInfo;\r
\r
if (This == NULL) {\r
return EFI_INVALID_PARAMETER;\r
}\r
\r
if (Mode->UsingIpv6) {\r
-\r
//\r
// Stop Udp6Read instance\r
//\r
Private->Udp6Read->Configure (Private->Udp6Read, NULL);\r
} else {\r
-\r
//\r
// Stop Udp4Read instance\r
//\r
//\r
if (!Mode->PxeDiscoverValid ||\r
!Mode->PxeReplyReceived ||\r
- (!Mode->PxeBisReplyReceived && UseBis)) {\r
+ (!Mode->PxeBisReplyReceived && UseBis))\r
+ {\r
Status = EFI_INVALID_PARAMETER;\r
goto ON_EXIT;\r
}\r
SrvList[0].AcceptAnyResponse = FALSE;\r
\r
CopyMem (&SrvList->IpAddr, &Private->ServerIp, sizeof (EFI_IP_ADDRESS));\r
-\r
} else if (Info == NULL) {\r
//\r
// 2. Extract the discover information from the cached packets if unspecified.\r
//\r
NewCreatedInfo = &DefaultInfo;\r
- Status = PxeBcExtractDiscoverInfo (Private, Type, &NewCreatedInfo, &BootSvrEntry, &SrvList);\r
+ Status = PxeBcExtractDiscoverInfo (Private, Type, &NewCreatedInfo, &BootSvrEntry, &SrvList);\r
if (EFI_ERROR (Status)) {\r
goto ON_EXIT;\r
}\r
+\r
ASSERT (NewCreatedInfo != NULL);\r
Info = NewCreatedInfo;\r
} else {\r
break;\r
}\r
}\r
+\r
if (Index != Info->IpCnt) {\r
//\r
// It's invalid if the first server doesn't accept any response\r
// Info and BootSvrEntry/SrvList are all ready by now, so execute discover by UniCast/BroadCast/MultiCast.\r
//\r
if ((!Info->UseUCast && !Info->UseBCast && !Info->UseMCast) ||\r
- (Info->MustUseList && Info->IpCnt == 0)) {\r
+ (Info->MustUseList && (Info->IpCnt == 0)))\r
+ {\r
Status = EFI_INVALID_PARAMETER;\r
goto ON_EXIT;\r
}\r
Info->IpCnt,\r
SrvList\r
);\r
-\r
} else if (Info->UseBCast) {\r
//\r
// Do discover by broadcast, but only valid for IPv4.\r
Info->IpCnt,\r
SrvList\r
);\r
-\r
} else if (Info->UseUCast) {\r
//\r
// Do discover by unicast.\r
Info->IpCnt,\r
SrvList\r
);\r
- }\r
+ }\r
}\r
\r
if (!EFI_ERROR (Status)) {\r
\r
ON_EXIT:\r
\r
- if (NewCreatedInfo != NULL && NewCreatedInfo != &DefaultInfo) {\r
+ if ((NewCreatedInfo != NULL) && (NewCreatedInfo != &DefaultInfo)) {\r
FreePool (NewCreatedInfo);\r
}\r
\r
// Dhcp(), Discover(), and Mtftp() set the IP filter, and return with the IP\r
// receive filter list emptied and the filter set to EFI_PXE_BASE_CODE_IP_FILTER_STATION_IP.\r
//\r
- ZeroMem(&IpFilter, sizeof (EFI_PXE_BASE_CODE_IP_FILTER));\r
+ ZeroMem (&IpFilter, sizeof (EFI_PXE_BASE_CODE_IP_FILTER));\r
IpFilter.Filters = EFI_PXE_BASE_CODE_IP_FILTER_STATION_IP;\r
This->SetIpFilter (This, &IpFilter);\r
\r
return Status;\r
}\r
\r
-\r
/**\r
Used to perform TFTP and MTFTP services.\r
\r
EFI_STATUS\r
EFIAPI\r
EfiPxeBcMtftp (\r
- IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
- IN EFI_PXE_BASE_CODE_TFTP_OPCODE Operation,\r
- IN OUT VOID *BufferPtr OPTIONAL,\r
- IN BOOLEAN Overwrite,\r
- IN OUT UINT64 *BufferSize,\r
- IN UINTN *BlockSize OPTIONAL,\r
- IN EFI_IP_ADDRESS *ServerIp,\r
- IN UINT8 *Filename,\r
- IN EFI_PXE_BASE_CODE_MTFTP_INFO *Info OPTIONAL,\r
- IN BOOLEAN DontUseBuffer\r
+ IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
+ IN EFI_PXE_BASE_CODE_TFTP_OPCODE Operation,\r
+ IN OUT VOID *BufferPtr OPTIONAL,\r
+ IN BOOLEAN Overwrite,\r
+ IN OUT UINT64 *BufferSize,\r
+ IN UINTN *BlockSize OPTIONAL,\r
+ IN EFI_IP_ADDRESS *ServerIp,\r
+ IN UINT8 *Filename,\r
+ IN EFI_PXE_BASE_CODE_MTFTP_INFO *Info OPTIONAL,\r
+ IN BOOLEAN DontUseBuffer\r
)\r
{\r
- PXEBC_PRIVATE_DATA *Private;\r
- EFI_PXE_BASE_CODE_MODE *Mode;\r
- EFI_MTFTP4_CONFIG_DATA Mtftp4Config;\r
- EFI_MTFTP6_CONFIG_DATA Mtftp6Config;\r
- VOID *Config;\r
- EFI_STATUS Status;\r
- EFI_PXE_BASE_CODE_IP_FILTER IpFilter;\r
- UINTN WindowSize;\r
+ PXEBC_PRIVATE_DATA *Private;\r
+ EFI_PXE_BASE_CODE_MODE *Mode;\r
+ EFI_MTFTP4_CONFIG_DATA Mtftp4Config;\r
+ EFI_MTFTP6_CONFIG_DATA Mtftp6Config;\r
+ VOID *Config;\r
+ EFI_STATUS Status;\r
+ EFI_PXE_BASE_CODE_IP_FILTER IpFilter;\r
+ UINTN WindowSize;\r
\r
if ((This == NULL) ||\r
(Filename == NULL) ||\r
(BufferSize == NULL) ||\r
(ServerIp == NULL) ||\r
- ((BlockSize != NULL) && (*BlockSize < PXE_MTFTP_DEFAULT_BLOCK_SIZE))) {\r
+ ((BlockSize != NULL) && (*BlockSize < PXE_MTFTP_DEFAULT_BLOCK_SIZE)))\r
+ {\r
return EFI_INVALID_PARAMETER;\r
}\r
\r
- if (Operation == EFI_PXE_BASE_CODE_TFTP_READ_FILE ||\r
- Operation == EFI_PXE_BASE_CODE_TFTP_READ_DIRECTORY ||\r
- Operation == EFI_PXE_BASE_CODE_MTFTP_READ_FILE ||\r
- Operation == EFI_PXE_BASE_CODE_MTFTP_READ_DIRECTORY) {\r
- if (BufferPtr == NULL && !DontUseBuffer) {\r
+ if ((Operation == EFI_PXE_BASE_CODE_TFTP_READ_FILE) ||\r
+ (Operation == EFI_PXE_BASE_CODE_TFTP_READ_DIRECTORY) ||\r
+ (Operation == EFI_PXE_BASE_CODE_MTFTP_READ_FILE) ||\r
+ (Operation == EFI_PXE_BASE_CODE_MTFTP_READ_DIRECTORY))\r
+ {\r
+ if ((BufferPtr == NULL) && !DontUseBuffer) {\r
return EFI_INVALID_PARAMETER;\r
}\r
}\r
\r
- Config = NULL;\r
- Status = EFI_DEVICE_ERROR;\r
- Private = PXEBC_PRIVATE_DATA_FROM_PXEBC (This);\r
- Mode = Private->PxeBc.Mode;\r
+ Config = NULL;\r
+ Status = EFI_DEVICE_ERROR;\r
+ Private = PXEBC_PRIVATE_DATA_FROM_PXEBC (This);\r
+ Mode = Private->PxeBc.Mode;\r
\r
//\r
// Get PcdPxeTftpWindowSize.\r
//\r
- WindowSize = (UINTN) PcdGet64 (PcdPxeTftpWindowSize);\r
+ WindowSize = (UINTN)PcdGet64 (PcdPxeTftpWindowSize);\r
\r
if (Mode->UsingIpv6) {\r
if (!NetIp6IsValidUnicast (&ServerIp->v6)) {\r
return EFI_INVALID_PARAMETER;\r
}\r
} else {\r
- if (IP4_IS_UNSPECIFIED (NTOHL (ServerIp->Addr[0])) || IP4_IS_LOCAL_BROADCAST (NTOHL (ServerIp->Addr[0]))) {\r
+ if (IP4_IS_UNSPECIFIED (NTOHL (ServerIp->Addr[0])) || IP4_IS_LOCAL_BROADCAST (NTOHL (ServerIp->Addr[0]))) {\r
return EFI_INVALID_PARAMETER;\r
}\r
}\r
// Set configuration data for Mtftp6 instance.\r
//\r
ZeroMem (&Mtftp6Config, sizeof (EFI_MTFTP6_CONFIG_DATA));\r
- Config = &Mtftp6Config;\r
- Mtftp6Config.TimeoutValue = PXEBC_MTFTP_TIMEOUT;\r
- Mtftp6Config.TryCount = PXEBC_MTFTP_RETRIES;\r
+ Config = &Mtftp6Config;\r
+ Mtftp6Config.TimeoutValue = PXEBC_MTFTP_TIMEOUT;\r
+ Mtftp6Config.TryCount = PXEBC_MTFTP_RETRIES;\r
CopyMem (&Mtftp6Config.StationIp, &Private->StationIp.v6, sizeof (EFI_IPv6_ADDRESS));\r
CopyMem (&Mtftp6Config.ServerIp, &ServerIp->v6, sizeof (EFI_IPv6_ADDRESS));\r
//\r
Mode->IcmpErrorReceived = FALSE;\r
\r
switch (Operation) {\r
+ case EFI_PXE_BASE_CODE_TFTP_GET_FILE_SIZE:\r
+ //\r
+ // Send TFTP request to get file size.\r
+ //\r
+ Status = PxeBcTftpGetFileSize (\r
+ Private,\r
+ Config,\r
+ Filename,\r
+ BlockSize,\r
+ (WindowSize > 1) ? &WindowSize : NULL,\r
+ BufferSize\r
+ );\r
\r
- case EFI_PXE_BASE_CODE_TFTP_GET_FILE_SIZE:\r
- //\r
- // Send TFTP request to get file size.\r
- //\r
- Status = PxeBcTftpGetFileSize (\r
- Private,\r
- Config,\r
- Filename,\r
- BlockSize,\r
- (WindowSize > 1) ? &WindowSize : NULL,\r
- BufferSize\r
- );\r
-\r
- break;\r
+ break;\r
\r
- case EFI_PXE_BASE_CODE_TFTP_READ_FILE:\r
- //\r
- // Send TFTP request to read file.\r
- //\r
- Status = PxeBcTftpReadFile (\r
- Private,\r
- Config,\r
- Filename,\r
- BlockSize,\r
- (WindowSize > 1) ? &WindowSize : NULL,\r
- BufferPtr,\r
- BufferSize,\r
- DontUseBuffer\r
- );\r
+ case EFI_PXE_BASE_CODE_TFTP_READ_FILE:\r
+ //\r
+ // Send TFTP request to read file.\r
+ //\r
+ Status = PxeBcTftpReadFile (\r
+ Private,\r
+ Config,\r
+ Filename,\r
+ BlockSize,\r
+ (WindowSize > 1) ? &WindowSize : NULL,\r
+ BufferPtr,\r
+ BufferSize,\r
+ DontUseBuffer\r
+ );\r
\r
- break;\r
+ break;\r
\r
- case EFI_PXE_BASE_CODE_TFTP_WRITE_FILE:\r
- //\r
- // Send TFTP request to write file.\r
- //\r
- Status = PxeBcTftpWriteFile (\r
- Private,\r
- Config,\r
- Filename,\r
- Overwrite,\r
- BlockSize,\r
- BufferPtr,\r
- BufferSize\r
- );\r
+ case EFI_PXE_BASE_CODE_TFTP_WRITE_FILE:\r
+ //\r
+ // Send TFTP request to write file.\r
+ //\r
+ Status = PxeBcTftpWriteFile (\r
+ Private,\r
+ Config,\r
+ Filename,\r
+ Overwrite,\r
+ BlockSize,\r
+ BufferPtr,\r
+ BufferSize\r
+ );\r
\r
- break;\r
+ break;\r
\r
- case EFI_PXE_BASE_CODE_TFTP_READ_DIRECTORY:\r
- //\r
- // Send TFTP request to read directory.\r
- //\r
- Status = PxeBcTftpReadDirectory (\r
- Private,\r
- Config,\r
- Filename,\r
- BlockSize,\r
- (WindowSize > 1) ? &WindowSize : NULL,\r
- BufferPtr,\r
- BufferSize,\r
- DontUseBuffer\r
- );\r
+ case EFI_PXE_BASE_CODE_TFTP_READ_DIRECTORY:\r
+ //\r
+ // Send TFTP request to read directory.\r
+ //\r
+ Status = PxeBcTftpReadDirectory (\r
+ Private,\r
+ Config,\r
+ Filename,\r
+ BlockSize,\r
+ (WindowSize > 1) ? &WindowSize : NULL,\r
+ BufferPtr,\r
+ BufferSize,\r
+ DontUseBuffer\r
+ );\r
\r
- break;\r
+ break;\r
\r
- case EFI_PXE_BASE_CODE_MTFTP_GET_FILE_SIZE:\r
- case EFI_PXE_BASE_CODE_MTFTP_READ_FILE:\r
- case EFI_PXE_BASE_CODE_MTFTP_READ_DIRECTORY:\r
- Status = EFI_UNSUPPORTED;\r
+ case EFI_PXE_BASE_CODE_MTFTP_GET_FILE_SIZE:\r
+ case EFI_PXE_BASE_CODE_MTFTP_READ_FILE:\r
+ case EFI_PXE_BASE_CODE_MTFTP_READ_DIRECTORY:\r
+ Status = EFI_UNSUPPORTED;\r
\r
- break;\r
+ break;\r
\r
- default:\r
- Status = EFI_INVALID_PARAMETER;\r
+ default:\r
+ Status = EFI_INVALID_PARAMETER;\r
\r
- break;\r
+ break;\r
}\r
\r
if (Status == EFI_ICMP_ERROR) {\r
} else {\r
Private->Udp4Read->Configure (Private->Udp4Read, &Private->Udp4CfgData);\r
}\r
+\r
//\r
// Dhcp(), Discover(), and Mtftp() set the IP filter, and return with the IP\r
// receive filter list emptied and the filter set to EFI_PXE_BASE_CODE_IP_FILTER_STATION_IP.\r
//\r
- ZeroMem(&IpFilter, sizeof (EFI_PXE_BASE_CODE_IP_FILTER));\r
+ ZeroMem (&IpFilter, sizeof (EFI_PXE_BASE_CODE_IP_FILTER));\r
IpFilter.Filters = EFI_PXE_BASE_CODE_IP_FILTER_STATION_IP;\r
This->SetIpFilter (This, &IpFilter);\r
\r
return Status;\r
}\r
\r
-\r
/**\r
Writes a UDP packet to the network interface.\r
\r
EFI_STATUS\r
EFIAPI\r
EfiPxeBcUdpWrite (\r
- IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
- IN UINT16 OpFlags,\r
- IN EFI_IP_ADDRESS *DestIp,\r
- IN EFI_PXE_BASE_CODE_UDP_PORT *DestPort,\r
- IN EFI_IP_ADDRESS *GatewayIp OPTIONAL,\r
- IN EFI_IP_ADDRESS *SrcIp OPTIONAL,\r
- IN OUT EFI_PXE_BASE_CODE_UDP_PORT *SrcPort OPTIONAL,\r
- IN UINTN *HeaderSize OPTIONAL,\r
- IN VOID *HeaderPtr OPTIONAL,\r
- IN UINTN *BufferSize,\r
- IN VOID *BufferPtr\r
+ IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
+ IN UINT16 OpFlags,\r
+ IN EFI_IP_ADDRESS *DestIp,\r
+ IN EFI_PXE_BASE_CODE_UDP_PORT *DestPort,\r
+ IN EFI_IP_ADDRESS *GatewayIp OPTIONAL,\r
+ IN EFI_IP_ADDRESS *SrcIp OPTIONAL,\r
+ IN OUT EFI_PXE_BASE_CODE_UDP_PORT *SrcPort OPTIONAL,\r
+ IN UINTN *HeaderSize OPTIONAL,\r
+ IN VOID *HeaderPtr OPTIONAL,\r
+ IN UINTN *BufferSize,\r
+ IN VOID *BufferPtr\r
)\r
{\r
- PXEBC_PRIVATE_DATA *Private;\r
- EFI_PXE_BASE_CODE_MODE *Mode;\r
- EFI_UDP4_SESSION_DATA Udp4Session;\r
- EFI_UDP6_SESSION_DATA Udp6Session;\r
- EFI_STATUS Status;\r
- BOOLEAN DoNotFragment;\r
-\r
- if (This == NULL || DestIp == NULL || DestPort == NULL) {\r
+ PXEBC_PRIVATE_DATA *Private;\r
+ EFI_PXE_BASE_CODE_MODE *Mode;\r
+ EFI_UDP4_SESSION_DATA Udp4Session;\r
+ EFI_UDP6_SESSION_DATA Udp6Session;\r
+ EFI_STATUS Status;\r
+ BOOLEAN DoNotFragment;\r
+\r
+ if ((This == NULL) || (DestIp == NULL) || (DestPort == NULL)) {\r
return EFI_INVALID_PARAMETER;\r
}\r
\r
DoNotFragment = TRUE;\r
}\r
\r
- if (!Mode->UsingIpv6 && GatewayIp != NULL && Mode->SubnetMask.Addr[0] != 0 &&\r
- !NetIp4IsUnicast (NTOHL (GatewayIp->Addr[0]), EFI_NTOHL(Mode->SubnetMask))) {\r
+ if (!Mode->UsingIpv6 && (GatewayIp != NULL) && (Mode->SubnetMask.Addr[0] != 0) &&\r
+ !NetIp4IsUnicast (NTOHL (GatewayIp->Addr[0]), EFI_NTOHL (Mode->SubnetMask)))\r
+ {\r
//\r
// Gateway is provided but it's not a unicast IPv4 address, while it will be ignored for IPv6.\r
//\r
return EFI_INVALID_PARAMETER;\r
}\r
\r
- if (HeaderSize != NULL && (*HeaderSize == 0 || HeaderPtr == NULL)) {\r
+ if ((HeaderSize != NULL) && ((*HeaderSize == 0) || (HeaderPtr == NULL))) {\r
return EFI_INVALID_PARAMETER;\r
}\r
\r
- if (BufferSize == NULL || (*BufferSize != 0 && BufferPtr == NULL)) {\r
+ if ((BufferSize == NULL) || ((*BufferSize != 0) && (BufferPtr == NULL))) {\r
return EFI_INVALID_PARAMETER;\r
}\r
\r
return EFI_NOT_STARTED;\r
}\r
\r
- if (!Private->IsAddressOk && SrcIp == NULL) {\r
+ if (!Private->IsAddressOk && (SrcIp == NULL)) {\r
return EFI_INVALID_PARAMETER;\r
}\r
\r
- if (Private->CurSrcPort == 0 ||\r
- (SrcPort != NULL && *SrcPort != Private->CurSrcPort)) {\r
+ if ((Private->CurSrcPort == 0) ||\r
+ ((SrcPort != NULL) && (*SrcPort != Private->CurSrcPort)))\r
+ {\r
//\r
// Reconfigure UDPv4/UDPv6 for UdpWrite if the source port changed.\r
//\r
if (SrcIp != NULL) {\r
CopyMem (&Udp6Session.SourceAddress, SrcIp, sizeof (EFI_IPv6_ADDRESS));\r
}\r
+\r
if (SrcPort != NULL) {\r
Udp6Session.SourcePort = *SrcPort;\r
}\r
if (SrcIp != NULL) {\r
CopyMem (&Udp4Session.SourceAddress, SrcIp, sizeof (EFI_IPv4_ADDRESS));\r
}\r
+\r
if (SrcPort != NULL) {\r
Udp4Session.SourcePort = *SrcPort;\r
}\r
+\r
//\r
// Override the gateway information if user specified.\r
//\r
Private->Udp4Write,\r
&Udp4Session,\r
Private->UdpTimeOutEvent,\r
- (EFI_IPv4_ADDRESS *) GatewayIp,\r
+ (EFI_IPv4_ADDRESS *)GatewayIp,\r
HeaderSize,\r
HeaderPtr,\r
BufferSize,\r
\r
gBS->SetTimer (Private->UdpTimeOutEvent, TimerCancel, 0);\r
\r
-\r
//\r
// Reset the UdpWrite instance.\r
//\r
return Status;\r
}\r
\r
-\r
/**\r
Reads a UDP packet from the network interface.\r
+\r
EFI_STATUS\r
EFIAPI\r
EfiPxeBcUdpRead (\r
- IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
- IN UINT16 OpFlags,\r
- IN OUT EFI_IP_ADDRESS *DestIp OPTIONAL,\r
- IN OUT EFI_PXE_BASE_CODE_UDP_PORT *DestPort OPTIONAL,\r
- IN OUT EFI_IP_ADDRESS *SrcIp OPTIONAL,\r
- IN OUT EFI_PXE_BASE_CODE_UDP_PORT *SrcPort OPTIONAL,\r
- IN UINTN *HeaderSize OPTIONAL,\r
- IN VOID *HeaderPtr OPTIONAL,\r
- IN OUT UINTN *BufferSize,\r
- IN VOID *BufferPtr\r
+ IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
+ IN UINT16 OpFlags,\r
+ IN OUT EFI_IP_ADDRESS *DestIp OPTIONAL,\r
+ IN OUT EFI_PXE_BASE_CODE_UDP_PORT *DestPort OPTIONAL,\r
+ IN OUT EFI_IP_ADDRESS *SrcIp OPTIONAL,\r
+ IN OUT EFI_PXE_BASE_CODE_UDP_PORT *SrcPort OPTIONAL,\r
+ IN UINTN *HeaderSize OPTIONAL,\r
+ IN VOID *HeaderPtr OPTIONAL,\r
+ IN OUT UINTN *BufferSize,\r
+ IN VOID *BufferPtr\r
)\r
{\r
- PXEBC_PRIVATE_DATA *Private;\r
- EFI_PXE_BASE_CODE_MODE *Mode;\r
- EFI_UDP4_COMPLETION_TOKEN Udp4Token;\r
- EFI_UDP6_COMPLETION_TOKEN Udp6Token;\r
- EFI_UDP4_RECEIVE_DATA *Udp4Rx;\r
- EFI_UDP6_RECEIVE_DATA *Udp6Rx;\r
- EFI_STATUS Status;\r
- BOOLEAN IsDone;\r
- BOOLEAN IsMatched;\r
- UINTN CopiedLen;\r
- UINTN HeaderLen;\r
- UINTN HeaderCopiedLen;\r
- UINTN BufferCopiedLen;\r
- UINT32 FragmentLength;\r
- UINTN FragmentIndex;\r
- UINT8 *FragmentBuffer;\r
+ PXEBC_PRIVATE_DATA *Private;\r
+ EFI_PXE_BASE_CODE_MODE *Mode;\r
+ EFI_UDP4_COMPLETION_TOKEN Udp4Token;\r
+ EFI_UDP6_COMPLETION_TOKEN Udp6Token;\r
+ EFI_UDP4_RECEIVE_DATA *Udp4Rx;\r
+ EFI_UDP6_RECEIVE_DATA *Udp6Rx;\r
+ EFI_STATUS Status;\r
+ BOOLEAN IsDone;\r
+ BOOLEAN IsMatched;\r
+ UINTN CopiedLen;\r
+ UINTN HeaderLen;\r
+ UINTN HeaderCopiedLen;\r
+ UINTN BufferCopiedLen;\r
+ UINT32 FragmentLength;\r
+ UINTN FragmentIndex;\r
+ UINT8 *FragmentBuffer;\r
\r
if (This == NULL) {\r
return EFI_INVALID_PARAMETER;\r
Udp4Rx = NULL;\r
Udp6Rx = NULL;\r
\r
- if (((OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_DEST_PORT) == 0 && DestPort == NULL) ||\r
- ((OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_SRC_IP) == 0 && SrcIp == NULL) ||\r
- ((OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_SRC_PORT) == 0 && SrcPort == NULL)) {\r
+ if ((((OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_DEST_PORT) == 0) && (DestPort == NULL)) ||\r
+ (((OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_SRC_IP) == 0) && (SrcIp == NULL)) ||\r
+ (((OpFlags & EFI_PXE_BASE_CODE_UDP_OPFLAGS_ANY_SRC_PORT) == 0) && (SrcPort == NULL)))\r
+ {\r
return EFI_INVALID_PARAMETER;\r
}\r
\r
- if ((HeaderSize != NULL && *HeaderSize == 0) || (HeaderSize != NULL && HeaderPtr == NULL)) {\r
+ if (((HeaderSize != NULL) && (*HeaderSize == 0)) || ((HeaderSize != NULL) && (HeaderPtr == NULL))) {\r
return EFI_INVALID_PARAMETER;\r
}\r
\r
}\r
}\r
\r
- if (Status == EFI_ICMP_ERROR ||\r
- Status == EFI_NETWORK_UNREACHABLE ||\r
- Status == EFI_HOST_UNREACHABLE ||\r
- Status == EFI_PROTOCOL_UNREACHABLE ||\r
- Status == EFI_PORT_UNREACHABLE) {\r
+ if ((Status == EFI_ICMP_ERROR) ||\r
+ (Status == EFI_NETWORK_UNREACHABLE) ||\r
+ (Status == EFI_HOST_UNREACHABLE) ||\r
+ (Status == EFI_PROTOCOL_UNREACHABLE) ||\r
+ (Status == EFI_PORT_UNREACHABLE))\r
+ {\r
//\r
// Get different return status for icmp error from Udp, refers to UEFI spec.\r
//\r
Mode->IcmpErrorReceived = TRUE;\r
}\r
+\r
gBS->SetTimer (Private->UdpTimeOutEvent, TimerCancel, 0);\r
\r
if (IsMatched) {\r
if (HeaderSize != NULL) {\r
*HeaderSize = HeaderLen;\r
}\r
+\r
*BufferSize = Udp6Rx->DataLength - HeaderLen;\r
\r
HeaderCopiedLen = 0;\r
//\r
// Copy the header part of received data.\r
//\r
- CopyMem ((UINT8 *) HeaderPtr + HeaderCopiedLen, FragmentBuffer, FragmentLength);\r
+ CopyMem ((UINT8 *)HeaderPtr + HeaderCopiedLen, FragmentBuffer, FragmentLength);\r
HeaderCopiedLen += FragmentLength;\r
} else if (HeaderCopiedLen < HeaderLen) {\r
//\r
// Copy the header part of received data.\r
//\r
CopiedLen = HeaderLen - HeaderCopiedLen;\r
- CopyMem ((UINT8 *) HeaderPtr + HeaderCopiedLen, FragmentBuffer, CopiedLen);\r
+ CopyMem ((UINT8 *)HeaderPtr + HeaderCopiedLen, FragmentBuffer, CopiedLen);\r
HeaderCopiedLen += CopiedLen;\r
\r
//\r
// Copy the other part of received data.\r
//\r
- CopyMem ((UINT8 *) BufferPtr + BufferCopiedLen, FragmentBuffer + CopiedLen, FragmentLength - CopiedLen);\r
+ CopyMem ((UINT8 *)BufferPtr + BufferCopiedLen, FragmentBuffer + CopiedLen, FragmentLength - CopiedLen);\r
BufferCopiedLen += (FragmentLength - CopiedLen);\r
} else {\r
//\r
// Copy the other part of received data.\r
//\r
- CopyMem ((UINT8 *) BufferPtr + BufferCopiedLen, FragmentBuffer, FragmentLength);\r
+ CopyMem ((UINT8 *)BufferPtr + BufferCopiedLen, FragmentBuffer, FragmentLength);\r
BufferCopiedLen += FragmentLength;\r
}\r
}\r
}\r
+\r
//\r
// Recycle the receiving buffer after copy to user.\r
//\r
if (HeaderSize != NULL) {\r
*HeaderSize = HeaderLen;\r
}\r
+\r
*BufferSize = Udp4Rx->DataLength - HeaderLen;\r
\r
HeaderCopiedLen = 0;\r
//\r
// Copy the header part of received data.\r
//\r
- CopyMem ((UINT8 *) HeaderPtr + HeaderCopiedLen, FragmentBuffer, FragmentLength);\r
+ CopyMem ((UINT8 *)HeaderPtr + HeaderCopiedLen, FragmentBuffer, FragmentLength);\r
HeaderCopiedLen += FragmentLength;\r
} else if (HeaderCopiedLen < HeaderLen) {\r
//\r
// Copy the header part of received data.\r
//\r
CopiedLen = HeaderLen - HeaderCopiedLen;\r
- CopyMem ((UINT8 *) HeaderPtr + HeaderCopiedLen, FragmentBuffer, CopiedLen);\r
+ CopyMem ((UINT8 *)HeaderPtr + HeaderCopiedLen, FragmentBuffer, CopiedLen);\r
HeaderCopiedLen += CopiedLen;\r
\r
//\r
// Copy the other part of received data.\r
//\r
- CopyMem ((UINT8 *) BufferPtr + BufferCopiedLen, FragmentBuffer + CopiedLen, FragmentLength - CopiedLen);\r
+ CopyMem ((UINT8 *)BufferPtr + BufferCopiedLen, FragmentBuffer + CopiedLen, FragmentLength - CopiedLen);\r
BufferCopiedLen += (FragmentLength - CopiedLen);\r
} else {\r
//\r
// Copy the other part of received data.\r
//\r
- CopyMem ((UINT8 *) BufferPtr + BufferCopiedLen, FragmentBuffer, FragmentLength);\r
+ CopyMem ((UINT8 *)BufferPtr + BufferCopiedLen, FragmentBuffer, FragmentLength);\r
BufferCopiedLen += FragmentLength;\r
}\r
}\r
}\r
+\r
//\r
// Recycle the receiving buffer after copy to user.\r
//\r
return Status;\r
}\r
\r
-\r
/**\r
Updates the IP receive filters of a network device and enables software filtering.\r
\r
EFI_STATUS\r
EFIAPI\r
EfiPxeBcSetIpFilter (\r
- IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
- IN EFI_PXE_BASE_CODE_IP_FILTER *NewFilter\r
+ IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
+ IN EFI_PXE_BASE_CODE_IP_FILTER *NewFilter\r
)\r
{\r
- EFI_STATUS Status;\r
- PXEBC_PRIVATE_DATA *Private;\r
- EFI_PXE_BASE_CODE_MODE *Mode;\r
- EFI_UDP4_CONFIG_DATA *Udp4Cfg;\r
- EFI_UDP6_CONFIG_DATA *Udp6Cfg;\r
- UINTN Index;\r
- BOOLEAN NeedPromiscuous;\r
- BOOLEAN AcceptPromiscuous;\r
- BOOLEAN AcceptBroadcast;\r
- BOOLEAN MultiCastUpdate;\r
-\r
- if (This == NULL || NewFilter == NULL) {\r
+ EFI_STATUS Status;\r
+ PXEBC_PRIVATE_DATA *Private;\r
+ EFI_PXE_BASE_CODE_MODE *Mode;\r
+ EFI_UDP4_CONFIG_DATA *Udp4Cfg;\r
+ EFI_UDP6_CONFIG_DATA *Udp6Cfg;\r
+ UINTN Index;\r
+ BOOLEAN NeedPromiscuous;\r
+ BOOLEAN AcceptPromiscuous;\r
+ BOOLEAN AcceptBroadcast;\r
+ BOOLEAN MultiCastUpdate;\r
+\r
+ if ((This == NULL) || (NewFilter == NULL)) {\r
return EFI_INVALID_PARAMETER;\r
}\r
\r
for (Index = 0; Index < NewFilter->IpCnt; Index++) {\r
ASSERT (Index < EFI_PXE_BASE_CODE_MAX_IPCNT);\r
if (!Mode->UsingIpv6 &&\r
- IP4_IS_LOCAL_BROADCAST (EFI_IP4 (NewFilter->IpList[Index].v4))) {\r
+ IP4_IS_LOCAL_BROADCAST (EFI_IP4 (NewFilter->IpList[Index].v4)))\r
+ {\r
//\r
// IPv4 broadcast address should not be in IP filter.\r
//\r
return EFI_INVALID_PARAMETER;\r
}\r
+\r
if (Mode->UsingIpv6) {\r
- if ((NewFilter->Filters & EFI_PXE_BASE_CODE_IP_FILTER_STATION_IP) != 0 &&\r
- NetIp6IsValidUnicast (&NewFilter->IpList[Index].v6)) {\r
+ if (((NewFilter->Filters & EFI_PXE_BASE_CODE_IP_FILTER_STATION_IP) != 0) &&\r
+ NetIp6IsValidUnicast (&NewFilter->IpList[Index].v6))\r
+ {\r
NeedPromiscuous = TRUE;\r
}\r
- } else if ((EFI_NTOHL(Mode->StationIp) != 0) &&\r
- (EFI_NTOHL(Mode->SubnetMask) != 0) &&\r
- IP4_NET_EQUAL(EFI_NTOHL(Mode->StationIp), EFI_NTOHL(NewFilter->IpList[Index].v4), EFI_NTOHL(Mode->SubnetMask.v4)) &&\r
- NetIp4IsUnicast (EFI_IP4 (NewFilter->IpList[Index].v4), EFI_NTOHL(Mode->SubnetMask)) &&\r
- ((NewFilter->Filters & EFI_PXE_BASE_CODE_IP_FILTER_STATION_IP) != 0)) {\r
+ } else if ((EFI_NTOHL (Mode->StationIp) != 0) &&\r
+ (EFI_NTOHL (Mode->SubnetMask) != 0) &&\r
+ IP4_NET_EQUAL (EFI_NTOHL (Mode->StationIp), EFI_NTOHL (NewFilter->IpList[Index].v4), EFI_NTOHL (Mode->SubnetMask.v4)) &&\r
+ NetIp4IsUnicast (EFI_IP4 (NewFilter->IpList[Index].v4), EFI_NTOHL (Mode->SubnetMask)) &&\r
+ ((NewFilter->Filters & EFI_PXE_BASE_CODE_IP_FILTER_STATION_IP) != 0))\r
+ {\r
NeedPromiscuous = TRUE;\r
}\r
}\r
MultiCastUpdate = FALSE;\r
\r
if (NeedPromiscuous ||\r
- (NewFilter->Filters & EFI_PXE_BASE_CODE_IP_FILTER_PROMISCUOUS) != 0 ||\r
- (NewFilter->Filters & EFI_PXE_BASE_CODE_IP_FILTER_PROMISCUOUS_MULTICAST) != 0) {\r
+ ((NewFilter->Filters & EFI_PXE_BASE_CODE_IP_FILTER_PROMISCUOUS) != 0) ||\r
+ ((NewFilter->Filters & EFI_PXE_BASE_CODE_IP_FILTER_PROMISCUOUS_MULTICAST) != 0))\r
+ {\r
//\r
// Configure UDPv4/UDPv6 as promiscuous mode to receive all packets.\r
//\r
//\r
// Configure UDPv4 to receive all broadcast packets.\r
//\r
- AcceptBroadcast = TRUE;\r
+ AcceptBroadcast = TRUE;\r
}\r
\r
//\r
//\r
Udp4Cfg = &Private->Udp4CfgData;\r
if ((AcceptPromiscuous != Udp4Cfg->AcceptPromiscuous) ||\r
- (AcceptBroadcast != Udp4Cfg->AcceptBroadcast) || MultiCastUpdate) {\r
+ (AcceptBroadcast != Udp4Cfg->AcceptBroadcast) || MultiCastUpdate)\r
+ {\r
//\r
// Clear the UDP4 instance configuration, all joined groups will be left\r
// during the operation.\r
//\r
Udp4Cfg->AcceptPromiscuous = AcceptPromiscuous;\r
Udp4Cfg->AcceptBroadcast = AcceptBroadcast;\r
- Status = Private->Udp4Read->Configure (Private->Udp4Read, Udp4Cfg);\r
+ Status = Private->Udp4Read->Configure (Private->Udp4Read, Udp4Cfg);\r
if (EFI_ERROR (Status)) {\r
return Status;\r
}\r
// Configure the UDP instance with the new configuration.\r
//\r
Udp6Cfg->AcceptPromiscuous = AcceptPromiscuous;\r
- Status = Private->Udp6Read->Configure (Private->Udp6Read, Udp6Cfg);\r
+ Status = Private->Udp6Read->Configure (Private->Udp6Read, Udp6Cfg);\r
if (EFI_ERROR (Status)) {\r
return Status;\r
}\r
return Status;\r
}\r
\r
-\r
/**\r
Uses the ARP protocol to resolve a MAC address. It is not supported for IPv6.\r
\r
EFI_STATUS\r
EFIAPI\r
EfiPxeBcArp (\r
- IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
- IN EFI_IP_ADDRESS *IpAddr,\r
- IN EFI_MAC_ADDRESS *MacAddr OPTIONAL\r
+ IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
+ IN EFI_IP_ADDRESS *IpAddr,\r
+ IN EFI_MAC_ADDRESS *MacAddr OPTIONAL\r
)\r
{\r
PXEBC_PRIVATE_DATA *Private;\r
EFI_MAC_ADDRESS ZeroMac;\r
BOOLEAN IsResolved;\r
\r
- if (This == NULL || IpAddr == NULL) {\r
+ if ((This == NULL) || (IpAddr == NULL)) {\r
return EFI_INVALID_PARAMETER;\r
}\r
\r
// If AutoArp is TRUE, try to send Arp request on initiative.\r
//\r
Status = Private->Arp->Request (Private->Arp, &IpAddr->v4, ResolvedEvent, &TempMac);\r
- if (EFI_ERROR (Status) && Status != EFI_NOT_READY) {\r
+ if (EFI_ERROR (Status) && (Status != EFI_NOT_READY)) {\r
goto ON_EXIT;\r
}\r
\r
break;\r
}\r
}\r
+\r
if (CompareMem (&TempMac, &ZeroMac, sizeof (EFI_MAC_ADDRESS)) != 0) {\r
Status = EFI_SUCCESS;\r
} else {\r
//\r
// Copy the Mac address to user if needed.\r
//\r
- if (MacAddr != NULL && !EFI_ERROR (Status)) {\r
+ if ((MacAddr != NULL) && !EFI_ERROR (Status)) {\r
CopyMem (MacAddr, &TempMac, sizeof (EFI_MAC_ADDRESS));\r
}\r
\r
if (ResolvedEvent != NULL) {\r
gBS->CloseEvent (ResolvedEvent);\r
}\r
+\r
return Status;\r
}\r
\r
-\r
/**\r
Updates the parameters that affect the operation of the PXE Base Code Protocol.\r
\r
EFI_STATUS\r
EFIAPI\r
EfiPxeBcSetParameters (\r
- IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
- IN BOOLEAN *NewAutoArp OPTIONAL,\r
- IN BOOLEAN *NewSendGUID OPTIONAL,\r
- IN UINT8 *NewTTL OPTIONAL,\r
- IN UINT8 *NewToS OPTIONAL,\r
- IN BOOLEAN *NewMakeCallback OPTIONAL\r
+ IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
+ IN BOOLEAN *NewAutoArp OPTIONAL,\r
+ IN BOOLEAN *NewSendGUID OPTIONAL,\r
+ IN UINT8 *NewTTL OPTIONAL,\r
+ IN UINT8 *NewToS OPTIONAL,\r
+ IN BOOLEAN *NewMakeCallback OPTIONAL\r
)\r
{\r
PXEBC_PRIVATE_DATA *Private;\r
Status = gBS->HandleProtocol (\r
Mode->UsingIpv6 ? Private->Ip6Nic->Controller : Private->Ip4Nic->Controller,\r
&gEfiPxeBaseCodeCallbackProtocolGuid,\r
- (VOID **) &Private->PxeBcCallback\r
+ (VOID **)&Private->PxeBcCallback\r
);\r
\r
if (EFI_ERROR (Status) || (Private->PxeBcCallback->Callback == NULL)) {\r
} else {\r
Private->PxeBcCallback = NULL;\r
}\r
+\r
Mode->MakeCallbacks = *NewMakeCallback;\r
}\r
\r
DEBUG ((DEBUG_WARN, "PXE: Failed to read system GUID from the smbios table!\n"));\r
return EFI_INVALID_PARAMETER;\r
}\r
+\r
Mode->SendGUID = *NewSendGUID;\r
}\r
\r
return EFI_SUCCESS;\r
}\r
\r
-\r
/**\r
Updates the station IP address and/or subnet mask values of a network device.\r
\r
EFI_STATUS\r
EFIAPI\r
EfiPxeBcSetStationIP (\r
- IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
- IN EFI_IP_ADDRESS *NewStationIp OPTIONAL,\r
- IN EFI_IP_ADDRESS *NewSubnetMask OPTIONAL\r
+ IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
+ IN EFI_IP_ADDRESS *NewStationIp OPTIONAL,\r
+ IN EFI_IP_ADDRESS *NewSubnetMask OPTIONAL\r
)\r
{\r
EFI_STATUS Status;\r
return EFI_INVALID_PARAMETER;\r
}\r
\r
- if (NewStationIp != NULL && !NetIp6IsValidUnicast (&NewStationIp->v6)) {\r
+ if ((NewStationIp != NULL) && !NetIp6IsValidUnicast (&NewStationIp->v6)) {\r
return EFI_INVALID_PARAMETER;\r
}\r
\r
Status = EFI_SUCCESS;\r
\r
if (!Mode->UsingIpv6 &&\r
- NewSubnetMask != NULL &&\r
- !IP4_IS_VALID_NETMASK (NTOHL (NewSubnetMask->Addr[0]))) {\r
+ (NewSubnetMask != NULL) &&\r
+ !IP4_IS_VALID_NETMASK (NTOHL (NewSubnetMask->Addr[0])))\r
+ {\r
return EFI_INVALID_PARAMETER;\r
}\r
\r
- if (!Mode->UsingIpv6 && NewStationIp != NULL) {\r
- if (IP4_IS_UNSPECIFIED(NTOHL (NewStationIp->Addr[0])) ||\r
- IP4_IS_LOCAL_BROADCAST(NTOHL (NewStationIp->Addr[0])) ||\r
- (NewSubnetMask != NULL && NewSubnetMask->Addr[0] != 0 && !NetIp4IsUnicast (NTOHL (NewStationIp->Addr[0]), NTOHL (NewSubnetMask->Addr[0])))) {\r
+ if (!Mode->UsingIpv6 && (NewStationIp != NULL)) {\r
+ if (IP4_IS_UNSPECIFIED (NTOHL (NewStationIp->Addr[0])) ||\r
+ IP4_IS_LOCAL_BROADCAST (NTOHL (NewStationIp->Addr[0])) ||\r
+ ((NewSubnetMask != NULL) && (NewSubnetMask->Addr[0] != 0) && !NetIp4IsUnicast (NTOHL (NewStationIp->Addr[0]), NTOHL (NewSubnetMask->Addr[0]))))\r
+ {\r
return EFI_INVALID_PARAMETER;\r
}\r
}\r
return EFI_NOT_STARTED;\r
}\r
\r
- if (Mode->UsingIpv6 && NewStationIp != NULL) {\r
+ if (Mode->UsingIpv6 && (NewStationIp != NULL)) {\r
//\r
// Set the IPv6 address by Ip6Config protocol.\r
//\r
CopyMem (&Private->StationIp, NewStationIp, sizeof (EFI_IP_ADDRESS));\r
}\r
\r
- if (!Mode->UsingIpv6 && NewSubnetMask != NULL) {\r
+ if (!Mode->UsingIpv6 && (NewSubnetMask != NULL)) {\r
CopyMem (&Mode->SubnetMask, NewSubnetMask, sizeof (EFI_IP_ADDRESS));\r
- CopyMem (&Private->SubnetMask ,NewSubnetMask, sizeof (EFI_IP_ADDRESS));\r
+ CopyMem (&Private->SubnetMask, NewSubnetMask, sizeof (EFI_IP_ADDRESS));\r
}\r
\r
Status = PxeBcFlushStationIp (Private, NewStationIp, NewSubnetMask);\r
return Status;\r
}\r
\r
-\r
/**\r
Updates the contents of the cached DHCP and Discover packets.\r
\r
EFI_STATUS\r
EFIAPI\r
EfiPxeBcSetPackets (\r
- IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
- IN BOOLEAN *NewDhcpDiscoverValid OPTIONAL,\r
- IN BOOLEAN *NewDhcpAckReceived OPTIONAL,\r
- IN BOOLEAN *NewProxyOfferReceived OPTIONAL,\r
- IN BOOLEAN *NewPxeDiscoverValid OPTIONAL,\r
- IN BOOLEAN *NewPxeReplyReceived OPTIONAL,\r
- IN BOOLEAN *NewPxeBisReplyReceived OPTIONAL,\r
- IN EFI_PXE_BASE_CODE_PACKET *NewDhcpDiscover OPTIONAL,\r
- IN EFI_PXE_BASE_CODE_PACKET *NewDhcpAck OPTIONAL,\r
- IN EFI_PXE_BASE_CODE_PACKET *NewProxyOffer OPTIONAL,\r
- IN EFI_PXE_BASE_CODE_PACKET *NewPxeDiscover OPTIONAL,\r
- IN EFI_PXE_BASE_CODE_PACKET *NewPxeReply OPTIONAL,\r
- IN EFI_PXE_BASE_CODE_PACKET *NewPxeBisReply OPTIONAL\r
+ IN EFI_PXE_BASE_CODE_PROTOCOL *This,\r
+ IN BOOLEAN *NewDhcpDiscoverValid OPTIONAL,\r
+ IN BOOLEAN *NewDhcpAckReceived OPTIONAL,\r
+ IN BOOLEAN *NewProxyOfferReceived OPTIONAL,\r
+ IN BOOLEAN *NewPxeDiscoverValid OPTIONAL,\r
+ IN BOOLEAN *NewPxeReplyReceived OPTIONAL,\r
+ IN BOOLEAN *NewPxeBisReplyReceived OPTIONAL,\r
+ IN EFI_PXE_BASE_CODE_PACKET *NewDhcpDiscover OPTIONAL,\r
+ IN EFI_PXE_BASE_CODE_PACKET *NewDhcpAck OPTIONAL,\r
+ IN EFI_PXE_BASE_CODE_PACKET *NewProxyOffer OPTIONAL,\r
+ IN EFI_PXE_BASE_CODE_PACKET *NewPxeDiscover OPTIONAL,\r
+ IN EFI_PXE_BASE_CODE_PACKET *NewPxeReply OPTIONAL,\r
+ IN EFI_PXE_BASE_CODE_PACKET *NewPxeBisReply OPTIONAL\r
)\r
{\r
PXEBC_PRIVATE_DATA *Private;\r
NULL\r
};\r
\r
-\r
/**\r
Callback function that is invoked when the PXE Base Code Protocol is about to transmit, has\r
received, or is waiting to receive a packet.\r
IN EFI_PXE_BASE_CODE_PACKET *PacketPtr OPTIONAL\r
)\r
{\r
- EFI_INPUT_KEY Key;\r
- EFI_STATUS Status;\r
+ EFI_INPUT_KEY Key;\r
+ EFI_STATUS Status;\r
\r
//\r
// Catch Ctrl-C or ESC to abort.\r
Status = gST->ConIn->ReadKeyStroke (gST->ConIn, &Key);\r
\r
if (!EFI_ERROR (Status)) {\r
-\r
- if (Key.ScanCode == SCAN_ESC || Key.UnicodeChar == (0x1F & 'c')) {\r
-\r
+ if ((Key.ScanCode == SCAN_ESC) || (Key.UnicodeChar == (0x1F & 'c'))) {\r
return EFI_PXE_BASE_CODE_CALLBACK_STATUS_ABORT;\r
}\r
}\r
+\r
//\r
// No print if receive packet\r
//\r
if (Received) {\r
return EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE;\r
}\r
+\r
//\r
// Print only for three functions\r
//\r
switch (Function) {\r
-\r
- case EFI_PXE_BASE_CODE_FUNCTION_MTFTP:\r
- //\r
- // Print only for open MTFTP packets, not every MTFTP packets\r
- //\r
- if (PacketLength != 0 && PacketPtr != NULL) {\r
- if (PacketPtr->Raw[0x1C] != 0x00 || PacketPtr->Raw[0x1D] != 0x01) {\r
- return EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE;\r
+ case EFI_PXE_BASE_CODE_FUNCTION_MTFTP:\r
+ //\r
+ // Print only for open MTFTP packets, not every MTFTP packets\r
+ //\r
+ if ((PacketLength != 0) && (PacketPtr != NULL)) {\r
+ if ((PacketPtr->Raw[0x1C] != 0x00) || (PacketPtr->Raw[0x1D] != 0x01)) {\r
+ return EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE;\r
+ }\r
}\r
- }\r
- break;\r
\r
- case EFI_PXE_BASE_CODE_FUNCTION_DHCP:\r
- case EFI_PXE_BASE_CODE_FUNCTION_DISCOVER:\r
- break;\r
+ break;\r
\r
- default:\r
- return EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE;\r
+ case EFI_PXE_BASE_CODE_FUNCTION_DHCP:\r
+ case EFI_PXE_BASE_CODE_FUNCTION_DISCOVER:\r
+ break;\r
+\r
+ default:\r
+ return EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE;\r
}\r
\r
- if (PacketLength != 0 && PacketPtr != NULL) {\r
+ if ((PacketLength != 0) && (PacketPtr != NULL)) {\r
//\r
// Print '.' when transmit a packet\r
//\r
return EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE;\r
}\r
\r
-EFI_PXE_BASE_CODE_CALLBACK_PROTOCOL gPxeBcCallBackTemplate = {\r
+EFI_PXE_BASE_CODE_CALLBACK_PROTOCOL gPxeBcCallBackTemplate = {\r
EFI_PXE_BASE_CODE_CALLBACK_PROTOCOL_REVISION,\r
EfiPxeLoadFileCallback\r
};\r
\r
-\r
/**\r
Causes the driver to load a specified file.\r
\r
EFI_STATUS\r
EFIAPI\r
EfiPxeLoadFile (\r
- IN EFI_LOAD_FILE_PROTOCOL *This,\r
- IN EFI_DEVICE_PATH_PROTOCOL *FilePath,\r
- IN BOOLEAN BootPolicy,\r
- IN OUT UINTN *BufferSize,\r
- IN VOID *Buffer OPTIONAL\r
+ IN EFI_LOAD_FILE_PROTOCOL *This,\r
+ IN EFI_DEVICE_PATH_PROTOCOL *FilePath,\r
+ IN BOOLEAN BootPolicy,\r
+ IN OUT UINTN *BufferSize,\r
+ IN VOID *Buffer OPTIONAL\r
)\r
{\r
PXEBC_PRIVATE_DATA *Private;\r
EFI_STATUS Status;\r
EFI_STATUS MediaStatus;\r
\r
- if (This == NULL || BufferSize == NULL || FilePath == NULL || !IsDevicePathEnd (FilePath)) {\r
+ if ((This == NULL) || (BufferSize == NULL) || (FilePath == NULL) || !IsDevicePathEnd (FilePath)) {\r
return EFI_INVALID_PARAMETER;\r
}\r
\r
// Start Pxe Base Code to initialize PXE boot.\r
//\r
Status = PxeBc->Start (PxeBc, UsingIpv6);\r
- if (Status == EFI_ALREADY_STARTED && UsingIpv6 != PxeBc->Mode->UsingIpv6) {\r
+ if ((Status == EFI_ALREADY_STARTED) && (UsingIpv6 != PxeBc->Mode->UsingIpv6)) {\r
//\r
// PxeBc protocol has already been started but not on the required IP version, restart it.\r
//\r
Status = PxeBc->Start (PxeBc, UsingIpv6);\r
}\r
}\r
- if (Status == EFI_SUCCESS || Status == EFI_ALREADY_STARTED) {\r
+\r
+ if ((Status == EFI_SUCCESS) || (Status == EFI_ALREADY_STARTED)) {\r
Status = PxeBcLoadBootFile (Private, BufferSize, Buffer);\r
}\r
\r
- if (Status != EFI_SUCCESS &&\r
- Status != EFI_UNSUPPORTED &&\r
- Status != EFI_BUFFER_TOO_SMALL) {\r
+ if ((Status != EFI_SUCCESS) &&\r
+ (Status != EFI_UNSUPPORTED) &&\r
+ (Status != EFI_BUFFER_TOO_SMALL))\r
+ {\r
//\r
// There are three cases, which needn't stop pxebc here.\r
// 1. success to download file.\r
projects / mirror_edk2.git / blobdiff