]> git.proxmox.com Git - mirror_edk2.git/blobdiff - OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Dxe.c
OvmfPkg: Apply uncrustify changes
[mirror_edk2.git] / OvmfPkg / Library / QemuFwCfgS3Lib / QemuFwCfgS3Dxe.c
index 4dcf4b1298863ee462299ef0fc6337a1cf6038e1..5706fa9be46af0865aaee9c5ceb84400ca0de283 100644 (file)
 #include <Library/UefiBootServicesTableLib.h>\r
 #include <Protocol/S3SaveState.h>\r
 \r
-\r
 //\r
 // Event to signal when the S3SaveState protocol interface is installed.\r
 //\r
-STATIC EFI_EVENT mS3SaveStateInstalledEvent;\r
+STATIC EFI_EVENT  mS3SaveStateInstalledEvent;\r
 \r
 //\r
 // Reference to the S3SaveState protocol interface, after it is installed.\r
 //\r
-STATIC EFI_S3_SAVE_STATE_PROTOCOL *mS3SaveState;\r
+STATIC EFI_S3_SAVE_STATE_PROTOCOL  *mS3SaveState;\r
 \r
 //\r
 // The control structure is allocated in reserved memory, aligned at 8 bytes.\r
 // The client-requested ScratchBuffer will be allocated adjacently, also\r
 // aligned at 8 bytes.\r
 //\r
-#define RESERVED_MEM_ALIGNMENT 8\r
+#define RESERVED_MEM_ALIGNMENT  8\r
 \r
-STATIC FW_CFG_DMA_ACCESS *mDmaAccess;\r
-STATIC VOID              *mScratchBuffer;\r
-STATIC UINTN             mScratchBufferSize;\r
+STATIC FW_CFG_DMA_ACCESS  *mDmaAccess;\r
+STATIC VOID               *mScratchBuffer;\r
+STATIC UINTN              mScratchBufferSize;\r
 \r
 //\r
 // Callback provided by the client, for appending ACPI S3 Boot Script opcodes.\r
 // To be called from S3SaveStateInstalledNotify().\r
 //\r
-STATIC FW_CFG_BOOT_SCRIPT_CALLBACK_FUNCTION *mCallback;\r
-\r
+STATIC FW_CFG_BOOT_SCRIPT_CALLBACK_FUNCTION  *mCallback;\r
 \r
 /**\r
   Event notification function for mS3SaveStateInstalledEvent.\r
@@ -50,32 +48,40 @@ STATIC
 VOID\r
 EFIAPI\r
 S3SaveStateInstalledNotify (\r
-  IN EFI_EVENT Event,\r
-  IN VOID      *Context\r
+  IN EFI_EVENT  Event,\r
+  IN VOID       *Context\r
   )\r
 {\r
-  EFI_STATUS Status;\r
+  EFI_STATUS  Status;\r
 \r
   ASSERT (Event == mS3SaveStateInstalledEvent);\r
 \r
-  Status = gBS->LocateProtocol (&gEfiS3SaveStateProtocolGuid,\r
-                  NULL /* Registration */, (VOID **)&mS3SaveState);\r
+  Status = gBS->LocateProtocol (\r
+                  &gEfiS3SaveStateProtocolGuid,\r
+                  NULL /* Registration */,\r
+                  (VOID **)&mS3SaveState\r
+                  );\r
   if (EFI_ERROR (Status)) {\r
     return;\r
   }\r
 \r
   ASSERT (mCallback != NULL);\r
 \r
-  DEBUG ((DEBUG_INFO, "%a: %a: DmaAccess@0x%Lx ScratchBuffer@[0x%Lx+0x%Lx]\n",\r
-    gEfiCallerBaseName, __FUNCTION__, (UINT64)(UINTN)mDmaAccess,\r
-    (UINT64)(UINTN)mScratchBuffer, (UINT64)mScratchBufferSize));\r
+  DEBUG ((\r
+    DEBUG_INFO,\r
+    "%a: %a: DmaAccess@0x%Lx ScratchBuffer@[0x%Lx+0x%Lx]\n",\r
+    gEfiCallerBaseName,\r
+    __FUNCTION__,\r
+    (UINT64)(UINTN)mDmaAccess,\r
+    (UINT64)(UINTN)mScratchBuffer,\r
+    (UINT64)mScratchBufferSize\r
+    ));\r
   mCallback (Context, mScratchBuffer);\r
 \r
   gBS->CloseEvent (mS3SaveStateInstalledEvent);\r
   mS3SaveStateInstalledEvent = NULL;\r
 }\r
 \r
-\r
 /**\r
   Install the client module's FW_CFG_BOOT_SCRIPT_CALLBACK_FUNCTION callback for\r
   when the production of ACPI S3 Boot Script opcodes becomes possible.\r
@@ -136,13 +142,13 @@ S3SaveStateInstalledNotify (
 RETURN_STATUS\r
 EFIAPI\r
 QemuFwCfgS3CallWhenBootScriptReady (\r
-  IN     FW_CFG_BOOT_SCRIPT_CALLBACK_FUNCTION *Callback,\r
-  IN OUT VOID                                 *Context           OPTIONAL,\r
-  IN     UINTN                                ScratchBufferSize\r
+  IN     FW_CFG_BOOT_SCRIPT_CALLBACK_FUNCTION  *Callback,\r
+  IN OUT VOID                                  *Context           OPTIONAL,\r
+  IN     UINTN                                 ScratchBufferSize\r
   )\r
 {\r
-  EFI_STATUS Status;\r
-  VOID       *Registration;\r
+  EFI_STATUS  Status;\r
+  VOID        *Registration;\r
 \r
   //\r
   // Basic fw_cfg is certainly available, as we can only be here after a\r
@@ -151,8 +157,12 @@ QemuFwCfgS3CallWhenBootScriptReady (
   ASSERT (QemuFwCfgIsAvailable ());\r
   QemuFwCfgSelectItem (QemuFwCfgItemInterfaceVersion);\r
   if ((QemuFwCfgRead32 () & FW_CFG_F_DMA) == 0) {\r
-    DEBUG ((DEBUG_ERROR, "%a: %a: fw_cfg DMA unavailable\n",\r
-      gEfiCallerBaseName, __FUNCTION__));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "%a: %a: fw_cfg DMA unavailable\n",\r
+      gEfiCallerBaseName,\r
+      __FUNCTION__\r
+      ));\r
     return RETURN_NOT_FOUND;\r
   }\r
 \r
@@ -161,37 +171,69 @@ QemuFwCfgS3CallWhenBootScriptReady (
   // client data together.\r
   //\r
   if (ScratchBufferSize >\r
-      MAX_UINT32 - (RESERVED_MEM_ALIGNMENT - 1) - sizeof *mDmaAccess) {\r
-    DEBUG ((DEBUG_ERROR, "%a: %a: ScratchBufferSize too big: %Lu\n",\r
-      gEfiCallerBaseName, __FUNCTION__, (UINT64)ScratchBufferSize));\r
+      MAX_UINT32 - (RESERVED_MEM_ALIGNMENT - 1) - sizeof *mDmaAccess)\r
+  {\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "%a: %a: ScratchBufferSize too big: %Lu\n",\r
+      gEfiCallerBaseName,\r
+      __FUNCTION__,\r
+      (UINT64)ScratchBufferSize\r
+      ));\r
     return RETURN_BAD_BUFFER_SIZE;\r
   }\r
-  mDmaAccess = AllocateReservedPool ((RESERVED_MEM_ALIGNMENT - 1) +\r
-                 sizeof *mDmaAccess + ScratchBufferSize);\r
+\r
+  mDmaAccess = AllocateReservedPool (\r
+                 (RESERVED_MEM_ALIGNMENT - 1) +\r
+                 sizeof *mDmaAccess + ScratchBufferSize\r
+                 );\r
   if (mDmaAccess == NULL) {\r
-    DEBUG ((DEBUG_ERROR, "%a: %a: AllocateReservedPool(): out of resources\n",\r
-      gEfiCallerBaseName, __FUNCTION__));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "%a: %a: AllocateReservedPool(): out of resources\n",\r
+      gEfiCallerBaseName,\r
+      __FUNCTION__\r
+      ));\r
     return RETURN_OUT_OF_RESOURCES;\r
   }\r
+\r
   mDmaAccess = ALIGN_POINTER (mDmaAccess, RESERVED_MEM_ALIGNMENT);\r
 \r
   //\r
   // Set up a protocol notify for EFI_S3_SAVE_STATE_PROTOCOL. Forward the\r
   // client's Context to the callback.\r
   //\r
-  Status = gBS->CreateEvent (EVT_NOTIFY_SIGNAL, TPL_CALLBACK,\r
-                  S3SaveStateInstalledNotify, Context,\r
-                  &mS3SaveStateInstalledEvent);\r
+  Status = gBS->CreateEvent (\r
+                  EVT_NOTIFY_SIGNAL,\r
+                  TPL_CALLBACK,\r
+                  S3SaveStateInstalledNotify,\r
+                  Context,\r
+                  &mS3SaveStateInstalledEvent\r
+                  );\r
   if (EFI_ERROR (Status)) {\r
-    DEBUG ((DEBUG_ERROR, "%a: %a: CreateEvent(): %r\n", gEfiCallerBaseName,\r
-      __FUNCTION__, Status));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "%a: %a: CreateEvent(): %r\n",\r
+      gEfiCallerBaseName,\r
+      __FUNCTION__,\r
+      Status\r
+      ));\r
     goto FreeDmaAccess;\r
   }\r
-  Status = gBS->RegisterProtocolNotify (&gEfiS3SaveStateProtocolGuid,\r
-                  mS3SaveStateInstalledEvent, &Registration);\r
+\r
+  Status = gBS->RegisterProtocolNotify (\r
+                  &gEfiS3SaveStateProtocolGuid,\r
+                  mS3SaveStateInstalledEvent,\r
+                  &Registration\r
+                  );\r
   if (EFI_ERROR (Status)) {\r
-    DEBUG ((DEBUG_ERROR, "%a: %a: RegisterProtocolNotify(): %r\n",\r
-      gEfiCallerBaseName, __FUNCTION__, Status));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "%a: %a: RegisterProtocolNotify(): %r\n",\r
+      gEfiCallerBaseName,\r
+      __FUNCTION__,\r
+      Status\r
+      ));\r
     goto CloseEvent;\r
   }\r
 \r
@@ -201,26 +243,31 @@ QemuFwCfgS3CallWhenBootScriptReady (
   // integral multiple of RESERVED_MEM_ALIGNMENT.\r
   //\r
   ASSERT (sizeof *mDmaAccess % RESERVED_MEM_ALIGNMENT == 0);\r
-  mScratchBuffer = mDmaAccess + 1;\r
+  mScratchBuffer     = mDmaAccess + 1;\r
   mScratchBufferSize = ScratchBufferSize;\r
-  mCallback = Callback;\r
+  mCallback          = Callback;\r
 \r
   //\r
   // Kick the event; EFI_S3_SAVE_STATE_PROTOCOL could be available already.\r
   //\r
   Status = gBS->SignalEvent (mS3SaveStateInstalledEvent);\r
   if (EFI_ERROR (Status)) {\r
-    DEBUG ((DEBUG_ERROR, "%a: %a: SignalEvent(): %r\n", gEfiCallerBaseName,\r
-      __FUNCTION__, Status));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "%a: %a: SignalEvent(): %r\n",\r
+      gEfiCallerBaseName,\r
+      __FUNCTION__,\r
+      Status\r
+      ));\r
     goto NullGlobals;\r
   }\r
 \r
   return RETURN_SUCCESS;\r
 \r
 NullGlobals:\r
-  mScratchBuffer = NULL;\r
+  mScratchBuffer     = NULL;\r
   mScratchBufferSize = 0;\r
-  mCallback = NULL;\r
+  mCallback          = NULL;\r
 \r
 CloseEvent:\r
   gBS->CloseEvent (mS3SaveStateInstalledEvent);\r
@@ -233,7 +280,6 @@ FreeDmaAccess:
   return (RETURN_STATUS)Status;\r
 }\r
 \r
-\r
 /**\r
   Produce ACPI S3 Boot Script opcodes that (optionally) select an fw_cfg item,\r
   and transfer data to it.\r
@@ -277,22 +323,23 @@ FreeDmaAccess:
 RETURN_STATUS\r
 EFIAPI\r
 QemuFwCfgS3ScriptWriteBytes (\r
-  IN INT32 FirmwareConfigItem,\r
-  IN UINTN NumberOfBytes\r
+  IN INT32  FirmwareConfigItem,\r
+  IN UINTN  NumberOfBytes\r
   )\r
 {\r
-  UINTN      Count;\r
-  EFI_STATUS Status;\r
-  UINT64     AccessAddress;\r
-  UINT32     ControlPollData;\r
-  UINT32     ControlPollMask;\r
+  UINTN       Count;\r
+  EFI_STATUS  Status;\r
+  UINT64      AccessAddress;\r
+  UINT32      ControlPollData;\r
+  UINT32      ControlPollMask;\r
 \r
   ASSERT (mDmaAccess != NULL);\r
   ASSERT (mS3SaveState != NULL);\r
 \r
-  if (FirmwareConfigItem < -1 || FirmwareConfigItem > MAX_UINT16) {\r
+  if ((FirmwareConfigItem < -1) || (FirmwareConfigItem > MAX_UINT16)) {\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
+\r
   if (NumberOfBytes > mScratchBufferSize) {\r
     return RETURN_BAD_BUFFER_SIZE;\r
   }\r
@@ -305,6 +352,7 @@ QemuFwCfgS3ScriptWriteBytes (
     mDmaAccess->Control |= FW_CFG_DMA_CTL_SELECT;\r
     mDmaAccess->Control |= (UINT32)FirmwareConfigItem << 16;\r
   }\r
+\r
   mDmaAccess->Control = SwapBytes32 (mDmaAccess->Control);\r
 \r
   //\r
@@ -321,7 +369,7 @@ QemuFwCfgS3ScriptWriteBytes (
   // script. When executed at S3 resume, this opcode will restore all of them\r
   // in-place.\r
   //\r
-  Count = (UINTN)mScratchBuffer + NumberOfBytes - (UINTN)mDmaAccess;\r
+  Count  = (UINTN)mScratchBuffer + NumberOfBytes - (UINTN)mDmaAccess;\r
   Status = mS3SaveState->Write (\r
                            mS3SaveState,                     // This\r
                            EFI_BOOT_SCRIPT_MEM_WRITE_OPCODE, // OpCode\r
@@ -331,8 +379,13 @@ QemuFwCfgS3ScriptWriteBytes (
                            (VOID *)mDmaAccess                // Buffer\r
                            );\r
   if (EFI_ERROR (Status)) {\r
-    DEBUG ((DEBUG_ERROR, "%a: %a: EFI_BOOT_SCRIPT_MEM_WRITE_OPCODE: %r\n",\r
-      gEfiCallerBaseName, __FUNCTION__, Status));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "%a: %a: EFI_BOOT_SCRIPT_MEM_WRITE_OPCODE: %r\n",\r
+      gEfiCallerBaseName,\r
+      __FUNCTION__,\r
+      Status\r
+      ));\r
     return (RETURN_STATUS)Status;\r
   }\r
 \r
@@ -343,17 +396,22 @@ QemuFwCfgS3ScriptWriteBytes (
   // transfer.\r
   //\r
   AccessAddress = SwapBytes64 ((UINTN)mDmaAccess);\r
-  Status = mS3SaveState->Write (\r
-                           mS3SaveState,                    // This\r
-                           EFI_BOOT_SCRIPT_IO_WRITE_OPCODE, // OpCode\r
-                           EfiBootScriptWidthUint32,        // Width\r
-                           (UINT64)FW_CFG_IO_DMA_ADDRESS,   // Address\r
-                           (UINTN)2,                        // Count\r
-                           (VOID *)&AccessAddress           // Buffer\r
-                           );\r
+  Status        = mS3SaveState->Write (\r
+                                  mS3SaveState,                    // This\r
+                                  EFI_BOOT_SCRIPT_IO_WRITE_OPCODE, // OpCode\r
+                                  EfiBootScriptWidthUint32,        // Width\r
+                                  (UINT64)FW_CFG_IO_DMA_ADDRESS,   // Address\r
+                                  (UINTN)2,                        // Count\r
+                                  (VOID *)&AccessAddress           // Buffer\r
+                                  );\r
   if (EFI_ERROR (Status)) {\r
-    DEBUG ((DEBUG_ERROR, "%a: %a: EFI_BOOT_SCRIPT_IO_WRITE_OPCODE: %r\n",\r
-      gEfiCallerBaseName, __FUNCTION__, Status));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "%a: %a: EFI_BOOT_SCRIPT_IO_WRITE_OPCODE: %r\n",\r
+      gEfiCallerBaseName,\r
+      __FUNCTION__,\r
+      Status\r
+      ));\r
     return (RETURN_STATUS)Status;\r
   }\r
 \r
@@ -364,25 +422,29 @@ QemuFwCfgS3ScriptWriteBytes (
   //\r
   ControlPollData = 0;\r
   ControlPollMask = MAX_UINT32;\r
-  Status = mS3SaveState->Write (\r
-                           mS3SaveState,                        // This\r
-                           EFI_BOOT_SCRIPT_MEM_POLL_OPCODE,     // OpCode\r
-                           EfiBootScriptWidthUint32,            // Width\r
-                           (UINT64)(UINTN)&mDmaAccess->Control, // Address\r
-                           (VOID *)&ControlPollData,            // Data\r
-                           (VOID *)&ControlPollMask,            // DataMask\r
-                           MAX_UINT64                           // Delay\r
-                           );\r
+  Status          = mS3SaveState->Write (\r
+                                    mS3SaveState,                        // This\r
+                                    EFI_BOOT_SCRIPT_MEM_POLL_OPCODE,     // OpCode\r
+                                    EfiBootScriptWidthUint32,            // Width\r
+                                    (UINT64)(UINTN)&mDmaAccess->Control, // Address\r
+                                    (VOID *)&ControlPollData,            // Data\r
+                                    (VOID *)&ControlPollMask,            // DataMask\r
+                                    MAX_UINT64                           // Delay\r
+                                    );\r
   if (EFI_ERROR (Status)) {\r
-    DEBUG ((DEBUG_ERROR, "%a: %a: EFI_BOOT_SCRIPT_MEM_POLL_OPCODE: %r\n",\r
-      gEfiCallerBaseName, __FUNCTION__, Status));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "%a: %a: EFI_BOOT_SCRIPT_MEM_POLL_OPCODE: %r\n",\r
+      gEfiCallerBaseName,\r
+      __FUNCTION__,\r
+      Status\r
+      ));\r
     return (RETURN_STATUS)Status;\r
   }\r
 \r
   return RETURN_SUCCESS;\r
 }\r
 \r
-\r
 /**\r
   Produce ACPI S3 Boot Script opcodes that (optionally) select an fw_cfg item,\r
   and transfer data from it.\r
@@ -425,21 +487,22 @@ QemuFwCfgS3ScriptWriteBytes (
 RETURN_STATUS\r
 EFIAPI\r
 QemuFwCfgS3ScriptReadBytes (\r
-  IN INT32 FirmwareConfigItem,\r
-  IN UINTN NumberOfBytes\r
+  IN INT32  FirmwareConfigItem,\r
+  IN UINTN  NumberOfBytes\r
   )\r
 {\r
-  EFI_STATUS Status;\r
-  UINT64     AccessAddress;\r
-  UINT32     ControlPollData;\r
-  UINT32     ControlPollMask;\r
+  EFI_STATUS  Status;\r
+  UINT64      AccessAddress;\r
+  UINT32      ControlPollData;\r
+  UINT32      ControlPollMask;\r
 \r
   ASSERT (mDmaAccess != NULL);\r
   ASSERT (mS3SaveState != NULL);\r
 \r
-  if (FirmwareConfigItem < -1 || FirmwareConfigItem > MAX_UINT16) {\r
+  if ((FirmwareConfigItem < -1) || (FirmwareConfigItem > MAX_UINT16)) {\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
+\r
   if (NumberOfBytes > mScratchBufferSize) {\r
     return RETURN_BAD_BUFFER_SIZE;\r
   }\r
@@ -452,6 +515,7 @@ QemuFwCfgS3ScriptReadBytes (
     mDmaAccess->Control |= FW_CFG_DMA_CTL_SELECT;\r
     mDmaAccess->Control |= (UINT32)FirmwareConfigItem << 16;\r
   }\r
+\r
   mDmaAccess->Control = SwapBytes32 (mDmaAccess->Control);\r
 \r
   //\r
@@ -476,8 +540,13 @@ QemuFwCfgS3ScriptReadBytes (
                            (VOID *)mDmaAccess                // Buffer\r
                            );\r
   if (EFI_ERROR (Status)) {\r
-    DEBUG ((DEBUG_ERROR, "%a: %a: EFI_BOOT_SCRIPT_MEM_WRITE_OPCODE: %r\n",\r
-      gEfiCallerBaseName, __FUNCTION__, Status));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "%a: %a: EFI_BOOT_SCRIPT_MEM_WRITE_OPCODE: %r\n",\r
+      gEfiCallerBaseName,\r
+      __FUNCTION__,\r
+      Status\r
+      ));\r
     return (RETURN_STATUS)Status;\r
   }\r
 \r
@@ -488,17 +557,22 @@ QemuFwCfgS3ScriptReadBytes (
   // transfer.\r
   //\r
   AccessAddress = SwapBytes64 ((UINTN)mDmaAccess);\r
-  Status = mS3SaveState->Write (\r
-                           mS3SaveState,                    // This\r
-                           EFI_BOOT_SCRIPT_IO_WRITE_OPCODE, // OpCode\r
-                           EfiBootScriptWidthUint32,        // Width\r
-                           (UINT64)FW_CFG_IO_DMA_ADDRESS,   // Address\r
-                           (UINTN)2,                        // Count\r
-                           (VOID *)&AccessAddress           // Buffer\r
-                           );\r
+  Status        = mS3SaveState->Write (\r
+                                  mS3SaveState,                    // This\r
+                                  EFI_BOOT_SCRIPT_IO_WRITE_OPCODE, // OpCode\r
+                                  EfiBootScriptWidthUint32,        // Width\r
+                                  (UINT64)FW_CFG_IO_DMA_ADDRESS,   // Address\r
+                                  (UINTN)2,                        // Count\r
+                                  (VOID *)&AccessAddress           // Buffer\r
+                                  );\r
   if (EFI_ERROR (Status)) {\r
-    DEBUG ((DEBUG_ERROR, "%a: %a: EFI_BOOT_SCRIPT_IO_WRITE_OPCODE: %r\n",\r
-      gEfiCallerBaseName, __FUNCTION__, Status));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "%a: %a: EFI_BOOT_SCRIPT_IO_WRITE_OPCODE: %r\n",\r
+      gEfiCallerBaseName,\r
+      __FUNCTION__,\r
+      Status\r
+      ));\r
     return (RETURN_STATUS)Status;\r
   }\r
 \r
@@ -509,25 +583,29 @@ QemuFwCfgS3ScriptReadBytes (
   //\r
   ControlPollData = 0;\r
   ControlPollMask = MAX_UINT32;\r
-  Status = mS3SaveState->Write (\r
-                           mS3SaveState,                        // This\r
-                           EFI_BOOT_SCRIPT_MEM_POLL_OPCODE,     // OpCode\r
-                           EfiBootScriptWidthUint32,            // Width\r
-                           (UINT64)(UINTN)&mDmaAccess->Control, // Address\r
-                           (VOID *)&ControlPollData,            // Data\r
-                           (VOID *)&ControlPollMask,            // DataMask\r
-                           MAX_UINT64                           // Delay\r
-                           );\r
+  Status          = mS3SaveState->Write (\r
+                                    mS3SaveState,                        // This\r
+                                    EFI_BOOT_SCRIPT_MEM_POLL_OPCODE,     // OpCode\r
+                                    EfiBootScriptWidthUint32,            // Width\r
+                                    (UINT64)(UINTN)&mDmaAccess->Control, // Address\r
+                                    (VOID *)&ControlPollData,            // Data\r
+                                    (VOID *)&ControlPollMask,            // DataMask\r
+                                    MAX_UINT64                           // Delay\r
+                                    );\r
   if (EFI_ERROR (Status)) {\r
-    DEBUG ((DEBUG_ERROR, "%a: %a: EFI_BOOT_SCRIPT_MEM_POLL_OPCODE: %r\n",\r
-      gEfiCallerBaseName, __FUNCTION__, Status));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "%a: %a: EFI_BOOT_SCRIPT_MEM_POLL_OPCODE: %r\n",\r
+      gEfiCallerBaseName,\r
+      __FUNCTION__,\r
+      Status\r
+      ));\r
     return (RETURN_STATUS)Status;\r
   }\r
 \r
   return RETURN_SUCCESS;\r
 }\r
 \r
-\r
 /**\r
   Produce ACPI S3 Boot Script opcodes that (optionally) select an fw_cfg item,\r
   and increase its offset.\r
@@ -563,21 +641,22 @@ QemuFwCfgS3ScriptReadBytes (
 RETURN_STATUS\r
 EFIAPI\r
 QemuFwCfgS3ScriptSkipBytes (\r
-  IN INT32 FirmwareConfigItem,\r
-  IN UINTN NumberOfBytes\r
+  IN INT32  FirmwareConfigItem,\r
+  IN UINTN  NumberOfBytes\r
   )\r
 {\r
-  EFI_STATUS Status;\r
-  UINT64     AccessAddress;\r
-  UINT32     ControlPollData;\r
-  UINT32     ControlPollMask;\r
+  EFI_STATUS  Status;\r
+  UINT64      AccessAddress;\r
+  UINT32      ControlPollData;\r
+  UINT32      ControlPollMask;\r
 \r
   ASSERT (mDmaAccess != NULL);\r
   ASSERT (mS3SaveState != NULL);\r
 \r
-  if (FirmwareConfigItem < -1 || FirmwareConfigItem > MAX_UINT16) {\r
+  if ((FirmwareConfigItem < -1) || (FirmwareConfigItem > MAX_UINT16)) {\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
+\r
   if (NumberOfBytes > MAX_UINT32) {\r
     return RETURN_BAD_BUFFER_SIZE;\r
   }\r
@@ -590,9 +669,10 @@ QemuFwCfgS3ScriptSkipBytes (
     mDmaAccess->Control |= FW_CFG_DMA_CTL_SELECT;\r
     mDmaAccess->Control |= (UINT32)FirmwareConfigItem << 16;\r
   }\r
+\r
   mDmaAccess->Control = SwapBytes32 (mDmaAccess->Control);\r
 \r
-  mDmaAccess->Length = SwapBytes32 ((UINT32)NumberOfBytes);\r
+  mDmaAccess->Length  = SwapBytes32 ((UINT32)NumberOfBytes);\r
   mDmaAccess->Address = 0;\r
 \r
   //\r
@@ -608,8 +688,13 @@ QemuFwCfgS3ScriptSkipBytes (
                            (VOID *)mDmaAccess                // Buffer\r
                            );\r
   if (EFI_ERROR (Status)) {\r
-    DEBUG ((DEBUG_ERROR, "%a: %a: EFI_BOOT_SCRIPT_MEM_WRITE_OPCODE: %r\n",\r
-      gEfiCallerBaseName, __FUNCTION__, Status));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "%a: %a: EFI_BOOT_SCRIPT_MEM_WRITE_OPCODE: %r\n",\r
+      gEfiCallerBaseName,\r
+      __FUNCTION__,\r
+      Status\r
+      ));\r
     return (RETURN_STATUS)Status;\r
   }\r
 \r
@@ -620,17 +705,22 @@ QemuFwCfgS3ScriptSkipBytes (
   // transfer.\r
   //\r
   AccessAddress = SwapBytes64 ((UINTN)mDmaAccess);\r
-  Status = mS3SaveState->Write (\r
-                           mS3SaveState,                    // This\r
-                           EFI_BOOT_SCRIPT_IO_WRITE_OPCODE, // OpCode\r
-                           EfiBootScriptWidthUint32,        // Width\r
-                           (UINT64)FW_CFG_IO_DMA_ADDRESS,   // Address\r
-                           (UINTN)2,                        // Count\r
-                           (VOID *)&AccessAddress           // Buffer\r
-                           );\r
+  Status        = mS3SaveState->Write (\r
+                                  mS3SaveState,                    // This\r
+                                  EFI_BOOT_SCRIPT_IO_WRITE_OPCODE, // OpCode\r
+                                  EfiBootScriptWidthUint32,        // Width\r
+                                  (UINT64)FW_CFG_IO_DMA_ADDRESS,   // Address\r
+                                  (UINTN)2,                        // Count\r
+                                  (VOID *)&AccessAddress           // Buffer\r
+                                  );\r
   if (EFI_ERROR (Status)) {\r
-    DEBUG ((DEBUG_ERROR, "%a: %a: EFI_BOOT_SCRIPT_IO_WRITE_OPCODE: %r\n",\r
-      gEfiCallerBaseName, __FUNCTION__, Status));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "%a: %a: EFI_BOOT_SCRIPT_IO_WRITE_OPCODE: %r\n",\r
+      gEfiCallerBaseName,\r
+      __FUNCTION__,\r
+      Status\r
+      ));\r
     return (RETURN_STATUS)Status;\r
   }\r
 \r
@@ -641,25 +731,29 @@ QemuFwCfgS3ScriptSkipBytes (
   //\r
   ControlPollData = 0;\r
   ControlPollMask = MAX_UINT32;\r
-  Status = mS3SaveState->Write (\r
-                           mS3SaveState,                        // This\r
-                           EFI_BOOT_SCRIPT_MEM_POLL_OPCODE,     // OpCode\r
-                           EfiBootScriptWidthUint32,            // Width\r
-                           (UINT64)(UINTN)&mDmaAccess->Control, // Address\r
-                           (VOID *)&ControlPollData,            // Data\r
-                           (VOID *)&ControlPollMask,            // DataMask\r
-                           MAX_UINT64                           // Delay\r
-                           );\r
+  Status          = mS3SaveState->Write (\r
+                                    mS3SaveState,                        // This\r
+                                    EFI_BOOT_SCRIPT_MEM_POLL_OPCODE,     // OpCode\r
+                                    EfiBootScriptWidthUint32,            // Width\r
+                                    (UINT64)(UINTN)&mDmaAccess->Control, // Address\r
+                                    (VOID *)&ControlPollData,            // Data\r
+                                    (VOID *)&ControlPollMask,            // DataMask\r
+                                    MAX_UINT64                           // Delay\r
+                                    );\r
   if (EFI_ERROR (Status)) {\r
-    DEBUG ((DEBUG_ERROR, "%a: %a: EFI_BOOT_SCRIPT_MEM_POLL_OPCODE: %r\n",\r
-      gEfiCallerBaseName, __FUNCTION__, Status));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "%a: %a: EFI_BOOT_SCRIPT_MEM_POLL_OPCODE: %r\n",\r
+      gEfiCallerBaseName,\r
+      __FUNCTION__,\r
+      Status\r
+      ));\r
     return (RETURN_STATUS)Status;\r
   }\r
 \r
   return RETURN_SUCCESS;\r
 }\r
 \r
-\r
 /**\r
   Produce ACPI S3 Boot Script opcodes that check a value in ScratchBuffer.\r
 \r
@@ -713,41 +807,42 @@ QemuFwCfgS3ScriptSkipBytes (
 RETURN_STATUS\r
 EFIAPI\r
 QemuFwCfgS3ScriptCheckValue (\r
-  IN VOID   *ScratchData,\r
-  IN UINT8  ValueSize,\r
-  IN UINT64 ValueMask,\r
-  IN UINT64 Value\r
+  IN VOID    *ScratchData,\r
+  IN UINT8   ValueSize,\r
+  IN UINT64  ValueMask,\r
+  IN UINT64  Value\r
   )\r
 {\r
-  EFI_BOOT_SCRIPT_WIDTH Width;\r
-  EFI_STATUS            Status;\r
+  EFI_BOOT_SCRIPT_WIDTH  Width;\r
+  EFI_STATUS             Status;\r
 \r
   ASSERT (mS3SaveState != NULL);\r
 \r
   switch (ValueSize) {\r
-  case 1:\r
-    Width = EfiBootScriptWidthUint8;\r
-    break;\r
+    case 1:\r
+      Width = EfiBootScriptWidthUint8;\r
+      break;\r
 \r
-  case 2:\r
-    Width = EfiBootScriptWidthUint16;\r
-    break;\r
+    case 2:\r
+      Width = EfiBootScriptWidthUint16;\r
+      break;\r
 \r
-  case 4:\r
-    Width = EfiBootScriptWidthUint32;\r
-    break;\r
+    case 4:\r
+      Width = EfiBootScriptWidthUint32;\r
+      break;\r
 \r
-  case 8:\r
-    Width = EfiBootScriptWidthUint64;\r
-    break;\r
+    case 8:\r
+      Width = EfiBootScriptWidthUint64;\r
+      break;\r
 \r
-  default:\r
-    return RETURN_INVALID_PARAMETER;\r
+    default:\r
+      return RETURN_INVALID_PARAMETER;\r
   }\r
 \r
-  if (ValueSize < 8 &&\r
-      (RShiftU64 (ValueMask, ValueSize * 8) > 0 ||\r
-       RShiftU64 (Value, ValueSize * 8) > 0)) {\r
+  if ((ValueSize < 8) &&\r
+      ((RShiftU64 (ValueMask, ValueSize * 8) > 0) ||\r
+       (RShiftU64 (Value, ValueSize * 8) > 0)))\r
+  {\r
     return RETURN_INVALID_PARAMETER;\r
   }\r
 \r
@@ -758,7 +853,8 @@ QemuFwCfgS3ScriptCheckValue (
   if (((UINTN)ScratchData < (UINTN)mScratchBuffer) ||\r
       ((UINTN)ScratchData > MAX_UINTN - ValueSize) ||\r
       ((UINTN)ScratchData + ValueSize >\r
-       (UINTN)mScratchBuffer + mScratchBufferSize)) {\r
+       (UINTN)mScratchBuffer + mScratchBufferSize))\r
+  {\r
     return RETURN_BAD_BUFFER_SIZE;\r
   }\r
 \r
@@ -777,8 +873,13 @@ QemuFwCfgS3ScriptCheckValue (
                            MAX_UINT64                       // Delay\r
                            );\r
   if (EFI_ERROR (Status)) {\r
-    DEBUG ((DEBUG_ERROR, "%a: %a: EFI_BOOT_SCRIPT_MEM_POLL_OPCODE: %r\n",\r
-      gEfiCallerBaseName, __FUNCTION__, Status));\r
+    DEBUG ((\r
+      DEBUG_ERROR,\r
+      "%a: %a: EFI_BOOT_SCRIPT_MEM_POLL_OPCODE: %r\n",\r
+      gEfiCallerBaseName,\r
+      __FUNCTION__,\r
+      Status\r
+      ));\r
     return (RETURN_STATUS)Status;\r
   }\r
 \r