StandaloneMmPkg: Replace DEBUG_INFO with DEBUG_ERROR

[mirror_edk2.git] / StandaloneMmPkg / Drivers / StandaloneMmCpu / EventHandle.c

diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c b/StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c
index 165d696f99051e06f0e0d45f2f586d48584b61be..556fd21451dab7ac3a2d9d4cfa51b001aa92faec 100644 (file)
--- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c
+++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c
@@ -11,7 +11,6 @@
 #include <Base.h>\r
 #include <Pi/PiMmCis.h>\r
 \r
-\r
 #include <Library/ArmSvcLib.h>\r
 #include <Library/ArmLib.h>\r
 #include <Library/BaseMemoryLib.h>\r
@@ -32,7 +31,7 @@ EFI_STATUS
 EFIAPI\r
 MmFoundationEntryRegister (\r
   IN CONST EFI_MM_CONFIGURATION_PROTOCOL  *This,\r
-  IN EFI_MM_ENTRY_POINT                    MmEntryPoint\r
+  IN EFI_MM_ENTRY_POINT                   MmEntryPoint\r
   );\r
 \r
 //\r
@@ -46,19 +45,19 @@ MmFoundationEntryRegister (
 // number of CPUs in the system are made known through the\r
 // MP_INFORMATION_HOB_DATA.\r
 //\r
-EFI_MM_COMMUNICATE_HEADER **PerCpuGuidedEventContext = NULL;\r
+EFI_MM_COMMUNICATE_HEADER  **PerCpuGuidedEventContext = NULL;\r
 \r
 // Descriptor with whereabouts of memory used for communication with the normal world\r
 EFI_MMRAM_DESCRIPTOR  mNsCommBuffer;\r
 \r
-MP_INFORMATION_HOB_DATA *mMpInformationHobData;\r
+MP_INFORMATION_HOB_DATA  *mMpInformationHobData;\r
 \r
-EFI_MM_CONFIGURATION_PROTOCOL mMmConfig = {\r
+EFI_MM_CONFIGURATION_PROTOCOL  mMmConfig = {\r
   0,\r
   MmFoundationEntryRegister\r
 };\r
 \r
-STATIC EFI_MM_ENTRY_POINT     mMmEntryPoint = NULL;\r
+STATIC EFI_MM_ENTRY_POINT  mMmEntryPoint = NULL;\r
 \r
 /**\r
   The PI Standalone MM entry point for the TF-A CPU driver.\r
@@ -75,15 +74,15 @@ STATIC EFI_MM_ENTRY_POINT     mMmEntryPoint = NULL;
 **/\r
 EFI_STATUS\r
 PiMmStandaloneArmTfCpuDriverEntry (\r
-  IN UINTN EventId,\r
-  IN UINTN CpuNumber,\r
-  IN UINTN NsCommBufferAddr\r
+  IN UINTN  EventId,\r
+  IN UINTN  CpuNumber,\r
+  IN UINTN  NsCommBufferAddr\r
   )\r
 {\r
-  EFI_MM_COMMUNICATE_HEADER   *GuidedEventContext;\r
-  EFI_MM_ENTRY_CONTEXT        MmEntryPointContext;\r
-  EFI_STATUS                  Status;\r
-  UINTN                       NsCommBufferSize;\r
+  EFI_MM_COMMUNICATE_HEADER  *GuidedEventContext;\r
+  EFI_MM_ENTRY_CONTEXT       MmEntryPointContext;\r
+  EFI_STATUS                 Status;\r
+  UINTN                      NsCommBufferSize;\r
 \r
   DEBUG ((DEBUG_INFO, "Received event - 0x%x on cpu %d\n", EventId, CpuNumber));\r
 \r
@@ -94,8 +93,9 @@ PiMmStandaloneArmTfCpuDriverEntry (
   // between synchronous and asynchronous events.\r
   //\r
   if ((ARM_SMC_ID_MM_COMMUNICATE != EventId) &&\r
-      (ARM_SVC_ID_FFA_MSG_SEND_DIRECT_REQ != EventId)) {\r
-    DEBUG ((DEBUG_INFO, "UnRecognized Event - 0x%x\n", EventId));\r
+      (ARM_SVC_ID_FFA_MSG_SEND_DIRECT_REQ != EventId))\r
+  {\r
+    DEBUG ((DEBUG_ERROR, "UnRecognized Event - 0x%x\n", EventId));\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -109,17 +109,19 @@ PiMmStandaloneArmTfCpuDriverEntry (
   }\r
 \r
   if ((NsCommBufferAddr + sizeof (EFI_MM_COMMUNICATE_HEADER)) >=\r
-      (mNsCommBuffer.PhysicalStart + mNsCommBuffer.PhysicalSize)) {\r
+      (mNsCommBuffer.PhysicalStart + mNsCommBuffer.PhysicalSize))\r
+  {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
   // Find out the size of the buffer passed\r
-  NsCommBufferSize = ((EFI_MM_COMMUNICATE_HEADER *) NsCommBufferAddr)->MessageLength +\r
-    sizeof (EFI_MM_COMMUNICATE_HEADER);\r
+  NsCommBufferSize = ((EFI_MM_COMMUNICATE_HEADER *)NsCommBufferAddr)->MessageLength +\r
+                     sizeof (EFI_MM_COMMUNICATE_HEADER);\r
 \r
   // perform bounds check.\r
   if (NsCommBufferAddr + NsCommBufferSize >=\r
-      mNsCommBuffer.PhysicalStart + mNsCommBuffer.PhysicalSize) {\r
+      mNsCommBuffer.PhysicalStart + mNsCommBuffer.PhysicalSize)\r
+  {\r
     return EFI_ACCESS_DENIED;\r
   }\r
 \r
@@ -129,17 +131,17 @@ PiMmStandaloneArmTfCpuDriverEntry (
   Status = mMmst->MmAllocatePool (\r
                     EfiRuntimeServicesData,\r
                     NsCommBufferSize,\r
-                    (VOID **) &GuidedEventContext\r
+                    (VOID **)&GuidedEventContext\r
                     );\r
 \r
   if (Status != EFI_SUCCESS) {\r
-    DEBUG ((DEBUG_INFO, "Mem alloc failed - 0x%x\n", EventId));\r
+    DEBUG ((DEBUG_ERROR, "Mem alloc failed - 0x%x\n", EventId));\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
 \r
   // X1 contains the VA of the normal world memory accessible from\r
   // S-EL0\r
-  CopyMem (GuidedEventContext, (CONST VOID *) NsCommBufferAddr, NsCommBufferSize);\r
+  CopyMem (GuidedEventContext, (CONST VOID *)NsCommBufferAddr, NsCommBufferSize);\r
 \r
   // Stash the pointer to the allocated Event Context for this CPU\r
   PerCpuGuidedEventContext[CpuNumber] = GuidedEventContext;\r
@@ -147,16 +149,16 @@ PiMmStandaloneArmTfCpuDriverEntry (
   ZeroMem (&MmEntryPointContext, sizeof (EFI_MM_ENTRY_CONTEXT));\r
 \r
   MmEntryPointContext.CurrentlyExecutingCpu = CpuNumber;\r
-  MmEntryPointContext.NumberOfCpus = mMpInformationHobData->NumberOfProcessors;\r
+  MmEntryPointContext.NumberOfCpus          = mMpInformationHobData->NumberOfProcessors;\r
 \r
   // Populate the MM system table with MP and state information\r
   mMmst->CurrentlyExecutingCpu = CpuNumber;\r
-  mMmst->NumberOfCpus = mMpInformationHobData->NumberOfProcessors;\r
-  mMmst->CpuSaveStateSize = 0;\r
-  mMmst->CpuSaveState = NULL;\r
+  mMmst->NumberOfCpus          = mMpInformationHobData->NumberOfProcessors;\r
+  mMmst->CpuSaveStateSize      = 0;\r
+  mMmst->CpuSaveState          = NULL;\r
 \r
   if (mMmEntryPoint == NULL) {\r
-    DEBUG ((DEBUG_INFO, "Mm Entry point Not Found\n"));\r
+    DEBUG ((DEBUG_ERROR, "Mm Entry point Not Found\n"));\r
     return EFI_UNSUPPORTED;\r
   }\r
 \r
@@ -164,12 +166,13 @@ PiMmStandaloneArmTfCpuDriverEntry (
 \r
   // Free the memory allocation done earlier and reset the per-cpu context\r
   ASSERT (GuidedEventContext);\r
-  CopyMem ((VOID *)NsCommBufferAddr, (CONST VOID *) GuidedEventContext, NsCommBufferSize);\r
+  CopyMem ((VOID *)NsCommBufferAddr, (CONST VOID *)GuidedEventContext, NsCommBufferSize);\r
 \r
-  Status = mMmst->MmFreePool ((VOID *) GuidedEventContext);\r
+  Status = mMmst->MmFreePool ((VOID *)GuidedEventContext);\r
   if (Status != EFI_SUCCESS) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
+\r
   PerCpuGuidedEventContext[CpuNumber] = NULL;\r
 \r
   return Status;\r
@@ -187,7 +190,7 @@ EFI_STATUS
 EFIAPI\r
 MmFoundationEntryRegister (\r
   IN CONST EFI_MM_CONFIGURATION_PROTOCOL  *This,\r
-  IN EFI_MM_ENTRY_POINT                    MmEntryPoint\r
+  IN EFI_MM_ENTRY_POINT                   MmEntryPoint\r
   )\r
 {\r
   // store the entry point in a global\r
@@ -214,14 +217,14 @@ MmFoundationEntryRegister (
 EFI_STATUS\r
 EFIAPI\r
 PiMmCpuTpFwRootMmiHandler (\r
-  IN     EFI_HANDLE               DispatchHandle,\r
-  IN     CONST VOID               *Context,        OPTIONAL\r
-  IN OUT VOID                     *CommBuffer,     OPTIONAL\r
-  IN OUT UINTN                    *CommBufferSize  OPTIONAL\r
+  IN     EFI_HANDLE  DispatchHandle,\r
+  IN     CONST VOID  *Context         OPTIONAL,\r
+  IN OUT VOID        *CommBuffer      OPTIONAL,\r
+  IN OUT UINTN       *CommBufferSize  OPTIONAL\r
   )\r
 {\r
-  EFI_STATUS Status;\r
-  UINTN      CpuNumber;\r
+  EFI_STATUS  Status;\r
+  UINTN       CpuNumber;\r
 \r
   ASSERT (Context == NULL);\r
   ASSERT (CommBuffer == NULL);\r
@@ -232,9 +235,12 @@ PiMmCpuTpFwRootMmiHandler (
     return EFI_NOT_FOUND;\r
   }\r
 \r
-  DEBUG ((DEBUG_INFO, "CommBuffer - 0x%x, CommBufferSize - 0x%x\n",\r
-          PerCpuGuidedEventContext[CpuNumber],\r
-          PerCpuGuidedEventContext[CpuNumber]->MessageLength));\r
+  DEBUG ((\r
+    DEBUG_INFO,\r
+    "CommBuffer - 0x%x, CommBufferSize - 0x%x\n",\r
+    PerCpuGuidedEventContext[CpuNumber],\r
+    PerCpuGuidedEventContext[CpuNumber]->MessageLength\r
+    ));\r
 \r
   Status = mMmst->MmiManage (\r
                     &PerCpuGuidedEventContext[CpuNumber]->HeaderGuid,\r