/** @file\r
\r
- The file is used to create, update PCD of MSA/MBD file\r
+ The file is used to create, update PcdCode section of the MSA file\r
\r
Copyright (c) 2006, Intel Corporation\r
All rights reserved. This program and the accompanying materials\r
import org.tianocore.frameworkwizard.workspace.WorkspaceTools;\r
\r
/**\r
- * The class is used to create, update PCD of MSA/MBD file It extends\r
- * IInternalFrame\r
+ * The class is used to create, update PcdCoded section of the MSA file\r
+ * \r
+ * It extends IDialog\r
* \r
*/\r
public class PCDsDlg extends IDialog implements ItemListener {\r
private JButton jButtonCancel = null;\r
\r
private JScrollPane jScrollPaneHelpText = null;\r
- \r
+\r
private JLabel jLabelUsage = null;\r
\r
private JComboBox jComboBoxUsage = null;\r
// Not used by UI\r
//\r
private PcdCodedIdentification id = null;\r
- \r
+\r
private EnumerationData ed = new EnumerationData();\r
\r
private WorkspaceTools wt = new WorkspaceTools();\r
private JTextField getJTextFieldFeatureFlag() {\r
if (jTextFieldFeatureFlag == null) {\r
jTextFieldFeatureFlag = new JTextField();\r
- jTextFieldFeatureFlag.setBounds(new java.awt.Rectangle(168, 157, 320, 20));\r
+ jTextFieldFeatureFlag.setBounds(new java.awt.Rectangle(168, 182, 320, 20));\r
jTextFieldFeatureFlag.setPreferredSize(new java.awt.Dimension(320, 20));\r
jTextFieldFeatureFlag.setToolTipText("Postfix expression that must evaluate to TRUE or FALSE");\r
+ jTextFieldFeatureFlag.setEnabled(false);\r
}\r
return jTextFieldFeatureFlag;\r
}\r
this.id = inPcdCodedId;\r
\r
if (this.id != null) {\r
- this.jComboBoxCName.setSelectedItem(id.getName());\r
+ for (int index = 0; index < this.jComboBoxCName.getItemCount(); index++) {\r
+ if (this.jComboBoxCName.getItemAt(index).toString().equals(id.getName())) {\r
+ this.jComboBoxCName.setSelectedIndex(index);\r
+ break;\r
+ }\r
+ }\r
this.jTextFieldTokenSpaceGuid.setText(id.getGuid());\r
this.jTextFieldDefaultValue.setText(id.getValue());\r
this.jComboBoxUsage.setSelectedItem(id.getUsage());\r
\r
jLabelFeatureFlag = new JLabel();\r
jLabelFeatureFlag.setText("Feature Flag Expression");\r
- jLabelFeatureFlag.setBounds(new java.awt.Rectangle(12, 157, 168, 20));\r
+ jLabelFeatureFlag.setBounds(new java.awt.Rectangle(12, 182, 168, 20));\r
+ jLabelFeatureFlag.setEnabled(false);\r
\r
jLabelTokenSpaceGuid = new JLabel();\r
jLabelTokenSpaceGuid.setText("Token Space C Name");\r
\r
jLabelArch = new JLabel();\r
jLabelArch.setText("Supported Architectures");\r
- jLabelArch.setBounds(new java.awt.Rectangle(12, 182, 168, 20));\r
+ jLabelArch.setBounds(new java.awt.Rectangle(12, 157, 168, 20));\r
jArchCheckBox = new ArchCheckBox();\r
jArchCheckBox.setPreferredSize(new java.awt.Dimension(320, 20));\r
- jArchCheckBox.setBounds(new java.awt.Rectangle(168, 182, 320, 20));\r
+ jArchCheckBox.setBounds(new java.awt.Rectangle(168, 157, 320, 20));\r
\r
// Hidden field\r
jLabelTokenSpaceGuid.setBounds(new java.awt.Rectangle(12, 62, 140, 20));\r
if (!isEmpty(this.jTextFieldTokenSpaceGuid.getText())) {\r
if (!DataValidation.isC_NameType(this.jTextFieldTokenSpaceGuid.getText())) {\r
Log.wrn("Update PcdCoded",\r
- "Incorrect data type for the selected pcd entry, please check in in spd file");\r
+ "Incorrect data type for the selected pcd entry, please check the datatype specified in the spd file");\r
return false;\r
}\r
}\r
|| pcd.getPcd(index).getType() == null || pcd.getPcd(index).getHelp() == null\r
|| isEmpty(pcd.getPcd(index).getHelp())) {\r
Log.wrn("select pcd entry when editing msa",\r
- "The selected is defined incorrectly.\r\nPlease check it in spd file");\r
+ "The selected value is defined incorrectly.\r\nPlease check it in the spd file");\r
} else {\r
this.jTextFieldTokenSpaceGuid.setText(pcd.getPcd(index).getGuidCName());\r
Tools.generateComboBoxByVector(this.jComboBoxItemType, pcd.getPcd(index).getType());\r