]> git.proxmox.com Git - mirror_edk2.git/blobdiff - Tools/Source/GenBuild/org/tianocore/build/pcd/action/CollectPCDAction.java
Add PcdDxe and PcdPEIM to all-arch for EdkModulePkg-All-Archs.fpd
[mirror_edk2.git] / Tools / Source / GenBuild / org / tianocore / build / pcd / action / CollectPCDAction.java
index 4057c417e44783e1e10771b860ae36766d101673..6686de9f1d8592387800cd5f09a849b3d09bc549 100644 (file)
@@ -21,29 +21,38 @@ import java.io.BufferedReader;
 import java.io.File;\r
 import java.io.FileReader;\r
 import java.io.IOException;\r
+import java.math.BigInteger;\r
 import java.util.ArrayList;\r
 import java.util.Collections;\r
 import java.util.Comparator;\r
 import java.util.HashMap;\r
+import java.util.Iterator;\r
 import java.util.List;\r
 import java.util.Map;\r
+import java.util.Set;\r
 import java.util.UUID;\r
+import java.util.regex.Matcher;\r
+import java.util.regex.Pattern;\r
 \r
 import org.apache.xmlbeans.XmlException;\r
 import org.apache.xmlbeans.XmlObject;\r
 import org.tianocore.DynamicPcdBuildDefinitionsDocument;\r
 import org.tianocore.DynamicPcdBuildDefinitionsDocument.DynamicPcdBuildDefinitions;\r
-import org.tianocore.DynamicPcdBuildDefinitionsDocument.DynamicPcdBuildDefinitions.PcdBuildData.SkuInfo;\r
 import org.tianocore.DynamicPcdBuildDefinitionsDocument.DynamicPcdBuildDefinitions.PcdBuildData;\r
+import org.tianocore.DynamicPcdBuildDefinitionsDocument.DynamicPcdBuildDefinitions.PcdBuildData.SkuInfo;\r
 import org.tianocore.FrameworkModulesDocument;\r
-import org.tianocore.FrameworkPlatformDescriptionDocument;\r
-import org.tianocore.FrameworkPlatformDescriptionDocument.FrameworkPlatformDescription;\r
+import org.tianocore.PcdDeclarationsDocument;\r
+import org.tianocore.PlatformSurfaceAreaDocument;\r
+import org.tianocore.PcdBuildDefinitionDocument;\r
+import org.tianocore.PlatformSurfaceAreaDocument.PlatformSurfaceArea;\r
 import org.tianocore.ModuleSADocument;\r
 import org.tianocore.ModuleSADocument.ModuleSA;\r
 import org.tianocore.PackageSurfaceAreaDocument;\r
 import org.tianocore.PcdBuildDefinitionDocument.PcdBuildDefinition;\r
+import org.tianocore.build.autogen.CommonDefinition;\r
 import org.tianocore.build.global.GlobalData;\r
 import org.tianocore.build.global.SurfaceAreaQuery;\r
+import org.tianocore.build.id.FpdModuleIdentification;\r
 import org.tianocore.build.pcd.action.ActionMessage;\r
 import org.tianocore.build.pcd.entity.DynamicTokenValue;\r
 import org.tianocore.build.pcd.entity.MemoryDatabaseManager;\r
@@ -51,22 +60,34 @@ import org.tianocore.build.pcd.entity.SkuInstance;
 import org.tianocore.build.pcd.entity.Token;\r
 import org.tianocore.build.pcd.entity.UsageInstance;\r
 import org.tianocore.build.pcd.exception.EntityException;\r
+import org.tianocore.logger.EdkLog;\r
+import org.tianocore.ModuleTypeDef;\r
+\r
+class CStructTypeDeclaration {\r
+    String key;\r
+    int alignmentSize;\r
+    String cCode;\r
+    boolean initTable;\r
+    \r
+    public CStructTypeDeclaration (String key, int alignmentSize, String cCode, boolean initTable) {\r
+        this.key = key;\r
+        this.alignmentSize = alignmentSize;\r
+        this.cCode = cCode;\r
+        this.initTable = initTable;\r
+    }\r
+}\r
 \r
 class StringTable {\r
     private ArrayList<String>   al; \r
     private ArrayList<String>   alComments;\r
     private String              phase;\r
     int                         len; \r
-    int                         bodyStart;\r
-    int                         bodyLineNum;\r
 \r
     public StringTable (String phase) {\r
         this.phase = phase;\r
         al = new ArrayList<String>();\r
         alComments = new ArrayList<String>();\r
         len = 0;\r
-        bodyStart = 0;\r
-        bodyLineNum = 0;\r
     }\r
 \r
     public String getSizeMacro () {\r
@@ -87,6 +108,74 @@ class StringTable {
     public String getExistanceMacro () {\r
         return String.format(PcdDatabase.StringTableExistenceMacro, phase, (al.size() == 0)? "TRUE":"FALSE");\r
     }\r
+    \r
+    public void genCodeNew (ArrayList<CStructTypeDeclaration> declaList, HashMap<String, String> instTable) {\r
+        final String stringTable = "StringTable";\r
+        final String tab         = "\t";\r
+        final String newLine     = "\r\n";\r
+        final String commaNewLine = ",\r\n";\r
+        \r
+        CStructTypeDeclaration decl;\r
+\r
+        String cDeclCode = "";\r
+        String cInstCode = "";\r
+\r
+        //\r
+        // If we have a empty StringTable\r
+        //\r
+        if (al.size() == 0) {\r
+            cDeclCode += String.format("%-20s%s[1]; /* StringTable is empty */", "UINT16", stringTable) + newLine; \r
+            decl = new CStructTypeDeclaration (\r
+                                                stringTable,\r
+                                                2,\r
+                                                cDeclCode,\r
+                                                true\r
+                                        );  \r
+            declaList.add(decl);\r
+\r
+            cInstCode = String.format("/* %s */", stringTable) + newLine + tab + "{ 0 }";\r
+            instTable.put(stringTable, cInstCode);\r
+        } else {\r
+\r
+            //\r
+            // If there is any String in the StringTable\r
+            //\r
+            for (int i = 0; i < al.size(); i++) {\r
+                String str = al.get(i);\r
+                String stringTableName;\r
+                \r
+                if (i == 0) {\r
+                    //\r
+                    // StringTable is a well-known name in the PCD DXE driver\r
+                    //\r
+                    stringTableName = stringTable;\r
+    \r
+                } else {\r
+                    stringTableName = String.format("%s_%d", stringTable, i);\r
+                    cDeclCode += tab;\r
+                }\r
+                cDeclCode += String.format("%-20s%s[%d]; /* %s */", "UINT16", stringTableName, str.length() + 1, alComments.get(i)) + newLine;\r
+                \r
+                if (i == 0) {\r
+                    cInstCode = "/* StringTable */" + newLine;\r
+                }\r
+                cInstCode += tab + String.format("L\"%s\" /* %s */", al.get(i), alComments.get(i));\r
+                if (i != al.size() - 1) {\r
+                    cInstCode += commaNewLine;\r
+                }\r
+            }\r
+            \r
+            decl = new CStructTypeDeclaration (\r
+                    stringTable,\r
+                    2,\r
+                    cDeclCode,\r
+                    true\r
+            );  \r
+            declaList.add(decl);\r
+    \r
+            instTable.put(stringTable, cInstCode);\r
+        }\r
+    }\r
 \r
     public String getTypeDeclaration () {\r
 \r
@@ -141,9 +230,33 @@ class StringTable {
         return output;\r
     }\r
 \r
-    public int add (String str, Token token) {\r
+    public int add (String inputStr, Token token) {\r
         int i;\r
+        int pos;\r
+\r
+        String str = inputStr;\r
+        \r
+        //\r
+        // The input can be two types:\r
+        // "L\"Bootmode\"" or "Bootmode". \r
+        // We drop the L\" and \" for the first type. \r
+        if (str.startsWith("L\"") && str.endsWith("\"")) {\r
+            str = str.substring(2, str.length() - 1);\r
+        }\r
+        //\r
+        // Check if StringTable has this String already.\r
+        // If so, return the current pos.\r
+        //\r
+        for (i = 0, pos = 0; i < al.size(); i++) {\r
+            String s = al.get(i);;\r
 \r
+            if (str.equals(s)) {\r
+                return pos;\r
+            }\r
+            pos = s.length() + 1;\r
+            \r
+        }\r
+        \r
         i = len;\r
         //\r
         // Include the NULL character at the end of String\r
@@ -161,16 +274,32 @@ class SizeTable {
     private ArrayList<String>   alComments;\r
     private String              phase;\r
     private int                 len;\r
-    private int             bodyStart;\r
-    private int             bodyLineNum;\r
-\r
+    \r
     public SizeTable (String phase) {\r
         this.phase = phase;\r
         al = new ArrayList<Integer>();\r
         alComments = new ArrayList<String>();\r
         len = 0;\r
-        bodyStart = 0;\r
-        bodyLineNum = 0;\r
+    }\r
+\r
+    public void genCodeNew (ArrayList<CStructTypeDeclaration> declaList, HashMap<String, String> instTable, String phase) {\r
+        final String name = "SizeTable";\r
+        \r
+        CStructTypeDeclaration decl;\r
+        String cCode;\r
+\r
+        cCode = String.format(PcdDatabase.SizeTableDeclaration, phase); \r
+        decl = new CStructTypeDeclaration (\r
+                                            name,\r
+                                            2,\r
+                                            cCode,\r
+                                            true\r
+                                           );  \r
+        declaList.add(decl);\r
+\r
+\r
+        cCode = PcdDatabase.genInstantiationStr(getInstantiation());\r
+        instTable.put(name, cCode);\r
     }\r
 \r
     public String getTypeDeclaration () {\r
@@ -182,14 +311,12 @@ class SizeTable {
 \r
         Output.add("/* SizeTable */");\r
         Output.add("{");\r
-        bodyStart = 2;\r
-\r
         if (al.size() == 0) {\r
-            Output.add("0");\r
+            Output.add("\t0");\r
         } else {\r
             for (int index = 0; index < al.size(); index++) {\r
                 Integer n = al.get(index);\r
-                String str = n.toString();\r
+                String str = "\t" + n.toString();\r
 \r
                 if (index != (al.size() - 1)) {\r
                     str += ",";\r
@@ -197,7 +324,6 @@ class SizeTable {
 \r
                 str += " /* " + alComments.get(index) + " */"; \r
                 Output.add(str);\r
-                bodyLineNum++;\r
     \r
             }\r
         }\r
@@ -206,14 +332,6 @@ class SizeTable {
         return Output;\r
     }\r
 \r
-    public int getBodyStart() {\r
-        return bodyStart;\r
-    }\r
-\r
-    public int getBodyLineNum () {\r
-        return bodyLineNum;\r
-    }\r
-\r
     public int add (Token token) {\r
         int index = len;\r
 \r
@@ -224,18 +342,6 @@ class SizeTable {
         return index;\r
     }\r
     \r
-    private int getDatumSize(Token token) {\r
-        /*\r
-        switch (token.datumType) {\r
-        case Token.DATUM_TYPE.UINT8:\r
-            return 1;\r
-        default:\r
-            return 0;\r
-        }\r
-        */\r
-        return 0;\r
-    }\r
-\r
     public int getTableLen () {\r
         return al.size() == 0 ? 1 : al.size();\r
     }\r
@@ -247,7 +353,6 @@ class GuidTable {
     private ArrayList<String> alComments;\r
     private String          phase;\r
     private int             len;\r
-    private int             bodyStart;\r
     private int             bodyLineNum;\r
 \r
     public GuidTable (String phase) {\r
@@ -255,7 +360,6 @@ class GuidTable {
         al = new ArrayList<UUID>();\r
         alComments = new ArrayList<String>();\r
         len = 0;\r
-        bodyStart = 0;\r
         bodyLineNum = 0;\r
     }\r
 \r
@@ -271,6 +375,26 @@ class GuidTable {
         return String.format(PcdDatabase.GuidTableExistenceMacro, phase, (al.size() == 0)? "TRUE":"FALSE");\r
     }\r
 \r
+    public void genCodeNew (ArrayList<CStructTypeDeclaration> declaList, HashMap<String, String> instTable, String phase) {\r
+        final String name = "GuidTable";\r
+        \r
+        CStructTypeDeclaration decl;\r
+        String cCode = "";\r
+\r
+        cCode += String.format(PcdDatabase.GuidTableDeclaration, phase); \r
+        decl = new CStructTypeDeclaration (\r
+                                            name,\r
+                                            8,\r
+                                            cCode,\r
+                                            true\r
+                                           );  \r
+        declaList.add(decl);\r
+\r
+\r
+        cCode = PcdDatabase.genInstantiationStr(getInstantiation());\r
+        instTable.put(name, cCode);\r
+    }\r
+\r
     public String getTypeDeclaration () {\r
         return String.format(PcdDatabase.GuidTableDeclaration, phase);\r
     }\r
@@ -280,7 +404,7 @@ class GuidTable {
 \r
         guidStrArray =(uuid.toString()).split("-");\r
 \r
-        return String.format("{ 0x%s, 0x%s, 0x%s, { 0x%s, 0x%s, 0x%s, 0x%s, 0x%s, 0x%s, 0x%s, 0x%s } }",\r
+        return String.format("{0x%s, 0x%s, 0x%s, {0x%s, 0x%s, 0x%s, 0x%s, 0x%s, 0x%s, 0x%s, 0x%s}}",\r
                                          guidStrArray[0],\r
                                          guidStrArray[1],\r
                                          guidStrArray[2],\r
@@ -300,17 +424,16 @@ class GuidTable {
 \r
         Output.add("/* GuidTable */");\r
         Output.add("{");\r
-        bodyStart = 2;\r
 \r
         if (al.size() == 0) {\r
-            Output.add(getUuidCString(new UUID(0, 0)));\r
+            Output.add("\t" + getUuidCString(new UUID(0, 0)));\r
         }\r
         \r
-        for (Object u : al) {\r
-            UUID uuid = (UUID)u;\r
-            String str = getUuidCString(uuid);\r
+        for (int i = 0; i < al.size(); i++) {\r
+            String str = "\t" + getUuidCString(al.get(i));\r
 \r
-            if (al.indexOf(u) != (al.size() - 1)) {\r
+            str += "/* " + alComments.get(i) +  " */";\r
+            if (i != (al.size() - 1)) {\r
                 str += ",";\r
             }\r
             Output.add(str);\r
@@ -322,23 +445,25 @@ class GuidTable {
         return Output;\r
     }\r
 \r
-    public int getBodyStart() {\r
-        return bodyStart;\r
-    }\r
-\r
-    public int getBodyLineNum () {\r
-        return bodyLineNum;\r
-    }\r
-\r
     public int add (UUID uuid, String name) {\r
-        int index = len;\r
         //\r
-        // Include the NULL character at the end of String\r
+        // Check if GuidTable has this entry already.\r
+        // If so, return the GuidTable index.\r
         //\r
+        for (int i = 0; i < al.size(); i++) {\r
+            if (al.get(i).equals(uuid)) {\r
+                return i;\r
+            }\r
+        }\r
+        \r
         len++; \r
         al.add(uuid);\r
+        alComments.add(name);\r
 \r
-        return index;\r
+        //\r
+        // Return the previous Table Index\r
+        //\r
+        return len - 1;\r
     }\r
 \r
     public int getTableLen () {\r
@@ -352,15 +477,11 @@ class SkuIdTable {
     private ArrayList<String>    alComment;\r
     private String               phase;\r
     private int                  len;\r
-    private int                   bodyStart;\r
-    private int                   bodyLineNum;\r
 \r
     public SkuIdTable (String phase) {\r
         this.phase = phase;\r
         al = new ArrayList<Integer[]>();\r
         alComment = new ArrayList<String>();\r
-        bodyStart = 0;\r
-        bodyLineNum = 0;\r
         len = 0;\r
     }\r
 \r
@@ -369,13 +490,49 @@ class SkuIdTable {
     }\r
 \r
     private int getSize () {\r
-        return (al.size() == 0)? 1 : al.size();\r
+        return (len == 0)? 1 : len;\r
     }\r
 \r
     public String getExistanceMacro () {\r
         return String.format(PcdDatabase.SkuTableExistenceMacro, phase, (al.size() == 0)? "TRUE":"FALSE");\r
     }\r
 \r
+    public void genCodeNew (ArrayList<CStructTypeDeclaration> declaList, HashMap<String, String> instTable, String phase) {\r
+        final String name = "SkuIdTable";\r
+        \r
+        CStructTypeDeclaration decl;\r
+        String cCode = "";\r
+\r
+        cCode += String.format(PcdDatabase.SkuIdTableDeclaration, phase); \r
+        decl = new CStructTypeDeclaration (\r
+                                            name,\r
+                                            1,\r
+                                            cCode,\r
+                                            true\r
+                                           );  \r
+        declaList.add(decl);\r
+\r
+\r
+        cCode = PcdDatabase.genInstantiationStr(getInstantiation());\r
+        instTable.put(name, cCode);\r
+\r
+        //\r
+        // SystemSkuId is in PEI phase PCD Database\r
+        //\r
+        if (phase.equalsIgnoreCase("PEI")) {\r
+            decl = new CStructTypeDeclaration (\r
+                                                "SystemSkuId",\r
+                                                1,\r
+                                                String.format("%-20sSystemSkuId;\r\n", "SKU_ID"),\r
+                                                true\r
+                                              );\r
+            declaList.add(decl);\r
+            \r
+            instTable.put("SystemSkuId", "0");\r
+        }\r
+\r
+    }\r
+\r
     public String getTypeDeclaration () {\r
         return String.format(PcdDatabase.SkuIdTableDeclaration, phase);\r
     }\r
@@ -385,10 +542,9 @@ class SkuIdTable {
 \r
         Output.add("/* SkuIdTable */");\r
         Output.add("{");\r
-        bodyStart = 2;\r
 \r
         if (al.size() == 0) {\r
-            Output.add("0");\r
+            Output.add("\t0");\r
         }\r
         \r
         for (int index = 0; index < al.size(); index++) {\r
@@ -400,16 +556,15 @@ class SkuIdTable {
 \r
             Integer[] ia = al.get(index);\r
 \r
-            str += ia[0].toString() + ", ";\r
+            str += "\t" + ia[0].toString() + ", ";\r
             for (int index2 = 1; index2 < ia.length; index2++) {\r
                str += ia[index2].toString();\r
-               if (index != al.size() - 1) {\r
+               if (!((index2 == ia.length - 1) && (index == al.size() - 1))) {\r
                    str += ", ";\r
                }\r
             }\r
 \r
             Output.add(str);\r
-            bodyLineNum++;\r
 \r
         }\r
 \r
@@ -421,6 +576,31 @@ class SkuIdTable {
     public int add (Token token) {\r
 \r
         int index;\r
+        int pos;\r
+        \r
+        //\r
+        // Check if this SKU_ID Array is already in the table\r
+        //\r
+        pos = 0;\r
+        for (Object o: al) {\r
+            Integer [] s = (Integer[]) o;\r
+            boolean different = false;\r
+            if (s[0] == token.getSkuIdCount()) {\r
+                for (index = 1; index < s.length; index++) {\r
+                    if (s[index] != token.skuData.get(index-1).id) {\r
+                        different = true;\r
+                        break;\r
+                    }\r
+                }\r
+            } else {\r
+                different = true;\r
+            }\r
+            if (different) {\r
+                pos += s[0] + 1;\r
+            } else {\r
+                return pos;\r
+            }\r
+        }\r
 \r
         Integer [] skuIds = new Integer[token.skuData.size() + 1];\r
         skuIds[0] = new Integer(token.skuData.size());\r
@@ -470,6 +650,25 @@ class LocalTokenNumberTable {
         return String.format(PcdDatabase.DatabaseExistenceMacro, phase, (al.size() == 0)? "TRUE":"FALSE");\r
     }\r
 \r
+    public void genCodeNew (ArrayList<CStructTypeDeclaration> declaList, HashMap<String, String> instTable, String phase) {\r
+        final String name = "LocalTokenNumberTable";\r
+        \r
+        CStructTypeDeclaration decl;\r
+        String cCode = "";\r
+\r
+        cCode += String.format(PcdDatabase.LocalTokenNumberTableDeclaration, phase); \r
+        decl = new CStructTypeDeclaration (\r
+                                            name,\r
+                                            4,\r
+                                            cCode,\r
+                                            true\r
+                                           );  \r
+        declaList.add(decl);\r
+\r
+        cCode = PcdDatabase.genInstantiationStr(getInstantiation());\r
+        instTable.put(name, cCode);\r
+    }\r
+\r
     public String getTypeDeclaration () {\r
         return String.format(PcdDatabase.LocalTokenNumberTableDeclaration, phase);\r
     }\r
@@ -481,13 +680,13 @@ class LocalTokenNumberTable {
         output.add("{");\r
 \r
         if (al.size() == 0) {\r
-            output.add("0");\r
+            output.add("\t0");\r
         }\r
         \r
         for (int index = 0; index < al.size(); index++) {\r
             String str;\r
 \r
-            str = (String)al.get(index);\r
+            str = "\t" + (String)al.get(index);\r
 \r
             str += " /* " + alComment.get(index) + " */ ";\r
 \r
@@ -513,7 +712,7 @@ class LocalTokenNumberTable {
 \r
         str =  String.format(PcdDatabase.offsetOfStrTemplate, phase, token.hasDefaultValue() ? "Init" : "Uninit", token.getPrimaryKeyString());\r
 \r
-        if (token.isStringType()) {\r
+        if (token.isUnicodeStringType()) {\r
             str += " | PCD_TYPE_STRING";\r
         }\r
 \r
@@ -554,15 +753,12 @@ class ExMapTable {
     private ArrayList<String>    alComment;\r
     private String               phase;\r
     private int                  len;\r
-    private int                   bodyStart;\r
     private int                   bodyLineNum;\r
-    private int                   base;\r
-\r
+    \r
     public ExMapTable (String phase) {\r
         this.phase = phase;\r
         al = new ArrayList<ExTriplet>();\r
         alComment = new ArrayList<String>();\r
-        bodyStart = 0;\r
         bodyLineNum = 0;\r
         len = 0;\r
     }\r
@@ -572,14 +768,32 @@ class ExMapTable {
              + String.format(PcdDatabase.ExTokenNumber, phase, al.size());\r
     }\r
 \r
-    private int getSize () {\r
-        return (al.size() == 0)? 1 : al.size();\r
-    }\r
-\r
     public String getExistanceMacro () {\r
         return String.format(PcdDatabase.ExMapTableExistenceMacro, phase, (al.size() == 0)? "TRUE":"FALSE");\r
     }\r
 \r
+    public void genCodeNew (ArrayList<CStructTypeDeclaration> declaList, HashMap<String, String> instTable, String phase) {\r
+        final String exMapTableName = "ExMapTable";\r
+        \r
+        sortTable();\r
+        \r
+        CStructTypeDeclaration decl;\r
+        String cCode = "";\r
+\r
+        cCode += String.format(PcdDatabase.ExMapTableDeclaration, phase); \r
+        decl = new CStructTypeDeclaration (\r
+                                            exMapTableName,\r
+                                            4,\r
+                                            cCode,\r
+                                            true\r
+                                           );  \r
+        declaList.add(decl);\r
+\r
+\r
+        cCode = PcdDatabase.genInstantiationStr(getInstantiation());\r
+        instTable.put(exMapTableName, cCode);\r
+    }\r
+    \r
     public String getTypeDeclaration () {\r
         return String.format(PcdDatabase.ExMapTableDeclaration, phase);\r
     }\r
@@ -589,10 +803,8 @@ class ExMapTable {
 \r
         Output.add("/* ExMapTable */");\r
         Output.add("{");\r
-        bodyStart = 2;\r
-\r
         if (al.size() == 0) {\r
-            Output.add("{0, 0, 0}");\r
+            Output.add("\t{0, 0, 0}");\r
         }\r
         \r
         int index;\r
@@ -601,11 +813,11 @@ class ExMapTable {
 \r
             ExTriplet e = (ExTriplet)al.get(index);\r
 \r
-            str = "{ " + e.exTokenNumber.toString() + ", ";\r
+            str = "\t" + "{ " + String.format("0x%08X", e.exTokenNumber) + ", ";\r
             str += e.localTokenIdx.toString() + ", ";\r
             str += e.guidTableIdx.toString();\r
 \r
-            str += " /* " + alComment.get(index) + " */";\r
+            str += "}" + " /* " + alComment.get(index) + " */" ;\r
 \r
             if (index != al.size() - 1) {\r
                 str += ",";\r
@@ -635,21 +847,52 @@ class ExMapTable {
         return al.size() == 0 ? 1 : al.size();\r
     }\r
 \r
+    //\r
+    // To simplify the algorithm for GetNextToken and GetNextTokenSpace in\r
+    // PCD PEIM/Driver, we need to sort the ExMapTable according to the\r
+    // following order:\r
+    // 1) ExGuid\r
+    // 2) ExTokenNumber\r
+    // \r
+    class ExTripletComp implements Comparator<ExTriplet> {\r
+        public int compare (ExTriplet a, ExTriplet b) {\r
+            if (a.guidTableIdx == b.guidTableIdx ) {\r
+                if (a.exTokenNumber > b.exTokenNumber) {\r
+                    return 1;\r
+                } else if (a.exTokenNumber > b.exTokenNumber) {\r
+                    return 1;\r
+                } else {\r
+                    return 0;\r
+                }\r
+            }\r
+            \r
+            return a.guidTableIdx - b.guidTableIdx;\r
+        }\r
+    }\r
+\r
+    private void sortTable () {\r
+        java.util.Comparator<ExTriplet> comparator = new ExTripletComp();\r
+        java.util.Collections.sort(al, comparator);\r
+    }\r
 }\r
 \r
 class PcdDatabase {\r
 \r
-    public final static String ExMapTableDeclaration            = "DYNAMICEX_MAPPING ExMapTable[%s_EXMAPPING_TABLE_SIZE];\r\n";\r
-    public final static String GuidTableDeclaration             = "EFI_GUID          GuidTable[%s_GUID_TABLE_SIZE];\r\n";\r
-    public final static String LocalTokenNumberTableDeclaration = "UINT32            LocalTokenNumberTable[%s_LOCAL_TOKEN_NUMBER_TABLE_SIZE];\r\n";\r
-    public final static String StringTableDeclaration           = "UINT16            StringTable[%s_STRING_TABLE_SIZE];\r\n";\r
-    public final static String SizeTableDeclaration             = "UINT16            SizeTable[%s_LOCAL_TOKEN_NUMBER_TABLE_SIZE];\r\n";\r
-    public final static String SkuIdTableDeclaration              = "UINT8             SkuIdTable[%s_SKUID_TABLE_SIZE];\r\n";\r
+    private final static int    SkuHeadAlignmentSize             = 4;\r
+    private final String        newLine                         = "\r\n";\r
+    private final String        commaNewLine                    = ",\r\n";\r
+    private final String        tab                             = "\t";\r
+    public final static String ExMapTableDeclaration            = "DYNAMICEX_MAPPING   ExMapTable[%s_EXMAPPING_TABLE_SIZE];\r\n";\r
+    public final static String GuidTableDeclaration             = "EFI_GUID            GuidTable[%s_GUID_TABLE_SIZE];\r\n";\r
+    public final static String LocalTokenNumberTableDeclaration = "UINT32              LocalTokenNumberTable[%s_LOCAL_TOKEN_NUMBER_TABLE_SIZE];\r\n";\r
+    public final static String StringTableDeclaration           = "UINT16              StringTable[%s_STRING_TABLE_SIZE];\r\n";\r
+    public final static String SizeTableDeclaration             = "UINT16              SizeTable[%s_LOCAL_TOKEN_NUMBER_TABLE_SIZE];\r\n";\r
+    public final static String SkuIdTableDeclaration            = "UINT8               SkuIdTable[%s_SKUID_TABLE_SIZE];\r\n";\r
 \r
 \r
     public final static String ExMapTableSizeMacro              = "#define %s_EXMAPPING_TABLE_SIZE  %d\r\n";\r
     public final static String ExTokenNumber                    = "#define %s_EX_TOKEN_NUMBER       %d\r\n";\r
-    public final static String GuidTableSizeMacro               = "#define %s_GUID_TABLE_SIZE         %d\r\n";\r
+    public final static String GuidTableSizeMacro               = "#define %s_GUID_TABLE_SIZE         %d\r\n"; \r
     public final static String LocalTokenNumberTableSizeMacro   = "#define %s_LOCAL_TOKEN_NUMBER_TABLE_SIZE            %d\r\n";\r
     public final static String LocalTokenNumberSizeMacro               = "#define %s_LOCAL_TOKEN_NUMBER            %d\r\n";\r
     public final static String StringTableSizeMacro             = "#define %s_STRING_TABLE_SIZE       %d\r\n";\r
@@ -663,7 +906,11 @@ class PcdDatabase {
     public final static String SkuTableExistenceMacro           = "#define %s_SKUID_TABLE_EMPTY    %s\r\n";\r
 \r
     public final static String offsetOfSkuHeadStrTemplate       = "offsetof(%s_PCD_DATABASE, %s.%s_SkuDataTable)";\r
+    public final static String offsetOfVariableEnabledDefault   = "offsetof(%s_PCD_DATABASE, %s.%s_VariableDefault_%d)";\r
     public final static String offsetOfStrTemplate              = "offsetof(%s_PCD_DATABASE, %s.%s)";\r
+    \r
+    private final static String  skuDataTableTemplate           = "SkuDataTable";\r
+\r
 \r
     private StringTable stringTable;\r
     private GuidTable   guidTable;\r
@@ -676,6 +923,12 @@ class PcdDatabase {
     private String phase;\r
     private int assignedTokenNumber;\r
     \r
+    //\r
+    // Use two class global variable to store\r
+    // temperary \r
+    //\r
+    private String      privateGlobalName;\r
+    private String      privateGlobalCCode;\r
     //\r
     // After Major changes done to the PCD\r
     // database generation class PcdDatabase\r
@@ -683,7 +936,7 @@ class PcdDatabase {
     // also update the version number in PCD\r
     // service PEIM and DXE driver accordingly.\r
     //\r
-    private final int version = 1;\r
+    private final int version = 2;\r
 \r
     private String hString;\r
     private String cString;\r
@@ -695,7 +948,7 @@ class PcdDatabase {
                     - getAlignmentSize(a);\r
         }\r
     }\r
-\r
+    \r
     public PcdDatabase (ArrayList<Token> alTokens, String exePhase, int startLen) {\r
        phase = exePhase;\r
 \r
@@ -706,10 +959,23 @@ class PcdDatabase {
        sizeTable = new SizeTable(phase);\r
        exMapTable = new ExMapTable(phase); \r
 \r
-       assignedTokenNumber = startLen;\r
+       assignedTokenNumber = startLen + 1;\r
        this.alTokens = alTokens;\r
     }\r
 \r
+    private void getNonExAndExTokens (ArrayList<Token> alTokens, List<Token> nexTokens, List<Token> exTokens) {\r
+        for (int i = 0; i < alTokens.size(); i++) {\r
+            Token t = (Token)alTokens.get(i);\r
+            if (t.isDynamicEx()) {\r
+                exTokens.add(t);\r
+            } else {\r
+                nexTokens.add(t);\r
+            }\r
+        }\r
+\r
+        return;\r
+    }\r
+\r
     private void getTwoGroupsOfTokens (ArrayList<Token> alTokens, List<Token> initTokens, List<Token> uninitTokens) {\r
         for (int i = 0; i < alTokens.size(); i++) {\r
             Token t = (Token)alTokens.get(i);\r
@@ -723,6 +989,49 @@ class PcdDatabase {
         return;\r
     }\r
 \r
+    private int getDataTypeAlignmentSize (Token token) {\r
+        switch (token.datumType) {\r
+        case UINT8:\r
+            return 1;\r
+        case UINT16:\r
+            return 2;\r
+        case UINT32:\r
+            return 4;\r
+        case UINT64:\r
+            return 8;\r
+        case POINTER:\r
+            return 1;\r
+        case BOOLEAN:\r
+            return 1;\r
+        default:\r
+            return 1;\r
+        }\r
+    }\r
+    \r
+    private int getHiiPtrTypeAlignmentSize(Token token) {\r
+        switch (token.datumType) {\r
+        case UINT8:\r
+            return 1;\r
+        case UINT16:\r
+            return 2;\r
+        case UINT32:\r
+            return 4;\r
+        case UINT64:\r
+            return 8;\r
+        case POINTER:\r
+            if (token.isHiiEnable()) {\r
+                if (token.isHiiDefaultValueUnicodeStringType()) {\r
+                    return 2;\r
+                }\r
+            }\r
+            return 1;\r
+        case BOOLEAN:\r
+            return 1;\r
+        default:\r
+            return 1;\r
+        }\r
+    }\r
+    \r
     private int getAlignmentSize (Token token) {\r
         if (token.getDefaultSku().type == DynamicTokenValue.VALUE_TYPE.HII_TYPE) {\r
             return 2;\r
@@ -732,25 +1041,11 @@ class PcdDatabase {
             return 4;\r
         }\r
 \r
-        if (token.isStringType()) {\r
+        if (token.isUnicodeStringType()) {\r
             return 2;\r
         }\r
-\r
-        switch (token.datumType) {\r
-            case UINT8:\r
-                return 1;\r
-            case UINT16:\r
-                return 2;\r
-            case UINT32:\r
-                return 4;\r
-            case UINT64:\r
-                return 8;\r
-            case POINTER:\r
-                return 1;\r
-            case BOOLEAN:\r
-                return 1;\r
-            }\r
-            return 1;\r
+        \r
+        return getDataTypeAlignmentSize(token);\r
      }\r
 \r
     public String getCString () {\r
@@ -760,6 +1055,235 @@ class PcdDatabase {
     public String getHString () {\r
         return hString;\r
     }\r
+    \r
+    private void genCodeWorker(Token t,\r
+            ArrayList<CStructTypeDeclaration> declaList,\r
+            HashMap<String, String> instTable, String phase)\r
+            throws EntityException {\r
+\r
+        CStructTypeDeclaration decl;\r
+\r
+        //\r
+        // Insert SKU_HEAD if isSkuEnable is true\r
+        //\r
+        if (t.isSkuEnable()) {\r
+            int tableIdx;\r
+            tableIdx = skuIdTable.add(t);\r
+            decl = new CStructTypeDeclaration(t.getPrimaryKeyString(),\r
+                    SkuHeadAlignmentSize, getSkuEnabledTypeDeclaration(t), true);\r
+            declaList.add(decl);\r
+            instTable.put(t.getPrimaryKeyString(),\r
+                    getSkuEnabledTypeInstantiaion(t, tableIdx));\r
+        }\r
+\r
+        //\r
+        // Insert PCD_ENTRY declaration and instantiation\r
+        //\r
+        getCDeclarationString(t);\r
+\r
+        decl = new CStructTypeDeclaration(privateGlobalName,\r
+                getAlignmentSize(t), privateGlobalCCode, t.hasDefaultValue());\r
+        declaList.add(decl);\r
+\r
+        if (t.hasDefaultValue()) {\r
+            instTable.put(privateGlobalName, \r
+                          getTypeInstantiation(t, declaList, instTable, phase)\r
+                          );\r
+        }\r
+\r
+    }\r
+\r
+    private void ProcessTokensNew (List<Token> tokens, \r
+                                   ArrayList<CStructTypeDeclaration> cStructDeclList,\r
+                                   HashMap<String, String> cStructInstTable,\r
+                                   String phase\r
+                                   ) \r
+    throws EntityException {\r
+        \r
+        for (int idx = 0; idx < tokens.size(); idx++) {\r
+            Token t = tokens.get(idx);\r
+            \r
+            genCodeWorker (t, cStructDeclList, cStructInstTable, phase);\r
+            \r
+            sizeTable.add(t);\r
+            localTokenNumberTable.add(t);\r
+            t.tokenNumber = assignedTokenNumber++;\r
+            \r
+            //\r
+            // Add a mapping if this dynamic PCD entry is a EX type\r
+            //\r
+            if (t.isDynamicEx()) {\r
+                exMapTable.add((int)t.tokenNumber, \r
+                                t.dynamicExTokenNumber, \r
+                                guidTable.add(t.tokenSpaceName, t.getPrimaryKeyString()), \r
+                                t.getPrimaryKeyString()\r
+                                );\r
+            }\r
+        }\r
+\r
+    }\r
+    \r
+    public void genCodeNew () throws EntityException {\r
+        \r
+        ArrayList<CStructTypeDeclaration> cStructDeclList = new ArrayList<CStructTypeDeclaration>();\r
+        HashMap<String, String> cStructInstTable = new HashMap<String, String>();\r
+        \r
+        List<Token> nexTokens = new ArrayList<Token> ();\r
+        List<Token> exTokens = new ArrayList<Token> ();\r
+\r
+        getNonExAndExTokens (alTokens, nexTokens, exTokens);\r
+\r
+        //\r
+        // We have to process Non-Ex type PCD entry first. The reason is\r
+        // that our optimization assumes that the Token Number of Non-Ex \r
+        // PCD entry start from 1 (for PEI phase) and grows continously upwards.\r
+        // \r
+        // EX type token number starts from the last Non-EX PCD entry and\r
+        // grows continously upwards.\r
+        //\r
+        ProcessTokensNew (nexTokens, cStructDeclList, cStructInstTable, phase);\r
+        ProcessTokensNew (exTokens, cStructDeclList, cStructInstTable, phase);\r
+        \r
+        stringTable.genCodeNew(cStructDeclList, cStructInstTable);\r
+        skuIdTable.genCodeNew(cStructDeclList, cStructInstTable, phase);\r
+        exMapTable.genCodeNew(cStructDeclList, cStructInstTable, phase);\r
+        localTokenNumberTable.genCodeNew(cStructDeclList, cStructInstTable, phase);\r
+        sizeTable.genCodeNew(cStructDeclList, cStructInstTable, phase);\r
+        guidTable.genCodeNew(cStructDeclList, cStructInstTable, phase);\r
+        \r
+        hString = genCMacroCode ();\r
+        \r
+        HashMap <String, String> result;\r
+        \r
+        result = genCStructCode(cStructDeclList, \r
+                cStructInstTable, \r
+                phase\r
+                );\r
+        \r
+        hString += result.get("initDeclStr");\r
+        hString += result.get("uninitDeclStr");\r
+        \r
+        hString += String.format("#define PCD_%s_SERVICE_DRIVER_VERSION         %d", phase, version);\r
+        \r
+        cString = newLine + newLine + result.get("initInstStr");\r
+        \r
+    }\r
+    \r
+    private String genCMacroCode () {\r
+        String macroStr   = "";\r
+\r
+        //\r
+        // Generate size info Macro for all Tables\r
+        //\r
+        macroStr += guidTable.getSizeMacro();\r
+        macroStr += stringTable.getSizeMacro();\r
+        macroStr += skuIdTable.getSizeMacro();\r
+        macroStr += localTokenNumberTable.getSizeMacro();\r
+        macroStr += exMapTable.getSizeMacro();\r
+\r
+        //\r
+        // Generate existance info Macro for all Tables\r
+        //\r
+        macroStr += guidTable.getExistanceMacro();\r
+        macroStr += stringTable.getExistanceMacro();\r
+        macroStr += skuIdTable.getExistanceMacro();\r
+        macroStr += localTokenNumberTable.getExistanceMacro();\r
+        macroStr += exMapTable.getExistanceMacro();\r
+\r
+        macroStr += newLine;\r
+        \r
+        return macroStr;\r
+    }\r
+    \r
+    private HashMap <String, String> genCStructCode(\r
+                                            ArrayList<CStructTypeDeclaration> declaList, \r
+                                            HashMap<String, String> instTable, \r
+                                            String phase\r
+                                            ) {\r
+        \r
+        int i;\r
+        HashMap <String, String> result = new HashMap<String, String>();\r
+        HashMap <Integer, ArrayList<String>>    alignmentInitDecl = new HashMap<Integer, ArrayList<String>>();\r
+        HashMap <Integer, ArrayList<String>>    alignmentUninitDecl = new HashMap<Integer, ArrayList<String>>();\r
+        HashMap <Integer, ArrayList<String>>    alignmentInitInst = new HashMap<Integer, ArrayList<String>>();\r
+        \r
+        //\r
+        // Initialize the storage for each alignment\r
+        //\r
+        for (i = 8; i > 0; i>>=1) {\r
+            alignmentInitDecl.put(new Integer(i), new ArrayList<String>());\r
+            alignmentInitInst.put(new Integer(i), new ArrayList<String>());\r
+            alignmentUninitDecl.put(new Integer(i), new ArrayList<String>());\r
+        }\r
+        \r
+        String initDeclStr   = "typedef struct {" + newLine;\r
+        String initInstStr   = String.format("%s_PCD_DATABASE_INIT g%sPcdDbInit = { ", phase.toUpperCase(), phase.toUpperCase()) + newLine;\r
+        String uninitDeclStr = "typedef struct {" + newLine;\r
+\r
+        //\r
+        // Sort all C declaration and instantiation base on Alignment Size \r
+        //\r
+        for (Object d : declaList) {\r
+            CStructTypeDeclaration decl = (CStructTypeDeclaration) d;\r
+            \r
+            if (decl.initTable) {\r
+                alignmentInitDecl.get(new Integer(decl.alignmentSize)).add(decl.cCode);\r
+                alignmentInitInst.get(new Integer(decl.alignmentSize)).add(instTable.get(decl.key));\r
+            } else {\r
+                alignmentUninitDecl.get(new Integer(decl.alignmentSize)).add(decl.cCode);\r
+            }\r
+        }\r
+\r
+        //\r
+        // Generate code for every alignment size\r
+        //\r
+        boolean uinitDatabaseEmpty = true;\r
+        for (int align = 8; align > 0; align >>= 1) {\r
+            ArrayList<String> declaListBasedOnAlignment = alignmentInitDecl.get(new Integer(align));\r
+            ArrayList<String> instListBasedOnAlignment = alignmentInitInst.get(new Integer(align));\r
+            for (i = 0; i < declaListBasedOnAlignment.size(); i++) {\r
+                initDeclStr += tab + declaListBasedOnAlignment.get(i);\r
+                initInstStr += tab + instListBasedOnAlignment.get(i);\r
+                \r
+                //\r
+                // We made a assumption that both PEI_PCD_DATABASE and DXE_PCD_DATABASE\r
+                // has a least one data memember with alignment size of 1. So we can\r
+                // remove the last "," in the C structure instantiation string. Luckily,\r
+                // this is true as both data structure has SKUID_TABLE anyway.\r
+                //\r
+                if ((align == 1) && (i == declaListBasedOnAlignment.size() - 1)) {\r
+                    initInstStr += newLine;\r
+                } else {\r
+                    initInstStr += commaNewLine;\r
+                }\r
+            }\r
+            \r
+            declaListBasedOnAlignment = alignmentUninitDecl.get(new Integer(align));\r
+            \r
+            if (declaListBasedOnAlignment.size() != 0) {\r
+                uinitDatabaseEmpty = false;\r
+            }\r
+            \r
+            for (Object d : declaListBasedOnAlignment) {\r
+                String s = (String)d;\r
+                uninitDeclStr += tab + s;\r
+            }\r
+        }\r
+        \r
+        if (uinitDatabaseEmpty) {\r
+            uninitDeclStr += tab + String.format("%-20sdummy; /* PCD_DATABASE_UNINIT is emptry */\r\n", "UINT8");\r
+        }\r
+        \r
+        initDeclStr += String.format("} %s_PCD_DATABASE_INIT;", phase) + newLine + newLine;\r
+        initInstStr += "};" + newLine;\r
+        uninitDeclStr += String.format("} %s_PCD_DATABASE_UNINIT;", phase) + newLine + newLine;\r
+        \r
+        result.put("initDeclStr", initDeclStr);\r
+        result.put("initInstStr", initInstStr);\r
+        result.put("uninitDeclStr", uninitDeclStr);\r
+\r
+        return result;\r
+    }\r
 \r
      public void genCode () \r
         throws EntityException {\r
@@ -914,10 +1438,13 @@ class PcdDatabase {
 \r
     }\r
 \r
-    private String genInstantiationStr (ArrayList<String> alStr) {\r
+    public static String genInstantiationStr (ArrayList<String> alStr) {\r
         String str = "";\r
         for (int i = 0; i< alStr.size(); i++) {\r
-            str += "\t" + alStr.get(i);\r
+            if (i != 0) {\r
+                str += "\t";\r
+            }\r
+            str += alStr.get(i);\r
             if (i != alStr.size() - 1) {\r
                 str += "\r\n";\r
             }\r
@@ -964,7 +1491,7 @@ class PcdDatabase {
                 } else if (token.getDefaultSku().type == DynamicTokenValue.VALUE_TYPE.VPD_TYPE) {\r
                     decl.add(getVpdEnableTypeDeclaration(token));\r
                     inst.add(getVpdEnableTypeInstantiation(token));\r
-                } else if (token.isStringType()) {\r
+                } else if (token.isUnicodeStringType()) {\r
                     decl.add(getStringTypeDeclaration(token));\r
                     inst.add(getStringTypeInstantiation(stringTable.add(token.getStringTypeString(), token), token));\r
                 }\r
@@ -991,13 +1518,13 @@ class PcdDatabase {
     }\r
 \r
     private String getSkuEnabledTypeDeclaration (Token token) {\r
-        return String.format("SKU_HEAD %s;\r\n", token.getPrimaryKeyString());\r
+        return String.format("%-20s%s;\r\n", "SKU_HEAD", token.getPrimaryKeyString());\r
     }\r
 \r
     private String getSkuEnabledTypeInstantiaion (Token token, int SkuTableIdx) {\r
 \r
         String offsetof = String.format(PcdDatabase.offsetOfSkuHeadStrTemplate, phase, token.hasDefaultValue()? "Init" : "Uninit", token.getPrimaryKeyString());\r
-        return String.format("{ %s, %d }", offsetof, SkuTableIdx);\r
+        return String.format("{ %s, %d } /* SKU_ENABLED: %s */", offsetof, SkuTableIdx, token.getPrimaryKeyString());\r
     }\r
 \r
     private String getDataTypeDeclarationForSkuEnabled (Token token) {\r
@@ -1034,23 +1561,127 @@ class PcdDatabase {
                     str += ", ";\r
                 }\r
             }\r
-            str += "}";\r
-\r
-            return str;\r
-        }\r
-\r
-    }\r
-\r
-    private String getDataTypeInstantiation (Token token) {\r
-\r
-        if (token.datumType == Token.DATUM_TYPE.POINTER) {\r
-            return String.format("%s /* %s */", token.getDefaultSku().value, token.getPrimaryKeyString());\r
+            str += "}";\r
+\r
+            return str;\r
+        }\r
+\r
+    }\r
+\r
+    private String getDataTypeInstantiationForVariableDefault_new (Token token, String cName, int skuId) {\r
+        return String.format("%s /* %s */", token.skuData.get(skuId).value.hiiDefaultValue, cName);\r
+    }\r
+\r
+    private String getDataTypeInstantiation (Token token) {\r
+\r
+        if (token.datumType == Token.DATUM_TYPE.POINTER) {\r
+            return String.format("%s /* %s */", token.getDefaultSku().value, token.getPrimaryKeyString());\r
+        } else {\r
+            return String.format("%s /* %s */", token.getDefaultSku().value, token.getPrimaryKeyString());\r
+        }\r
+    }\r
+\r
+    private String getCType (Token t) \r
+        throws EntityException {\r
+        \r
+        if (t.isHiiEnable()) {\r
+            return "VARIABLE_HEAD";\r
+        }\r
+        \r
+        if (t.isVpdEnable()) {\r
+            return "VPD_HEAD";\r
+        }\r
+        \r
+        if (t.isUnicodeStringType()) {\r
+            return "STRING_HEAD";\r
+        }\r
+        \r
+        switch (t.datumType) {\r
+        case UINT64:\r
+            return "UINT64";\r
+        case UINT32:\r
+            return "UINT32";\r
+        case UINT16:\r
+            return "UINT16";\r
+        case UINT8:\r
+            return "UINT8";\r
+        case BOOLEAN:\r
+            return "BOOLEAN";\r
+        case POINTER:\r
+            return "UINT8";\r
+        default:\r
+            throw new EntityException("Unknown type in getDataTypeCDeclaration");\r
+        }\r
+    }\r
+    \r
+    private void getCDeclarationString(Token t) \r
+        throws EntityException {\r
+        \r
+        if (t.isSkuEnable()) {\r
+            privateGlobalName = String.format("%s_%s", t.getPrimaryKeyString(), skuDataTableTemplate);\r
+        } else {\r
+            privateGlobalName = t.getPrimaryKeyString();\r
+        }\r
+\r
+        String type = getCType(t);\r
+        if ((t.datumType == Token.DATUM_TYPE.POINTER) && (!t.isHiiEnable())) {\r
+            int bufferSize;\r
+            if (t.isASCIIStringType()) {\r
+                //\r
+                // Build tool will add a NULL string at the end of the ASCII string\r
+                //\r
+                bufferSize = t.datumSize + 1;\r
+            } else {\r
+                bufferSize = t.datumSize;\r
+            }\r
+            privateGlobalCCode = String.format("%-20s%s[%d][%d];\r\n", type, privateGlobalName, t.getSkuIdCount(), bufferSize);\r
+        } else {\r
+            privateGlobalCCode = String.format("%-20s%s[%d];\r\n", type, privateGlobalName, t.getSkuIdCount());\r
+        }\r
+    }\r
+    \r
+    private String getDataTypeDeclarationForVariableDefault_new (Token token, String cName, int skuId) \r
+    throws EntityException {\r
+\r
+        String typeStr;\r
+\r
+        if (token.datumType == Token.DATUM_TYPE.UINT8) {\r
+            typeStr = "UINT8";\r
+        } else if (token.datumType == Token.DATUM_TYPE.UINT16) {\r
+            typeStr = "UINT16";\r
+        } else if (token.datumType == Token.DATUM_TYPE.UINT32) {\r
+            typeStr = "UINT32";\r
+        } else if (token.datumType == Token.DATUM_TYPE.UINT64) {\r
+            typeStr = "UINT64";\r
+        } else if (token.datumType == Token.DATUM_TYPE.BOOLEAN) {\r
+            typeStr = "BOOLEAN";\r
+        } else if (token.datumType == Token.DATUM_TYPE.POINTER) {\r
+            int size;\r
+            if (token.isHiiDefaultValueUnicodeStringType()) {\r
+                typeStr = "UINT16";\r
+                //\r
+                // Include the NULL charactor\r
+                //\r
+                size = token.datumSize / 2 + 1;\r
+            } else {\r
+                typeStr = "UINT8";\r
+                if (token.isHiiDefaultValueASCIIStringType()) {\r
+                    //\r
+                    // Include the NULL charactor\r
+                    //\r
+                    size = token.datumSize + 1;\r
+                } else {\r
+                    size = token.datumSize;\r
+                }\r
+            }\r
+            return String.format("%-20s%s[%d];\r\n", typeStr, cName, size);\r
         } else {\r
-            return String.format("%s /* %s */", token.getDefaultSku().value, token.getPrimaryKeyString());\r
+            throw new EntityException("Unknown DATUM_TYPE type in when generating code for VARIABLE_ENABLED PCD entry");\r
         }\r
-    }\r
-\r
 \r
+        return String.format("%-20s%s;\r\n", typeStr, cName);\r
+    }\r
+    \r
     private String getDataTypeDeclaration (Token token) {\r
 \r
         String typeStr = "";\r
@@ -1076,7 +1707,75 @@ class PcdDatabase {
     private String getVpdEnableTypeDeclaration (Token token) {\r
         return String.format("VPD_HEAD %s", token.getPrimaryKeyString());\r
     }\r
+    \r
+    private String getTypeInstantiation (Token t, ArrayList<CStructTypeDeclaration> declaList, HashMap<String, String> instTable, String phase) throws EntityException {\r
+      \r
+        int     i;\r
+\r
+        String s;\r
+        s = String.format("/* %s */", t.getPrimaryKeyString()) + newLine;\r
+        s += tab + "{" + newLine;\r
+\r
+        for (i = 0; i < t.skuData.size(); i++) {\r
+            if (t.isUnicodeStringType()) {\r
+                s += tab + tab + String.format("{ %d }", stringTable.add(t.skuData.get(i).value.value, t));\r
+            } else if (t.isHiiEnable()) {\r
+                /* VPD_HEAD definition\r
+                   typedef struct {\r
+                      UINT16  GuidTableIndex;   // Offset in Guid Table in units of GUID.\r
+                      UINT16  StringIndex;      // Offset in String Table in units of UINT16.\r
+                      UINT16  Offset;           // Offset in Variable\r
+                      UINT16  DefaultValueOffset; // Offset of the Default Value\r
+                    } VARIABLE_HEAD  ;\r
+                 */\r
+                String variableDefaultName = String.format("%s_VariableDefault_%d", t.getPrimaryKeyString(), i); \r
+                \r
+                s += tab + tab + String.format("{ %d, %d, %s, %s }", guidTable.add(t.skuData.get(i).value.variableGuid, t.getPrimaryKeyString()),\r
+                                                          stringTable.add(t.skuData.get(i).value.getStringOfVariableName(), t),\r
+                                                          t.skuData.get(i).value.variableOffset,\r
+                                                          String.format("offsetof(%s_PCD_DATABASE, Init.%s)", phase, variableDefaultName)\r
+                                                          );\r
+                //\r
+                // We need to support the default value, so we add the declaration and\r
+                // the instantiation for the default value.\r
+                //\r
+                CStructTypeDeclaration decl = new CStructTypeDeclaration (variableDefaultName,\r
+                                                        getHiiPtrTypeAlignmentSize(t),\r
+                                                        getDataTypeDeclarationForVariableDefault_new(t, variableDefaultName, i),\r
+                                                        true\r
+                                                        ); \r
+                declaList.add(decl);\r
+                instTable.put(variableDefaultName, getDataTypeInstantiationForVariableDefault_new (t, variableDefaultName, i));\r
+            } else if (t.isVpdEnable()) {\r
+                    /* typedef  struct {\r
+                        UINT32  Offset;\r
+                      } VPD_HEAD;\r
+                    */\r
+                s += tab + tab + String.format("{ %s }", t.skuData.get(i).value.vpdOffset);\r
+            } else {\r
+                if (t.isByteStreamType()) {\r
+                    //\r
+                    // Byte stream type input has their own "{" "}", so we won't help to insert.\r
+                    //\r
+                    s += tab + tab + String.format(" %s ", t.skuData.get(i).value.value);\r
+                } else {\r
+                    s += tab + tab + String.format("{ %s }", t.skuData.get(i).value.value);\r
+                }\r
+            }\r
+            \r
+            if (i != t.skuData.size() - 1) {\r
+                s += commaNewLine;\r
+            } else {\r
+                s += newLine;\r
+            }\r
 \r
+        }\r
+        \r
+        s += tab + "}";\r
+        \r
+        return s;\r
+    }\r
+    \r
     private String getVpdEnableTypeInstantiation (Token token) {\r
         return String.format("{ %s } /* %s */", token.getDefaultSku().vpdOffset,\r
                                                 token.getPrimaryKeyString());\r
@@ -1183,12 +1882,25 @@ class PcdDatabase {
 }\r
 \r
 class ModuleInfo {\r
-    public ModuleSADocument.ModuleSA module;\r
-    public UsageInstance.MODULE_TYPE type;\r
+    private String                  type;\r
+    private FpdModuleIdentification moduleId;\r
+    private PcdBuildDefinitionDocument.PcdBuildDefinition pcdBuildDef;\r
+    \r
+    \r
 \r
-    public ModuleInfo (ModuleSADocument.ModuleSA module, UsageInstance.MODULE_TYPE type) {\r
-        this.module = module;\r
+    public ModuleInfo (FpdModuleIdentification moduleId, String type, XmlObject pcdDef) {\r
+        this.moduleId = moduleId;\r
         this.type   = type;\r
+        this.pcdBuildDef = ((PcdBuildDefinitionDocument)pcdDef).getPcdBuildDefinition();\r
+    }\r
+    public String getModuleType (){\r
+       return this.type;\r
+    }\r
+    public FpdModuleIdentification getModuleId (){\r
+       return this.moduleId;\r
+    }\r
+    public PcdBuildDefinitionDocument.PcdBuildDefinition getPcdBuildDef(){\r
+       return this.pcdBuildDef;\r
     }\r
 }\r
 \r
@@ -1210,8 +1922,11 @@ public class CollectPCDAction {
     private int                   originalMessageLevel;\r
 \r
     /// Cache the fpd docment instance for private usage.\r
-    private FrameworkPlatformDescriptionDocument fpdDocInstance;\r
-\r
+    private PlatformSurfaceAreaDocument fpdDocInstance;\r
+    \r
+    /// xmlObject name\r
+    private static String xmlObjectName = "PcdBuildDefinition"; \r
+       \r
     /**\r
       Set WorkspacePath parameter for this action class.\r
 \r
@@ -1278,7 +1993,7 @@ public class CollectPCDAction {
       @throws  EntityException Exception indicate failed to execute this action.\r
       \r
     **/\r
-    private void execute() throws EntityException {\r
+    public void execute() throws EntityException {\r
         //\r
         // Get memoryDatabaseManager instance from GlobalData.\r
         // The memoryDatabaseManager should be initialized for whatever build\r
@@ -1319,19 +2034,19 @@ public class CollectPCDAction {
 \r
         dbManager.getTwoPhaseDynamicRecordArray(alPei, alDxe);\r
         PcdDatabase pcdPeiDatabase = new PcdDatabase (alPei, "PEI", 0);\r
-        pcdPeiDatabase.genCode();\r
-        dbManager.PcdPeimHString        = PcdCommonHeaderString + pcdPeiDatabase.getHString()\r
+        pcdPeiDatabase.genCodeNew();\r
+        MemoryDatabaseManager.PcdPeimHString        = PcdCommonHeaderString + pcdPeiDatabase.getHString()\r
                                             + PcdDatabase.getPcdPeiDatabaseDefinitions();\r
-        dbManager.PcdPeimCString        = pcdPeiDatabase.getCString();\r
+        MemoryDatabaseManager.PcdPeimCString        = pcdPeiDatabase.getCString();\r
 \r
         PcdDatabase pcdDxeDatabase = new PcdDatabase (alDxe, \r
                                                       "DXE",\r
                                                       alPei.size()\r
                                                       );\r
-        pcdDxeDatabase.genCode();\r
-        dbManager.PcdDxeHString   = dbManager.PcdPeimHString + pcdDxeDatabase.getHString()\r
+        pcdDxeDatabase.genCodeNew();\r
+        MemoryDatabaseManager.PcdDxeHString   = MemoryDatabaseManager.PcdPeimHString + pcdDxeDatabase.getHString()\r
                                       + PcdDatabase.getPcdDxeDatabaseDefinitions();\r
-        dbManager.PcdDxeCString   = pcdDxeDatabase.getCString();\r
+        MemoryDatabaseManager.PcdDxeCString   = pcdDxeDatabase.getCString();\r
     }\r
 \r
     /**\r
@@ -1344,18 +2059,16 @@ public class CollectPCDAction {
      */\r
     private List<ModuleInfo> getComponentsFromFPD() \r
         throws EntityException {\r
-        HashMap<String, XmlObject>  map         = new HashMap<String, XmlObject>();\r
         List<ModuleInfo>            allModules  = new ArrayList<ModuleInfo>();\r
         ModuleInfo                  current     = null;\r
         int                         index       = 0;\r
-        org.tianocore.Components    components  = null;\r
         FrameworkModulesDocument.FrameworkModules fModules = null;\r
-        java.util.List<ModuleSADocument.ModuleSA> modules  = null;\r
-        \r
+        ModuleSADocument.ModuleSA[]               modules  = null;\r
+        HashMap<String, XmlObject>                map      = new HashMap<String, XmlObject>();\r
 \r
         if (fpdDocInstance == null) {\r
             try {\r
-                fpdDocInstance = (FrameworkPlatformDescriptionDocument)XmlObject.Factory.parse(new File(fpdFilePath));\r
+                fpdDocInstance = (PlatformSurfaceAreaDocument)XmlObject.Factory.parse(new File(fpdFilePath));\r
             } catch(IOException ioE) {\r
                 throw new EntityException("File IO error for xml file:" + fpdFilePath + "\n" + ioE.getMessage());\r
             } catch(XmlException xmlE) {\r
@@ -1364,64 +2077,12 @@ public class CollectPCDAction {
 \r
         }\r
 \r
-        //\r
-        // Check whether FPD contians <FramworkModules>\r
-        // \r
-        fModules = fpdDocInstance.getFrameworkPlatformDescription().getFrameworkModules();\r
-        if (fModules == null) {\r
-            return null;\r
-        }\r
-\r
-        //\r
-        // BUGBUG: The following is work around code, the final component type should be get from\r
-        // GlobalData class.\r
-        // \r
-        components = fModules.getSEC();\r
-        if (components != null) {\r
-            modules = components.getModuleSAList();\r
-            for (index = 0; index < modules.size(); index ++) {\r
-                allModules.add(new ModuleInfo(modules.get(index), UsageInstance.MODULE_TYPE.SEC));\r
-            }\r
-        }\r
-\r
-        components = fModules.getPEICORE();\r
-        if (components != null) {\r
-            modules = components.getModuleSAList();\r
-            for (index = 0; index < modules.size(); index ++) {\r
-                allModules.add(new ModuleInfo(modules.get(index), UsageInstance.MODULE_TYPE.PEI_CORE));\r
-            }\r
-        }\r
-\r
-        components = fModules.getPEIM();\r
-        if (components != null) {\r
-            modules = components.getModuleSAList();\r
-            for (index = 0; index < modules.size(); index ++) {\r
-                allModules.add(new ModuleInfo(modules.get(index), UsageInstance.MODULE_TYPE.PEIM));\r
-            }\r
-        }\r
-\r
-        components = fModules.getDXECORE();\r
-        if (components != null) {\r
-            modules = components.getModuleSAList();\r
-            for (index = 0; index < modules.size(); index ++) {\r
-                allModules.add(new ModuleInfo(modules.get(index), UsageInstance.MODULE_TYPE.DXE_CORE));\r
-            }\r
-        }\r
-\r
-        components = fModules.getDXEDRIVERS();\r
-        if (components != null) {\r
-            modules = components.getModuleSAList();\r
-            for (index = 0; index < modules.size(); index ++) {\r
-                allModules.add(new ModuleInfo(modules.get(index), UsageInstance.MODULE_TYPE.DXE_DRIVERS));\r
-            }\r
-        }\r
-\r
-        components = fModules.getOTHERCOMPONENTS();\r
-        if (components != null) {\r
-            modules = components.getModuleSAList();\r
-            for (index = 0; index < modules.size(); index ++) {\r
-                allModules.add(new ModuleInfo(modules.get(index), UsageInstance.MODULE_TYPE.OTHER_COMPONENTS));\r
-            }\r
+        Map<FpdModuleIdentification,XmlObject>pcdBuildDef = GlobalData.getFpdModuleSaXmlObject(CollectPCDAction.xmlObjectName);\r
+        Set<FpdModuleIdentification> pcdBuildKeySet = pcdBuildDef.keySet();\r
+        Iterator item = pcdBuildKeySet.iterator();\r
+        while (item.hasNext()){\r
+            FpdModuleIdentification id = (FpdModuleIdentification)item.next();\r
+            allModules.add(new ModuleInfo(id, id.getModule().getModuleType(),pcdBuildDef.get(id)));    \r
         }\r
         \r
         return allModules;\r
@@ -1456,10 +2117,11 @@ public class CollectPCDAction {
         boolean                             isDuplicate       = false;\r
         Token.PCD_TYPE                      pcdType           = Token.PCD_TYPE.UNKNOWN;\r
         Token.DATUM_TYPE                    datumType         = Token.DATUM_TYPE.UNKNOWN;\r
-        int                                 tokenNumber       = 0;\r
+        long                                tokenNumber       = 0;\r
         String                              moduleName        = null;\r
         String                              datum             = null;\r
         int                                 maxDatumSize      = 0;\r
+        String[]                            tokenSpaceStrRet  = null;\r
 \r
         //\r
         // ----------------------------------------------\r
@@ -1469,7 +2131,7 @@ public class CollectPCDAction {
         modules = getComponentsFromFPD();\r
 \r
         if (modules == null) {\r
-            throw new EntityException("No modules in FPD file, Please check whether there are elements in <FrameworkModules> in FPD file!");\r
+            throw new EntityException("[FPD file error] No modules in FPD file, Please check whether there are elements in <FrameworkModules> in FPD file!");\r
         }\r
 \r
         //\r
@@ -1484,17 +2146,17 @@ public class CollectPCDAction {
                 // BUGBUG: For transition schema, we can *not* get module's version from \r
                 // <ModuleSAs>, It is work around code.\r
                 // \r
-                primaryKey1 = UsageInstance.getPrimaryKey(modules.get(index).module.getModuleName(), \r
-                                                          translateSchemaStringToUUID(modules.get(index).module.getModuleGuid()),\r
-                                                          modules.get(index).module.getPackageName(), \r
-                                                          translateSchemaStringToUUID(modules.get(index).module.getPackageGuid())\r
-                                                          modules.get(index).module.getArch().toString(),\r
+                primaryKey1 = UsageInstance.getPrimaryKey(modules.get(index).getModuleId().getModule().getName(), \r
+                                                          null,\r
+                                                          null,\r
+                                                          null\r
+                                                          modules.get(index).getModuleId().getArch(),\r
                                                           null);\r
-                primaryKey2 = UsageInstance.getPrimaryKey(modules.get(index2).module.getModuleName(), \r
-                                                          translateSchemaStringToUUID(modules.get(index2).module.getModuleGuid())\r
-                                                          modules.get(index2).module.getPackageName()\r
-                                                          translateSchemaStringToUUID(modules.get(index2).module.getPackageGuid())\r
-                                                          modules.get(index2).module.getArch().toString(), \r
+                primaryKey2 = UsageInstance.getPrimaryKey(modules.get(index2).getModuleId().getModule().getName(), \r
+                                                          null\r
+                                                          null\r
+                                                          null\r
+                                                          modules.get(index2).getModuleId().getArch(), \r
                                                           null);\r
                 if (primaryKey1.equalsIgnoreCase(primaryKey2)) {\r
                     isDuplicate = true;\r
@@ -1509,13 +2171,13 @@ public class CollectPCDAction {
            //\r
            // It is legal for a module does not contains ANY pcd build definitions.\r
            // \r
-           if (modules.get(index).module.getPcdBuildDefinition() == null) {\r
+           if (modules.get(index).getPcdBuildDef() == null) {\r
                 continue;\r
            }\r
     \r
-            pcdBuildDataArray = modules.get(index).module.getPcdBuildDefinition().getPcdDataList();\r
+            pcdBuildDataArray = modules.get(index).getPcdBuildDef().getPcdDataList();\r
 \r
-            moduleName = modules.get(index).module.getModuleName();\r
+            moduleName = modules.get(index).getModuleId().getModule().getName();\r
 \r
             //\r
             // ----------------------------------------------------------------------\r
@@ -1524,14 +2186,38 @@ public class CollectPCDAction {
             // \r
             for (pcdIndex = 0; pcdIndex < pcdBuildDataArray.size(); pcdIndex ++) {\r
                 pcdBuildData = pcdBuildDataArray.get(pcdIndex);\r
+                \r
+                try {\r
+                    tokenSpaceStrRet = GlobalData.getGuidInfoFromCname(pcdBuildData.getTokenSpaceGuidCName());\r
+                } catch ( Exception e ) {\r
+                    throw new EntityException ("Faile get Guid for token " + pcdBuildData.getCName() + ":" + e.getMessage());\r
+                }\r
+\r
+                if (tokenSpaceStrRet == null) {\r
+                    throw new EntityException ("Fail to get Token space guid for token" + pcdBuildData.getCName());\r
+                } \r
+\r
                 primaryKey   = Token.getPrimaryKeyString(pcdBuildData.getCName(),\r
-                                                         translateSchemaStringToUUID(pcdBuildData.getTokenSpaceGuid()));\r
+                                                         translateSchemaStringToUUID(tokenSpaceStrRet[1]));\r
                 pcdType      = Token.getpcdTypeFromString(pcdBuildData.getItemType().toString());\r
                 datumType    = Token.getdatumTypeFromString(pcdBuildData.getDatumType().toString());\r
-                tokenNumber  = Integer.decode(pcdBuildData.getToken().toString());\r
-                datum        = pcdBuildData.getValue();\r
+                tokenNumber  = Long.decode(pcdBuildData.getToken().toString());\r
+                if (pcdBuildData.getValue() != null) {\r
+                    datum = pcdBuildData.getValue().toString();\r
+                } else {\r
+                    datum = null;\r
+                }\r
                 maxDatumSize = pcdBuildData.getMaxDatumSize();\r
 \r
+                if ((pcdType    == Token.PCD_TYPE.FEATURE_FLAG) &&\r
+                    (datumType  != Token.DATUM_TYPE.BOOLEAN)){\r
+                    exceptionString = String.format("[FPD file error] For PCD %s in module %s, the PCD type is FEATRUE_FLAG but "+\r
+                                                    "datum type of this PCD entry is not BOOLEAN!",\r
+                                                    pcdBuildData.getCName(),\r
+                                                    moduleName);\r
+                    throw new EntityException(exceptionString);\r
+                }\r
+\r
                 //\r
                 // -------------------------------------------------------------------------------------------\r
                 // 2.1.1), Do some necessary checking work for FixedAtBuild, FeatureFlag and PatchableInModule\r
@@ -1542,7 +2228,7 @@ public class CollectPCDAction {
                      // Value is required.\r
                      // \r
                      if (datum == null) {\r
-                         exceptionString = String.format("There is no value for PCD entry %s in module %s!",\r
+                         exceptionString = String.format("[FPD file error] There is no value for PCD entry %s in module %s!",\r
                                                          pcdBuildData.getCName(),\r
                                                          moduleName);\r
                          throw new EntityException(exceptionString);\r
@@ -1551,10 +2237,11 @@ public class CollectPCDAction {
                      //\r
                      // Check whether the datum size is matched datum type.\r
                      // \r
-                     if ((exceptionString = verifyDatumSize(pcdBuildData.getCName(), \r
-                                                            moduleName,\r
-                                                            maxDatumSize, \r
-                                                            datumType)) != null) {\r
+                     if ((exceptionString = verifyDatum(pcdBuildData.getCName(), \r
+                                                        moduleName,\r
+                                                        datum,\r
+                                                        datumType,\r
+                                                        maxDatumSize)) != null) {\r
                          throw new EntityException(exceptionString);\r
                      }\r
                 }\r
@@ -1576,7 +2263,7 @@ public class CollectPCDAction {
                     // modules.\r
                     // \r
                     if (token.datumType != datumType) {\r
-                        exceptionString = String.format("The datum type of PCD entry %s is %s, which is different with  %s defined in before!",\r
+                        exceptionString = String.format("[FPD file error] The datum type of PCD entry %s is %s, which is different with  %s defined in before!",\r
                                                         pcdBuildData.getCName(), \r
                                                         pcdBuildData.getDatumType().toString(), \r
                                                         Token.getStringOfdatumType(token.datumType));\r
@@ -1587,7 +2274,7 @@ public class CollectPCDAction {
                     // Check token number is valid\r
                     // \r
                     if (tokenNumber != token.tokenNumber) {\r
-                        exceptionString = String.format("The token number of PCD entry %s in module %s is different with same PCD entry in other modules!",\r
+                        exceptionString = String.format("[FPD file error] The token number of PCD entry %s in module %s is different with same PCD entry in other modules!",\r
                                                         pcdBuildData.getCName(),\r
                                                         moduleName);\r
                         throw new EntityException(exceptionString);\r
@@ -1597,7 +2284,7 @@ public class CollectPCDAction {
                     // For same PCD used in different modules, the PCD type should all be dynamic or non-dynamic.\r
                     // \r
                     if (token.isDynamicPCD != Token.isDynamic(pcdType)) {\r
-                        exceptionString = String.format("For PCD entry %s in module %s, you define dynamic or non-dynamic PCD type which"+\r
+                        exceptionString = String.format("[FPD file error] For PCD entry %s in module %s, you define dynamic or non-dynamic PCD type which"+\r
                                                         "is different with others module's",\r
                                                         token.cName,\r
                                                         moduleName);\r
@@ -1611,15 +2298,28 @@ public class CollectPCDAction {
                         // But if you write, the <Value> must be same as the value in <DynamicPcdBuildDefinitions>.\r
                         // \r
                         if (!token.isSkuEnable() && \r
-                            (token.skuData.get(0).value.type == DynamicTokenValue.VALUE_TYPE.DEFAULT_TYPE)) {\r
-                            if (!datum.equalsIgnoreCase(token.skuData.get(0).value.value)) {\r
-                                exceptionString = String.format("For dynamic PCD %s in module %s, the datum in <ModuleSA> is "+\r
+                            (token.getDefaultSku().type == DynamicTokenValue.VALUE_TYPE.DEFAULT_TYPE) &&\r
+                            (datum != null)) {\r
+                            if (!datum.equalsIgnoreCase(token.getDefaultSku().value)) {\r
+                                exceptionString = String.format("[FPD file error] For dynamic PCD %s in module %s, the datum in <ModuleSA> is "+\r
                                                                 "not equal to the datum in <DynamicPcdBuildDefinitions>, it is "+\r
-                                                                "illega! You can choose no <Value> in <ModuleSA>!",\r
+                                                                "illega! You could no set <Value> in <ModuleSA> for a dynamic PCD!",\r
                                                                 token.cName,\r
                                                                 moduleName);\r
+                                throw new EntityException(exceptionString);\r
                             }\r
                         }\r
+\r
+                        if ((maxDatumSize != 0) &&\r
+                            (maxDatumSize != token.datumSize)){\r
+                            exceptionString = String.format("[FPD file error] For dynamic PCD %s in module %s, the max datum size is %d which "+\r
+                                                            "is different with <MaxDatumSize> %d defined in <DynamicPcdBuildDefinitions>!",\r
+                                                            token.cName,\r
+                                                            moduleName,\r
+                                                            maxDatumSize,\r
+                                                            token.datumSize);\r
+                            throw new EntityException(exceptionString);\r
+                        }\r
                     }\r
                     \r
                 } else {\r
@@ -1627,8 +2327,18 @@ public class CollectPCDAction {
                     // If the token is not in database, create a new token instance and add\r
                     // a usage instance into this token in database.\r
                     // \r
+                    try {\r
+                        tokenSpaceStrRet = GlobalData.getGuidInfoFromCname(pcdBuildData.getTokenSpaceGuidCName());\r
+                    } catch (Exception e) {\r
+                        throw new EntityException("Fail to get token space guid for token " + token.cName);\r
+                    }\r
+\r
+                    if (tokenSpaceStrRet == null) {\r
+                        throw new EntityException("Fail to get token space guid for token " + token.cName);\r
+                    }\r
+\r
                     token = new Token(pcdBuildData.getCName(), \r
-                                      translateSchemaStringToUUID(pcdBuildData.getTokenSpaceGuid()));\r
+                                      translateSchemaStringToUUID(tokenSpaceStrRet[1]));\r
     \r
                     token.datumType     = datumType;\r
                     token.tokenNumber   = tokenNumber;\r
@@ -1663,12 +2373,12 @@ public class CollectPCDAction {
                 // \r
                 usageInstance = new UsageInstance(token, \r
                                                   moduleName, \r
-                                                  translateSchemaStringToUUID(modules.get(index).module.getModuleGuid()),\r
-                                                  modules.get(index).module.getPackageName(),\r
-                                                  translateSchemaStringToUUID(modules.get(index).module.getPackageGuid()),\r
-                                                  modules.get(index).type\r
+                                                  null,\r
+                                                  null,\r
+                                                  null,\r
+                                                  CommonDefinition.getModuleType(modules.get(index).getModuleType())\r
                                                   pcdType,\r
-                                                  modules.get(index).module.getArch().toString(), \r
+                                                  modules.get(index).getModuleId().getArch(), \r
                                                   null,\r
                                                   datum,\r
                                                   maxDatumSize);\r
@@ -1677,6 +2387,331 @@ public class CollectPCDAction {
         }\r
     }\r
 \r
+    /**\r
+       Verify the datum value according its datum size and datum type, this\r
+       function maybe moved to FPD verification tools in future.\r
+       \r
+       @param cName\r
+       @param moduleName\r
+       @param datum\r
+       @param datumType\r
+       @param maxDatumSize\r
+       \r
+       @return String\r
+     */\r
+    /***/\r
+    public String verifyDatum(String            cName,\r
+                              String            moduleName,\r
+                              String            datum, \r
+                              Token.DATUM_TYPE  datumType, \r
+                              int               maxDatumSize) {\r
+        String      exceptionString = null;\r
+        int         value;\r
+        BigInteger  value64;\r
+        String      subStr;\r
+        int         index;\r
+\r
+        if (moduleName == null) {\r
+            moduleName = "section <DynamicPcdBuildDefinitions>";\r
+        } else {\r
+            moduleName = "module " + moduleName;\r
+        }\r
+\r
+        if (maxDatumSize == 0) {\r
+            exceptionString = String.format("[FPD file error] You maybe miss <MaxDatumSize> for PCD %s in %s",\r
+                                            cName,\r
+                                            moduleName);\r
+            return exceptionString;\r
+        }\r
+\r
+        switch (datumType) {\r
+        case UINT8:\r
+            if (maxDatumSize != 1) {\r
+                exceptionString = String.format("[FPD file error] The datum type of PCD data %s in %s "+\r
+                                                "is UINT8, but datum size is %d, they are not matched!",\r
+                                                 cName,\r
+                                                 moduleName,\r
+                                                 maxDatumSize);\r
+                return exceptionString;\r
+            }\r
+\r
+            if (datum != null) {\r
+                try {\r
+                    value = Integer.decode(datum);\r
+                } catch (NumberFormatException nfeExp) {\r
+                    exceptionString = String.format("[FPD file error] The datum for PCD %s in %s is not valid "+\r
+                                                    "digital format of UINT8",\r
+                                                    cName,\r
+                                                    moduleName);\r
+                    return exceptionString;\r
+                }\r
+                if (value > 0xFF) {\r
+                    exceptionString = String.format("[FPD file error] The datum for PCD %s in %s is %s exceed"+\r
+                                                    " the max size of UINT8 - 0xFF",\r
+                                                    cName, \r
+                                                    moduleName,\r
+                                                    datum);\r
+                    return exceptionString;\r
+                }\r
+            }\r
+            break;\r
+        case UINT16:\r
+            if (maxDatumSize != 2) {\r
+                exceptionString = String.format("[FPD file error] The datum type of PCD data %s in %s "+\r
+                                                "is UINT16, but datum size is %d, they are not matched!",\r
+                                                 cName,\r
+                                                 moduleName,\r
+                                                 maxDatumSize);\r
+                return exceptionString;\r
+            }\r
+            if (datum != null) {\r
+                try {\r
+                    value = Integer.decode(datum);\r
+                } catch (NumberFormatException nfeExp) {\r
+                    exceptionString = String.format("[FPD file error] The datum for PCD %s in %s is "+\r
+                                                    "not valid digital of UINT16",\r
+                                                    cName,\r
+                                                    moduleName);\r
+                    return exceptionString;\r
+                }\r
+                if (value > 0xFFFF) {\r
+                    exceptionString = String.format("[FPD file error] The datum for PCD %s in %s is %s "+\r
+                                                    "which exceed the range of UINT16 - 0xFFFF",\r
+                                                    cName, \r
+                                                    moduleName,\r
+                                                    datum);\r
+                    return exceptionString;\r
+                }\r
+            }\r
+            break;\r
+        case UINT32:\r
+            if (maxDatumSize != 4) {\r
+                exceptionString = String.format("[FPD file error] The datum type of PCD data %s in %s "+\r
+                                                "is UINT32, but datum size is %d, they are not matched!",\r
+                                                 cName,\r
+                                                 moduleName,\r
+                                                 maxDatumSize);\r
+                return exceptionString;\r
+            }\r
+\r
+            if (datum != null) {\r
+                try {\r
+                    if (datum.length() > 2) {\r
+                        if ((datum.charAt(0) == '0')        && \r
+                            ((datum.charAt(1) == 'x') || (datum.charAt(1) == 'X'))){\r
+                            subStr = datum.substring(2, datum.length());\r
+                            value64 = new BigInteger(subStr, 16);\r
+                        } else {\r
+                            value64 = new BigInteger(datum);\r
+                        }\r
+                    } else {\r
+                        value64 = new BigInteger(datum);\r
+                    }\r
+                } catch (NumberFormatException nfeExp) {\r
+                    exceptionString = String.format("[FPD file error] The datum for PCD %s in %s is not "+\r
+                                                    "valid digital of UINT32",\r
+                                                    cName,\r
+                                                    moduleName);\r
+                    return exceptionString;\r
+                }\r
+\r
+                if (value64.bitLength() > 32) {\r
+                    exceptionString = String.format("[FPD file error] The datum for PCD %s in %s is %s which "+\r
+                                                    "exceed the range of UINT32 - 0xFFFFFFFF",\r
+                                                    cName, \r
+                                                    moduleName,\r
+                                                    datum);\r
+                    return exceptionString;\r
+                }\r
+            }\r
+            break;\r
+        case UINT64:\r
+            if (maxDatumSize != 8) {\r
+                exceptionString = String.format("[FPD file error] The datum type of PCD data %s in %s "+\r
+                                                "is UINT64, but datum size is %d, they are not matched!",\r
+                                                 cName,\r
+                                                 moduleName,\r
+                                                 maxDatumSize);\r
+                return exceptionString;\r
+            }\r
+\r
+            if (datum != null) {\r
+                try {\r
+                    if (datum.length() > 2) {\r
+                        if ((datum.charAt(0) == '0')        && \r
+                            ((datum.charAt(1) == 'x') || (datum.charAt(1) == 'X'))){\r
+                            subStr = datum.substring(2, datum.length());\r
+                            value64 = new BigInteger(subStr, 16);\r
+                        } else {\r
+                            value64 = new BigInteger(datum);\r
+                        }\r
+                    } else {\r
+                        value64 = new BigInteger(datum);\r
+                    }\r
+                } catch (NumberFormatException nfeExp) {\r
+                    exceptionString = String.format("[FPD file error] The datum for PCD %s in %s is not valid"+\r
+                                                    " digital of UINT64",\r
+                                                    cName,\r
+                                                    moduleName);\r
+                    return exceptionString;\r
+                }\r
+\r
+                if (value64.bitLength() > 64) {\r
+                    exceptionString = String.format("[FPD file error] The datum for PCD %s in %s is %s "+\r
+                                                    "exceed the range of UINT64 - 0xFFFFFFFFFFFFFFFF",\r
+                                                    cName, \r
+                                                    moduleName,\r
+                                                    datum);\r
+                    return exceptionString;\r
+                }\r
+            }\r
+            break;\r
+        case BOOLEAN:\r
+            if (maxDatumSize != 1) {\r
+                exceptionString = String.format("[FPD file error] The datum type of PCD data %s in %s "+\r
+                                                "is BOOLEAN, but datum size is %d, they are not matched!",\r
+                                                 cName,\r
+                                                 moduleName,\r
+                                                 maxDatumSize);\r
+                return exceptionString;\r
+            }\r
+\r
+            if (datum != null) {\r
+                if (!(datum.equalsIgnoreCase("TRUE") ||\r
+                     datum.equalsIgnoreCase("FALSE"))) {\r
+                    exceptionString = String.format("[FPD file error] The datum type of PCD data %s in %s "+\r
+                                                    "is BOOELAN, but value is not 'true'/'TRUE' or 'FALSE'/'false'",\r
+                                                    cName,\r
+                                                    moduleName);\r
+                    return exceptionString;\r
+                }\r
+\r
+            }\r
+            break;\r
+        case POINTER:\r
+            if (datum == null) {\r
+                break;\r
+            }\r
+\r
+            char    ch     = datum.charAt(0);\r
+            int     start, end;\r
+            String  strValue;\r
+            //\r
+            // For void* type PCD, only three datum is support:\r
+            // 1) Unicode: string with start char is "L"\r
+            // 2) Ansci: String start char is ""\r
+            // 3) byte array: String start char "{"\r
+            // \r
+            if (ch == 'L') {\r
+                start       = datum.indexOf('\"');\r
+                end         = datum.lastIndexOf('\"');\r
+                if ((start > end)           || \r
+                    (end   > datum.length())||\r
+                    ((start == end) && (datum.length() > 0))) {\r
+                    exceptionString = String.format("[FPD file error] The datum type of PCD %s in %s is VOID* and datum is "+\r
+                                                    "a UNICODE string because start with L\", but format maybe"+\r
+                                                    "is not right, correct UNICODE string is L\"...\"!",\r
+                                                    cName,\r
+                                                    moduleName);\r
+                    return exceptionString;\r
+                }\r
+\r
+                strValue    = datum.substring(start + 1, end);\r
+                if ((strValue.length() * 2) > maxDatumSize) {\r
+                    exceptionString = String.format("[FPD file error] The datum type of PCD %s in %s is VOID*, and datum is "+\r
+                                                    "a UNICODE string, but the datum size is %d exceed to <MaxDatumSize> : %d",\r
+                                                    cName,\r
+                                                    moduleName,\r
+                                                    strValue.length() * 2, \r
+                                                    maxDatumSize);\r
+                    return exceptionString;\r
+                }\r
+            } else if (ch == '\"'){\r
+                start       = datum.indexOf('\"');\r
+                end         = datum.lastIndexOf('\"');\r
+                if ((start > end)           || \r
+                    (end   > datum.length())||\r
+                    ((start == end) && (datum.length() > 0))) {\r
+                    exceptionString = String.format("[FPD file error] The datum type of PCD %s in %s is VOID* and datum is "+\r
+                                                    "a ANSCII string because start with \", but format maybe"+\r
+                                                    "is not right, correct ANSIC string is \"...\"!",\r
+                                                    cName,\r
+                                                    moduleName);\r
+                    return exceptionString;\r
+                }\r
+                strValue    = datum.substring(start + 1, end);\r
+                if ((strValue.length()) > maxDatumSize) {\r
+                    exceptionString = String.format("[FPD file error] The datum type of PCD %s in %s is VOID*, and datum is "+\r
+                                                    "a ANSCI string, but the datum size is %d which exceed to <MaxDatumSize> : %d",\r
+                                                    cName,\r
+                                                    moduleName,\r
+                                                    strValue.length(),\r
+                                                    maxDatumSize);\r
+                    return exceptionString;\r
+                }\r
+            } else if (ch =='{') {\r
+                String[]  strValueArray;\r
+\r
+                start           = datum.indexOf('{');\r
+                end             = datum.lastIndexOf('}');\r
+                strValue        = datum.substring(start + 1, end);\r
+                strValue        = strValue.trim();\r
+                if (strValue.length() == 0) {\r
+                    break;\r
+                }\r
+                strValueArray   = strValue.split(",");\r
+                for (index = 0; index < strValueArray.length; index ++) {\r
+                    try{\r
+                        value = Integer.decode(strValueArray[index].trim());\r
+                    } catch (NumberFormatException nfeEx) {\r
+                        exceptionString = String.format("[FPD file error] The datum type of PCD %s in %s is VOID*, and "+\r
+                                                         "it is byte array in fact. For every byte in array should be a valid"+\r
+                                                         "byte digital, but element %s is not a valid byte digital!",\r
+                                                         cName,\r
+                                                         moduleName,\r
+                                                         strValueArray[index]);\r
+                        return exceptionString;\r
+                    }\r
+                    if (value > 0xFF) {\r
+                        exceptionString = String.format("[FPD file error] The datum type of PCD %s in %s is VOID*, "+\r
+                                                        "it is byte array in fact. But the element of %s exceed the byte range",\r
+                                                        cName,\r
+                                                        moduleName,\r
+                                                        strValueArray[index]);\r
+                        return exceptionString;\r
+                    }\r
+                }\r
+\r
+                if (strValueArray.length > maxDatumSize) {\r
+                    exceptionString = String.format("[FPD file error] The datum type of PCD %s in %s is VOID*, and datum is byte"+\r
+                                                    "array, but the number of bytes is %d which exceed to <MaxDatumSzie> : %d!",\r
+                                                    cName,\r
+                                                    moduleName,\r
+                                                    strValueArray.length,\r
+                                                    maxDatumSize);\r
+                    return exceptionString;\r
+                }\r
+            } else {\r
+                exceptionString = String.format("[FPD file error] The datum type of PCD %s in %s is VOID*. For VOID* type, you have three format choise:\n "+\r
+                                                "1) UNICODE string: like L\"xxxx\";\r\n"+\r
+                                                "2) ANSIC string: like \"xxx\";\r\n"+\r
+                                                "3) Byte array: like {0x2, 0x45, 0x23}\r\n"+\r
+                                                "But the datum in seems does not following above format!",\r
+                                                cName, \r
+                                                moduleName);\r
+                return exceptionString;\r
+            }\r
+            break;\r
+        default:\r
+            exceptionString = String.format("[FPD file error] For PCD entry %s in %s, datum type is unknown, it should be one of "+\r
+                                            "UINT8, UINT16, UINT32, UINT64, VOID*, BOOLEAN",\r
+                                            cName,\r
+                                            moduleName);\r
+            return exceptionString;\r
+        }\r
+        return null;\r
+    }\r
+\r
     /**\r
        Get dynamic information for a dynamic PCD from <DynamicPcdBuildDefinition> seciton in FPD file.\r
        \r
@@ -1696,23 +2731,24 @@ public class CollectPCDAction {
         String dynamicPrimaryKey = null;\r
         DynamicPcdBuildDefinitions                    dynamicPcdBuildDefinitions = null;\r
         List<DynamicPcdBuildDefinitions.PcdBuildData> dynamicPcdBuildDataArray   = null;\r
+        String[]                                      tokenSpaceStrRet           = null;\r
 \r
         //\r
         // If FPD document is not be opened, open and initialize it.\r
         // \r
         if (fpdDocInstance == null) {\r
             try {\r
-                fpdDocInstance = (FrameworkPlatformDescriptionDocument)XmlObject.Factory.parse(new File(fpdFilePath));\r
+                fpdDocInstance = (PlatformSurfaceAreaDocument)XmlObject.Factory.parse(new File(fpdFilePath));\r
             } catch(IOException ioE) {\r
                 throw new EntityException("File IO error for xml file:" + fpdFilePath + "\n" + ioE.getMessage());\r
             } catch(XmlException xmlE) {\r
                 throw new EntityException("Can't parse the FPD xml fle:" + fpdFilePath + "\n" + xmlE.getMessage());\r
             }\r
         }\r
-\r
-        dynamicPcdBuildDefinitions = fpdDocInstance.getFrameworkPlatformDescription().getDynamicPcdBuildDefinitions();\r
+        \r
+        dynamicPcdBuildDefinitions = fpdDocInstance.getPlatformSurfaceArea().getDynamicPcdBuildDefinitions();\r
         if (dynamicPcdBuildDefinitions == null) {\r
-            exceptionString = String.format("There are no <PcdDynamicBuildDescriptions> in FPD file but contains Dynamic type "+\r
+            exceptionString = String.format("[FPD file error] There are no <PcdDynamicBuildDescriptions> in FPD file but contains Dynamic type "+\r
                                             "PCD entry %s in module %s!",\r
                                             token.cName,\r
                                             moduleName);\r
@@ -1721,8 +2757,20 @@ public class CollectPCDAction {
 \r
         dynamicPcdBuildDataArray = dynamicPcdBuildDefinitions.getPcdBuildDataList();\r
         for (index = 0; index < dynamicPcdBuildDataArray.size(); index ++) {\r
+            //String tokenSpaceGuidString = GlobalData.getGuidInfoFromCname(dynamicPcdBuildDataArray.get(index).getTokenSpaceGuidCName())[1];\r
+            String tokenSpaceGuidString = null;\r
+            try {\r
+                tokenSpaceStrRet = GlobalData.getGuidInfoFromCname(dynamicPcdBuildDataArray.get(index).getTokenSpaceGuidCName());\r
+            } catch (Exception e) {\r
+                throw new EntityException ("Fail to get token space guid for token " + dynamicPcdBuildDataArray.get(index).getCName());\r
+            }\r
+            \r
+            if (tokenSpaceStrRet == null) {\r
+                throw new EntityException ("Fail to get token space guid for token " + dynamicPcdBuildDataArray.get(index).getCName());\r
+            }\r
+\r
             dynamicPrimaryKey = Token.getPrimaryKeyString(dynamicPcdBuildDataArray.get(index).getCName(),\r
-                                                          translateSchemaStringToUUID(dynamicPcdBuildDataArray.get(index).getTokenSpaceGuid()));\r
+                                                          translateSchemaStringToUUID(tokenSpaceStrRet[1]));\r
             if (dynamicPrimaryKey.equalsIgnoreCase(token.getPrimaryKeyString())) {\r
                 return dynamicPcdBuildDataArray.get(index);\r
             }\r
@@ -1731,73 +2779,6 @@ public class CollectPCDAction {
         return null;\r
     }\r
 \r
-    /**\r
-       Verify the maxDatumSize for a PCD data is matched to Datum type.\r
-       \r
-       @param token             The token instance\r
-       @param moduleName        The module name who use this PCD data.\r
-       @param maxDatumSize      The value of max datum size in FPD file\r
-       @param datumType         The datum type\r
-       \r
-       @return String           if is unmatched, set the exception information\r
-                                as return value, otherwice is null.\r
-    **/\r
-    private String verifyDatumSize(String           cName, \r
-                                   String           moduleName,\r
-                                   int              maxDatumSize, \r
-                                   Token.DATUM_TYPE datumType) {\r
-        String exceptionString = null;\r
-        switch (datumType) {\r
-        case UINT8:\r
-            if (maxDatumSize != 1) {\r
-                exceptionString = String.format("In FPD file, the datum type of PCD data %s in module %s "+\r
-                                                "is UINT8, but datum size is %d, they are not matched!",\r
-                                                cName,\r
-                                                moduleName,\r
-                                                maxDatumSize);\r
-            }\r
-            break;\r
-        case UINT16:\r
-            if (maxDatumSize != 2) {\r
-                exceptionString = String.format("In FPD file, the datum type of PCD data %s in module %s "+\r
-                                                "is UINT16, but datum size is %d, they are not matched!",\r
-                                                cName,\r
-                                                moduleName,\r
-                                                maxDatumSize);\r
-            }\r
-            break;\r
-        case UINT32:\r
-            if (maxDatumSize != 4) {\r
-                exceptionString = String.format("In FPD file, the datum type of PCD data %s in module %s "+\r
-                                                "is UINT32, but datum size is %d, they are not matched!",\r
-                                                cName,\r
-                                                moduleName,\r
-                                                maxDatumSize);\r
-            }\r
-            break;\r
-        case UINT64:\r
-            if (maxDatumSize != 8) {\r
-                exceptionString = String.format("In FPD file, the datum type of PCD data %s in module %s "+\r
-                                                "is UINT64, but datum size is %d, they are not matched!",\r
-                                                cName,\r
-                                                moduleName,\r
-                                                maxDatumSize);\r
-            }\r
-            break;\r
-        case BOOLEAN:\r
-            if (maxDatumSize != 1) {\r
-                exceptionString = String.format("In FPD file, the datum type of PCD data %s in module %s "+\r
-                                                "is BOOLEAN, but datum size is %d, they are not matched!",\r
-                                                cName,\r
-                                                moduleName,\r
-                                                maxDatumSize);\r
-            }\r
-            break;\r
-        }\r
-\r
-        return exceptionString;\r
-    }\r
-\r
     /**\r
        Update dynamic information for PCD entry.\r
        \r
@@ -1823,13 +2804,17 @@ public class CollectPCDAction {
         SkuInstance         skuInstance     = null;\r
         String              temp;\r
         boolean             hasSkuId0       = false;\r
+        Token.PCD_TYPE      pcdType         = Token.PCD_TYPE.UNKNOWN;\r
+        long                tokenNumber     = 0;\r
+        String              hiiDefaultValue = null;\r
+        String[]            variableGuidString = null;\r
 \r
         List<DynamicPcdBuildDefinitions.PcdBuildData.SkuInfo>   skuInfoList = null;\r
         DynamicPcdBuildDefinitions.PcdBuildData                 dynamicInfo = null;\r
 \r
         dynamicInfo = getDynamicInfoFromFPD(token, moduleName);\r
         if (dynamicInfo == null) {\r
-            exceptionString = String.format("For Dynamic PCD %s used by module %s, "+\r
+            exceptionString = String.format("[FPD file error] For Dynamic PCD %s used by module %s, "+\r
                                             "there is no dynamic information in <DynamicPcdBuildDefinitions> "+\r
                                             "in FPD file, but it is required!",\r
                                             token.cName,\r
@@ -1837,6 +2822,43 @@ public class CollectPCDAction {
             throw new EntityException(exceptionString);\r
         }\r
 \r
+        token.datumSize = dynamicInfo.getMaxDatumSize();\r
+\r
+        exceptionString = verifyDatum(token.cName, \r
+                                      moduleName,\r
+                                      null, \r
+                                      token.datumType, \r
+                                      token.datumSize);\r
+        if (exceptionString != null) {\r
+            throw new EntityException(exceptionString);\r
+        }\r
+\r
+        if ((maxDatumSize != 0) && \r
+            (maxDatumSize != token.datumSize)) {\r
+            exceptionString = String.format("FPD file error] For dynamic PCD %s, the datum size in module %s is %d, but "+\r
+                                            "the datum size in <DynamicPcdBuildDefinitions> is %d, they are not match!",\r
+                                            token.cName,\r
+                                            moduleName, \r
+                                            maxDatumSize,\r
+                                            dynamicInfo.getMaxDatumSize());\r
+            throw new EntityException(exceptionString);\r
+        }\r
+        tokenNumber = Long.decode(dynamicInfo.getToken().toString());\r
+        if (tokenNumber != token.tokenNumber) {\r
+            exceptionString = String.format("[FPD file error] For dynamic PCD %s, the token number in module %s is 0x%x, but"+\r
+                                            "in <DynamicPcdBuildDefinictions>, the token number is 0x%x, they are not match!",\r
+                                            token.cName,\r
+                                            moduleName,\r
+                                            token.tokenNumber,\r
+                                            tokenNumber);\r
+            throw new EntityException(exceptionString);\r
+        }\r
+\r
+        pcdType = Token.getpcdTypeFromString(dynamicInfo.getItemType().toString());\r
+        if (pcdType == Token.PCD_TYPE.DYNAMIC_EX) {\r
+            token.dynamicExTokenNumber = tokenNumber;\r
+        }\r
+\r
         skuInfoList = dynamicInfo.getSkuInfoList();\r
 \r
         //\r
@@ -1849,7 +2871,6 @@ public class CollectPCDAction {
             // \r
             temp = skuInfoList.get(index).getSkuId().toString();\r
             skuInstance.id = Integer.decode(temp);\r
-\r
             if (skuInstance.id == 0) {\r
                 hasSkuId0 = true;\r
             }\r
@@ -1857,7 +2878,15 @@ public class CollectPCDAction {
             // Judge whether is DefaultGroup at first, because most case is DefautlGroup.\r
             // \r
             if (skuInfoList.get(index).getValue() != null) {\r
-                skuInstance.value.setValue(skuInfoList.get(index).getValue());\r
+                skuInstance.value.setValue(skuInfoList.get(index).getValue().toString());\r
+                if ((exceptionString = verifyDatum(token.cName, \r
+                                                   null, \r
+                                                   skuInfoList.get(index).getValue().toString(), \r
+                                                   token.datumType, \r
+                                                   token.datumSize)) != null) {\r
+                    throw new EntityException(exceptionString);\r
+                }\r
+\r
                 token.skuData.add(skuInstance);\r
 \r
                 //\r
@@ -1866,12 +2895,10 @@ public class CollectPCDAction {
                 // \r
                 if (datum != null) {\r
                     if ((skuInstance.id == 0)                                   &&\r
-                        !datum.equalsIgnoreCase(skuInfoList.get(index).getValue())) {\r
-                        exceptionString = String.format("For dynamic PCD %s, module %s give <datum> as %s which is different with "+\r
-                                                        "Sku 0's <datum> %s defined in <DynamicPcdBuildDefinitions>! Please sync them at first!",\r
-                                                        token.cName,\r
-                                                        datum,\r
-                                                        skuInfoList.get(index).getValue());\r
+                        !datum.toString().equalsIgnoreCase(skuInfoList.get(index).getValue().toString())) {\r
+                        exceptionString = "[FPD file error] For dynamic PCD " + token.cName + ", the value in module " + moduleName + " is " + datum.toString() + " but the "+\r
+                                          "value of sku 0 data in <DynamicPcdBuildDefinition> is " + skuInstance.value.value + ". They are must be same!"+\r
+                                          " or you could not define value for a dynamic PCD in every <ModuleSA>!"; \r
                         throw new EntityException(exceptionString);\r
                     }\r
                 }\r
@@ -1884,42 +2911,79 @@ public class CollectPCDAction {
             if (skuInfoList.get(index).getVariableName() != null) {\r
                 exceptionString = null;\r
                 if (skuInfoList.get(index).getVariableGuid() == null) {\r
-                    exceptionString = String.format("For dynamic PCD %s in <DynamicPcdBuildDefinitions> section in FPD "+\r
+                    exceptionString = String.format("[FPD file error] For dynamic PCD %s in <DynamicPcdBuildDefinitions> section in FPD "+\r
                                                     "file, who use HII, but there is no <VariableGuid> defined for Sku %d data!",\r
                                                     token.cName,\r
                                                     index);\r
-                                                    \r
+                    if (exceptionString != null) {\r
+                        throw new EntityException(exceptionString);\r
+                    }                                                    \r
                 }\r
 \r
                 if (skuInfoList.get(index).getVariableOffset() == null) {\r
-                    exceptionString = String.format("For dynamic PCD %s in <DynamicPcdBuildDefinitions> section in FPD "+\r
+                    exceptionString = String.format("[FPD file error] For dynamic PCD %s in <DynamicPcdBuildDefinitions> section in FPD "+\r
                                                     "file, who use HII, but there is no <VariableOffset> defined for Sku %d data!",\r
                                                     token.cName,\r
                                                     index);\r
+                    if (exceptionString != null) {\r
+                        throw new EntityException(exceptionString);\r
+                    }\r
                 }\r
 \r
                 if (skuInfoList.get(index).getHiiDefaultValue() == null) {\r
-                    exceptionString = String.format("For dynamic PCD %s in <DynamicPcdBuildDefinitions> section in FPD "+\r
+                    exceptionString = String.format("[FPD file error] For dynamic PCD %s in <DynamicPcdBuildDefinitions> section in FPD "+\r
                                                     "file, who use HII, but there is no <HiiDefaultValue> defined for Sku %d data!",\r
                                                     token.cName,\r
                                                     index);\r
+                    if (exceptionString != null) {\r
+                        throw new EntityException(exceptionString);\r
+                    }\r
+                }\r
+\r
+                if (skuInfoList.get(index).getHiiDefaultValue() != null) {\r
+                    hiiDefaultValue = skuInfoList.get(index).getHiiDefaultValue().toString();\r
+                } else {\r
+                    hiiDefaultValue = null;\r
                 }\r
 \r
-                if (exceptionString != null) {\r
+                if ((exceptionString = verifyDatum(token.cName, \r
+                                                   null, \r
+                                                   hiiDefaultValue, \r
+                                                   token.datumType, \r
+                                                   token.datumSize)) != null) {\r
                     throw new EntityException(exceptionString);\r
                 }\r
+\r
                 offset = Integer.decode(skuInfoList.get(index).getVariableOffset());\r
                 if (offset > 0xFFFF) {\r
-                    throw new EntityException(String.format("For dynamic PCD %s ,  the variable offset defined in sku %d data "+\r
+                    throw new EntityException(String.format("[FPD file error] For dynamic PCD %s ,  the variable offset defined in sku %d data "+\r
                                                             "exceed 64K, it is not allowed!",\r
                                                             token.cName,\r
                                                             index));\r
                 }\r
 \r
-                skuInstance.value.setHiiData(skuInfoList.get(index).getVariableName(),\r
-                                             translateSchemaStringToUUID(skuInfoList.get(index).getVariableGuid().toString()),\r
+                //\r
+                // Get variable guid string according to the name of guid which will be mapped into a GUID in SPD file.\r
+                // \r
+                variableGuidString = GlobalData.getGuidInfoFromCname(skuInfoList.get(index).getVariableGuid().toString());\r
+                if (variableGuidString == null) {\r
+                    throw new EntityException(String.format("[GUID Error] For dynamic PCD %s,  the variable guid %s can be found in all SPD file!",\r
+                                                            token.cName, \r
+                                                            skuInfoList.get(index).getVariableGuid().toString()));\r
+                }\r
+                String variableStr = skuInfoList.get(index).getVariableName();\r
+                Pattern pattern = Pattern.compile("0x([a-fA-F0-9]){4}");\r
+                Matcher matcher = pattern.matcher(variableStr);\r
+                List<String> varNameList = new ArrayList<String>();\r
+                while (matcher.find()){\r
+                       String str = variableStr.substring(matcher.start(),matcher.end());\r
+                       varNameList.add(str);\r
+                }\r
+                \r
+                skuInstance.value.setHiiData(varNameList,\r
+                                             translateSchemaStringToUUID(variableGuidString[1]),\r
                                              skuInfoList.get(index).getVariableOffset(),\r
-                                             skuInfoList.get(index).getHiiDefaultValue());\r
+                                             skuInfoList.get(index).getHiiDefaultValue().toString());\r
                 token.skuData.add(skuInstance);\r
                 continue;\r
             }\r
@@ -1930,16 +2994,17 @@ public class CollectPCDAction {
                 continue;\r
             }\r
 \r
-            exceptionString = String.format("For dynamic PCD %s, the dynamic info must "+\r
+            exceptionString = String.format("[FPD file error] For dynamic PCD %s, the dynamic info must "+\r
                                             "be one of 'DefaultGroup', 'HIIGroup', 'VpdGroup'.",\r
                                             token.cName);\r
             throw new EntityException(exceptionString);\r
         }\r
 \r
         if (!hasSkuId0) {\r
-            exceptionString = String.format("For dynamic PCD %s in <DynamicPcdBuildDefinitions>, there are "+\r
+            exceptionString = String.format("[FPD file error] For dynamic PCD %s in <DynamicPcdBuildDefinitions>, there are "+\r
                                             "no sku id = 0 data, which is required for every dynamic PCD",\r
                                             token.cName);\r
+            throw new EntityException(exceptionString);\r
         }\r
 \r
         return token;\r
@@ -1982,6 +3047,9 @@ public class CollectPCDAction {
             return new UUID(0, 0);\r
         }\r
 \r
+        uuidString = uuidString.replaceAll("\\{", "");\r
+        uuidString = uuidString.replaceAll("\\}", "");\r
+\r
         //\r
         // If the UUID schema string is GuidArrayType type then need translate \r
         // to GuidNamingConvention type at first.\r
@@ -1989,7 +3057,7 @@ public class CollectPCDAction {
         if ((uuidString.charAt(0) == '0') && ((uuidString.charAt(1) == 'x') || (uuidString.charAt(1) == 'X'))) {\r
             splitStringArray = uuidString.split("," );\r
             if (splitStringArray.length != 11) {\r
-                throw new EntityException ("Wrong format for UUID string: " + uuidString);\r
+                throw new EntityException ("[FPD file error] Wrong format for UUID string: " + uuidString);\r
             }\r
 \r
             //\r
@@ -2069,8 +3137,8 @@ public class CollectPCDAction {
         ca.setWorkspacePath("m:/tianocore/edk2");\r
         ca.setFPDFilePath("m:/tianocore/edk2/EdkNt32Pkg/Nt32.fpd");\r
         ca.setActionMessageLevel(ActionMessage.MAX_MESSAGE_LEVEL);\r
-        GlobalData.initInfo("Tools" + File.separator + "Conf" + File.separator + "FrameworkDatabase.db",\r
-                            "m:/tianocore/edk2");\r
-        ca.execute();\r
+//        GlobalData.initInfo("Tools" + File.separator + "Conf" + File.separator + "FrameworkDatabase.db",\r
+//                            "m:/tianocore/edk2");\r
+//        ca.execute();\r
     }\r
 }\r