modify critic

[mirror_edk2.git] / Tools / Source / MigrationTools / org / tianocore / migration / Critic.java

diff --git a/Tools/Source/MigrationTools/org/tianocore/migration/Critic.java b/Tools/Source/MigrationTools/org/tianocore/migration/Critic.java
index 93cb23b9417804618a8e5b96d1976f8046d56c48..23ad95abfcad28016368a0d3307a4faef2d63f02 100644 (file)
--- a/Tools/Source/MigrationTools/org/tianocore/migration/Critic.java
+++ b/Tools/Source/MigrationTools/org/tianocore/migration/Critic.java
@@ -17,11 +17,10 @@ import java.io.*;
 \r
 public class Critic implements Common.ForDoAll {\r
        private static Pattern ptnheadcomment = Pattern.compile("^\\/\\*\\+\\+(.*?)\\-\\-\\*\\/",Pattern.DOTALL);\r
-       private static Pattern ptnfunccomment = Pattern.compile("([\\w\\d]*\\s*[_\\w][_\\w\\d]*\\s*\\([^\\)\\(]*\\)\\s*)\\/\\*\\+\\+(.*?)\\-\\-\\*\\/(\\s*.*?)([\\{;])",Pattern.DOTALL);\r
-       private static Pattern ptncommentstructure = Pattern.compile("\\/\\*\\+\\+\\s*Routine Description:\\s*(.*?)\\s*Arguments:\\s*(.*?)\\s*Returns:\\s*(.*?)\\s*\\-\\-\\*\\/",Pattern.DOTALL);\r
+       private static Pattern ptnfunccomment = Pattern.compile("([\\};\\/]\\s*)([\\w\\s]*?[_\\w][_\\w\\d]*\\s*\\([^\\)\\(]*\\)\\s*)\\/\\*\\+\\+(.*?)\\-\\-\\*\\/(\\s*.*?)([\\{;])",Pattern.DOTALL);\r
+       //private static Pattern ptncommentstructure = Pattern.compile("\\/\\*\\+\\+\\s*Routine Description:\\s*(.*?)\\s*Arguments:\\s*(.*?)\\s*Returns:\\s*(.*?)\\s*\\-\\-\\*\\/",Pattern.DOTALL);\r
        private static Pattern ptninfequation = Pattern.compile("([^\\s]*)\\s*-\\s*(.*)\\s*");\r
        private static Matcher mtrinfequation;\r
-       private static Matcher mtrfunccomment;\r
        \r
        public void toDo(String filepath) throws Exception {\r
                if (filepath.contains(".c") || filepath.contains(".h")) {\r
@@ -32,12 +31,14 @@ public class Critic implements Common.ForDoAll {
                        boolean description = false;\r
                        boolean arguments = false;\r
                        boolean returns = false;\r
-                       \r
+                       boolean inequation = false;\r
+\r
                        System.out.println("Criticing   " + filepath);\r
                        String wholeline = Common.file2string(filepath);\r
-                       \r
+\r
+                       wholeline = wholeline.replaceAll("\t", "  ");\r
                        wholeline = Common.replaceAll(wholeline, ptnheadcomment, "/** @file$1**/");\r
-                       wholeline = Common.replaceAll(wholeline, ptnfunccomment, "/**$2**/$3$1$4");\r
+                       wholeline = Common.replaceAll(wholeline, ptnfunccomment, "$1/**$3**/$4$2$5");\r
                        //wholeline = Common.replaceAll(wholeline, ptncommentstructure, "/**\n#%\n$1\n%#\n#%%\n$2\n%%#\n#%%%\n$3\n%%%#\n**/");\r
                        \r
                        rd = new BufferedReader(new StringReader(wholeline));\r
@@ -65,14 +66,26 @@ public class Critic implements Common.ForDoAll {
                                } else if (incomment && arguments) {\r
                                        mtrinfequation = ptninfequation.matcher(line);\r
                                        if (mtrinfequation.find()) {\r
-                                               templine.append("  @param   " + mtrinfequation.group(1) + "     " + mtrinfequation.group(2) + "\n");\r
+                                               inequation = true;\r
+                                               templine.append("  @param " + mtrinfequation.group(1) + "     " + mtrinfequation.group(2) + "\n");\r
+                                       } else if (inequation && line.trim().length() == 0) {\r
+                                               inequation = false;\r
+                                               templine.append(line + "\n");\r
+                                       } else if (inequation && line.trim().length() != 0) {\r
+                                               templine.append("#%#%" + line + "\n");\r
                                        } else {\r
                                                templine.append(line + "\n");\r
                                        }\r
                                } else if (incomment && returns) {\r
                                        mtrinfequation = ptninfequation.matcher(line);\r
                                        if (mtrinfequation.find()) {\r
-                                               templine.append("  @retval   " + mtrinfequation.group(1) + "     " + mtrinfequation.group(2) + "\n");\r
+                                               inequation = true;\r
+                                               templine.append("  @retval " + mtrinfequation.group(1) + "     " + mtrinfequation.group(2) + "\n");\r
+                                       } else if (inequation && line.trim().length() == 0) {\r
+                                               inequation = false;\r
+                                               templine.append(line + "\n");\r
+                                       } else if (inequation && line.trim().length() != 0) {\r
+                                               templine.append("#%#%" + line + "\n");\r
                                        } else {\r
                                                templine.append(line + "\n");\r
                                        }\r
@@ -81,6 +94,7 @@ public class Critic implements Common.ForDoAll {
                                }\r
                        }\r
                        wholeline = templine.toString();\r
+                       wholeline = wholeline.replaceAll("\n#%#%\\s*", " ");\r
                        \r
                        /* -----slow edition of replacefirst with stringbuffer-----\r
                        line.append(wholeline);\r