]> git.proxmox.com Git - mirror_edk2.git/blobdiff - UefiCpuPkg/Library/MpInitLib/MpLib.c
UefiCpuPkg/MpInitLib: wait no longer than necessary for initial AP startup
[mirror_edk2.git] / UefiCpuPkg / Library / MpInitLib / MpLib.c
index 56b870e52748b42672b086666f73880df7f8af2d..ed22ce67782ef48b1148b5aac9868b1789a30e50 100644 (file)
@@ -253,33 +253,33 @@ SortApicId (
   UINTN             Index2;\r
   UINTN             Index3;\r
   UINT32            ApicId;\r
-  CPU_AP_DATA       CpuData;\r
+  CPU_INFO_IN_HOB   CpuInfo;\r
   UINT32            ApCount;\r
   CPU_INFO_IN_HOB   *CpuInfoInHob;\r
 \r
   ApCount = CpuMpData->CpuCount - 1;\r
-\r
+  CpuInfoInHob = (CPU_INFO_IN_HOB *) (UINTN) CpuMpData->CpuInfoInHob;\r
   if (ApCount != 0) {\r
     for (Index1 = 0; Index1 < ApCount; Index1++) {\r
       Index3 = Index1;\r
       //\r
       // Sort key is the hardware default APIC ID\r
       //\r
-      ApicId = CpuMpData->CpuData[Index1].ApicId;\r
+      ApicId = CpuInfoInHob[Index1].ApicId;\r
       for (Index2 = Index1 + 1; Index2 <= ApCount; Index2++) {\r
-        if (ApicId > CpuMpData->CpuData[Index2].ApicId) {\r
+        if (ApicId > CpuInfoInHob[Index2].ApicId) {\r
           Index3 = Index2;\r
-          ApicId = CpuMpData->CpuData[Index2].ApicId;\r
+          ApicId = CpuInfoInHob[Index2].ApicId;\r
         }\r
       }\r
       if (Index3 != Index1) {\r
-        CopyMem (&CpuData, &CpuMpData->CpuData[Index3], sizeof (CPU_AP_DATA));\r
+        CopyMem (&CpuInfo, &CpuInfoInHob[Index3], sizeof (CPU_INFO_IN_HOB));\r
         CopyMem (\r
-          &CpuMpData->CpuData[Index3],\r
-          &CpuMpData->CpuData[Index1],\r
-          sizeof (CPU_AP_DATA)\r
+          &CpuInfoInHob[Index3],\r
+          &CpuInfoInHob[Index1],\r
+          sizeof (CPU_INFO_IN_HOB)\r
           );\r
-        CopyMem (&CpuMpData->CpuData[Index1], &CpuData, sizeof (CPU_AP_DATA));\r
+        CopyMem (&CpuInfoInHob[Index1], &CpuInfo, sizeof (CPU_INFO_IN_HOB));\r
       }\r
     }\r
 \r
@@ -288,18 +288,11 @@ SortApicId (
     //\r
     ApicId = GetInitialApicId ();\r
     for (Index1 = 0; Index1 < CpuMpData->CpuCount; Index1++) {\r
-      if (CpuMpData->CpuData[Index1].ApicId == ApicId) {\r
+      if (CpuInfoInHob[Index1].ApicId == ApicId) {\r
         CpuMpData->BspNumber = (UINT32) Index1;\r
         break;\r
       }\r
     }\r
-\r
-    CpuInfoInHob = (CPU_INFO_IN_HOB *) (UINTN) CpuMpData->CpuInfoInHob;\r
-    for (Index1 = 0; Index1 < CpuMpData->CpuCount; Index1++) {\r
-      CpuInfoInHob[Index1].InitialApicId = CpuMpData->CpuData[Index1].InitialApicId;\r
-      CpuInfoInHob[Index1].ApicId        = CpuMpData->CpuData[Index1].ApicId;\r
-      CpuInfoInHob[Index1].Health        = CpuMpData->CpuData[Index1].Health;\r
-    }\r
   }\r
 }\r
 \r
@@ -358,10 +351,13 @@ GetProcessorNumber (
 {\r
   UINTN                   TotalProcessorNumber;\r
   UINTN                   Index;\r
+  CPU_INFO_IN_HOB         *CpuInfoInHob;\r
+\r
+  CpuInfoInHob = (CPU_INFO_IN_HOB *) (UINTN) CpuMpData->CpuInfoInHob;\r
 \r
   TotalProcessorNumber = CpuMpData->CpuCount;\r
   for (Index = 0; Index < TotalProcessorNumber; Index ++) {\r
-    if (CpuMpData->CpuData[Index].ApicId == GetApicId ()) {\r
+    if (CpuInfoInHob[Index].ApicId == GetApicId ()) {\r
       *ProcessorNumber = Index;\r
       return EFI_SUCCESS;\r
     }\r
@@ -436,15 +432,21 @@ VOID
 InitializeApData (\r
   IN OUT CPU_MP_DATA      *CpuMpData,\r
   IN     UINTN            ProcessorNumber,\r
-  IN     UINT32           BistData\r
+  IN     UINT32           BistData,\r
+  IN     UINT64           ApTopOfStack\r
   )\r
 {\r
+  CPU_INFO_IN_HOB          *CpuInfoInHob;\r
+\r
+  CpuInfoInHob = (CPU_INFO_IN_HOB *) (UINTN) CpuMpData->CpuInfoInHob;\r
+  CpuInfoInHob[ProcessorNumber].InitialApicId = GetInitialApicId ();\r
+  CpuInfoInHob[ProcessorNumber].ApicId        = GetApicId ();\r
+  CpuInfoInHob[ProcessorNumber].Health        = BistData;\r
+  CpuInfoInHob[ProcessorNumber].ApTopOfStack  = ApTopOfStack;\r
+\r
   CpuMpData->CpuData[ProcessorNumber].Waiting    = FALSE;\r
-  CpuMpData->CpuData[ProcessorNumber].Health     = BistData;\r
   CpuMpData->CpuData[ProcessorNumber].CpuHealthy = (BistData == 0) ? TRUE : FALSE;\r
-  CpuMpData->CpuData[ProcessorNumber].ApicId     = GetApicId ();\r
-  CpuMpData->CpuData[ProcessorNumber].InitialApicId = GetInitialApicId ();\r
-  if (CpuMpData->CpuData[ProcessorNumber].InitialApicId >= 0xFF) {\r
+  if (CpuInfoInHob[ProcessorNumber].InitialApicId >= 0xFF) {\r
     //\r
     // Set x2APIC mode if there are any logical processor reporting\r
     // an Initial APIC ID of 255 or greater.\r
@@ -477,6 +479,8 @@ ApWakeupFunction (
   VOID                       *Parameter;\r
   UINT32                     BistData;\r
   volatile UINT32            *ApStartupSignalBuffer;\r
+  CPU_INFO_IN_HOB            *CpuInfoInHob;\r
+  UINT64                     ApTopOfStack;\r
 \r
   //\r
   // AP finished assembly code and begin to execute C code\r
@@ -495,7 +499,8 @@ ApWakeupFunction (
       //\r
       // This is first time AP wakeup, get BIST information from AP stack\r
       //\r
-      BistData = *(UINT32 *) (CpuMpData->Buffer + ProcessorNumber * CpuMpData->CpuApStackSize - sizeof (UINTN));\r
+      ApTopOfStack  = CpuMpData->Buffer + (ProcessorNumber + 1) * CpuMpData->CpuApStackSize;\r
+      BistData = *(UINT32 *) ((UINTN) ApTopOfStack - sizeof (UINTN));\r
       //\r
       // Do some AP initialize sync\r
       //\r
@@ -504,7 +509,7 @@ ApWakeupFunction (
       // Sync BSP's Control registers to APs\r
       //\r
       RestoreVolatileRegisters (&CpuMpData->CpuData[0].VolatileRegisters, FALSE);\r
-      InitializeApData (CpuMpData, ProcessorNumber, BistData);\r
+      InitializeApData (CpuMpData, ProcessorNumber, BistData, ApTopOfStack);\r
       ApStartupSignalBuffer = CpuMpData->CpuData[ProcessorNumber].StartupApSignal;\r
     } else {\r
       //\r
@@ -536,6 +541,7 @@ ApWakeupFunction (
           // Invoke AP function here\r
           //\r
           Procedure (Parameter);\r
+          CpuInfoInHob = (CPU_INFO_IN_HOB *) (UINTN) CpuMpData->CpuInfoInHob;\r
           if (CpuMpData->SwitchBspFlag) {\r
             //\r
             // Re-get the processor number due to BSP/AP maybe exchange in AP function\r
@@ -543,12 +549,14 @@ ApWakeupFunction (
             GetProcessorNumber (CpuMpData, &ProcessorNumber);\r
             CpuMpData->CpuData[ProcessorNumber].ApFunction = 0;\r
             CpuMpData->CpuData[ProcessorNumber].ApFunctionArgument = 0;\r
+            ApStartupSignalBuffer = CpuMpData->CpuData[ProcessorNumber].StartupApSignal;\r
+            CpuInfoInHob[ProcessorNumber].ApTopOfStack = CpuInfoInHob[CpuMpData->NewBspNumber].ApTopOfStack;\r
           } else {\r
             //\r
             // Re-get the CPU APICID and Initial APICID\r
             //\r
-            CpuMpData->CpuData[ProcessorNumber].ApicId        = GetApicId ();\r
-            CpuMpData->CpuData[ProcessorNumber].InitialApicId = GetInitialApicId ();\r
+            CpuInfoInHob[ProcessorNumber].ApicId        = GetApicId ();\r
+            CpuInfoInHob[ProcessorNumber].InitialApicId = GetInitialApicId ();\r
           }\r
         }\r
         SetApState (&CpuMpData->CpuData[ProcessorNumber], CpuStateFinished);\r
@@ -662,6 +670,8 @@ FillExchangeInfoData (
 \r
   ExchangeInfo->CFunction       = (UINTN) ApWakeupFunction;\r
   ExchangeInfo->NumApsExecuting = 0;\r
+  ExchangeInfo->InitFlag        = (UINTN) CpuMpData->InitFlag;\r
+  ExchangeInfo->CpuInfo         = (CPU_INFO_IN_HOB *) (UINTN) CpuMpData->CpuInfoInHob;\r
   ExchangeInfo->CpuMpData       = CpuMpData;\r
 \r
   ExchangeInfo->EnableExecuteDisable = IsBspExecuteDisableEnabled ();\r
@@ -673,6 +683,21 @@ FillExchangeInfoData (
   AsmReadIdtr ((IA32_DESCRIPTOR *) &ExchangeInfo->IdtrProfile);\r
 }\r
 \r
+/**\r
+  Helper function that waits until the finished AP count reaches the specified\r
+  limit, or the specified timeout elapses (whichever comes first).\r
+\r
+  @param[in] CpuMpData        Pointer to CPU MP Data.\r
+  @param[in] FinishedApLimit  The number of finished APs to wait for.\r
+  @param[in] TimeLimit        The number of microseconds to wait for.\r
+**/\r
+VOID\r
+TimedWaitForApFinish (\r
+  IN CPU_MP_DATA               *CpuMpData,\r
+  IN UINT32                    FinishedApLimit,\r
+  IN UINT32                    TimeLimit\r
+  );\r
+\r
 /**\r
   This function will be called by BSP to wakeup AP.\r
 \r
@@ -696,6 +721,7 @@ WakeUpAP (
   UINTN                            Index;\r
   CPU_AP_DATA                      *CpuData;\r
   BOOLEAN                          ResetVectorRequired;\r
+  CPU_INFO_IN_HOB                  *CpuInfoInHob;\r
 \r
   CpuMpData->FinishedCount = 0;\r
   ResetVectorRequired = FALSE;\r
@@ -737,7 +763,11 @@ WakeUpAP (
       //\r
       // Wait for all potential APs waken up in one specified period\r
       //\r
-      MicroSecondDelay (PcdGet32(PcdCpuApInitTimeOutInMicroSeconds));\r
+      TimedWaitForApFinish (\r
+        CpuMpData,\r
+        PcdGet32 (PcdCpuMaxLogicalProcessorNumber) - 1,\r
+        PcdGet32 (PcdCpuApInitTimeOutInMicroSeconds)\r
+        );\r
     } else {\r
       //\r
       // Wait all APs waken up if this is not the 1st broadcast of SIPI\r
@@ -760,8 +790,9 @@ WakeUpAP (
     ASSERT (CpuMpData->InitFlag != ApInitConfig);\r
     *(UINT32 *) CpuData->StartupApSignal = WAKEUP_AP_SIGNAL;\r
     if (ResetVectorRequired) {\r
+      CpuInfoInHob = (CPU_INFO_IN_HOB *) (UINTN) CpuMpData->CpuInfoInHob;\r
       SendInitSipiSipi (\r
-        CpuData->ApicId,\r
+        CpuInfoInHob[ProcessorNumber].ApicId,\r
         (UINT32) ExchangeInfo->BufferStart\r
         );\r
     }\r
@@ -882,6 +913,58 @@ CheckTimeout (
   return FALSE;\r
 }\r
 \r
+/**\r
+  Helper function that waits until the finished AP count reaches the specified\r
+  limit, or the specified timeout elapses (whichever comes first).\r
+\r
+  @param[in] CpuMpData        Pointer to CPU MP Data.\r
+  @param[in] FinishedApLimit  The number of finished APs to wait for.\r
+  @param[in] TimeLimit        The number of microseconds to wait for.\r
+**/\r
+VOID\r
+TimedWaitForApFinish (\r
+  IN CPU_MP_DATA               *CpuMpData,\r
+  IN UINT32                    FinishedApLimit,\r
+  IN UINT32                    TimeLimit\r
+  )\r
+{\r
+  //\r
+  // CalculateTimeout() and CheckTimeout() consider a TimeLimit of 0\r
+  // "infinity", so check for (TimeLimit == 0) explicitly.\r
+  //\r
+  if (TimeLimit == 0) {\r
+    return;\r
+  }\r
+\r
+  CpuMpData->TotalTime = 0;\r
+  CpuMpData->ExpectedTime = CalculateTimeout (\r
+                              TimeLimit,\r
+                              &CpuMpData->CurrentTime\r
+                              );\r
+  while (CpuMpData->FinishedCount < FinishedApLimit &&\r
+         !CheckTimeout (\r
+            &CpuMpData->CurrentTime,\r
+            &CpuMpData->TotalTime,\r
+            CpuMpData->ExpectedTime\r
+            )) {\r
+    CpuPause ();\r
+  }\r
+\r
+  if (CpuMpData->FinishedCount >= FinishedApLimit) {\r
+    DEBUG ((\r
+      DEBUG_VERBOSE,\r
+      "%a: reached FinishedApLimit=%u in %Lu microseconds\n",\r
+      __FUNCTION__,\r
+      FinishedApLimit,\r
+      DivU64x64Remainder (\r
+        MultU64x32 (CpuMpData->TotalTime, 1000000),\r
+        GetPerformanceCounterProperties (NULL, NULL),\r
+        NULL\r
+        )\r
+      ));\r
+  }\r
+}\r
+\r
 /**\r
   Reset an AP to Idle state.\r
 \r
@@ -899,7 +982,12 @@ ResetProcessorToIdleState (
 \r
   CpuMpData = GetCpuMpData ();\r
 \r
+  CpuMpData->InitFlag = ApInitReconfig;\r
   WakeUpAP (CpuMpData, FALSE, ProcessorNumber, NULL, NULL);\r
+  while (CpuMpData->FinishedCount < 1) {\r
+    CpuPause ();\r
+  }\r
+  CpuMpData->InitFlag = ApInitDone;\r
 \r
   SetApState (&CpuMpData->CpuData[ProcessorNumber], CpuStateIdle);\r
 }\r
@@ -1143,6 +1231,7 @@ MpInitLibInitialize (
   } else {\r
     MaxLogicalProcessorNumber = OldCpuMpData->CpuCount;\r
   }\r
+  ASSERT (MaxLogicalProcessorNumber != 0);\r
 \r
   AsmGetAddressMap (&AddressMap);\r
   ApResetVectorSize = AddressMap.RendezvousFunnelSize + sizeof (MP_CPU_EXCHANGE_INFO);\r
@@ -1182,7 +1271,7 @@ MpInitLibInitialize (
   //\r
   // Set BSP basic information\r
   //\r
-  InitializeApData (CpuMpData, 0, 0);\r
+  InitializeApData (CpuMpData, 0, 0, CpuMpData->Buffer);\r
   //\r
   // Save assembly code information\r
   //\r
@@ -1209,10 +1298,12 @@ MpInitLibInitialize (
   MtrrGetAllMtrrs (&CpuMpData->MtrrTable);\r
 \r
   if (OldCpuMpData == NULL) {\r
-    //\r
-    // Wakeup all APs and calculate the processor count in system\r
-    //\r
-    CollectProcessorCount (CpuMpData);\r
+    if (MaxLogicalProcessorNumber > 1) {\r
+      //\r
+      // Wakeup all APs and calculate the processor count in system\r
+      //\r
+      CollectProcessorCount (CpuMpData);\r
+    }\r
   } else {\r
     //\r
     // APs have been wakeup before, just get the CPU Information\r
@@ -1221,16 +1312,14 @@ MpInitLibInitialize (
     CpuMpData->CpuCount  = OldCpuMpData->CpuCount;\r
     CpuMpData->BspNumber = OldCpuMpData->BspNumber;\r
     CpuMpData->InitFlag  = ApInitReconfig;\r
-    CpuInfoInHob = (CPU_INFO_IN_HOB *) (UINTN) OldCpuMpData->CpuInfoInHob;\r
+    CpuMpData->CpuInfoInHob = OldCpuMpData->CpuInfoInHob;\r
+    CpuInfoInHob = (CPU_INFO_IN_HOB *) (UINTN) CpuMpData->CpuInfoInHob;\r
     for (Index = 0; Index < CpuMpData->CpuCount; Index++) {\r
       InitializeSpinLock(&CpuMpData->CpuData[Index].ApLock);\r
-      CpuMpData->CpuData[Index].ApicId        = CpuInfoInHob[Index].ApicId;\r
-      CpuMpData->CpuData[Index].InitialApicId = CpuInfoInHob[Index].InitialApicId;\r
-      if (CpuMpData->CpuData[Index].InitialApicId >= 255) {\r
+      if (CpuInfoInHob[Index].InitialApicId >= 255) {\r
         CpuMpData->X2ApicEnable = TRUE;\r
       }\r
-      CpuMpData->CpuData[Index].Health     = CpuInfoInHob[Index].Health;\r
-      CpuMpData->CpuData[Index].CpuHealthy = (CpuMpData->CpuData[Index].Health == 0)? TRUE:FALSE;\r
+      CpuMpData->CpuData[Index].CpuHealthy = (CpuInfoInHob[Index].Health == 0)? TRUE:FALSE;\r
       CpuMpData->CpuData[Index].ApFunction = 0;\r
       CopyMem (\r
         &CpuMpData->CpuData[Index].VolatileRegisters,\r
@@ -1238,19 +1327,21 @@ MpInitLibInitialize (
         sizeof (CPU_VOLATILE_REGISTERS)\r
         );\r
     }\r
-    //\r
-    // Wakeup APs to do some AP initialize sync\r
-    //\r
-    WakeUpAP (CpuMpData, TRUE, 0, ApInitializeSync, CpuMpData);\r
-    //\r
-    // Wait for all APs finished initialization\r
-    //\r
-    while (CpuMpData->FinishedCount < (CpuMpData->CpuCount - 1)) {\r
-      CpuPause ();\r
-    }\r
-    CpuMpData->InitFlag = ApInitDone;\r
-    for (Index = 0; Index < CpuMpData->CpuCount; Index++) {\r
-      SetApState (&CpuMpData->CpuData[Index], CpuStateIdle);\r
+    if (MaxLogicalProcessorNumber > 1) {\r
+      //\r
+      // Wakeup APs to do some AP initialize sync\r
+      //\r
+      WakeUpAP (CpuMpData, TRUE, 0, ApInitializeSync, CpuMpData);\r
+      //\r
+      // Wait for all APs finished initialization\r
+      //\r
+      while (CpuMpData->FinishedCount < (CpuMpData->CpuCount - 1)) {\r
+        CpuPause ();\r
+      }\r
+      CpuMpData->InitFlag = ApInitDone;\r
+      for (Index = 0; Index < CpuMpData->CpuCount; Index++) {\r
+        SetApState (&CpuMpData->CpuData[Index], CpuStateIdle);\r
+      }\r
     }\r
   }\r
 \r
@@ -1289,8 +1380,10 @@ MpInitLibGetProcessorInfo (
 {\r
   CPU_MP_DATA            *CpuMpData;\r
   UINTN                  CallerNumber;\r
+  CPU_INFO_IN_HOB        *CpuInfoInHob;\r
 \r
   CpuMpData = GetCpuMpData ();\r
+  CpuInfoInHob = (CPU_INFO_IN_HOB *) (UINTN) CpuMpData->CpuInfoInHob;\r
 \r
   //\r
   // Check whether caller processor is BSP\r
@@ -1308,7 +1401,7 @@ MpInitLibGetProcessorInfo (
     return EFI_NOT_FOUND;\r
   }\r
 \r
-  ProcessorInfoBuffer->ProcessorId = (UINT64) CpuMpData->CpuData[ProcessorNumber].ApicId;\r
+  ProcessorInfoBuffer->ProcessorId = (UINT64) CpuInfoInHob[ProcessorNumber].ApicId;\r
   ProcessorInfoBuffer->StatusFlag  = 0;\r
   if (ProcessorNumber == CpuMpData->BspNumber) {\r
     ProcessorInfoBuffer->StatusFlag |= PROCESSOR_AS_BSP_BIT;\r
@@ -1326,14 +1419,14 @@ MpInitLibGetProcessorInfo (
   // Get processor location information\r
   //\r
   GetProcessorLocationByApicId (\r
-    CpuMpData->CpuData[ProcessorNumber].ApicId,\r
+    CpuInfoInHob[ProcessorNumber].ApicId,\r
     &ProcessorInfoBuffer->Location.Package,\r
     &ProcessorInfoBuffer->Location.Core,\r
     &ProcessorInfoBuffer->Location.Thread\r
     );\r
 \r
   if (HealthData != NULL) {\r
-    HealthData->Uint32 = CpuMpData->CpuData[ProcessorNumber].Health;\r
+    HealthData->Uint32 = CpuInfoInHob[ProcessorNumber].Health;\r
   }\r
 \r
   return EFI_SUCCESS;\r
@@ -1400,6 +1493,7 @@ SwitchBSPWorker (
   CpuMpData->BSPInfo.State = CPU_SWITCH_STATE_IDLE;\r
   CpuMpData->APInfo.State  = CPU_SWITCH_STATE_IDLE;\r
   CpuMpData->SwitchBspFlag = TRUE;\r
+  CpuMpData->NewBspNumber  = ProcessorNumber;\r
 \r
   //\r
   // Clear the BSP bit of MSR_IA32_APIC_BASE\r