]> git.proxmox.com Git - mirror_edk2.git/commit - ArmPkg/Drivers/ArmGic/ArmGicLib.c
ArmPkg/Drivers: ArmGicIsInterruptEnabled returns incorrect value
authorRobbie King <robbiek@xsightlabs.com>
Fri, 1 Jul 2022 15:06:17 +0000 (11:06 -0400)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Fri, 1 Jul 2022 15:28:08 +0000 (15:28 +0000)
commit7861b24dc9c520449160e6322627587f0922b237
treed68a13a1d34bc943930159c33843498d4e951319
parent70586d4e3af67dcc4fa2cd49524b7e5b71e0c7e1
ArmPkg/Drivers: ArmGicIsInterruptEnabled returns incorrect value

The issue appears to have been introduced by:

41fb5d46 : ArmPkg/ArmGic: Use the GIC Redistributor instead of GIC Distributor for GICv3

The changes to ArmGicIsInterruptEnabled() introduced the error where the Boolean
result is assigned to Interrupts, but then the bit position check is performed
again (against the computed Boolean result instead of the interrupt mask) during
the return statement.

Fix removes erroneous test and relies on boolean test made at return.

Signed-off-by: Robbie King <robbiek@xsightlabs.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
ArmPkg/Drivers/ArmGic/ArmGicLib.c