]> git.proxmox.com Git - mirror_edk2.git/commit - ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
ArmPkg/ArmMmuLib AARCH64: preserve attributes when replacing a table entry
authorArd Biesheuvel <ard.biesheuvel@linaro.org>
Sat, 7 Mar 2020 12:35:55 +0000 (13:35 +0100)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Thu, 26 Mar 2020 10:34:14 +0000 (10:34 +0000)
commitf7079d1bc1efe6a5eda3d993aefe245749e694f5
tree3d25134726081cadbbdb525fd661669726f626c7
parent5fc899535e5195247258aac3f43e93967543d34d
ArmPkg/ArmMmuLib AARCH64: preserve attributes when replacing a table entry

Currently, depending on the size of the region being (re)mapped, the
page table manipulation code may replace a table entry with a block entry,
even if the existing table entry uses different mapping attributes to
describe different parts of the region it covers. This is undesirable, and
instead, we should avoid doing so unless we are disregarding the original
attributes anyway. And if we make such a replacement, we should free all
the page tables that have become orphaned in the process.

So let's implement this, by taking the table entry path through the code
for block sized regions if a table entry already exists, and the clear
mask is set (which means we are preserving attributes from the existing
mapping). And when we do replace a table entry with a block entry, free
all the pages that are no longer referenced.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Reviewed-by: Ashish Singhal <ashishsingha@nvidia.com>
Tested-by: Ashish Singhal <ashishsingha@nvidia.com>
Tested-by: Laszlo Ersek <lersek@redhat.com>
ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c