]> git.proxmox.com Git - mirror_edk2.git/commit - CryptoPkg/Library/OpensslLib/OpensslLib.inf
CryptoPkg/OpensslLib: improve INF file consistency
authorLaszlo Ersek <lersek@redhat.com>
Thu, 21 Nov 2019 07:46:10 +0000 (08:46 +0100)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Mon, 2 Dec 2019 19:35:18 +0000 (19:35 +0000)
commitb49a6c8f80d970cf7ab25c28a079c0db225f3ad2
tree7c19f41e83fc1a85ef51b837f1cb38cbb2b6249a
parentfe6142f04c4f742f5f1159d50161da8c0ede338c
CryptoPkg/OpensslLib: improve INF file consistency

When diffing "OpensslLib.inf" against "OpensslLibCrypto.inf", the *only*
differences should be:

- BASE_NAME, MODULE_UNI_FILE, and FILE_GUID are expected to differ, in
  [Defines];

- "OpensslLib.inf" is expected to list "$(OPENSSL_PATH)/ssl/..." source
  files in the auto-generated part of the [Sources] section.

Commit 8906f076de35 ("CryptoPkg/OpensslLib: Add missing header files in
INF file", 2019-08-16) broke that invariant, by adding "buildinf.h" and
"rand_pool_noise.h" in different order to both INF files.

Fix that order in "OpensslLib.inf" now. (Note that this does not
re-establish full consistency between both INF files -- it just highlights
another problem, which we'll fix in the next patch.)

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Shenglei Zhang <shenglei.zhang@intel.com>
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
Fixes: 8906f076de35b222a7d62bcf6ed1a4a2498a5791
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
CryptoPkg/Library/OpensslLib/OpensslLib.inf