]> git.proxmox.com Git - mirror_edk2.git/commit - EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c
EmbeddedPkg/AndroidFastbootTransportTcpDxe: fix DestroyChild() call
authorLaszlo Ersek <lersek@redhat.com>
Fri, 6 Sep 2019 23:25:10 +0000 (01:25 +0200)
committerLaszlo Ersek <lersek@redhat.com>
Wed, 9 Oct 2019 07:40:09 +0000 (09:40 +0200)
commit7b6ceb4d3b4678a9e76a3ff881b25d5e68c4439c
tree7ca5b0872e32c904949d6a3f4e927bc285098901
parent7609c0472838debe6c7cc7b053e3f5ed710465fd
EmbeddedPkg/AndroidFastbootTransportTcpDxe: fix DestroyChild() call

- The 2nd parameter of EFI_SERVICE_BINDING_CREATE_CHILD is:

  IN OUT EFI_HANDLE *ChildHandle

- The 2nd parameter of EFI_SERVICE_BINDING_DESTROY_CHILD is:

  IN EFI_HANDLE ChildHandle

Fix the DestroyChild() call in TcpFastbootTransportStop().

This is an actual bugfix; I don't know why the current code doesn't crash.
Perhaps the function is never reached in practice? (It could be tied to an
error path.)

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c