]> git.proxmox.com Git - mirror_edk2.git/commit - EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c
EmbeddedPkg/TimeBaseLib: remove useless truncation to 32-bit
authorLaszlo Ersek <lersek@redhat.com>
Mon, 21 Dec 2020 11:36:57 +0000 (12:36 +0100)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Mon, 21 Dec 2020 15:55:16 +0000 (15:55 +0000)
commitc06635ea3f4b7b52054fe5d5b5e0cda3b594d2f5
tree6ee8cf877a521fc63a6f1a9f31aa2df1b2b6757b
parent3af6c521d9c1b195a6105169df92c0b3a8107e39
EmbeddedPkg/TimeBaseLib: remove useless truncation to 32-bit

EfiTimeToEpoch() calls EfiGetEpochDays() internally, which (reasonably)
returns a UINTN. But then EfiTimeToEpoch() truncates the EfiGetEpochDays()
retval to UINT32 for no good reason, effectively restricting Time->Year
under 2106.

This truncation was pointed out with a valid warning (= build error) by
VS2019.

Allow EfiTimeToEpoch() to return / propagate a UINTN value.

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20201221113657.6779-3-lersek@redhat.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
EmbeddedPkg/Include/Library/TimeBaseLib.h
EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c