]> git.proxmox.com Git - mirror_edk2.git/commit - EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
EmbeddedPkg/VirtualRealTimeClockLib: Explicit cast to UINT32
authorPete Batard <pete@akeo.ie>
Thu, 8 Oct 2020 10:08:21 +0000 (11:08 +0100)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Thu, 22 Oct 2020 13:23:48 +0000 (13:23 +0000)
commit24cf72726564eac7ba9abb24f3d05795164d0a70
tree2eeaa2c1473a42e2ccec8a318b66a7a0283e1634
parente3c7db50cac9125607df49d5873991df6df11eae
EmbeddedPkg/VirtualRealTimeClockLib: Explicit cast to UINT32

Addresses BZ https://bugzilla.tianocore.org/show_bug.cgi?id=2380 where
explicit casts are required for 64 to 32 bit assignment.

We can apply a straight cast for Time->Nanosecond since we already checked
for overflow.

On the other hand, we may have a frequency that is greater than UINT32_MAX
for Capabilities->Resolution. But using the frequency for the resolution
is the wrong approach anyway, since we can't actually vouch for the actual
resolution of the virtual library. Instead, play it safe by defaulting to
1 Hz, which is what a standard PC-AT CMOS RTC device would use.

Signed-off-by: Pete Batard <pete@akeo.ie>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c