]> git.proxmox.com Git - mirror_edk2.git/commit - MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c
MdeModulePkg/Usb/Keyboard.c: Don't request protocol before setting
authorSean Rhodes <sean@starlabs.systems>
Thu, 24 Feb 2022 11:38:18 +0000 (19:38 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Thu, 3 Mar 2022 06:25:50 +0000 (06:25 +0000)
commit589d51df260465e2561979b8a988e77b0f32a6e8
treeaffacb59c008e0ff72b4bdacaf8845fa8e4e0092
parentb422b0fcf92dd4103dfc16d8d5f77fbec2d8c5b9
MdeModulePkg/Usb/Keyboard.c: Don't request protocol before setting

No need to check the interface protocol then conditionally setting,
just set it to BOOT_PROTOCOL and check for error.

This is what Linux does for HID devices as some don't follow the USB spec.
One example is the Aspeed BMC HID keyboard device, which adds a massive
boot delay without this patch as it doesn't respond to
'GetProtocolRequest'.

Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c