]> git.proxmox.com Git - mirror_edk2.git/commit - MdeModulePkg/Library/PiDxeS3BootScriptLib/BootScriptSave.c
MdePkg, MdeModulePkg: S3BootScriptSaveMemPoll(): accept 64-bit LoopTimes
authorLaszlo Ersek <lersek@redhat.com>
Wed, 30 Nov 2016 19:07:50 +0000 (20:07 +0100)
committerLaszlo Ersek <lersek@redhat.com>
Tue, 3 Jan 2017 11:22:47 +0000 (12:22 +0100)
commit63042a718887693a07e6575fc8c8f58cdd0933cc
tree0ca61dffd680753f784124ebf5c4b0651ff8fd19
parent7c6075e2546dd818b7b87090a983429b1942796a
MdePkg, MdeModulePkg: S3BootScriptSaveMemPoll(): accept 64-bit LoopTimes

The BaseNull instance of S3BootScriptLib obviously doesn't care about the
type of the S3BootScriptSaveMemPoll() function's LoopTimes parameter; this
lib instance doesn't do anything with the parameters received in
S3BootScriptSaveMemPoll().

The PiDxe instance saves the LoopTimes parameter in
EFI_BOOT_SCRIPT_MEM_POLL.LoopTimes. This target field already has UINT64
type. Furthermore, the BootScriptExecuteMemPoll() function in the same
library instance already uses a local UINT64 variable called LoopTimes to
count up to EFI_BOOT_SCRIPT_MEM_POLL.LoopTimes. This means that the the
UINTN type for S3BootScriptSaveMemPoll()'s LoopTimes parameter is an
unnecessary restriction.

The callers of S3BootScriptSaveMemPoll() will be updated in the next
patches, functionally. At this stage, they will continue to compile, since
UINT64 parameters can accept UINTN arguments.

Cc: Feng Tian <feng.tian@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: "Yao, Jiewen" <jiewen.yao@intel.com>
Reviewed-by: Michael Kinney <michael.d.kinney@intel.com>
MdeModulePkg/Library/PiDxeS3BootScriptLib/BootScriptSave.c
MdePkg/Include/Library/S3BootScriptLib.h
MdePkg/Library/BaseS3BootScriptLibNull/BootScriptLib.c