]> git.proxmox.com Git - mirror_edk2.git/commit - MdeModulePkg/Universal/SerialDxe/SerialIo.c
MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported
authorJulien Grall <julien.grall@linaro.org>
Wed, 29 Nov 2017 17:28:23 +0000 (01:28 +0800)
committerStar Zeng <star.zeng@intel.com>
Thu, 30 Nov 2017 01:11:53 +0000 (09:11 +0800)
commit7ce5af40c98b17aef5a512b7823dd51ecdfbd2fe
tree155a4e7e3916f309ff919786b6b362c9bc15ad35
parent13d378fc82d4c10eff48bec383cd679cec6c4fdb
MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

After commit 91cc526b15 "MdeModulePkg/SerialDxe: Fix not able to change
serial attributes", serial is initialized using the reset method that
will call SetAttributes.

However, SetAttributes may return EFI_INVALID_PARAMETER when a driver
does not support some parameters. This will be propagated by the reset
function and lead to UEFI failing to get the console setup.

For instance, this is the case when using the Xen console driver.

Fix it by introspecting the result and return EFI_SUCCESS when the
SetAttributes report an invalid parameter (i.e EFI_INVALID_PARAMETER).

Contributed-under: Tianocore Contribution Agreement 1.1
Signed-off-by: Julien Grall <julien.grall@linaro.org>
Reviewed-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
MdeModulePkg/Universal/SerialDxe/SerialIo.c