]> git.proxmox.com Git - mirror_edk2.git/commit - MdePkg/Include/IndustryStandard/PciExpress21.h
MdePkg/PciExpress21.h: Fix typo in PCI_REG_PCIE_SLOT_CONTROL
authorRuiyu Ni <ruiyu.ni@intel.com>
Thu, 26 Oct 2017 08:06:56 +0000 (16:06 +0800)
committerRuiyu Ni <ruiyu.ni@intel.com>
Wed, 8 Nov 2017 04:46:50 +0000 (12:46 +0800)
commit400a59737fc3d14b0acc0b0a66a294bb6db894b6
treee481b9f5423440232a975c3150ac2306b5e9b6a6
parentcb68247d5c47c5adb667ed7433c6610641edbf95
MdePkg/PciExpress21.h: Fix typo in PCI_REG_PCIE_SLOT_CONTROL

PCI_REG_PCIE_SLOT_CONTROL contains a typo. It is defined as:
typedef union {
  struct {
    UINT32 AttentionButtonPressed : 1;
    UINT32 ...
    ...
  } Bits;
  UINT16   Uint16;
} PCI_REG_PCIE_SLOT_CONTROL;

The bit field data type should be UINT16 instead of UINT32,
results sizeof (PCI_REG_PCIE_SLOT_CONTROL) equals to 4 instead of 2.

Because this structure is used in PCI_CAPABILITY_PCIEXP as below:
typedef struct {
  ...
  PCI_REG_PCIE_SLOT_CONTROL       SlotControl;
  PCI_REG_PCIE_SLOT_STATUS        SlotStatus;
} PCI_CAPABILITY_PCIEXP;

It cause the OFFSET_OF (PCI_CAPABILITY_PCIEXP, SlotStatus) equal
to a wrong value.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
MdePkg/Include/IndustryStandard/PciExpress21.h