]> git.proxmox.com Git - mirror_edk2.git/commit - NetworkPkg/TcpDxe/TcpInput.c
NetworkPkg: Fix bug in TCP which not sending out ACK in certain circumstance.
authorFu Siyuan <siyuan.fu@intel.com>
Fri, 8 Jul 2016 03:59:13 +0000 (11:59 +0800)
committerFu Siyuan <siyuan.fu@intel.com>
Mon, 18 Jul 2016 02:08:35 +0000 (10:08 +0800)
commit09c25d1f6cea196a0c6c4128e839a3402f60308c
tree4951ce141c267d090f34b992db7420dca039dc73
parentc9da41b235eaf34248c92839924650f071079dc8
NetworkPkg: Fix bug in TCP which not sending out ACK in certain circumstance.

Consider the situation as shown in below chart. The last ACK message has
acknowledged the Tcb->RcvWl2, and all the segments until Tcb->RcvNxt have
been received by TCP driver. The Tcb->RcvNxt is not acknowledged due to the
delayed ACK. In this case an incoming segment (Seg->Seq, Seg->End) should
not be accepted by TCP driver, and an immediate ACK is required.

Current TcpSeqAcceptable() thought it’s an acceptable segment incorrectly, it
continues the TcpInput() process instead of sending out an ACK and droping the
segment immediately.

Tcb->RcvWl2                       Tcb->RcvNxt        Tcb->RcvWl2 + Tcb->RcvWnd
        Seg->Seq       Seg->End         |                          |
    |     |               |             |                          |
 ---+-----+---------------+-------------+--------------------------+-----------
           <income segment>             <----Acceptable Range--- -->

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-By: Eugene Cohen <eugene@hp.com>
Reviewed-By: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-By: Ye Ting <ting.ye@intel.com>
NetworkPkg/TcpDxe/TcpInput.c