]> git.proxmox.com Git - mirror_edk2.git/commit - ShellPkg/Application/Shell/ShellProtocol.c
ShellPkg/Shell: Do not set end device path if already end
authorMichael D Kinney <michael.d.kinney@intel.com>
Fri, 9 Dec 2022 15:53:21 +0000 (07:53 -0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Tue, 13 Dec 2022 21:12:47 +0000 (21:12 +0000)
commit592bf33a29360e8a447ed8b75daefe94c0888642
treef50e9cba983a31355f6351e35cc6b4d35ff5b070
parent1fd8d08970a9ee7d350c7dd42bffb0cb96426041
ShellPkg/Shell: Do not set end device path if already end

Update Shell Protocol EfiShellGetMapFromDevicePath() to not
set the end if the device path if it is already an end of
entire device path.  This removes a write operation that can
cause failures if the Device Path Protocol is mapped to
read-only memory.  In general Device Path Protocols should not
be modified unless the API explicitly states that the device
path is modified.

Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
ShellPkg/Application/Shell/ShellProtocol.c