]> git.proxmox.com Git - mirror_edk2.git/commit
MdeModulePkg/FileExplorerLib: Add return value check
authorwenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
Tue, 12 Jan 2021 07:06:38 +0000 (15:06 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Fri, 15 Jan 2021 01:08:45 +0000 (01:08 +0000)
commit014b9850f2a33ae402b87c46268f4d98395d5d59
tree5339c63cf5d017117f3b0d87aa0415475f9d03dd
parent40c4cd54213b78ef0daee2f4b186150d7ef63bb4
MdeModulePkg/FileExplorerLib: Add return value check

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3113
According to FAT specification, the length of file path
should not larger than 260. When the length exceed 260,
function FatLocateOFile will return EFI_INVALID_PARAMETER
and the parameter FileHandle will be NULL. Then on the
top-level function?an exception happens when the NULL
pointer is passed and be used.
So adding return value check after calling
LibGetFileHandleFromMenu, if return value is not success,
stop calling LibFindFiles.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
MdeModulePkg/Library/FileExplorerLib/FileExplorer.c