]> git.proxmox.com Git - mirror_edk2.git/commit
CryptoPkg/TlsLib: Change the return type of TlsInitialize().
authorJiaxin Wu <jiaxin.wu@intel.com>
Fri, 17 Nov 2017 03:50:11 +0000 (11:50 +0800)
committerJiaxin Wu <jiaxin.wu@intel.com>
Fri, 24 Nov 2017 00:46:20 +0000 (08:46 +0800)
commit0878771f0c6d7fcbf3617a530b4d6a49316c7ab9
treeb488f87955218e4710576bc109a6c7bcc9e29aee
parentc6c501654e85d712bc6381b1c9f2beb28b44ec68
CryptoPkg/TlsLib: Change the return type of TlsInitialize().

V2:
* Correct the commit log.

Currently, the return code of OPENSSL_init_ssl(0 or 1) and RandomSeed
(TRUE or FALSE) are not checked in TlsInitialize(). Also "VOID" is used
as the return type of TlsInitialize(), which can't be used to capture
the returned value for error handling.

From Long Qin (CryptoPkg owner):
The early version of OPENSSL_init_ssl() use the "VOID" as the return
value, which was updated to "int" later because the function changes
can fail.

So, this patch is to change the return type of TlsInitialize() to
follow up the OPENSSL_init_ssl() update.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Long Qin <qin.long@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-by: Long Qin <qin.long@intel.com>
CryptoPkg/Include/Library/TlsLib.h
CryptoPkg/Library/TlsLib/TlsInit.c