]> git.proxmox.com Git - mirror_edk2.git/commit
ArmVirtPkg/ArmVirtMemoryInitPeiLib: avoid redundant cache invalidation
authorArd Biesheuvel <ardb@kernel.org>
Sat, 29 Jan 2022 14:58:26 +0000 (15:58 +0100)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Fri, 25 Feb 2022 15:57:11 +0000 (15:57 +0000)
commit2dbed5250648794bdb6cb0d9111af9924a4e4e00
tree8ba7123e14bc4c5249fedb6ac0d59320a08727c1
parentb24306f15daa2ff8510b06702114724b33895d3c
ArmVirtPkg/ArmVirtMemoryInitPeiLib: avoid redundant cache invalidation

Alex reports that the cache invalidation performed by
ArmVirtMemoryInitPeiLib takes a non-negligible amount of time at boot.
This cache invalidation used to be necessary to avoid inconsistencies
between the CPU's cached and uncached views of the permanent PEI memory
region, given that the PEI phase is where the MMU gets enabled.

The only allocations done from permanent PEI memory with the MMU off are
pages used for page tables, and since commit 748fea6279ef
("ArmPkg/ArmMmuLib AARCH64: invalidate page tables before populating
them"), each of those is invalidated in the caches explicitly, for
reasons described in the patch's commit log. All other allocations done
in PEI are either from temporary PEI memory, which includes the stack,
or from permanent PEI memory but after the MMU has been enabled.

This means that the cache invalidation in ArmVirtMemoryInitPeiLib is no
longer necessary, and can simply be dropped.

Reported-by: Alexander Graf <graf@amazon.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Reviewed-by: Alexander Graf <graf@amazon.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
ArmVirtPkg/Library/ArmVirtMemoryInitPeiLib/ArmVirtMemoryInitPeiLib.c