]> git.proxmox.com Git - mirror_edk2.git/commit
SecurityPkg OpalPasswordDxe: Fix buffer overflow issue.
authorDong, Eric <eric.dong@intel.com>
Tue, 2 Aug 2016 11:32:30 +0000 (19:32 +0800)
committerStar Zeng <star.zeng@intel.com>
Wed, 3 Aug 2016 01:21:27 +0000 (09:21 +0800)
commit4636e4426a31802c25bd8409be9031c4d20324f4
tree41152dcf8d3e6936c54012e7db1e9e3265338677
parenta6d594c5fabd8da2273d2794826ec086cf9c3c04
SecurityPkg OpalPasswordDxe: Fix buffer overflow issue.

In current code, PSID is processed as string and the length is 0x20.
Current code only reserved 0x20 length buffer for it, no extra buffer
for the '\0'. When driver call UnicodeStrToAsciiStrS to convert PSID,
it search the '\0' for the end. So extra dirty data saved in PSID
info which caused PSID revert action failed. This patch reserved
extra 1 byte data for the '\0'.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c
SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHiiFormValues.h