]> git.proxmox.com Git - mirror_edk2.git/commit
FmpDevicePkg/FmpDxe: Update FmpDeviceCheckImageWithStatus() handling
authorMichael Kubacki <michael.kubacki@microsoft.com>
Tue, 4 Jan 2022 20:38:24 +0000 (04:38 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Thu, 20 Jan 2022 01:41:06 +0000 (01:41 +0000)
commit772c5bb8dcb9841f1839dec02f33324e31b36d25
tree98d1cfc2b05cc790eee1a2fcf744432919be77d9
parent5801910013757bd626f67ed77eea6c16a176eebf
FmpDevicePkg/FmpDxe: Update FmpDeviceCheckImageWithStatus() handling

Update the logic handling last attempt status codes from
FmpDeviceCheckImageWithStatus() implementations to account for
cases when the function return status code is EFI_SUCCESS
(since the image was checked successfully) but the ImageUpdatable
value is not valid.

In addition the following sentence is removed from the
LastAttemptStatus parameter definition for
FmpDeviceCheckImageWithStatus() since it can lead to confusion.
The expected status code value range is sufficient to implement
the library API.

  "This value will only be checked when this
   function returns an error."

Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Cc: Wei6 Xu <wei6.xu@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>
FmpDevicePkg/FmpDxe/FmpDxe.c
FmpDevicePkg/Include/Library/FmpDeviceLib.h
FmpDevicePkg/Library/FmpDeviceLibNull/FmpDeviceLib.c