]> git.proxmox.com Git - mirror_edk2.git/commit
EmbeddedPkg: Unload image on EFI_SECURITY_VIOLATION
authorDandan Bi <dandan.bi@intel.com>
Tue, 3 Sep 2019 07:58:40 +0000 (15:58 +0800)
committerHao A Wu <hao.a.wu@intel.com>
Wed, 25 Sep 2019 02:03:57 +0000 (10:03 +0800)
commit82e0c422b2166434d78d0e03434e23d4226c6040
tree1bd3cbf7199332c8b2c171ef8ad7302376ea6e1f
parent590c9d58280bb0fad144f760c4da2acaf16622aa
EmbeddedPkg: Unload image on EFI_SECURITY_VIOLATION

For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval,
the Image was loaded and an ImageHandle was created with a valid
EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now.
This follows UEFI Spec.

But if the caller of LoadImage() doesn't have the option to defer
the execution of an image, we can not treat EFI_SECURITY_VIOLATION
like any other LoadImage() error, we should unload image for the
EFI_SECURITY_VIOLATION to avoid resource leak.

This patch is to do error handling for EFI_SECURITY_VIOLATION explicitly
for the callers in EmbeddedPkg which don't have the policy to defer the
execution of the image.

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Philippe Mathieu-Daude <philmd@redhat.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1992
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
EmbeddedPkg/Application/AndroidFastboot/Arm/BootAndroidBootImg.c
EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c