]> git.proxmox.com Git - mirror_edk2.git/commit
OvmfPkg: QemuVideoDxe: eliminate useless Private->HardwareNeedsStarting
authorLaszlo Ersek <lersek@redhat.com>
Mon, 3 Mar 2014 08:40:52 +0000 (08:40 +0000)
committerjljusten <jljusten@6f19259b-4bc3-4df7-8a09-765794883524>
Mon, 3 Mar 2014 08:40:52 +0000 (08:40 +0000)
commit96b5f3977773b71702f67d99f5b758c1a184d2bf
tree5a97f386d00176e7ead67140111f980d562c812a
parent847e4c3477d3ecb7362c3b31fe9889384557e8ae
OvmfPkg: QemuVideoDxe: eliminate useless Private->HardwareNeedsStarting

Currently, QemuVideoGraphicsOutputQueryMode() reports EFI_NOT_STARTED when
this boolean field is set.

However, QemuVideoGraphicsOutputQueryMode() is only available to callers
after the GOP interface has been installed. That in turn implies that the
following partial call tree has succeeded without errors:

  QemuVideoControllerDriverStart()
    QemuVideoGraphicsOutputConstructor()
      QemuVideoGraphicsOutputSetMode(... 0 ...)
        HardwareNeedsStarting = FALSE
    InstallMultipleProtocolInterfaces(... GOP ...)

That is, when QemuVideoGraphicsOutputQueryMode() is reached,
HardwareNeedsStarting is always FALSE.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15286 6f19259b-4bc3-4df7-8a09-765794883524
OvmfPkg/QemuVideoDxe/Gop.c
OvmfPkg/QemuVideoDxe/Qemu.h